net/bnxt: statistic related fixes
cover net/bnxt: statistic related fixes
A couple of minor things in bnxt statistics
Stephen Hemminger (2):
net/bnxt: do not print error if stats queried before start net/bnxt: remove unnecessary memset
drivers/net/bnxt/bnxt_stats.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/2 net/bnxt: do not print error if stats queried before start
When using pktgen lots of unnecessary errors are printed because pktgen queries statistics before device is started.
--- drivers/net/bnxt/bnxt_stats.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/bnxt/bnxt_stats.c +1 -3
@@ -390,10 +390,8 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,return rc;memset (bnxt_stats,0 ,sizeof (*bnxt_stats)); -if (!(bp->flags &BNXT_FLAG_INIT_DONE )) { -PMD_DRV_LOG (ERR ,"Device Initialization not complete!\n" ); +if (!(bp->flags &BNXT_FLAG_INIT_DONE ))return -EIO ; - } num_q_stats =RTE_MIN (bp->rx_cp_nr_rings, (unsigned int )RTE_ETHDEV_QUEUE_STAT_CNTRS );
Signature · 1 line
2.20.1
PATCH 2/2 net/bnxt: remove unnecessary memset
In reply to Stephen HemmingerThe rte_ethdev layer already zeros statistics before calling the device.
--- drivers/net/bnxt/bnxt_stats.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/bnxt/bnxt_stats.c +0 -1
@@ -389,7 +389,6 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,if (rc)return rc; -memset (bnxt_stats,0 ,sizeof (*bnxt_stats));if (!(bp->flags &BNXT_FLAG_INIT_DONE ))return -EIO ;
Signature · 1 line
2.20.1
Quoted 16 lines · Stephen Hemminger
A couple of minor things in bnxt statistics
Stephen Hemminger (2):
net/bnxt: do not print error if stats queried before start net/bnxt: remove unnecessary memsetdrivers/net/bnxt/bnxt_stats.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)Patches applied to dpdk-next-net-brcm. Thanks
--
2.20.1
Quoted 5 lines · Ajit Khaparde
Quoted 2 lines · Stephen Hemminger
A couple of minor things in bnxt statistics
Quoted 9 lines
Quoted 8 lines
Stephen Hemminger (2):
net/bnxt: do not print error if stats queried before start net/bnxt: remove unnecessary memsetdrivers/net/bnxt/bnxt_stats.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)Patches applied to dpdk-next-net-brcm. Thanks
Hi Ajit,
It seems they are not pushed into your tree. Please ping me when you do, I can pull afterwards.