Skip to contentSkip to conversation

drm/dp_mst: Convert drm_dp_mst_topology_mgr.is_waiting_for_dwn_reply to bitfield

PATCH In review Lyude Paul 2 participants 2 messages Jan 22, 2020 – Jan 31, 2020

Subsystems (2)
lore
Share & tools
lore

Lyude Paul

author
#0 lore raw

PATCH 1/1 drm/dp_mst: Convert drm_dp_mst_topology_mgr.is_waiting_for_dwn_reply to bitfield

Small nitpick that I noticed a second ago - we can save some space in the struct by making this a bitfield and sticking it with the rest of the bitfields. Also, some small cleanup to the kdocs for this member.

There should be no functional changes in this patch.

---
 include/drm/drm_dp_mst_helper.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
include/drm/drm_dp_mst_helper.h +5 -5
index bcb39da9adb4..58bbab3684b5 100644
@@ -590,6 +590,11 @@ struct drm_dp_mst_topology_mgr {
 	 */
 	bool payload_id_table_cleared : 1;
 
+	/**
+	 * @is_waiting_for_dwn_reply: whether we're waiting for a down reply.
+	 */
+	bool is_waiting_for_dwn_reply : 1;
+
 	/**
 	 * @mst_primary: Pointer to the primary/first branch device.
 	 */
@@ -619,11 +624,6 @@ struct drm_dp_mst_topology_mgr {
 	 */
 	struct mutex qlock;
 
-	/**
-	 * @is_waiting_for_dwn_reply: indicate whether is waiting for down reply
-	 */
-	bool is_waiting_for_dwn_reply;
-
 	/**
 	 * @tx_msg_downq: List of pending down replies.
 	 */
Signature · 6 lines
2.24.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw

[AMD Public Use]

Thanks!

Quoted 54 lines

-----Original Message-----
From: Lyude Paul <[email protected]>
Sent: Thursday, January 23, 2020 3:49 AM
To: [email protected]
Cc: Lin, Wayne <[email protected]>; Maarten Lankhorst <[email protected]>; Maxime Ripard <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; [email protected]
Subject: [PATCH] drm/dp_mst: Convert drm_dp_mst_topology_mgr.is_waiting_for_dwn_reply to bitfield

Small nitpick that I noticed a second ago - we can save some space in the struct by making this a bitfield and sticking it with the rest of the bitfields. Also, some small cleanup to the kdocs for this member.

There should be no functional changes in this patch.

---
 include/drm/drm_dp_mst_helper.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
(quoted diff) +0 -0

b/include/drm/drm_dp_mst_helper.h index bcb39da9adb4..58bbab3684b5 100644

include/drm/drm_dp_mst_helper.h +5 -2
@@ -590,6 +590,11 @@ struct drm_dp_mst_topology_mgr {
 	 */
 	bool payload_id_table_cleared : 1;
 
+	/**
+	 * @is_waiting_for_dwn_reply: whether we're waiting for a down reply.
+	 */
+	bool is_waiting_for_dwn_reply : 1;
+
 	/**
 	 * @mst_primary: Pointer to the primary/first branch device.
 	 */
@@ -619,11 +624,6 @@ struct drm_dp_mst_topology_mgr {
 	 */
 	struct mutex qlock;
 
-	/**
-	 * @is_waiting_for_dwn_reply: indicate whether is waiting for down

reply

include/drm/drm_dp_mst_helper.h +0 -4
-	 */
-	bool is_waiting_for_dwn_reply;
-
 	/**
 	 * @tx_msg_downq: List of pending down replies.
 	 */
--
Quoted 1 line

2.24.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel