net: fddi: skfp: Use print_hex_dump() helper
Subsystems (2)
PATCH 1/1 net: fddi: skfp: Use print_hex_dump() helper
Use the print_hex_dump() helper, instead of open-coding the same operations.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/net/fddi/skfp/skfddi.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)
drivers/net/fddi/skfp/skfddi.c +1 -15
@@ -1520,22 +1520,8 @@ void mac_drv_tx_complete(struct s_smc *smc, volatile struct s_smt_fp_txd *txd)#ifdef DUMPPACKETS void dump_data (unsigned char *Data,int length) { -int i, j; -unsigned char s[255 ], sh[10 ]; -if (length >64 ) { - length =64 ; - }printk (KERN_INFO "---Packet start---\n" ); -for (i =0 , j =0 ; i < length /8 ; i++, j +=8 ) -printk (KERN_INFO "%02x %02x %02x %02x %02x %02x %02x %02x\n" , - Data[j +0 ], Data[j +1 ], Data[j +2 ], Data[j +3 ], - Data[j +4 ], Data[j +5 ], Data[j +6 ], Data[j +7 ]); -strcpy (s,"" ); -for (i =0 ; i < length %8 ; i++) { -sprintf (sh,"%02x " , Data[j + i]); -strcat (s, sh); - } -printk (KERN_INFO "%s\n" , s); +print_hex_dump (KERN_INFO ,"" ,DUMP_PREFIX_NONE ,16 ,1 , Data,min_t (size_t, length,64 ), false);printk (KERN_INFO "------------------\n" ); }// dump_data #else
Signature · 1 line
2.24.1
From: Andy Shevchenko <[email protected]>
Date: Thu, 23 Jan 2020 16:27:29 +0200
Quoted 3 lines
Use the
print_hex_dump()helper, instead of open-coding the same operations.Signed-off-by Andy Shevchenko <[email protected]>
Applied.