xfs: fix uninitialized variable in xfs_attr3_leaf_inactive
PATCH 1/1 xfs: fix uninitialized variable in xfs_attr3_leaf_inactive
From: Darrick J. Wong <[email protected]>
Dan Carpenter pointed out that error is uninitialized. While there never should be an attr leaf block with zero entries, let's not leave that logic bomb there.
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Darrick J. Wong <[email protected]>
--- fs/xfs/xfs_attr_inactive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_attr_inactive.c +1 -1
@@ -89,7 +89,7 @@ xfs_attr3_leaf_inactive(struct xfs_attr_leafblock *leaf = bp->b_addr;struct xfs_attr_leaf_entry *entry;struct xfs_attr_leaf_name_remote *name_rmt; -int error; +int error =0 ;int i;xfs_attr3_leaf_hdr_from_disk (mp->m_attr_geo, &ichdr, leaf);
Quoted 6 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Dan Carpenter pointed out that error is uninitialized. While there never should be an attr leaf block with zero entries, let's not leave that logic bomb there.
Looks fine to me.
Reviewed-by Allison Collins <[email protected]>
Quoted 20 lines
Reported-by Dan Carpenter <[email protected]>Signed-off-by Darrick J. Wong <[email protected]>--- fs/xfs/xfs_attr_inactive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/xfs/xfs_attr_inactive.c +1
-1@@ -89,7 +89,7 @@ xfs_attr3_leaf_inactive(struct xfs_attr_leafblock *leaf = bp->b_addr;struct xfs_attr_leaf_entry *entry;struct xfs_attr_leaf_name_remote *name_rmt; -int error; +int error =0 ;int i;xfs_attr3_leaf_hdr_from_disk (mp->m_attr_geo, &ichdr, leaf);
Quoted 8 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Dan Carpenter pointed out that error is uninitialized. While there never should be an attr leaf block with zero entries, let's not leave that logic bomb there.
Reported-by Dan Carpenter <[email protected]>Signed-off-by Darrick J. Wong <[email protected]>
Fixes 0bb9d159bd01 ("xfs: streamline xfs_attr3_leaf_inactive")
Reviewed-by Eric Sandeen <[email protected]>
Quoted 18 lines
--- fs/xfs/xfs_attr_inactive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/xfs/xfs_attr_inactive.c +1
-1@@ -89,7 +89,7 @@ xfs_attr3_leaf_inactive(struct xfs_attr_leafblock *leaf = bp->b_addr;struct xfs_attr_leaf_entry *entry;struct xfs_attr_leaf_name_remote *name_rmt; -int error; +int error =0 ;int i;xfs_attr3_leaf_hdr_from_disk (mp->m_attr_geo, &ichdr, leaf);