Print ratio of acquisitions, not failures
Paul E. McKenney
maintainerRFC PATCH 1/1 Print ratio of acquisitions, not failures
The __torture_print_stats() function in locktorture.c carefully initializes local variable "min" to statp[0].n_lock_acquired, but then compares it to statp[i].n_lock_fail. Given that the .n_lock_fail field should normally be zero, and given the initialization, it seems reasonable to display the maximum and minimum number acquisitions instead of miscomputing the maximum and minimum number of failures. This commit therefore switches from failures to acquisitions.
kernel/locking/locktorture.c +4 -4
@@ -696,10 +696,10 @@ static void __torture_print_stats(char *page,if (statp[i].n_lock_fail) fail = true; sum += statp[i].n_lock_acquired; -if (max < statp[i].n_lock_fail) - max = statp[i].n_lock_fail; -if (min > statp[i].n_lock_fail) - min = statp[i].n_lock_fail; +if (max < statp[i].n_lock_acquired) + max = statp[i].n_lock_acquired; +if (min > statp[i].n_lock_acquired) + min = statp[i].n_lock_acquired; } page += sprintf(page, "%s: Total: %lld Max/Min: %ld/%ld %s Fail: %d %s\n",
Quoted 9 lines · Paul E. McKenney
kernel/locking/locktorture.c +0
-1@@ -696,10 +696,10 @@ static void __torture_print_stats(char *page,if (statp[i].n_lock_fail) fail = true; sum += statp[i].n_lock_acquired; -if (max < statp[i].n_lock_fail)
kernel/locking/locktorture.c static void __torture_print_stats(char *page, · line 705
Quoted 10 lines
kernel/locking/locktorture.c +4
-3- max = statp[i].n_lock_fail; -if (min > statp[i].n_lock_fail) - min = statp[i].n_lock_fail; +if (max < statp[i].n_lock_acquired) + max = statp[i].n_lock_acquired; +if (min > statp[i].n_lock_acquired) + min = statp[i].n_lock_acquired; } page += sprintf(page, "%s: Total: %lld Max/Min: %ld/%ld %s Fail: %d %s\n",
Will
Quoted 7 lines · Paul E. McKenney
The
__torture_print_stats()function inlocktorture.ccarefully initializes local variable "min" to statp[0].n_lock_acquired, but then compares it to statp[i].n_lock_fail. Given that the .n_lock_fail field should normally be zero, and given the initialization, it seems reasonable to display the maximum and minimum number acquisitions instead of miscomputing the maximum and minimum number of failures. This commit therefore switches from failures to acquisitions.
This makes sense, thanks!
Quoted 6 lines
Reported-by Will Deacon <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>Cc Davidlohr Bueso <[email protected]>Cc Josh Triplett <[email protected]>Cc Peter Zijlstra <[email protected]>