arm64/spinlock: fix a -Wunused-function warning
Subsystems (2)
PATCH v2 1/1 arm64/spinlock: fix a -Wunused-function warning
The commit f5bfdc8e3947 ("locking/osq: Use optimized spinning loop for arm64") introduced a warning from Clang because vcpu_is_preempted() is compiled away,
kernel/locking/osq_lock.c:25:19: warning: unused function 'node_cpu' [-Wunused-function]
static inline int node_cpu(struct optimistic_spin_node *node)
^
1 warning generated.
Fix it by converting vcpu_is_preempted() to a static inline function.
---
v2: convert vcpu_is_preempted() to a static inline function.
arch/arm64/include/asm/spinlock.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
arch/arm64/include/asm/spinlock.h +5 -1
@@ -18,6 +18,10 @@* See: * https://lore.kernel.org/lkml/[email protected] */ -#define vcpu_is_preempted (cpu) false +#define vcpu_is_preempted vcpu_is_preempted +static inline bool vcpu_is_preempted (int cpu) +{ +return false; +}#endif /* __ASM_SPINLOCK_H */
Signature · 1 line
2.21.0 (Apple Git-122.2)
Quoted 27 lines · Qian Cai
The commit
f5bfdc8e3947("locking/osq: Use optimized spinning loop for arm64") introduced a warning from Clang becausevcpu_is_preempted()is compiled away,
kernel/locking/osq_lock.c:25:19: warning: unused function 'node_cpu' [-Wunused-function]
static inline intnode_cpu(struct optimistic_spin_node *node)^1 warning generated.
Fix it by converting
vcpu_is_preempted()to a static inline function.Fixes f5bfdc8e3947 ("locking/osq: Use optimized spinning loop for arm64")Signed-off-by Qian Cai <[email protected]>---
v2: convert
vcpu_is_preempted()to a static inline function.arch/arm64/include/asm/spinlock.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)arch/arm64/include/asm/spinlock.h +0
-0@@ -18,6 +18,10 @@* See:
arch/arm64/include/asm/spinlock.h line 27
Quoted 10 lines
arch/arm64/include/asm/spinlock.h +5
-1* https://lore.kernel.org/lkml/[email protected] */ -#define vcpu_is_preempted (cpu) false +#define vcpu_is_preempted vcpu_is_preempted +static inline bool vcpu_is_preempted (int cpu) +{ +return false; +}#endif /* __ASM_SPINLOCK_H */
Will Deacon
maintainerQuoted 26 lines · Qian Cai
The commit
f5bfdc8e3947("locking/osq: Use optimized spinning loop for arm64") introduced a warning from Clang becausevcpu_is_preempted()is compiled away,
kernel/locking/osq_lock.c:25:19: warning: unused function 'node_cpu' [-Wunused-function]
static inline intnode_cpu(struct optimistic_spin_node *node)^1 warning generated.
Fix it by converting
vcpu_is_preempted()to a static inline function.Fixes f5bfdc8e3947 ("locking/osq: Use optimized spinning loop for arm64")Signed-off-by Qian Cai <[email protected]>---
v2: convert
vcpu_is_preempted()to a static inline function.arch/arm64/include/asm/spinlock.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)arch/arm64/include/asm/spinlock.h +0
-0
arch/arm64/include/asm/spinlock.h line 25
Quoted 9 lines
arch/arm64/include/asm/spinlock.h +5
-1@@ -18,6 +18,10 @@* See: * https://lore.kernel.org/lkml/[email protected] */ -#define vcpu_is_preempted (cpu) false +#define vcpu_is_preempted vcpu_is_preempted +static inline bool vcpu_is_preempted (int cpu) +{ +return false; +}
Cheers, I'll queue this at -rc1.
Will