Skip to contentSkip to conversation

uml: make CONFIG_STATIC_LINK actually static

PATCH Superseded Brendan Higgins 2 participants 3 messages Jan 23, 2020 – Jan 24, 2020 User-mode Linux (UML)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 uml: make CONFIG_STATIC_LINK actually static

Currently, CONFIG_STATIC_LINK can be enabled with options which cannot be statically linked, namely UML_NET_VECTOR, UML_NET_VDE, and UML_NET_PCAP; this is because glibc tries to load NSS which does not support being statically linked. So make CONFIG_STATIC_LINK depend on !UML_NET_VECTOR && !UML_NET_VDE && !UML_NET_PCAP.

---
Changes since last revision:

Incorporated Geert Uytterhoeven's suggestion of using a separate FORBID_STATIC_LINK config option that each driver incompatible with static linking selects.

---
 arch/um/Kconfig         | 7 +++++++
 arch/um/drivers/Kconfig | 3 +++
 2 files changed, 10 insertions(+)
arch/um/Kconfig +7 -0
index 0917f8443c285..27a51e7dd59c6 100644
@@ -62,8 +62,12 @@ config NR_CPUS
 
 source "arch/$(HEADER_ARCH)/um/Kconfig"
 
+config FORBID_STATIC_LINK
+	def_bool n
+
 config STATIC_LINK
 	bool "Force a static link"
+	depends on !FORBID_STATIC_LINK
 	default n
 	help
 	  This option gives you the ability to force a static link of UML.
@@ -73,6 +77,9 @@ config STATIC_LINK
 	  Additionally, this option enables using higher memory spaces (up to
 	  2.75G) for UML.
 
+	  NOTE: This option is incompatible with some networking features which
+	  depend on features that require being dynamically loaded (like NSS).
+
 config LD_SCRIPT_STATIC
 	bool
 	default y
arch/um/drivers/Kconfig +3 -0
index 72d4170557820..9160ead56e33c 100644
@@ -234,6 +234,7 @@ config UML_NET_DAEMON
 config UML_NET_VECTOR
 	bool "Vector I/O high performance network devices"
 	depends on UML_NET
+	select FORBID_STATIC_LINK
 	help
 	This User-Mode Linux network driver uses multi-message send
 	and receive functions. The host running the UML guest must have
@@ -245,6 +246,7 @@ config UML_NET_VECTOR
 config UML_NET_VDE
 	bool "VDE transport (obsolete)"
 	depends on UML_NET
+	select FORBID_STATIC_LINK
 	help
 	This User-Mode Linux network transport allows one or more running
 	UMLs on a single host to communicate with each other and also
@@ -292,6 +294,7 @@ config UML_NET_MCAST
 config UML_NET_PCAP
 	bool "pcap transport (obsolete)"
 	depends on UML_NET
+	select FORBID_STATIC_LINK
 	help
 	The pcap transport makes a pcap packet stream on the host look
 	like an ethernet device inside UML.  This is useful for making
Signature · 1 line
2.25.0.341.g760bfbb309-goog
#1 lore raw

Hi Brendan,

Quoted 24 lines · Brendan Higgins

Currently, CONFIG_STATIC_LINK can be enabled with options which cannot be statically linked, namely UML_NET_VECTOR, UML_NET_VDE, and UML_NET_PCAP; this is because glibc tries to load NSS which does not support being statically linked. So make CONFIG_STATIC_LINK depend on !UML_NET_VECTOR && !UML_NET_VDE && !UML_NET_PCAP.

---
Changes since last revision:

Incorporated Geert Uytterhoeven's suggestion of using a separate FORBID_STATIC_LINK config option that each driver incompatible with static linking selects.

---
 arch/um/Kconfig         | 7 +++++++
 arch/um/drivers/Kconfig | 3 +++
 2 files changed, 10 insertions(+)
arch/um/Kconfig +0 -0
index 0917f8443c285..27a51e7dd59c6 100644

arch/um/Kconfig config NR_CPUS · line 66

Quoted 5 lines
arch/um/Kconfig +2 -0
@@ -62,8 +62,12 @@ config NR_CPUS
 
 source "arch/$(HEADER_ARCH)/um/Kconfig"
 
+config FORBID_STATIC_LINK
+       def_bool n

bool

("n" is the default)

arch/um/Kconfig config NR_CPUS · line 71

Quoted 5 lines
arch/um/Kconfig +2 -0
+
 config STATIC_LINK
        bool "Force a static link"
+       depends on !FORBID_STATIC_LINK
        default n

"default n" is the default (preexisting)

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#2 lore raw
Quoted 30 lines · Geert Uytterhoeven

Hi Brendan,

Quoted 25 lines · Brendan Higgins

Currently, CONFIG_STATIC_LINK can be enabled with options which cannot be statically linked, namely UML_NET_VECTOR, UML_NET_VDE, and UML_NET_PCAP; this is because glibc tries to load NSS which does not support being statically linked. So make CONFIG_STATIC_LINK depend on !UML_NET_VECTOR && !UML_NET_VDE && !UML_NET_PCAP.

---
Changes since last revision:

Incorporated Geert Uytterhoeven's suggestion of using a separate FORBID_STATIC_LINK config option that each driver incompatible with static linking selects.

---
 arch/um/Kconfig         | 7 +++++++
 arch/um/drivers/Kconfig | 3 +++
 2 files changed, 10 insertions(+)
arch/um/Kconfig +0 -0
index 0917f8443c285..27a51e7dd59c6 100644
@@ -62,8 +62,12 @@ config NR_CPUS
 
Quoted 8 lines

arch/um/Kconfig config NR_CPUS · line 66

Quoted 4 lines
arch/um/Kconfig +2 -0
 source "arch/$(HEADER_ARCH)/um/Kconfig"
 
+config FORBID_STATIC_LINK
+       def_bool n

bool

("n" is the default)

Whoops, I always forget that.

Thanks for catching that!

Quoted 7 lines

arch/um/Kconfig config NR_CPUS · line 71

Quoted 5 lines
arch/um/Kconfig +2 -0
+
 config STATIC_LINK
        bool "Force a static link"
+       depends on !FORBID_STATIC_LINK
        default n

"default n" is the default (preexisting)

I'll go ahead and fix that too, then.

Thanks!