drm/amdgpu: Stop using the DRIVER debugging flag for vblank debugging messages
Subsystems (3)
PATCH 1/1 drm/amdgpu: Stop using the DRIVER debugging flag for vblank debugging messages
These are some very loud debug statements that get printed on every vblank when driver level debug printing is enabled in DRM, and doesn't really tell us anything that isn't related to vblanks. So let's move this over to the proper debug flag to be a little less spammy with our debug output.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +8 -6
@@ -407,8 +407,9 @@ static void dm_vupdate_high_irq(void *interrupt_params)if (acrtc) { acrtc_state =to_dm_crtc_state (acrtc->base.state); -DRM_DEBUG_DRIVER ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, -amdgpu_dm_vrr_active (acrtc_state)); +DRM_DEBUG_VBL ("crtc:%d, vupdate-vrr:%d\n" , + acrtc->crtc_id, +amdgpu_dm_vrr_active (acrtc_state));/* Core vblank handling is done here after end of front-porch in * vrr mode, as vblank timestamping will give valid results
@@ -458,8 +459,9 @@ static void dm_crtc_high_irq(void *interrupt_params)if (acrtc) { acrtc_state =to_dm_crtc_state (acrtc->base.state); -DRM_DEBUG_DRIVER ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, -amdgpu_dm_vrr_active (acrtc_state)); +DRM_DEBUG_VBL ("crtc:%d, vupdate-vrr:%d\n" , + acrtc->crtc_id, +amdgpu_dm_vrr_active (acrtc_state));/* Core vblank handling at start of front-porch is only possible * in non-vrr mode, as only there vblank timestamping will give
@@ -522,8 +524,8 @@ static void dm_dcn_crtc_high_irq(void *interrupt_params) acrtc_state =to_dm_crtc_state (acrtc->base.state); -DRM_DEBUG_DRIVER ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, -amdgpu_dm_vrr_active (acrtc_state)); +DRM_DEBUG_VBL ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, +amdgpu_dm_vrr_active (acrtc_state));amdgpu_dm_crtc_handle_crc_irq (&acrtc->base);drm_crtc_handle_vblank (&acrtc->base);
Signature · 1 line
2.24.1
Quoted 7 lines · Lyude Paul
These are some very loud debug statements that get printed on every vblank when driver level debug printing is enabled in DRM, and doesn't really tell us anything that isn't related to vblanks. So let's move this over to the proper debug flag to be a little less spammy with our debug output.
Signed-off-by Lyude Paul <[email protected]>
Thanks. Great change.
Harry
Quoted 34 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +6
-4@@ -407,8 +407,9 @@ static void dm_vupdate_high_irq(void *interrupt_params)if (acrtc) { acrtc_state =to_dm_crtc_state (acrtc->base.state); -DRM_DEBUG_DRIVER ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, -amdgpu_dm_vrr_active (acrtc_state)); +DRM_DEBUG_VBL ("crtc:%d, vupdate-vrr:%d\n" , + acrtc->crtc_id, +amdgpu_dm_vrr_active (acrtc_state));/* Core vblank handling is done here after end of front-porch in * vrr mode, as vblank timestamping will give valid results @@ -458,8 +459,9 @@ static void dm_crtc_high_irq(void *interrupt_params)if (acrtc) { acrtc_state =to_dm_crtc_state (acrtc->base.state); -DRM_DEBUG_DRIVER ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, -amdgpu_dm_vrr_active (acrtc_state)); +DRM_DEBUG_VBL ("crtc:%d, vupdate-vrr:%d\n" , + acrtc->crtc_id, +amdgpu_dm_vrr_active (acrtc_state));/* Core vblank handling at start of front-porch is only possible * in non-vrr mode, as only there vblank timestamping will give
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void dm_dcn_crtc_high_irq(void *interrupt_params) · line 531
Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-2@@ -522,8 +524,8 @@ static void dm_dcn_crtc_high_irq(void *interrupt_params) acrtc_state =to_dm_crtc_state (acrtc->base.state); -DRM_DEBUG_DRIVER ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, -amdgpu_dm_vrr_active (acrtc_state)); +DRM_DEBUG_VBL ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, +amdgpu_dm_vrr_active (acrtc_state));amdgpu_dm_crtc_handle_crc_irq (&acrtc->base);drm_crtc_handle_vblank (&acrtc->base);
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
AppliedApplied. thanks!
Alex
Quoted 57 lines · Harry Wentland
Quoted 7 lines · Lyude Paul
These are some very loud debug statements that get printed on every vblank when driver level debug printing is enabled in DRM, and doesn't really tell us anything that isn't related to vblanks. So let's move this over to the proper debug flag to be a little less spammy with our debug output.
Signed-off-by Lyude Paul <[email protected]>Thanks. Great change.
Reviewed-by Harry Wentland <[email protected]>Harry
Quoted 41 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +8
-6@@ -407,8 +407,9 @@ static void dm_vupdate_high_irq(void *interrupt_params)if (acrtc) { acrtc_state =to_dm_crtc_state (acrtc->base.state); -DRM_DEBUG_DRIVER ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, -amdgpu_dm_vrr_active (acrtc_state)); +DRM_DEBUG_VBL ("crtc:%d, vupdate-vrr:%d\n" , + acrtc->crtc_id, +amdgpu_dm_vrr_active (acrtc_state));/* Core vblank handling is done here after end of front-porch in * vrr mode, as vblank timestamping will give valid results @@ -458,8 +459,9 @@ static void dm_crtc_high_irq(void *interrupt_params)if (acrtc) { acrtc_state =to_dm_crtc_state (acrtc->base.state); -DRM_DEBUG_DRIVER ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, -amdgpu_dm_vrr_active (acrtc_state)); +DRM_DEBUG_VBL ("crtc:%d, vupdate-vrr:%d\n" , + acrtc->crtc_id, +amdgpu_dm_vrr_active (acrtc_state));/* Core vblank handling at start of front-porch is only possible * in non-vrr mode, as only there vblank timestamping will give @@ -522,8 +524,8 @@ static void dm_dcn_crtc_high_irq(void *interrupt_params) acrtc_state =to_dm_crtc_state (acrtc->base.state); -DRM_DEBUG_DRIVER ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, -amdgpu_dm_vrr_active (acrtc_state)); +DRM_DEBUG_VBL ("crtc:%d, vupdate-vrr:%d\n" , acrtc->crtc_id, +amdgpu_dm_vrr_active (acrtc_state));
Quoted 7 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void dm_dcn_crtc_high_irq(void *interrupt_params) · line 531
Quoted 3 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0amdgpu_dm_crtc_handle_crc_irq (&acrtc->base);drm_crtc_handle_vblank (&acrtc->base);_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx