Skip to contentSkip to conversation

4.19.99-stable review

PATCH In review Greg Kroah-Hartman 9 participants 677 messages Jan 24, 2020 – Jan 27, 2020 1 message not in the archive Page 5 of 5

Subsystems (10)
lore
Share & tools
lore
author maintainer
#662 lore raw

PATCH 638/639 arm64: dts: meson-gxm-khadas-vim2: fix uart_A bluetooth node

In reply to Greg Kroah-Hartman

From: Christian Hewitt <[email protected]>

[ Upstream commit 388a2772979b625042524d8b91280616ab4ff5ee ]

Fixes 33344e2111a3 ("arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support")
---
 arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +3 -0
index 785240733d946..bdf7c6c5983ce 100644
@@ -413,6 +413,9 @@
 	bluetooth {
 		compatible = "brcm,bcm43438-bt";
 		shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
+		max-speed = <2000000>;
+		clocks = <&wifi32k>;
+		clock-names = "lpo";
 	};
 };
 
Signature · 1 line
2.20.1
author maintainer
#663 lore raw

PATCH 639/639 m68k: Call timer_interrupt() with interrupts disabled

In reply to Greg Kroah-Hartman

From: Finn Thain <[email protected]>

[ Upstream commit 1efdd4bd254311498123a15fa0acd565f454da97 ]

Some platforms execute their timer handler with the interrupt priority level set below 6. That means the handler could be interrupted by another driver and this could lead to re-entry of the timer core.

Avoid this by use of local_irq_save/restore for timer interrupt dispatch. This provides mutual exclusion around the timer interrupt flag access which is needed later in this series for the clocksource conversion.

---
 arch/m68k/amiga/cia.c       |  9 +++++++++
 arch/m68k/atari/ataints.c   |  4 ++--
 arch/m68k/atari/time.c      | 15 ++++++++++++++-
 arch/m68k/bvme6000/config.c | 20 ++++++++++----------
 arch/m68k/hp300/time.c      | 10 ++++++++--
 arch/m68k/mac/via.c         | 17 +++++++++++++++++
 arch/m68k/mvme147/config.c  | 18 ++++++++++--------
 arch/m68k/mvme16x/config.c  | 21 +++++++++++----------
 arch/m68k/q40/q40ints.c     | 19 +++++++++++--------
 arch/m68k/sun3/sun3ints.c   |  3 +++
 arch/m68k/sun3x/time.c      | 16 ++++++++++------
 11 files changed, 105 insertions(+), 47 deletions(-)
arch/m68k/amiga/cia.c +9 -0
index 2081b8cd5591c..b9aee983e6f4c 100644
@@ -88,10 +88,19 @@ static irqreturn_t cia_handler(int irq, void *dev_id)
 	struct ciabase *base = dev_id;
 	int mach_irq;
 	unsigned char ints;
+	unsigned long flags;
 
+	/* Interrupts get disabled while the timer irq flag is cleared and
+	 * the timer interrupt serviced.
+	 */
 	mach_irq = base->cia_irq;
+	local_irq_save(flags);
 	ints = cia_set_irq(base, CIA_ICR_ALL);
 	amiga_custom.intreq = base->int_mask;
+	if (ints & 1)
+		generic_handle_irq(mach_irq);
+	local_irq_restore(flags);
+	mach_irq++, ints >>= 1;
 	for (; ints; mach_irq++, ints >>= 1) {
 		if (ints & 1)
 			generic_handle_irq(mach_irq);
arch/m68k/atari/ataints.c +2 -2
index 3d2b63bedf058..56f02ea2c248d 100644
@@ -142,7 +142,7 @@ struct mfptimerbase {
 	.name		= "MFP Timer D"
 };
 
-static irqreturn_t mfptimer_handler(int irq, void *dev_id)
+static irqreturn_t mfp_timer_d_handler(int irq, void *dev_id)
 {
 	struct mfptimerbase *base = dev_id;
 	int mach_irq;
@@ -344,7 +344,7 @@ void __init atari_init_IRQ(void)
 	st_mfp.tim_ct_cd = (st_mfp.tim_ct_cd & 0xf0) | 0x6;
 
 	/* request timer D dispatch handler */
-	if (request_irq(IRQ_MFP_TIMD, mfptimer_handler, IRQF_SHARED,
+	if (request_irq(IRQ_MFP_TIMD, mfp_timer_d_handler, IRQF_SHARED,
 			stmfp_base.name, &stmfp_base))
 		pr_err("Couldn't register %s interrupt\n", stmfp_base.name);
 
arch/m68k/atari/time.c +14 -1
index 9cca64286464c..fafa20f75ab9a 100644
@@ -24,6 +24,18 @@
 DEFINE_SPINLOCK(rtc_lock);
 EXPORT_SYMBOL_GPL(rtc_lock);
 
+static irqreturn_t mfp_timer_c_handler(int irq, void *dev_id)
+{
+	irq_handler_t timer_routine = dev_id;
+	unsigned long flags;
+
+	local_irq_save(flags);
+	timer_routine(0, NULL);
+	local_irq_restore(flags);
+
+	return IRQ_HANDLED;
+}
+
 void __init
 atari_sched_init(irq_handler_t timer_routine)
 {
@@ -32,7 +44,8 @@ atari_sched_init(irq_handler_t timer_routine)
     /* start timer C, div = 1:100 */
     st_mfp.tim_ct_cd = (st_mfp.tim_ct_cd & 15) | 0x60;
     /* install interrupt service routine for MFP Timer C */
-    if (request_irq(IRQ_MFP_TIMC, timer_routine, 0, "timer", timer_routine))
+    if (request_irq(IRQ_MFP_TIMC, mfp_timer_c_handler, 0, "timer",
+                    timer_routine))
 	pr_err("Couldn't register timer interrupt\n");
 }
 
arch/m68k/bvme6000/config.c +10 -10
index 143ee9fa3893e..0e5efed4da865 100644
@@ -44,11 +44,6 @@ extern int bvme6000_hwclk (int, struct rtc_time *);
 extern void bvme6000_reset (void);
 void bvme6000_set_vectors (void);
 
-/* Save tick handler routine pointer, will point to xtime_update() in
- * kernel/timer/timekeeping.c, called via bvme6000_process_int() */
-
-static irq_handler_t tick_handler;
-
 
 int __init bvme6000_parse_bootinfo(const struct bi_record *bi)
 {
@@ -157,12 +152,18 @@ irqreturn_t bvme6000_abort_int (int irq, void *dev_id)
 
 static irqreturn_t bvme6000_timer_int (int irq, void *dev_id)
 {
+    irq_handler_t timer_routine = dev_id;
+    unsigned long flags;
     volatile RtcPtr_t rtc = (RtcPtr_t)BVME_RTC_BASE;
-    unsigned char msr = rtc->msr & 0xc0;
+    unsigned char msr;
 
+    local_irq_save(flags);
+    msr = rtc->msr & 0xc0;
     rtc->msr = msr | 0x20;		/* Ack the interrupt */
+    timer_routine(0, NULL);
+    local_irq_restore(flags);
 
-    return tick_handler(irq, dev_id);
+    return IRQ_HANDLED;
 }
 
 /*
@@ -181,9 +182,8 @@ void bvme6000_sched_init (irq_handler_t timer_routine)
 
     rtc->msr = 0;	/* Ensure timer registers accessible */
 
-    tick_handler = timer_routine;
-    if (request_irq(BVME_IRQ_RTC, bvme6000_timer_int, 0,
-				"timer", bvme6000_timer_int))
+    if (request_irq(BVME_IRQ_RTC, bvme6000_timer_int, 0, "timer",
+                    timer_routine))
 	panic ("Couldn't register timer int");
 
     rtc->t1cr_omr = 0x04;	/* Mode 2, ext clk */
arch/m68k/hp300/time.c +8 -2
index 289d928a46cbe..d30b03ea93a27 100644
@@ -38,13 +38,19 @@
 
 static irqreturn_t hp300_tick(int irq, void *dev_id)
 {
+	irq_handler_t timer_routine = dev_id;
+	unsigned long flags;
 	unsigned long tmp;
-	irq_handler_t vector = dev_id;
+
+	local_irq_save(flags);
 	in_8(CLOCKBASE + CLKSR);
 	asm volatile ("movpw %1@(5),%0" : "=d" (tmp) : "a" (CLOCKBASE));
+	timer_routine(0, NULL);
+	local_irq_restore(flags);
+
 	/* Turn off the network and SCSI leds */
 	blinken_leds(0, 0xe0);
-	return vector(irq, NULL);
+	return IRQ_HANDLED;
 }
 
 u32 hp300_gettimeoffset(void)
arch/m68k/mac/via.c +17 -0
index 288ec3aa5b575..038d5a1c4d484 100644
@@ -387,6 +387,8 @@ void via_nubus_irq_shutdown(int irq)
  * via6522.c :-), disable/pending masks added.
  */
 
+#define VIA_TIMER_1_INT BIT(6)
+
 void via1_irq(struct irq_desc *desc)
 {
 	int irq_num;
@@ -396,6 +398,21 @@ void via1_irq(struct irq_desc *desc)
 	if (!events)
 		return;
 
+	irq_num = IRQ_MAC_TIMER_1;
+	irq_bit = VIA_TIMER_1_INT;
+	if (events & irq_bit) {
+		unsigned long flags;
+
+		local_irq_save(flags);
+		via1[vIFR] = irq_bit;
+		generic_handle_irq(irq_num);
+		local_irq_restore(flags);
+
+		events &= ~irq_bit;
+		if (!events)
+			return;
+	}
+
 	irq_num = VIA1_SOURCE_BASE;
 	irq_bit = 1;
 	do {
arch/m68k/mvme147/config.c +10 -8
index adea549d240e9..93c68d2b8e0ea 100644
@@ -45,11 +45,6 @@ extern void mvme147_reset (void);
 
 static int bcd2int (unsigned char b);
 
-/* Save tick handler routine pointer, will point to xtime_update() in
- * kernel/time/timekeeping.c, called via mvme147_process_int() */
-
-irq_handler_t tick_handler;
-
 
 int __init mvme147_parse_bootinfo(const struct bi_record *bi)
 {
@@ -104,16 +99,23 @@ void __init config_mvme147(void)
 
 static irqreturn_t mvme147_timer_int (int irq, void *dev_id)
 {
+	irq_handler_t timer_routine = dev_id;
+	unsigned long flags;
+
+	local_irq_save(flags);
 	m147_pcc->t1_int_cntrl = PCC_TIMER_INT_CLR;
 	m147_pcc->t1_int_cntrl = PCC_INT_ENAB|PCC_LEVEL_TIMER1;
-	return tick_handler(irq, dev_id);
+	timer_routine(0, NULL);
+	local_irq_restore(flags);
+
+	return IRQ_HANDLED;
 }
 
 
 void mvme147_sched_init (irq_handler_t timer_routine)
 {
-	tick_handler = timer_routine;
-	if (request_irq(PCC_IRQ_TIMER1, mvme147_timer_int, 0, "timer 1", NULL))
+	if (request_irq(PCC_IRQ_TIMER1, mvme147_timer_int, 0, "timer 1",
+			timer_routine))
 		pr_err("Couldn't register timer interrupt\n");
 
 	/* Init the clock with a value */
arch/m68k/mvme16x/config.c +11 -10
index 6ee36a5b528d8..5feb3ab484d08 100644
@@ -50,11 +50,6 @@ extern void mvme16x_reset (void);
 
 int bcd2int (unsigned char b);
 
-/* Save tick handler routine pointer, will point to xtime_update() in
- * kernel/time/timekeeping.c, called via mvme16x_process_int() */
-
-static irq_handler_t tick_handler;
-
 
 unsigned short mvme16x_config;
 EXPORT_SYMBOL(mvme16x_config);
@@ -352,8 +347,15 @@ static irqreturn_t mvme16x_abort_int (int irq, void *dev_id)
 
 static irqreturn_t mvme16x_timer_int (int irq, void *dev_id)
 {
-    *(volatile unsigned char *)0xfff4201b |= 8;
-    return tick_handler(irq, dev_id);
+	irq_handler_t timer_routine = dev_id;
+	unsigned long flags;
+
+	local_irq_save(flags);
+	*(volatile unsigned char *)0xfff4201b |= 8;
+	timer_routine(0, NULL);
+	local_irq_restore(flags);
+
+	return IRQ_HANDLED;
 }
 
 void mvme16x_sched_init (irq_handler_t timer_routine)
@@ -361,14 +363,13 @@ void mvme16x_sched_init (irq_handler_t timer_routine)
     uint16_t brdno = be16_to_cpu(mvme_bdid.brdno);
     int irq;
 
-    tick_handler = timer_routine;
     /* Using PCCchip2 or MC2 chip tick timer 1 */
     *(volatile unsigned long *)0xfff42008 = 0;
     *(volatile unsigned long *)0xfff42004 = 10000;	/* 10ms */
     *(volatile unsigned char *)0xfff42017 |= 3;
     *(volatile unsigned char *)0xfff4201b = 0x16;
-    if (request_irq(MVME16x_IRQ_TIMER, mvme16x_timer_int, 0,
-				"timer", mvme16x_timer_int))
+    if (request_irq(MVME16x_IRQ_TIMER, mvme16x_timer_int, 0, "timer",
+                    timer_routine))
 	panic ("Couldn't register timer int");
 
     if (brdno == 0x0162 || brdno == 0x172)
arch/m68k/q40/q40ints.c +11 -8
index 3e7603202977e..1c696906c159f 100644
@@ -127,10 +127,10 @@ void q40_mksound(unsigned int hz, unsigned int ticks)
 	sound_ticks = ticks << 1;
 }
 
-static irq_handler_t q40_timer_routine;
-
-static irqreturn_t q40_timer_int (int irq, void * dev)
+static irqreturn_t q40_timer_int(int irq, void *dev_id)
 {
+	irq_handler_t timer_routine = dev_id;
+
 	ql_ticks = ql_ticks ? 0 : 1;
 	if (sound_ticks) {
 		unsigned char sval=(sound_ticks & 1) ? 128-SVOL : 128+SVOL;
@@ -139,8 +139,13 @@ static irqreturn_t q40_timer_int (int irq, void * dev)
 		*DAC_RIGHT=sval;
 	}
 
-	if (!ql_ticks)
-		q40_timer_routine(irq, dev);
+	if (!ql_ticks) {
+		unsigned long flags;
+
+		local_irq_save(flags);
+		timer_routine(0, NULL);
+		local_irq_restore(flags);
+	}
 	return IRQ_HANDLED;
 }
 
@@ -148,11 +153,9 @@ void q40_sched_init (irq_handler_t timer_routine)
 {
 	int timer_irq;
 
-	q40_timer_routine = timer_routine;
 	timer_irq = Q40_IRQ_FRAME;
 
-	if (request_irq(timer_irq, q40_timer_int, 0,
-				"timer", q40_timer_int))
+	if (request_irq(timer_irq, q40_timer_int, 0, "timer", timer_routine))
 		panic("Couldn't register timer int");
 
 	master_outb(-1, FRAME_CLEAR_REG);
arch/m68k/sun3/sun3ints.c +3 -0
index 6bbca30c91884..a5824abb4a39c 100644
@@ -61,8 +61,10 @@ static irqreturn_t sun3_int7(int irq, void *dev_id)
 
 static irqreturn_t sun3_int5(int irq, void *dev_id)
 {
+	unsigned long flags;
 	unsigned int cnt;
 
+	local_irq_save(flags);
 #ifdef CONFIG_SUN3
 	intersil_clear();
 #endif
@@ -76,6 +78,7 @@ static irqreturn_t sun3_int5(int irq, void *dev_id)
 	cnt = kstat_irqs_cpu(irq, 0);
 	if (!(cnt % 20))
 		sun3_leds(led_pattern[cnt % 160 / 20]);
+	local_irq_restore(flags);
 	return IRQ_HANDLED;
 }
 
arch/m68k/sun3x/time.c +10 -6
index 047e2bcee3d7a..3c8a86d085084 100644
@@ -80,15 +80,19 @@ u32 sun3x_gettimeoffset(void)
 }
 
 #if 0
-static void sun3x_timer_tick(int irq, void *dev_id, struct pt_regs *regs)
+static irqreturn_t sun3x_timer_tick(int irq, void *dev_id)
 {
-    void (*vector)(int, void *, struct pt_regs *) = dev_id;
+	irq_handler_t timer_routine = dev_id;
+	unsigned long flags;
 
-    /* Clear the pending interrupt - pulse the enable line low */
-    disable_irq(5);
-    enable_irq(5);
+	local_irq_save(flags);
+	/* Clear the pending interrupt - pulse the enable line low */
+	disable_irq(5);
+	enable_irq(5);
+	timer_routine(0, NULL);
+	local_irq_restore(flags);
 
-    vector(irq, NULL, regs);
+	return IRQ_HANDLED;
 }
 #endif
 
Signature · 1 line
2.20.1
maintainer
#664 lore raw
In reply to Greg Kroah-Hartman

Hi Greg,

Quoted 20 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

...

Quoted 2 lines

Rafael J. Wysocki <[email protected]>
PCI: PM: Skip devices in D0 for suspend-to-idle

The above commit is causing a suspend regression on Tegra124 Jetson-TK1. Reverting this on top of v4.19.99-rc1 fixes the issue.

Cheers
Jon

Signature · 1 line
nvpublic
author maintainer
#665 lore raw
Quoted 24 lines · Jon Hunter

Hi Greg,

Quoted 14 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

Quoted 6 lines

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Quoted 7 lines

...

Quoted 2 lines

Rafael J. Wysocki <[email protected]>
PCI: PM: Skip devices in D0 for suspend-to-idle

The above commit is causing a suspend regression on Tegra124 Jetson-TK1. Reverting this on top of v4.19.99-rc1 fixes the issue.

This is also in the 4.14 queue, so should I drop it there too?

thanks,

greg k-h

maintainer
#666 lore raw
Quoted 27 lines · Greg Kroah-Hartman
Quoted 26 lines · Jon Hunter

Hi Greg,

Quoted 20 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

...

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Rafael J. Wysocki <[email protected]>
PCI: PM: Skip devices in D0 for suspend-to-idle

The above commit is causing a suspend regression on Tegra124 Jetson-TK1. Reverting this on top of v4.19.99-rc1 fixes the issue.

This is also in the 4.14 queue, so should I drop it there too?

I did not see any failures with the same board on that branch, so I would say no, but odd that it only fails here. It was failing for me 100% so I would have expected to see if there too if it was a problem.

Jon

Signature · 1 line
nvpublic
maintainer
#667 lore raw
Quoted 32 lines · Jon Hunter
Quoted 30 lines · Greg Kroah-Hartman
Quoted 29 lines · Jon Hunter

Hi Greg,

Quoted 20 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

...

Quoted 2 lines

Rafael J. Wysocki <[email protected]>
PCI: PM: Skip devices in D0 for suspend-to-idle

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

The above commit is causing a suspend regression on Tegra124 Jetson-TK1. Reverting this on top of v4.19.99-rc1 fixes the issue.

This is also in the 4.14 queue, so should I drop it there too?

I did not see any failures with the same board on that branch, so I would say no, but odd that it only fails here. It was failing for me 100% so I would have expected to see if there too if it was a problem.

Hmmm, rc2 still not working for me ...

Test results for stable-v4.19:

    11 builds:	11 pass, 0 fail
    22 boots:	22 pass, 0 fail
    32 tests:	30 pass, 2 fail

Linux version: 4.19.99-rc2-g24832ad2c623
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,

                tegra194-p2972-0000, tegra20-ventana,
                tegra210-p2371-2180, tegra30-cardhu-a04

I still see the following commit in rc2 ...

commit bb52152abe85f971278a7a4f033b29483f64bfdb

Author: Rafael J. Wysocki <[email protected]>
Date:   Thu Jun 13 23:59:45 2019 +0200

PCI: PM: Skip devices in D0 for suspend-to-idle

BTW, I checked the 4.14. queue and I do not see the above change in there, however, there is similar change ...

Rafael J. Wysocki <[email protected]>
PCI: PM: Avoid possible suspend-to-idle issue

Cheers
Jon

Signature · 1 line
nvpublic
#668 lore raw
Quoted 61 lines · Jon Hunter
Quoted 32 lines · Jon Hunter
Quoted 30 lines · Greg Kroah-Hartman
Quoted 29 lines · Jon Hunter

Hi Greg,

Quoted 20 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

...

Quoted 2 lines

Rafael J. Wysocki <[email protected]>
PCI: PM: Skip devices in D0 for suspend-to-idle

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

The above commit is causing a suspend regression on Tegra124 Jetson-TK1. Reverting this on top of v4.19.99-rc1 fixes the issue.

This is also in the 4.14 queue, so should I drop it there too?

I did not see any failures with the same board on that branch, so I would say no, but odd that it only fails here. It was failing for me 100% so I would have expected to see if there too if it was a problem.

Hmmm, rc2 still not working for me ...

Test results for stable-v4.19:

     11 builds:	11 pass, 0 fail
     22 boots:	22 pass, 0 fail
     32 tests:	30 pass, 2 fail

Linux version: 4.19.99-rc2-g24832ad2c623
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,

                 tegra194-p2972-0000, tegra20-ventana,
                 tegra210-p2371-2180, tegra30-cardhu-a04

I still see the following commit in rc2 ...

commit bb52152abe85f971278a7a4f033b29483f64bfdb

Author: Rafael J. Wysocki <[email protected]>
Date:   Thu Jun 13 23:59:45 2019 +0200
Quoted 8 lines

PCI: PM: Skip devices in D0 for suspend-to-idle

BTW, I checked the 4.14. queue and I do not see the above change in there, however, there is similar change ...

Rafael J. Wysocki <[email protected]>
PCI: PM: Avoid possible suspend-to-idle issue

bb52152abe85 fixes this one, which in turn fixes 33e4f80ee69b. The above in 4.14 but not its fixes is spelling a bit of trouble.

Maybe commit 471a739a47aa7 ("PCI: PM: Avoid skipping bus-level PM on platforms without ACPI") was added to -rc2, since it is supposed to fix bb52152abe85.

Guenter

author maintainer
#669 lore raw
Quoted 56 lines · Guenter Roeck
Quoted 55 lines · Jon Hunter
Quoted 32 lines · Jon Hunter
Quoted 30 lines · Greg Kroah-Hartman
Quoted 29 lines · Jon Hunter

Hi Greg,

Quoted 20 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

...

Quoted 2 lines

Rafael J. Wysocki <[email protected]>
PCI: PM: Skip devices in D0 for suspend-to-idle

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

The above commit is causing a suspend regression on Tegra124 Jetson-TK1. Reverting this on top of v4.19.99-rc1 fixes the issue.

This is also in the 4.14 queue, so should I drop it there too?

I did not see any failures with the same board on that branch, so I would say no, but odd that it only fails here. It was failing for me 100% so I would have expected to see if there too if it was a problem.

Hmmm, rc2 still not working for me ...

Test results for stable-v4.19:

     11 builds:	11 pass, 0 fail
     22 boots:	22 pass, 0 fail
     32 tests:	30 pass, 2 fail

Linux version: 4.19.99-rc2-g24832ad2c623
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,

                 tegra194-p2972-0000, tegra20-ventana,
                 tegra210-p2371-2180, tegra30-cardhu-a04
Quoted 7 lines
Quoted 7 lines

I still see the following commit in rc2 ...

commit bb52152abe85f971278a7a4f033b29483f64bfdb

Author: Rafael J. Wysocki <[email protected]>
Date:   Thu Jun 13 23:59:45 2019 +0200

PCI: PM: Skip devices in D0 for suspend-to-idle

Yes, I did not change anything in -rc2 for you, sorry.

Quoted 6 lines
Quoted 6 lines

BTW, I checked the 4.14. queue and I do not see the above change in there, however, there is similar change ...

Rafael J. Wysocki <[email protected]>
PCI: PM: Avoid possible suspend-to-idle issue

Quoted 6 lines

bb52152abe85 fixes this one, which in turn fixes 33e4f80ee69b. The above in 4.14 but not its fixes is spelling a bit of trouble.

Maybe commit 471a739a47aa7 ("PCI: PM: Avoid skipping bus-level PM on platforms without ACPI") was added to -rc2, since it is supposed to fix bb52152abe85.

I have added that fix to 4.14 now, and will go push out a -rc3 for both 4.19.y and 4.14.y to try to sync up on this and figure it out.

Jon, if you could retest 4.14.y, that would be great, to see if it has the same issue that 4.19.y has. And if so, that means I should probably just drop both patches from both trees, right?

thanks,

greg k-h

maintainer
#670 lore raw
Quoted 80 lines · Greg Kroah-Hartman
Quoted 56 lines · Guenter Roeck
Quoted 55 lines · Jon Hunter
Quoted 32 lines · Jon Hunter
Quoted 30 lines · Greg Kroah-Hartman
Quoted 29 lines · Jon Hunter

Hi Greg,

Quoted 20 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

...

Quoted 2 lines

Rafael J. Wysocki <[email protected]>
PCI: PM: Skip devices in D0 for suspend-to-idle

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

The above commit is causing a suspend regression on Tegra124 Jetson-TK1. Reverting this on top of v4.19.99-rc1 fixes the issue.

This is also in the 4.14 queue, so should I drop it there too?

I did not see any failures with the same board on that branch, so I would say no, but odd that it only fails here. It was failing for me 100% so I would have expected to see if there too if it was a problem.

Hmmm, rc2 still not working for me ...

Test results for stable-v4.19:

     11 builds:	11 pass, 0 fail
     22 boots:	22 pass, 0 fail
     32 tests:	30 pass, 2 fail

Linux version: 4.19.99-rc2-g24832ad2c623
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,

                 tegra194-p2972-0000, tegra20-ventana,
                 tegra210-p2371-2180, tegra30-cardhu-a04
Quoted 7 lines
Quoted 7 lines

I still see the following commit in rc2 ...

commit bb52152abe85f971278a7a4f033b29483f64bfdb

Author: Rafael J. Wysocki <[email protected]>
Date:   Thu Jun 13 23:59:45 2019 +0200

PCI: PM: Skip devices in D0 for suspend-to-idle

Yes, I did not change anything in -rc2 for you, sorry.

Quoted 6 lines
Quoted 6 lines

BTW, I checked the 4.14. queue and I do not see the above change in there, however, there is similar change ...

Rafael J. Wysocki <[email protected]>
PCI: PM: Avoid possible suspend-to-idle issue

Quoted 6 lines

bb52152abe85 fixes this one, which in turn fixes 33e4f80ee69b. The above in 4.14 but not its fixes is spelling a bit of trouble.

Maybe commit 471a739a47aa7 ("PCI: PM: Avoid skipping bus-level PM on platforms without ACPI") was added to -rc2, since it is supposed to fix bb52152abe85.

Quoted 6 lines

I have added that fix to 4.14 now, and will go push out a -rc3 for both 4.19.y and 4.14.y to try to sync up on this and figure it out.

Jon, if you could retest 4.14.y, that would be great, to see if it has the same issue that 4.19.y has. And if so, that means I should probably just drop both patches from both trees, right?

So v4.19 is still failing for me ...

Test results for stable-v4.19:

    11 builds:  11 pass, 0 fail
    22 boots:   22 pass, 0 fail
    32 tests:   30 pass, 2 fail
Linux version:  4.19.99-rc3-g041f280e6a1a
Boards tested:  tegra124-jetson-tk1, tegra186-p2771-0000,
                tegra194-p2972-0000, tegra20-ventana,
                tegra210-p2371-2180, tegra30-cardhu-a04

However, I am not seeing any issues with v4.14, so still not clear what is going on here.

Cheers
Jon

Signature · 1 line
nvpublic
author maintainer
#671 lore raw
Quoted 97 lines · Jon Hunter
Quoted 80 lines · Greg Kroah-Hartman
Quoted 56 lines · Guenter Roeck
Quoted 55 lines · Jon Hunter
Quoted 32 lines · Jon Hunter
Quoted 30 lines · Greg Kroah-Hartman
Quoted 29 lines · Jon Hunter

Hi Greg,

Quoted 20 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

...

Quoted 2 lines

Rafael J. Wysocki <[email protected]>
PCI: PM: Skip devices in D0 for suspend-to-idle

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

The above commit is causing a suspend regression on Tegra124 Jetson-TK1. Reverting this on top of v4.19.99-rc1 fixes the issue.

This is also in the 4.14 queue, so should I drop it there too?

I did not see any failures with the same board on that branch, so I would say no, but odd that it only fails here. It was failing for me 100% so I would have expected to see if there too if it was a problem.

Hmmm, rc2 still not working for me ...

Test results for stable-v4.19:

     11 builds:	11 pass, 0 fail
     22 boots:	22 pass, 0 fail
     32 tests:	30 pass, 2 fail

Linux version: 4.19.99-rc2-g24832ad2c623
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,

                 tegra194-p2972-0000, tegra20-ventana,
                 tegra210-p2371-2180, tegra30-cardhu-a04
Quoted 7 lines
Quoted 7 lines

I still see the following commit in rc2 ...

commit bb52152abe85f971278a7a4f033b29483f64bfdb

Author: Rafael J. Wysocki <[email protected]>
Date:   Thu Jun 13 23:59:45 2019 +0200

PCI: PM: Skip devices in D0 for suspend-to-idle

Yes, I did not change anything in -rc2 for you, sorry.

Quoted 6 lines
Quoted 6 lines

BTW, I checked the 4.14. queue and I do not see the above change in there, however, there is similar change ...

Rafael J. Wysocki <[email protected]>
PCI: PM: Avoid possible suspend-to-idle issue

Quoted 6 lines

bb52152abe85 fixes this one, which in turn fixes 33e4f80ee69b. The above in 4.14 but not its fixes is spelling a bit of trouble.

Maybe commit 471a739a47aa7 ("PCI: PM: Avoid skipping bus-level PM on platforms without ACPI") was added to -rc2, since it is supposed to fix bb52152abe85.

Quoted 6 lines

I have added that fix to 4.14 now, and will go push out a -rc3 for both 4.19.y and 4.14.y to try to sync up on this and figure it out.

Jon, if you could retest 4.14.y, that would be great, to see if it has the same issue that 4.19.y has. And if so, that means I should probably just drop both patches from both trees, right?

So v4.19 is still failing for me ...

Test results for stable-v4.19:

    11 builds:  11 pass, 0 fail
    22 boots:   22 pass, 0 fail
    32 tests:   30 pass, 2 fail
Quoted 7 lines
Linux version:  4.19.99-rc3-g041f280e6a1a
Boards tested:  tegra124-jetson-tk1, tegra186-p2771-0000,
                tegra194-p2972-0000, tegra20-ventana,
                tegra210-p2371-2180, tegra30-cardhu-a04

However, I am not seeing any issues with v4.14, so still not clear what is going on here.

Ugh, odd. Ok, I'll go drop both patches from both trees and do some releases in a few hours and then try adding them back so we can do a bit more debugging without the deadline of the release being on us.

thanks so much for letting me know!

greg k-h

#672 lore raw
In reply to Greg Kroah-Hartman
Quoted 15 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

        https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

Quoted 6 lines

thanks,

greg k-h

Petr Machata <[email protected]>
vxlan: changelink: Fix handling of default remotes

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

selftest / net / test_vxlan_fdb_changelink.sh fixed.

Summary
------------------------------------------------------------------------

kernel: 4.19.99-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.19.y
git commit: d521598bed2464511b7d1f1dd553132c7b658394
git describe: v4.19.98-640-gd521598bed24
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.19-oe/build/v4.19.98-640-gd521598bed24

No regressions (compared to build v4.19.98)

Fixes (compared to build v4.19.98)
------------------------------------------------------------------------
kselftest:
* net_test_vxlan_fdb_changelink.sh

Ran 24093 total tests in the following environments and test suites.

Environments
--------------
- dragonboard-410c - arm64
- hi6220-hikey - arm64
- i386
- juno-r2 - arm64
- nxp-ls2088
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15 - arm
- x86_64

Test Suites
-----------
* build
* install-android-platform-tools-r2600
* libhugetlbfs
* linux-log-parser
* ltp-containers-tests
* ltp-ipc-tests
* ltp-hugetlb-tests
* ltp-mm-tests
* kselftest
* kvm-unit-tests
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-cpuhotplug-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-io-tests
* ltp-math-tests
* ltp-nptl-tests
* ltp-open-posix-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* network-basic-tests
* spectre-meltdown-checker-test
* v4l2-compliance
* perf
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none

Signature · 2 lines
Linaro LKFT
https://lkft.linaro.org
#673 lore raw
In reply to Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 9 lines
	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

Compiled and booted on my test system. No dmesg regressions.

thanks,
-- Shuah

#674 lore raw
In reply to Greg Kroah-Hartman
Quoted 8 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

For v4.19.98-638-g24832ad2c623:

Build results:

	total: 156 pass: 156 fail: 0
Qemu test results:
	total: 383 pass: 383 fail: 0

Guenter

maintainer
#675 lore raw

Hi Guenter,

Quoted 11 lines · Guenter Roeck
Quoted 8 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

For v4.19.98-638-g24832ad2c623:

This does not appear to be the correct tag/version for this review.

Cheers
Jon

Signature · 1 line
nvpublic
#676 lore raw
Quoted 9 lines · Jon Hunter

Hi Guenter,

Quoted 6 lines · Guenter Roeck
Quoted 5 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

For v4.19.98-638-g24832ad2c623:

This does not appear to be the correct tag/version for this review.

It is the tip of v4.19.y.queue in my test system.

$ git describe local-stable/linux-4.19.y.queue
v4.19.98-638-g24832ad2c623

and the tip of the stable-queue repository as of right now.

$ git describe stable-queue/linux-4.19.y
v4.19.98-638-g24832ad2c623
$ git remote -v | grep stable-queue
stable-queue	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git (fetch)
stable-queue	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git (push)

What is wrong with it ?

Guenter

maintainer
#677 lore raw
Quoted 36 lines · Guenter Roeck
Quoted 9 lines · Jon Hunter

Hi Guenter,

Quoted 6 lines · Guenter Roeck
Quoted 5 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.99 release. There are 639 patches in this series, all will be posted as a response to this one.  If anyone has any issues with these being applied, please let me know.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000. Anything received after that time might be too late.

For v4.19.98-638-g24832ad2c623:

This does not appear to be the correct tag/version for this review.

It is the tip of v4.19.y.queue in my test system.

$ git describe local-stable/linux-4.19.y.queue
v4.19.98-638-g24832ad2c623

and the tip of the stable-queue repository as of right now.

$ git describe stable-queue/linux-4.19.y
v4.19.98-638-g24832ad2c623
$ git remote -v | grep stable-queue
stable-queue   
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
(fetch)
stable-queue   
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
(push)
Quoted 1 line

What is wrong with it ?

Ah you are right, there is nothing wrong now I look at the git describe output. At first glance I thought the tag was not correct.

Sorry for the noise.

Jon

Signature · 1 line
nvpublic