s390x: sigp: Fix sense running reporting
PATCH v2 1/1 s390x: sigp: Fix sense running reporting
The logic was inverted and reported running if the cpu was stopped. Let's fix that.
Signed-off-by Janosch Frank <[email protected]>
Fixes d1b468bc8869 ("s390x/tcg: implement SIGP SENSE RUNNING STATUS")
Reviewed-by David Hildenbrand <[email protected]>
---
Switched the actions instead of the condition so the comment still applies.
--- target/s390x/sigp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
target/s390x/sigp.c +2 -2
@@ -348,9 +348,9 @@ static void sigp_sense_running(S390CPU *dst_cpu, SigpInfo *si)/* If halted (which includes also STOPPED), it is not running */ if (CPU (dst_cpu)->halted) { - si->cc =SIGP_CC_ORDER_CODE_ACCEPTED ; - }else {set_sigp_status (si,SIGP_STAT_NOT_RUNNING ); + }else { + si->cc =SIGP_CC_ORDER_CODE_ACCEPTED ; } }
Signature · 1 line
2.20.1
Cornelia Huck
AppliedQuoted 6 lines · On Fri, 24 Jan 2020 08:48:18 -0500 Janosch Frank <[email protected]> wrote:
The logic was inverted and reported running if the cpu was stopped. Let's fix that.
Signed-off-by Janosch Frank <[email protected]>Fixes d1b468bc8869 ("s390x/tcg: implement SIGP SENSE RUNNING STATUS")Reviewed-by David Hildenbrand <[email protected]>
Quoted 8 lines
---
Switched the actions instead of the condition so the comment still applies.
--- target/s390x/sigp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied.