build-sys: fix configure --without-systemd
PATCH 1/1 build-sys: fix configure --without-systemd
--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -1
@@ -2215,7 +2215,7 @@ AM_CONDITIONAL([HAVE_BTRFS], [test "x$have_btrfs" = xyes]) AC_ARG_WITH([systemd], AS_HELP_STRING([--without-systemd], [do not build with systemd support]), - [], [with_systemd=check] + [], [with_systemd=no] ) have_systemd=no
Signature · 1 line
2.24.1
Karel Zak
maintainerQuoted 10 lines · Theodore Ts'o
Signed-off-by Theodore Ts'o <[email protected]>--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configure.ac +0
-0
configure.ac AM_CONDITIONAL([HAVE_BTRFS], [test "x$have_btrfs" = xyes]) · line 2218
Quoted 5 lines
configure.ac +1
-1@@ -2215,7 +2215,7 @@ AM_CONDITIONAL([HAVE_BTRFS], [test "x$have_btrfs" = xyes]) AC_ARG_WITH([systemd], AS_HELP_STRING([--without-systemd], [do not build with systemd support]), - [], [with_systemd=check] + [], [with_systemd=no]
The current default is to check for the libraries, if installed than enable systemd support. This is generic way we use for many libs and features. Why do you think that explicit --enable-* will be better?
Karel
Signature · 2 lines
Karel Zak <[email protected]> http://karelzak.blogspot.com
Quoted 8 lines · Karel Zak
configure.ac AM_CONDITIONAL([HAVE_BTRFS], [test "x$have_btrfs" = xyes]) · line 2218
Quoted 5 lines · Theodore Ts'o
AC_ARG_WITH([systemd],
AS_HELP_STRING([--without-systemd], [do not build with systemd support]),configure.ac +1
-1- [], [with_systemd=check] + [], [with_systemd=no]
Quoted 4 lines
The current default is to check for the libraries, if installed than enable systemd support. This is generic way we use for many libs and features. Why do you think that explicit --enable-* will be better?
---
Perhaps Ted didn't realize that the line he replaced
was only the default action (1st bracket pair empty => no option). Initially, I thought the same until I read further
down (two lines):
have_systemd=no
AS_IF([test "x$with_systemd" != xno], [ ...
test for positive case ]
If any of the tests fail, then 'have_systemd=no'
is the option passed along.
I don't _think_ Ted is asking for for the default to be changed, as the subject of his note states it is to fix the "--without-systemd" case, but a
fix was added for a bug that wasn't present, so I don't think he knowingly did what he intended to do.