Skip to contentSkip to conversation

lib: Kconfig dependencies for seudo-random library

PATCH Superseded Heinrich Schuchardt 3 participants 4 messages Jan 19, 2020 – Jan 30, 2020 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: Kconfig dependencies for seudo-random library

drivers/rng/sandbox_rng.c requires rand() to be defined but configuration option CONFIG_CONFIG_LIB_RAND selected in drivers/rng/Kconfig does not exist.

test/lib/test_aes.c requires rand() to be defined.

Fix the selection criteria for choice "Pseudo-random library support type".

---
 drivers/rng/Kconfig | 1 -
 lib/Kconfig         | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/rng/Kconfig +0 -1
index 35a3bd192a..893b89d49b 100644
@@ -9,7 +9,6 @@ config DM_RNG
 config RNG_SANDBOX
 	bool "Sandbox random number generator"
 	depends on SANDBOX && DM_RNG
-	select CONFIG_LIB_RAND
 	help
 	  Enable random number generator for sandbox. This is an
 	  emulation of a rng device.
lib/Kconfig +2 -1
index d040a87d26..ab6aff710d 100644
@@ -150,7 +150,8 @@ config REGEX
 
 choice
 	prompt "Pseudo-random library support type"
-	depends on NET_RANDOM_ETHADDR || RANDOM_UUID || CMD_UUID
+	depends on NET_RANDOM_ETHADDR || RANDOM_UUID || CMD_UUID || \
+		   RNG_SANDBOX || UT_LIB && AES
 	default LIB_RAND
 	help
 	  Select the library to provide pseudo-random number generator

--
2.24.1

#1 lore raw

PATCH v2 1/1 lib: Kconfig dependencies for pseudo-random library

drivers/rng/sandbox_rng.c requires rand() to be defined but configuration option CONFIG_CONFIG_LIB_RAND selected in drivers/rng/Kconfig does not exist.

test/lib/test_aes.c requires rand() to be defined.

Fix the selection criteria for choice "Pseudo-random library support type".

---
v2:
fix typo in title

---
 drivers/rng/Kconfig | 1 -
 lib/Kconfig         | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/rng/Kconfig +0 -1
index 35a3bd192a..893b89d49b 100644
@@ -9,7 +9,6 @@ config DM_RNG
 config RNG_SANDBOX
 	bool "Sandbox random number generator"
 	depends on SANDBOX && DM_RNG
-	select CONFIG_LIB_RAND
 	help
 	  Enable random number generator for sandbox. This is an
 	  emulation of a rng device.
lib/Kconfig +2 -1
index d040a87d26..ab6aff710d 100644
@@ -150,7 +150,8 @@ config REGEX
 
 choice
 	prompt "Pseudo-random library support type"
-	depends on NET_RANDOM_ETHADDR || RANDOM_UUID || CMD_UUID
+	depends on NET_RANDOM_ETHADDR || RANDOM_UUID || CMD_UUID || \
+		   RNG_SANDBOX || UT_LIB && AES
 	default LIB_RAND
 	help
 	  Select the library to provide pseudo-random number generator

--
2.24.1

#2 lore raw

PATCH v2 1/1 lib: Kconfig dependencies for pseudo-random library

Quoted 9 lines · Heinrich Schuchardt

drivers/rng/sandbox_rng.c requires rand() to be defined but configuration option CONFIG_CONFIG_LIB_RAND selected in drivers/rng/Kconfig does not exist.

test/lib/test_aes.c requires rand() to be defined.

Fix the selection criteria for choice "Pseudo-random library support type".

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200125/d3b56e0b/attachment.sig>
#3 lore raw

PATCH 1/1 lib: Kconfig dependencies for seudo-random library

In reply to Heinrich Schuchardt
Quoted 7 lines · Heinrich Schuchardt

drivers/rng/sandbox_rng.c requires rand() to be defined but configuration option CONFIG_CONFIG_LIB_RAND selected in drivers/rng/Kconfig does not exist.

test/lib/test_aes.c requires rand() to be defined.

Quoted 7 lines

Fix the selection criteria for choice "Pseudo-random library support type".

---
 drivers/rng/Kconfig | 1 -
 lib/Kconfig         | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)