Skip to contentSkip to conversation

watchdog: cannot select CONFIG_CONFIG_MPC8xx_WATCHDOG

PATCH New Heinrich Schuchardt 2 participants 2 messages Jan 25, 2020 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: cannot select CONFIG_CONFIG_MPC8xx_WATCHDOG

There is no configuration option CONFIG_CONFIG_MPC8xx_WATCHDOG. So we should not try to select it.

The select statement was introduced in a patch that was meant to only sort config options without changing them.

Fixes b3134ffbd944 ("watchdog: Kconfig: Sort entry alphabetically")
---
 drivers/watchdog/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/Kconfig +0 -1
index 2b8064dfae..8b65b5a88c 100644
@@ -103,7 +103,6 @@ config WDT_CDNS
 config WDT_MPC8xx
 	bool "MPC8xx watchdog timer support"
 	depends on WDT && MPC8xx
-	select CONFIG_MPC8xx_WATCHDOG
 	help
 	   Select this to enable mpc8xx watchdog timer
 

--
2.24.1

#1 lore raw

PATCH 1/1 watchdog: cannot select CONFIG_CONFIG_MPC8xx_WATCHDOG

Quoted 17 lines · Heinrich Schuchardt

There is no configuration option CONFIG_CONFIG_MPC8xx_WATCHDOG. So we should not try to select it.

The select statement was introduced in a patch that was meant to only sort config options without changing them.

Fixes b3134ffbd944 ("watchdog: Kconfig: Sort entry alphabetically")
---
 drivers/watchdog/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/Kconfig +0 -0
index 2b8064dfae..8b65b5a88c 100644

drivers/watchdog/Kconfig config WDT_CDNS · line 107

Quoted 6 lines
drivers/watchdog/Kconfig +0 -1
@@ -103,7 +103,6 @@ config WDT_CDNS
 config WDT_MPC8xx
 	bool "MPC8xx watchdog timer support"
 	depends on WDT && MPC8xx
-	select CONFIG_MPC8xx_WATCHDOG
 	help
 	   Select this to enable mpc8xx watchdog timer

A bit of looking in 'git log' and I think f3729ba6e7b2dff9a6f6e72e8839d99c2e3dbb03 was incomplete, probably due to using 'select CONFIG_...' here rather than just 'select MPC8xx_WATCHDOG'. Can you please finish the migration of things here? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200125/bf8cd364/attachment-0001.sig>