Skip to contentSkip to conversation

Fix building openjre-8 242

PATCH In review Jacob Kroon 3 participants 9 messages Jan 26, 2020 – Feb 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix building openjre-8 242

Hi Richard,

I need something like this in order to build on my Fedora 31 host. I'm using master branches of bitbake, oe-core, meta-openembedded.

Good thing is the crash I reported earlier seems to be fixed.

Cheers,
Jacob

---
 recipes-core/openjdk/openjdk-8-release-common.inc   |  1 +
 recipes-core/openjdk/openjre-8_242.bb               |  2 +-
 .../openjdk/patches-openjdk-8/fix-build.patch       | 13 +++++++++++++
 3 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 recipes-core/openjdk/patches-openjdk-8/fix-build.patch
recipes-core/openjdk/openjdk-8-release-common.inc +1 -0
index a8a653b..bd1b9c0 100644
@@ -9,6 +9,7 @@ PATCHES_URI = "\
     file://0008-autoconf-fix-shark-build-common.patch \
     file://0009-prevent-debuginfo-in-favour-of-openembedded-package-.patch \
     file://0010-autoconf-remove-shell-variables-from-autoheader.patch \
+    file://fix-build.patch \
     ${HOTSPOT_UB_PATCH} \
     file://2001-jdk-comparison-between-pointer-and-integer.patch \
     file://2002-jdk-Allow-using-a-system-installed-libjpeg.patch \
recipes-core/openjdk/openjre-8_242.bb +1 -1
index 4ed2e6b..2c8a6a5 100644
@@ -11,7 +11,7 @@ do_install() {
     cp -rp ${B}/images/j2re-image/* ${D}${JRE_HOME}
     chown -R root:root ${D}${JRE_HOME}
     install -m644 ${WORKDIR}/jvm.cfg  ${D}${JRE_HOME}/lib/${JDK_ARCH}/
-    find ${D}${JDK_HOME} -name "*.debuginfo" -exec rm {} \;
+    [ -d ${D}${JDK_HOME} ] && find ${D}${JDK_HOME} -name "*.debuginfo" -exec rm {} \;
 }
 
 FILES_${PN}_append = "\
recipes-core/openjdk/patches-openjdk-8/fix-build.patch new file +13 -0
new file mode 100644
index 0000000..e35d0eb
@@ -0,0 +1,13 @@
+Index: jdk8u-jdk8u242-ga/jdk/make/gensrc/GensrcMisc.gmk
+===================================================================
+--- jdk8u-jdk8u242-ga.orig/jdk/make/gensrc/GensrcMisc.gmk
++++ jdk8u-jdk8u242-ga/jdk/make/gensrc/GensrcMisc.gmk
+@@ -76,7 +76,7 @@ $(eval $(call SetupNativeCompilation,BUI
+     INCLUDE_FILES := $(GENSRC_SOR_SRC_FILE), \
+     LANG := C, \
+     CC := $(BUILD_CC), \
+-    LDEXE := $(BUILD_LD), \
++    LDEXE := $(BUILD_CC), \
+     OBJECT_DIR := $(GENSRC_SOR_BIN), \
+     OUTPUT_DIR := $(GENSRC_SOR_BIN), \
+     PROGRAM := genSocketOptionRegistry))
Signature · 1 line
2.24.1
#1 lore raw
Quoted 4 lines · Jacob Kroon

Hi Richard,

I need something like this in order to build on my Fedora 31 host. I'm using master branches of bitbake, oe-core, meta-openembedded.

Ok, then please just ignore the mail I sent some minutes ago ;-)

Quoted 2 lines

Good thing is the crash I reported earlier seems to be fixed.

Great!

I'll do some tests on my side and give you feedback afterwards.

Is it OK for you if i rename the "fix-build.patch" to something more meaningful?

regards;rl

Quoted 64 lines

Cheers,
Jacob

---
 recipes-core/openjdk/openjdk-8-release-common.inc   |  1 +
 recipes-core/openjdk/openjre-8_242.bb               |  2 +-
 .../openjdk/patches-openjdk-8/fix-build.patch       | 13 +++++++++++++
 3 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 recipes-core/openjdk/patches-openjdk-8/fix-build.patch
recipes-core/openjdk/openjdk-8-release-common.inc +1 -0
index a8a653b..bd1b9c0 100644
@@ -9,6 +9,7 @@ PATCHES_URI = "\
     file://0008-autoconf-fix-shark-build-common.patch \
     file://0009-prevent-debuginfo-in-favour-of-openembedded-package-.patch \
     file://0010-autoconf-remove-shell-variables-from-autoheader.patch \
+    file://fix-build.patch \
     ${HOTSPOT_UB_PATCH} \
     file://2001-jdk-comparison-between-pointer-and-integer.patch \
     file://2002-jdk-Allow-using-a-system-installed-libjpeg.patch \
recipes-core/openjdk/openjre-8_242.bb +1 -1
index 4ed2e6b..2c8a6a5 100644
@@ -11,7 +11,7 @@ do_install() {
     cp -rp ${B}/images/j2re-image/* ${D}${JRE_HOME}
     chown -R root:root ${D}${JRE_HOME}
     install -m644 ${WORKDIR}/jvm.cfg  ${D}${JRE_HOME}/lib/${JDK_ARCH}/
-    find ${D}${JDK_HOME} -name "*.debuginfo" -exec rm {} \;
+    [ -d ${D}${JDK_HOME} ] && find ${D}${JDK_HOME} -name "*.debuginfo" -exec rm {} \;
 }
 
 FILES_${PN}_append = "\
recipes-core/openjdk/patches-openjdk-8/fix-build.patch new file +13 -0
new file mode 100644
index 0000000..e35d0eb
@@ -0,0 +1,13 @@
+Index: jdk8u-jdk8u242-ga/jdk/make/gensrc/GensrcMisc.gmk
+===================================================================
+--- jdk8u-jdk8u242-ga.orig/jdk/make/gensrc/GensrcMisc.gmk
++++ jdk8u-jdk8u242-ga/jdk/make/gensrc/GensrcMisc.gmk
+@@ -76,7 +76,7 @@ $(eval $(call SetupNativeCompilation,BUI
+     INCLUDE_FILES := $(GENSRC_SOR_SRC_FILE), \
+     LANG := C, \
+     CC := $(BUILD_CC), \
+-    LDEXE := $(BUILD_LD), \
++    LDEXE := $(BUILD_CC), \
+     OBJECT_DIR := $(GENSRC_SOR_BIN), \
+     OUTPUT_DIR := $(GENSRC_SOR_BIN), \
+     PROGRAM := genSocketOptionRegistry))
Signature · 7 lines
2.24.1

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
#2 lore raw
Quoted 9 lines · Richard Leitner
Quoted 4 lines · Jacob Kroon

Hi Richard,

I need something like this in order to build on my Fedora 31 host. I'm using master branches of bitbake, oe-core, meta-openembedded.

Ok, then please just ignore the mail I sent some minutes ago ;-)

Quoted 1 line
Quoted 9 lines
Quoted 1 line

Good thing is the crash I reported earlier seems to be fixed.

Great!

I'll do some tests on my side and give you feedback afterwards.

Is it OK for you if i rename the "fix-build.patch" to something more meaningful?

Yes, feel free to rename/rework anything here to your liking; this was just hacked together to get the build going.

Cheers,
Jacob

#3 lore raw
Quoted 16 lines · Jacob Kroon
Quoted 15 lines · Richard Leitner
Quoted 4 lines · Jacob Kroon

Hi Richard,

I need something like this in order to build on my Fedora 31 host. I'm using master branches of bitbake, oe-core, meta-openembedded.

Ok, then please just ignore the mail I sent some minutes ago ;-)

Quoted 2 lines

Good thing is the crash I reported earlier seems to be fixed.

Great!

I'll do some tests on my side and give you feedback afterwards.

Quoted 8 lines
Quoted 3 lines

Is it OK for you if i rename the "fix-build.patch" to something more meaningful?

Yes, feel free to rename/rework anything here to your liking; this was just hacked together to get the build going.

Cheers,
Jacob

Btw, as I mentioned my build host is an up2date Fedora 31, x86-64. Any idea why these errors aren't showing up on your test builds ?

Cheers,
Jacob

#4 lore raw
Quoted 1 line · Jacob Kroon

On 1/26/20 12:26 PM, Jacob Kroon wrote:

...

Quoted 3 lines

Btw, as I mentioned my build host is an up2date Fedora 31, x86-64. Any idea why these errors aren't showing up on your test builds ?

In my tests I only built the openjdk package, therefore the "find" issue didn't trigger.

The linker errors were fixed in aarch32 [1] and aarch64 [2] upstream. I just double-checked my tests and it seems I only built for those two architectures... Time for me to rework my tests ;-)

So I will adapt and apply your PATCH and push it to the branch. Thanks for your work!
If you have any further feedback/tests for the 242 update please feel free to share ;-)

regards;rl

[1] http://hg.openjdk.java.net/aarch32-port/jdk8u/jdk/rev/4a51a4ac7fc2
[2] https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/391be061dfc7

Quoted 3 lines

Cheers,
Jacob

#5 lore raw

Hi Richard and Jacob,

I just stumbled across the very same error, but on aarch64. I tried to switch to the wip-branch, but I get

ParseError at
/[...]/meta-java/recipes-core/openjdk/openjdk-7_99b00-2.6.5.bb:7: Could not inherit file classes/features_check.bbclass

I am on zeus...

Regards,

Matthias

Quoted 29 lines · Richard Leitner
Quoted 1 line · Jacob Kroon

On 1/26/20 12:26 PM, Jacob Kroon wrote:

...

Quoted 3 lines

Btw, as I mentioned my build host is an up2date Fedora 31, x86-64. Any idea why these errors aren't showing up on your test builds ?

In my tests I only built the openjdk package, therefore the "find" issue didn't trigger.

The linker errors were fixed in aarch32 [1] and aarch64 [2] upstream. I just double-checked my tests and it seems I only built for those two architectures... Time for me to rework my tests ;-)

So I will adapt and apply your PATCH and push it to the branch. Thanks for your work!
If you have any further feedback/tests for the 242 update please feel free to share ;-)

regards;rl

[1] http://hg.openjdk.java.net/aarch32-port/jdk8u/jdk/rev/4a51a4ac7fc2
[2] https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/391be061dfc7

Quoted 3 lines

Cheers,
Jacob

Signature · 2 lines
Dr.-Ing. Matthias Schöpfer
[email protected]
#6 lore raw

Hi Matthias,

Quoted 10 lines · Matthias Schoepfer via Openembedded-devel

Hi Richard and Jacob,

I just stumbled across the very same error, but on aarch64. I tried to switch to the wip-branch, but I get

ParseError at
/[...]/meta-java/recipes-core/openjdk/openjdk-7_99b00-2.6.5.bb:7: Could not inherit file classes/features_check.bbclass

I am on zeus...

This seems legit as AFAIK features_check.bbclass was introduced after the zeus release. For zeus you can replace it with distro_features_check.bbclass, but please note that I haven't tested on zeus. I'm working on master.

Futhermore please use meta-java's master-next branch for testing as I will remove the wip branch in the near future.

thanks for your testing!

regards;rl

Quoted 5 lines

Regards,

Matthias

#7 lore raw

Hi Richard,

I "fixed" it by manually copying feature_check.bbclass into the layer. I can confirm, that your java8u242 works on aarch64 (even could get rid of some patches needed to compile on kernel 5.x)!

Is there anything planed to "backport" it to zeus branch of meta-java?

Thanks and Regards,

Matthias

Quoted 30 lines · Richard Leitner

Hi Matthias,

Quoted 10 lines · Matthias Schoepfer via Openembedded-devel

Hi Richard and Jacob,

I just stumbled across the very same error, but on aarch64. I tried to switch to the wip-branch, but I get

ParseError at
/[...]/meta-java/recipes-core/openjdk/openjdk-7_99b00-2.6.5.bb:7: Could not inherit file classes/features_check.bbclass

I am on zeus...

This seems legit as AFAIK features_check.bbclass was introduced after the zeus release. For zeus you can replace it with distro_features_check.bbclass, but please note that I haven't tested on zeus. I'm working on master.

Futhermore please use meta-java's master-next branch for testing as I will remove the wip branch in the near future.

thanks for your testing!

regards;rl

Quoted 5 lines

Regards,

Matthias

Signature · 2 lines
Dr.-Ing. Matthias Schöpfer
[email protected]
#8 lore raw
Quoted 7 lines · Matthias Schoepfer

Hi Richard,

I "fixed" it by manually copying feature_check.bbclass into the layer. I can confirm, that your java8u242 works on aarch64 (even could get rid of some patches needed to compile on kernel 5.x)!

Is there anything planed to "backport" it to zeus branch of meta-java?

Yes, I'm definitely planning to backport the JDK updates to zeus and warrior.

regards;rl

Quoted 40 lines

Thanks and Regards,

Matthias

Quoted 30 lines · Richard Leitner

Hi Matthias,

Quoted 10 lines · Matthias Schoepfer via Openembedded-devel

Hi Richard and Jacob,

I just stumbled across the very same error, but on aarch64. I tried to switch to the wip-branch, but I get

ParseError at
/[...]/meta-java/recipes-core/openjdk/openjdk-7_99b00-2.6.5.bb:7: Could not inherit file classes/features_check.bbclass

I am on zeus...

This seems legit as AFAIK features_check.bbclass was introduced after the zeus release. For zeus you can replace it with distro_features_check.bbclass, but please note that I haven't tested on zeus. I'm working on master.

Futhermore please use meta-java's master-next branch for testing as I will remove the wip branch in the near future.

thanks for your testing!

regards;rl

Quoted 5 lines

Regards,

Matthias

Signature · 2 lines
Dr.-Ing. Matthias Schöpfer
[email protected]