Skip to contentSkip to conversation

ath11k: htt stats module does not handle multiple skbs

PATCH In review John Crispin 2 participants 3 messages Dec 17, 2019 – Jan 26, 2020 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: htt stats module does not handle multiple skbs

From: Miles Hu <[email protected]>

This patch removes the "done" check from the stats handler thus allowing the code to parse more skbs.

---
 drivers/net/wireless/ath/ath11k/debug_htt_stats.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/wireless/ath/ath11k/debug_htt_stats.c +5 -5
index 27b301bc1a1b..45dbffaca3bd 100644
@@ -4119,6 +4119,7 @@ void ath11k_dbg_htt_ext_stats_handler(struct ath11k_base *ab,
 {
 	struct ath11k_htt_extd_stats_msg *msg;
 	struct debug_htt_stats_req *stats_req;
+	bool send_completion = false;
 	struct ath11k *ar;
 	u32 len;
 	u64 cookie;
@@ -4147,10 +4148,8 @@ void ath11k_dbg_htt_ext_stats_handler(struct ath11k_base *ab,
 		return;
 
 	spin_lock_bh(&ar->debug.htt_stats.lock);
-	if (stats_req->done) {
-		spin_unlock_bh(&ar->debug.htt_stats.lock);
-		return;
-	}
+	if (!stats_req->done)
+		send_completion = true;
 	stats_req->done = true;
 	spin_unlock_bh(&ar->debug.htt_stats.lock);
 
@@ -4161,7 +4160,8 @@ void ath11k_dbg_htt_ext_stats_handler(struct ath11k_base *ab,
 	if (ret)
 		ath11k_warn(ab, "Failed to parse tlv %d\n", ret);
 
-	complete(&stats_req->cmpln);
+	if (send_completion)
+		complete(&stats_req->cmpln);
 }
 
 static ssize_t ath11k_read_htt_stats_type(struct file *file,
Signature · 1 line
2.20.1
#1 lore raw
Quoted 6 lines · John Crispin

This patch removes the "done" check from the stats handler thus allowing the code to parse more skbs.

s-o-b from John missing

Patch set to Changes Requested.

Signature · 3 lines
https://patchwork.kernel.org/patch/11298295/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to John Crispin
Quoted 6 lines · John Crispin

This patch removes the "done" check from the stats handler thus allowing the code to parse more skbs.

s-o-b from John missing

Patch set to Changes Requested.

Signature · 8 lines
https://patchwork.kernel.org/patch/11298295/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k