WARNING in ex_handler_uaccess
Subsystems (2)
Christoph Paasch
Another one, also related to IP socket-options. Not sure if it's the same as the other one.
C-Repro:
// autogenerated by syzkaller (https://github.com/google/syzkaller)
#define _GNU_SOURCE
#include <endian.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/syscall.h>
#include <sys/types.h>
#include <unistd.h>
uint64_t r[1] = { 0xffffffffffffffff };
int main(void)
{
syscall(__NR_mmap, 0x20000000ul, 0x1000000ul, 3ul, 0x32ul, -1, 0); intptr_t res = 0;
res = syscall(__NR_socket, 2ul, 1ul, 0x106ul);
if (res != -1)
r[0] = res;
syscall(__NR_getsockopt, r[0], 0ul, 0x11ul, 0ul, 0x9999999999999999ul); return 0;
}
======
------------[ cut here ]------------ General protection fault in user access. Non-canonical address? WARNING: CPU: 1 PID: 5352 at arch/x86/mm/extable.c:77 ex_handler_uaccess+0xba/0xe0 arch/x86/mm/extable.c:77 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 5352 Comm: syz-executor.6 Not tainted 5.5.0-rc6 #3 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xef/0x16e lib/dump_stack.c:118 panic+0x2aa/0x6f7 kernel/panic.c:221 __warn.cold+0x2f/0x3a kernel/panic.c:582 report_bug+0x28b/0x2f0 lib/bug.c:195 fixup_bug arch/x86/kernel/traps.c:174 [inline] fixup_bug arch/x86/kernel/traps.c:169 [inline] do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:267 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:286 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1027 RIP: 0010:ex_handler_uaccess+0xba/0xe0 arch/x86/mm/extable.c:77 Code: 1d 4d b7 f8 03 31 ff 89 de e8 12 22 2e 00 84 db 75 80 e8 d9 20 2e 00 48 c7 c7 a0 a6 04 84 c6 05 2d b7 f8 03 01 e8 4e 78 03 00 <0f> 0b e9 61 ff ff ff 48 89 df e8 e7 f6 61 00 eb 87 e8 70 f7 61 00 RSP: 0018:ffff888110d37850 EFLAGS: 00010286 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: 00000000000017ae RSI: ffffffff81290f0d RDI: ffffed10221a6efc RBP: ffff888110d378d8 R08: ffff8881168a17c0 R09: fffffbfff0c270ad R10: fffffbfff0c270ac R11: ffffffff86138567 R12: ffffffff848730cc R13: 000000000000000d R14: 0000000000000000 R15: 0000000000000000 fixup_exception+0x9d/0xcd arch/x86/mm/extable.c:178 do_general_protection+0xa2/0x300 arch/x86/kernel/traps.c:543 general_protection+0x2d/0x40 arch/x86/entry/entry_64.S:1202 RIP: 0010:__get_user_4+0x21/0x30 arch/x86/lib/getuser.S:78 Code: 50 ff 31 c0 0f 1f 00 c3 90 48 83 c0 03 72 5d 65 48 8b 14 25 00 0f 02 00 48 3b 82 10 13 00 00 73 4b 48 19 d2 48 21 d0 0f 1f 00 <8b> 50 fd 31 c0 0f 1f 00 c3 66 0f 1f 44 00 00 48 83 c0 07 72 2d 65 RSP: 0018:ffff888110d37980 EFLAGS: 00010286 RAX: 999999999999999c RBX: 00000000ffffff49 RCX: ffffc90002e91000 RDX: ffffffffffffffff RSI: ffffffff831df23d RDI: 0000000000000007 RBP: ffff888112710b80 R08: ffff8881168a17c0 R09: 0000000000000000 R10: ffffed1022d142f8 R11: ffff8881168a17c7 R12: 0000000000000011 R13: 0000000000000011 R14: 1ffff110221a6f35 R15: 0000000020000240 do_ip_getsockopt+0x1f6/0x1860 net/ipv4/ip_sockglue.c:1323 ip_getsockopt+0x87/0x1c0 net/ipv4/ip_sockglue.c:1561 tcp_getsockopt net/ipv4/tcp.c:3691 [inline] tcp_getsockopt+0x8c/0xd0 net/ipv4/tcp.c:3685 kernel_getsockopt+0x121/0x1f0 net/socket.c:3736 mptcp_getsockopt+0x69/0x90 net/mptcp/protocol.c:830 __sys_getsockopt+0x13a/0x220 net/socket.c:2175 __do_sys_getsockopt net/socket.c:2190 [inline] __se_sys_getsockopt net/socket.c:2187 [inline] __x64_sys_getsockopt+0xba/0x150 net/socket.c:2187 do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f6c40ace469 Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d ff 49 2b 00 f7 d8 64 89 01 48 RSP: 002b:00007f6c411bedd8 EFLAGS: 00000246 ORIG_RAX: 0000000000000037 RAX: ffffffffffffffda RBX: 000000000066bf00 RCX: 00007f6c40ace469 RDX: 0000000000000011 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 00000000ffffffff R08: 9999999999999999 R09: 0000000000000000 R10: 0000000020000240 R11: 0000000000000246 R12: 000000000000016b R13: 0000000000435308 R14: 00007f6c411bf5c0 R15: 0000000000000003
Dumping ftrace buffer:
(ftrace buffer empty)
Kernel Offset: disabled
Rebooting in 1 seconds..
Florian Westphal
PATCH 1/1 mptcp: protocol: fix panic on user pointer access
Its not possible to call the kernel_(s|g)etsockopt functions here, the address points to user memory:
General protection fault in user access. Non-canonical address?
WARNING: CPU: 1 PID: 5352 at arch/x86/mm/extable.c:77 ex_handler_uaccess+0xba/0xe0 arch/x86/mm/extable.c:77 Kernel panic - not syncing: panic_on_warn set ... [..] Call Trace: fixup_exception+0x9d/0xcd arch/x86/mm/extable.c:178 general_protection+0x2d/0x40 arch/x86/entry/entry_64.S:1202 do_ip_getsockopt+0x1f6/0x1860 net/ipv4/ip_sockglue.c:1323 ip_getsockopt+0x87/0x1c0 net/ipv4/ip_sockglue.c:1561 tcp_getsockopt net/ipv4/tcp.c:3691 [inline] tcp_getsockopt+0x8c/0xd0 net/ipv4/tcp.c:3685 kernel_getsockopt+0x121/0x1f0 net/socket.c:3736 mptcp_getsockopt+0x69/0x90 net/mptcp/protocol.c:830 __sys_getsockopt+0x13a/0x220 net/socket.c:2175
--- net/mptcp/protocol.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-)
net/mptcp/protocol.c +23 -7
@@ -778,17 +778,23 @@ static void mptcp_destroy(struct sock *sk) { } +static int fallback_setsockopt (struct socket *sock,int level,int optname, +char __user *optval,unsigned int optlen) +{ +if (level ==SOL_SOCKET ) +return sock_setsockopt (sock, level, optname, optval, optlen); + +return sock->ops->setsockopt (sock, level, optname, optval, + optlen); +} +static int mptcp_setsockopt (struct sock *sk,int level,int optname, -char __user *uoptval,unsigned int optlen) +char __user *optval,unsigned int optlen) {struct mptcp_sock *msk =mptcp_sk (sk); -char __kernel *optval;int ret = -EOPNOTSUPP ;struct socket *ssock; -/* will be treated as __user in tcp_setsockopt */ - optval = (char __kernel __force *)uoptval; -pr_debug ("msk=%p" , msk);/* @@ the meaning of setsockopt() when the socket is connected and
@@ -798,13 +804,23 @@ static int mptcp_setsockopt(struct sock *sk, int level, int optname, ssock =__mptcp_socket_create (msk,MPTCP_SAME_STATE );if (!IS_ERR (ssock)) {pr_debug ("subflow=%p" , ssock->sk); - ret =kernel_setsockopt (ssock, level, optname, optval, optlen); + ret =fallback_setsockopt (ssock, level, optname, optval, optlen); }release_sock (sk);return ret; } +static int fallback_getsockopt (struct socket *sock,int level,int optname, +char __user *optval,int __user *optlen) +{ +if (level ==SOL_SOCKET ) +return sock_getsockopt (sock, level, optname, optval, optlen); + +return sock->ops->getsockopt (sock, level, optname, optval, + optlen); +} +static int mptcp_getsockopt (struct sock *sk,int level,int optname,char __user *uoptval,int __user *uoption) {
@@ -827,7 +843,7 @@ static int mptcp_getsockopt(struct sock *sk, int level, int optname, ssock =__mptcp_socket_create (msk,MPTCP_SAME_STATE );if (!IS_ERR (ssock)) {pr_debug ("subflow=%p" , ssock->sk); - ret =kernel_getsockopt (ssock, level, optname, optval, option); + ret =fallback_getsockopt (ssock, level, optname, optval, option); }release_sock (sk);
Signature · 1 line
2.24.1
Florian Westphal
PATCH v2 1/1 mptcp: protocol: fix panic on user pointer access
Its not possible to call the kernel_(s|g)etsockopt functions here, the address points to user memory:
General protection fault in user access. Non-canonical address?
WARNING: CPU: 1 PID: 5352 at arch/x86/mm/extable.c:77 ex_handler_uaccess+0xba/0xe0 arch/x86/mm/extable.c:77 Kernel panic - not syncing: panic_on_warn set ... [..] Call Trace: fixup_exception+0x9d/0xcd arch/x86/mm/extable.c:178 general_protection+0x2d/0x40 arch/x86/entry/entry_64.S:1202 do_ip_getsockopt+0x1f6/0x1860 net/ipv4/ip_sockglue.c:1323 ip_getsockopt+0x87/0x1c0 net/ipv4/ip_sockglue.c:1561 tcp_getsockopt net/ipv4/tcp.c:3691 [inline] tcp_getsockopt+0x8c/0xd0 net/ipv4/tcp.c:3685 kernel_getsockopt+0x121/0x1f0 net/socket.c:3736 mptcp_getsockopt+0x69/0x90 net/mptcp/protocol.c:830 __sys_getsockopt+0x13a/0x220 net/socket.c:2175
v2: also fix a circular locking dependency reported by Christoph:
release the mptcp-level lock before calling set/getsockopt on the underlying tcp subflow socket, else this yields:
WARNING: possible circular locking dependency detected
5.5.0-rc6 #2 Not tainted
------------------------------------------------------
syz-executor.0/16334 is trying to acquire lock:
ffffffff84f7a080 (rtnl_mutex){+.+.}, at: do_ip_setsockopt.isra.0+0x277/0x3820 net/ipv4/ip_sockglue.c:644 but task is already holding lock:
ffff888116503b90 (sk_lock-AF_INET){+.+.}, at: lock_sock include/net/sock.h:1516 [inline] ffff888116503b90 (sk_lock-AF_INET){+.+.}, at: mptcp_setsockopt+0x28/0x90 net/mptcp/protocol.c:1284
which lock already depends on the new lock. the existing dependency chain (in reverse order) is:
-> #1 (sk_lock-AF_INET){+.+.}:
lock_sock_nested+0xca/0x120 net/core/sock.c:2944
lock_sock include/net/sock.h:1516 [inline]
do_ip_setsockopt.isra.0+0x281/0x3820 net/ipv4/ip_sockglue.c:645
ip_setsockopt+0x44/0xf0 net/ipv4/ip_sockglue.c:1248
udp_setsockopt+0x5d/0xa0 net/ipv4/udp.c:2639
__sys_setsockopt+0x152/0x240 net/socket.c:2130
__do_sys_setsockopt net/socket.c:2146 [inline]
__se_sys_setsockopt net/socket.c:2143 [inline]
__x64_sys_setsockopt+0xba/0x150 net/socket.c:2143
do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x49/0xbe-> #0 (rtnl_mutex){+.+.}:
check_prev_add kernel/locking/lockdep.c:2475 [inline]
check_prevs_add kernel/locking/lockdep.c:2580 [inline]
validate_chain kernel/locking/lockdep.c:2970 [inline]
__lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954
lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484
__mutex_lock_common kernel/locking/mutex.c:956 [inline]
__mutex_lock+0x158/0x1340 kernel/locking/mutex.c:1103
do_ip_setsockopt.isra.0+0x277/0x3820 net/ipv4/ip_sockglue.c:644
ip_setsockopt+0x44/0xf0 net/ipv4/ip_sockglue.c:1248
tcp_setsockopt net/ipv4/tcp.c:3159 [inline]
tcp_setsockopt+0x8c/0xd0 net/ipv4/tcp.c:3153
kernel_setsockopt+0x121/0x1f0 net/socket.c:3767
mptcp_setsockopt+0x69/0x90 net/mptcp/protocol.c:1288
__sys_setsockopt+0x152/0x240 net/socket.c:2130
__do_sys_setsockopt net/socket.c:2146 [inline]
__se_sys_setsockopt net/socket.c:2143 [inline]
__x64_sys_setsockopt+0xba/0x150 net/socket.c:2143
do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x49/0xbeother info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(sk_lock-AF_INET);
lock(rtnl_mutex);
lock(sk_lock-AF_INET); lock(rtnl_mutex);
--- net/mptcp/protocol.c | 42 ++++++++++++++++++++++++++---------------- 1 file changed, 26 insertions(+), 16 deletions(-)
net/mptcp/protocol.c +26 -16
@@ -778,17 +778,23 @@ static void mptcp_destroy(struct sock *sk) { } +static int fallback_setsockopt (struct socket *sock,int level,int optname, +char __user *optval,unsigned int optlen) +{ +if (level ==SOL_SOCKET ) +return sock_setsockopt (sock, level, optname, optval, optlen); + +return sock->ops->setsockopt (sock, level, optname, optval, + optlen); +} +static int mptcp_setsockopt (struct sock *sk,int level,int optname, -char __user *uoptval,unsigned int optlen) +char __user *optval,unsigned int optlen) {struct mptcp_sock *msk =mptcp_sk (sk); -char __kernel *optval;int ret = -EOPNOTSUPP ;struct socket *ssock; -/* will be treated as __user in tcp_setsockopt */ - optval = (char __kernel __force *)uoptval; -pr_debug ("msk=%p" , msk);/* @@ the meaning of setsockopt() when the socket is connected and
@@ -796,28 +802,32 @@ static int mptcp_setsockopt(struct sock *sk, int level, int optname,*/ lock_sock (sk); ssock =__mptcp_socket_create (msk,MPTCP_SAME_STATE ); +release_sock (sk);if (!IS_ERR (ssock)) {pr_debug ("subflow=%p" , ssock->sk); - ret =kernel_setsockopt (ssock, level, optname, optval, optlen); + ret =fallback_setsockopt (ssock, level, optname, optval, optlen); } -release_sock (sk);return ret; } +static int fallback_getsockopt (struct socket *sock,int level,int optname, +char __user *optval,int __user *optlen) +{ +if (level ==SOL_SOCKET ) +return sock_getsockopt (sock, level, optname, optval, optlen); + +return sock->ops->getsockopt (sock, level, optname, optval, + optlen); +} +static int mptcp_getsockopt (struct sock *sk,int level,int optname, -char __user *uoptval,int __user *uoption) +char __user *optval,int __user *option) {struct mptcp_sock *msk =mptcp_sk (sk); -char __kernel *optval;int ret = -EOPNOTSUPP ; -int __kernel *option;struct socket *ssock; -/* will be treated as __user in tcp_getsockopt */ - optval = (char __kernel __force *)uoptval; - option = (int __kernel __force *)uoption; -pr_debug ("msk=%p" , msk);/* @@ the meaning of getsockopt() when the socket is connected and
@@ -825,11 +835,11 @@ static int mptcp_getsockopt(struct sock *sk, int level, int optname,*/ lock_sock (sk); ssock =__mptcp_socket_create (msk,MPTCP_SAME_STATE ); +release_sock (sk);if (!IS_ERR (ssock)) {pr_debug ("subflow=%p" , ssock->sk); - ret =kernel_getsockopt (ssock, level, optname, optval, option); + ret =fallback_getsockopt (ssock, level, optname, optval, option); } -release_sock (sk);return ret; }
Signature · 1 line
2.24.1
Christoph Paasch
[MPTCP] Re: [PATCH net-next v2] mptcp: protocol: fix panic on user pointer access
Hello,
Quoted 77 lines · Florian Westphal
Its not possible to call the kernel_(s|g)etsockopt functions here, the address points to user memory:
General protection fault in user access. Non-canonical address?
WARNING: CPU: 1 PID: 5352 at arch/x86/mm/extable.c:77 ex_handler_uaccess+0xba/0xe0 arch/x86/mm/extable.c:77 Kernel panic - not syncing: panic_on_warn set ... [..] Call Trace: fixup_exception+0x9d/0xcd arch/x86/mm/extable.c:178 general_protection+0x2d/0x40 arch/x86/entry/entry_64.S:1202 do_ip_getsockopt+0x1f6/0x1860 net/ipv4/ip_sockglue.c:1323 ip_getsockopt+0x87/0x1c0 net/ipv4/ip_sockglue.c:1561 tcp_getsockopt net/ipv4/tcp.c:3691 [inline] tcp_getsockopt+0x8c/0xd0 net/ipv4/tcp.c:3685 kernel_getsockopt+0x121/0x1f0 net/socket.c:3736 mptcp_getsockopt+0x69/0x90 net/mptcp/protocol.c:830 __sys_getsockopt+0x13a/0x220 net/socket.c:2175v2: also fix a circular locking dependency reported by Christoph:
release the mptcp-level lock before calling set/getsockopt on the underlying tcp subflow socket, else this yields:WARNING: possible circular locking dependency detected
5.5.0-rc6 #2 Not tainted
------------------------------------------------------
syz-executor.0/16334 is trying to acquire lock:
ffffffff84f7a080(rtnl_mutex){+.+.}, at: do_ip_setsockopt.isra.0+0x277/0x3820net/ipv4/ip_sockglue.c:644but task is already holding lock:
ffff888116503b90(sk_lock-AF_INET){+.+.}, at:lock_sockinclude/net/sock.h:1516[inline]ffff888116503b90(sk_lock-AF_INET){+.+.}, at:mptcp_setsockopt+0x28/0x90net/mptcp/protocol.c:1284which lock already depends on the new lock. the existing dependency chain (in reverse order) is:
-> #1 (sk_lock-AF_INET){+.+.}:
lock_sock_nested+0xca/0x120 net/core/sock.c:2944 lock_sock include/net/sock.h:1516 [inline] do_ip_setsockopt.isra.0+0x281/0x3820 net/ipv4/ip_sockglue.c:645 ip_setsockopt+0x44/0xf0 net/ipv4/ip_sockglue.c:1248 udp_setsockopt+0x5d/0xa0 net/ipv4/udp.c:2639 __sys_setsockopt+0x152/0x240 net/socket.c:2130 __do_sys_setsockopt net/socket.c:2146 [inline] __se_sys_setsockopt net/socket.c:2143 [inline] __x64_sys_setsockopt+0xba/0x150 net/socket.c:2143 do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe-> #0 (rtnl_mutex){+.+.}:
check_prev_add kernel/locking/lockdep.c:2475 [inline] check_prevs_add kernel/locking/lockdep.c:2580 [inline] validate_chain kernel/locking/lockdep.c:2970 [inline] __lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954 lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484 __mutex_lock_common kernel/locking/mutex.c:956 [inline] __mutex_lock+0x158/0x1340 kernel/locking/mutex.c:1103 do_ip_setsockopt.isra.0+0x277/0x3820 net/ipv4/ip_sockglue.c:644 ip_setsockopt+0x44/0xf0 net/ipv4/ip_sockglue.c:1248 tcp_setsockopt net/ipv4/tcp.c:3159 [inline] tcp_setsockopt+0x8c/0xd0 net/ipv4/tcp.c:3153 kernel_setsockopt+0x121/0x1f0 net/socket.c:3767 mptcp_setsockopt+0x69/0x90 net/mptcp/protocol.c:1288 __sys_setsockopt+0x152/0x240 net/socket.c:2130 __do_sys_setsockopt net/socket.c:2146 [inline] __se_sys_setsockopt net/socket.c:2143 [inline] __x64_sys_setsockopt+0xba/0x150 net/socket.c:2143 do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbeother info that might help us debug this:
Possible unsafe locking scenario:CPU0 CPU1 ---- ---- lock(sk_lock-AF_INET); lock(rtnl_mutex); lock(sk_lock-AF_INET);
Quoted 5 lines
lock(rtnl_mutex);Fixes 717e79c867ca5 ("mptcp: Add setsockopt()/getsockopt() socket operations")Reported-by Christoph Paasch <cpaasch(a)apple.com>Signed-off-by Florian Westphal <fw(a)strlen.de>
I kicked off syzkaller on top of net-next + this patch here.
I'm still getting some circular lockdep-warnings in the setsockopt codepath (no reproducer yet):
==============
======================================================
WARNING: possible circular locking dependency detected
5.5.0-rc7 #1 Not tainted
------------------------------------------------------
syz-executor.3/22312 is trying to acquire lock:ffffffff84f7aac0 (rtnl_mutex){+.+.}, at: ipv6_sock_mc_close+0xc1/0xf0 net/ipv6/mcast.c:323
but task is already holding lock:ffff888111f74010 (sk_lock-AF_INET6){+.+.}, at: lock_sock include/net/sock.h:1516 [inline] ffff888111f74010 (sk_lock-AF_INET6){+.+.}, at: mptcp_close+0x18/0x30 net/mptcp/protocol.c:665
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (sk_lock-AF_INET6){+.+.}:
lock_sock_nested+0xca/0x120 net/core/sock.c:2944
lock_sock include/net/sock.h:1516 [inline]
do_ipv6_setsockopt.isra.0+0x362/0x4360 net/ipv6/ipv6_sockglue.c:165
ipv6_setsockopt+0x101/0x180 net/ipv6/ipv6_sockglue.c:944
udpv6_setsockopt+0x5d/0xa0 net/ipv6/udp.c:1564
__sys_setsockopt+0x152/0x240 net/socket.c:2130
__do_sys_setsockopt net/socket.c:2146 [inline]
__se_sys_setsockopt net/socket.c:2143 [inline]
__x64_sys_setsockopt+0xba/0x150 net/socket.c:2143
do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x49/0xbe-> #0 (rtnl_mutex){+.+.}:
check_prev_add kernel/locking/lockdep.c:2475 [inline]
check_prevs_add kernel/locking/lockdep.c:2580 [inline]
validate_chain kernel/locking/lockdep.c:2970 [inline]
__lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954
lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484
__mutex_lock_common kernel/locking/mutex.c:956 [inline]
__mutex_lock+0x158/0x1340 kernel/locking/mutex.c:1103
ipv6_sock_mc_close+0xc1/0xf0 net/ipv6/mcast.c:323
inet6_release+0x3c/0x70 net/ipv6/af_inet6.c:465
__sock_release+0x1dd/0x290 net/socket.c:605
__mptcp_close_ssk net/mptcp/protocol.c:592 [inline]
__mptcp_close+0xec/0x360 net/mptcp/protocol.c:654
inet_release+0xe9/0x1f0 net/ipv4/af_inet.c:427
inet6_release+0x4c/0x70 net/ipv6/af_inet6.c:470
__sock_release+0xd2/0x290 net/socket.c:605
sock_close+0x18/0x20 net/socket.c:1283
__fput+0x2da/0x850 fs/file_table.c:280
task_work_run+0x144/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:188 [inline]
exit_to_usermode_loop+0x1d2/0x200 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:195 [inline]
syscall_return_slowpath arch/x86/entry/common.c:278 [inline]
do_syscall_64+0x4d7/0x5b0 arch/x86/entry/common.c:304
entry_SYSCALL_64_after_hwframe+0x49/0xbeother info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(sk_lock-AF_INET6);
lock(rtnl_mutex);
lock(sk_lock-AF_INET6); lock(rtnl_mutex);
*** DEADLOCK ***
2 locks held by syz-executor.3/22312:
#0: ffff888109b4a500 (&sb->s_type->i_mutex_key#10){+.+.}, at: inode_lock include/linux/fs.h:791 [inline] #0: ffff888109b4a500 (&sb->s_type->i_mutex_key#10){+.+.}, at: __sock_release+0x86/0x290 net/socket.c:604 #1: ffff888111f74010 (sk_lock-AF_INET6){+.+.}, at: lock_sock include/net/sock.h:1516 [inline] #1: ffff888111f74010 (sk_lock-AF_INET6){+.+.}, at: mptcp_close+0x18/0x30 net/mptcp/protocol.c:665
stack backtrace: CPU: 0 PID: 22312 Comm: syz-executor.3 Not tainted 5.5.0-rc7 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xef/0x16e lib/dump_stack.c:118 check_noncircular+0x337/0x3f0 kernel/locking/lockdep.c:1808 check_prev_add kernel/locking/lockdep.c:2475 [inline] check_prevs_add kernel/locking/lockdep.c:2580 [inline] validate_chain kernel/locking/lockdep.c:2970 [inline] __lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954 lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484 __mutex_lock_common kernel/locking/mutex.c:956 [inline] __mutex_lock+0x158/0x1340 kernel/locking/mutex.c:1103 ipv6_sock_mc_close+0xc1/0xf0 net/ipv6/mcast.c:323 inet6_release+0x3c/0x70 net/ipv6/af_inet6.c:465 __sock_release+0x1dd/0x290 net/socket.c:605 __mptcp_close_ssk net/mptcp/protocol.c:592 [inline] __mptcp_close+0xec/0x360 net/mptcp/protocol.c:654 inet_release+0xe9/0x1f0 net/ipv4/af_inet.c:427 inet6_release+0x4c/0x70 net/ipv6/af_inet6.c:470 __sock_release+0xd2/0x290 net/socket.c:605 sock_close+0x18/0x20 net/socket.c:1283 __fput+0x2da/0x850 fs/file_table.c:280 task_work_run+0x144/0x1c0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_usermode_loop+0x1d2/0x200 arch/x86/entry/common.c:164 prepare_exit_to_usermode arch/x86/entry/common.c:195 [inline] syscall_return_slowpath arch/x86/entry/common.c:278 [inline] do_syscall_64+0x4d7/0x5b0 arch/x86/entry/common.c:304 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f691394128d Code: c1 20 00 00 75 10 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8 ee fb ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 37 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01 RSP: 002b:00007ffec314aaf0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 0000000000000001 RCX: 00007f691394128d RDX: 0000001b30220000 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 0000000000000004 R08: 00000000006704a8 R09: 000000008fa73b09 R10: 000000008fa73b0d R11: 0000000000000293 R12: 0000000000000001 R13: 000000000002076c R14: 00000000006704a8 R15: 00000000000007d0
syz-executor.2 (2179) used greatest stack depth: 24704 bytes left syz-executor.1 (2127) used greatest stack depth: 24384 bytes left
=========================
======================================================
WARNING: possible circular locking dependency detected
5.5.0-rc7 #1 Not tainted
------------------------------------------------------
syz-executor.5/16250 is trying to acquire lock:ffff88811348e690 (sk_lock-AF_INET6){+.+.}, at: lock_sock include/net/sock.h:1516 [inline] ffff88811348e690 (sk_lock-AF_INET6){+.+.}, at: do_ipv6_setsockopt.isra.0+0x362/0x4360 net/ipv6/ipv6_sockglue.c:165
but task is already holding lock:ffffffff84f7aac0 (rtnl_mutex){+.+.}, at: do_ipv6_setsockopt.isra.0+0x358/0x4360 net/ipv6/ipv6_sockglue.c:164
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (rtnl_mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:956 [inline]
__mutex_lock+0x158/0x1340 kernel/locking/mutex.c:1103
ipv6_sock_mc_close+0xc1/0xf0 net/ipv6/mcast.c:323
inet6_release+0x3c/0x70 net/ipv6/af_inet6.c:465
__sock_release+0x1dd/0x290 net/socket.c:605
__mptcp_close_ssk net/mptcp/protocol.c:592 [inline]
__mptcp_close+0xec/0x360 net/mptcp/protocol.c:654
inet_release+0xe9/0x1f0 net/ipv4/af_inet.c:427
inet6_release+0x4c/0x70 net/ipv6/af_inet6.c:470
__sock_release+0xd2/0x290 net/socket.c:605
sock_close+0x18/0x20 net/socket.c:1283
__fput+0x2da/0x850 fs/file_table.c:280
task_work_run+0x144/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:188 [inline]
exit_to_usermode_loop+0x1d2/0x200 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:195 [inline]
syscall_return_slowpath arch/x86/entry/common.c:278 [inline]
do_syscall_64+0x4d7/0x5b0 arch/x86/entry/common.c:304
entry_SYSCALL_64_after_hwframe+0x49/0xbe-> #0 (sk_lock-AF_INET6){+.+.}:
check_prev_add kernel/locking/lockdep.c:2475 [inline]
check_prevs_add kernel/locking/lockdep.c:2580 [inline]
validate_chain kernel/locking/lockdep.c:2970 [inline]
__lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954
lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484
lock_sock_nested+0xca/0x120 net/core/sock.c:2944
lock_sock include/net/sock.h:1516 [inline]
do_ipv6_setsockopt.isra.0+0x362/0x4360 net/ipv6/ipv6_sockglue.c:165
ipv6_setsockopt+0x101/0x180 net/ipv6/ipv6_sockglue.c:944
udpv6_setsockopt+0x5d/0xa0 net/ipv6/udp.c:1564
__sys_setsockopt+0x152/0x240 net/socket.c:2130
__do_sys_setsockopt net/socket.c:2146 [inline]
__se_sys_setsockopt net/socket.c:2143 [inline]
__x64_sys_setsockopt+0xba/0x150 net/socket.c:2143
do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x49/0xbeother info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(rtnl_mutex);
lock(sk_lock-AF_INET6);
lock(rtnl_mutex); lock(sk_lock-AF_INET6);
*** DEADLOCK ***
1 lock held by syz-executor.5/16250:
#0: ffffffff84f7aac0 (rtnl_mutex){+.+.}, at: do_ipv6_setsockopt.isra.0+0x358/0x4360 net/ipv6/ipv6_sockglue.c:164
stack backtrace: CPU: 1 PID: 16250 Comm: syz-executor.5 Not tainted 5.5.0-rc7 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xef/0x16e lib/dump_stack.c:118 check_noncircular+0x337/0x3f0 kernel/locking/lockdep.c:1808 check_prev_add kernel/locking/lockdep.c:2475 [inline] check_prevs_add kernel/locking/lockdep.c:2580 [inline] validate_chain kernel/locking/lockdep.c:2970 [inline] __lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954 lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484 lock_sock_nested+0xca/0x120 net/core/sock.c:2944 lock_sock include/net/sock.h:1516 [inline] do_ipv6_setsockopt.isra.0+0x362/0x4360 net/ipv6/ipv6_sockglue.c:165 ipv6_setsockopt+0x101/0x180 net/ipv6/ipv6_sockglue.c:944 udpv6_setsockopt+0x5d/0xa0 net/ipv6/udp.c:1564 __sys_setsockopt+0x152/0x240 net/socket.c:2130 __do_sys_setsockopt net/socket.c:2146 [inline] __se_sys_setsockopt net/socket.c:2143 [inline] __x64_sys_setsockopt+0xba/0x150 net/socket.c:2143 do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f35bd9ad469 Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d ff 49 2b 00 f7 d8 64 89 01 48 RSP: 002b:00007f35be09ddd8 EFLAGS: 00000246 ORIG_RAX: 0000000000000036 RAX: ffffffffffffffda RBX: 000000000066bf00 RCX: 00007f35bd9ad469 RDX: 000000000000002c RSI: 0000000000000029 RDI: 0000000000000015 RBP: 00000000ffffffff R08: 0000000000000108 R09: 0000000000000000 R10: 0000000020000540 R11: 0000000000000246 R12: 0000000000000a50 R13: 0000000000439e70 R14: 00007f35be09e5c0 R15: 0000000000000003
syz-executor.7 (2193) used greatest stack depth: 24704 bytes left syz-executor.1 (2164) used greatest stack depth: 24568 bytes left syz-executor.6 (2142) used greatest stack depth: 24448 bytes left syz-executor.3 (2140) used greatest stack depth: 24336 bytes left
Cheers,
Christoph
Christoph Paasch
[MPTCP] Re: [PATCH net-next v2] mptcp: protocol: fix panic on user pointer access
Quoted 82 lines · Christoph Paasch
Hello,
Quoted 79 lines · Florian Westphal
Its not possible to call the kernel_(s|g)etsockopt functions here, the address points to user memory:
General protection fault in user access. Non-canonical address?
WARNING: CPU: 1 PID: 5352 at arch/x86/mm/extable.c:77 ex_handler_uaccess+0xba/0xe0 arch/x86/mm/extable.c:77 Kernel panic - not syncing: panic_on_warn set ... [..] Call Trace: fixup_exception+0x9d/0xcd arch/x86/mm/extable.c:178 general_protection+0x2d/0x40 arch/x86/entry/entry_64.S:1202 do_ip_getsockopt+0x1f6/0x1860 net/ipv4/ip_sockglue.c:1323 ip_getsockopt+0x87/0x1c0 net/ipv4/ip_sockglue.c:1561 tcp_getsockopt net/ipv4/tcp.c:3691 [inline] tcp_getsockopt+0x8c/0xd0 net/ipv4/tcp.c:3685 kernel_getsockopt+0x121/0x1f0 net/socket.c:3736 mptcp_getsockopt+0x69/0x90 net/mptcp/protocol.c:830 __sys_getsockopt+0x13a/0x220 net/socket.c:2175v2: also fix a circular locking dependency reported by Christoph:
release the mptcp-level lock before calling set/getsockopt on the underlying tcp subflow socket, else this yields:WARNING: possible circular locking dependency detected
5.5.0-rc6 #2 Not tainted
------------------------------------------------------
syz-executor.0/16334 is trying to acquire lock:
ffffffff84f7a080(rtnl_mutex){+.+.}, at: do_ip_setsockopt.isra.0+0x277/0x3820net/ipv4/ip_sockglue.c:644but task is already holding lock:
ffff888116503b90(sk_lock-AF_INET){+.+.}, at:lock_sockinclude/net/sock.h:1516[inline]ffff888116503b90(sk_lock-AF_INET){+.+.}, at:mptcp_setsockopt+0x28/0x90net/mptcp/protocol.c:1284which lock already depends on the new lock. the existing dependency chain (in reverse order) is:
-> #1 (sk_lock-AF_INET){+.+.}:
lock_sock_nested+0xca/0x120 net/core/sock.c:2944 lock_sock include/net/sock.h:1516 [inline] do_ip_setsockopt.isra.0+0x281/0x3820 net/ipv4/ip_sockglue.c:645 ip_setsockopt+0x44/0xf0 net/ipv4/ip_sockglue.c:1248 udp_setsockopt+0x5d/0xa0 net/ipv4/udp.c:2639 __sys_setsockopt+0x152/0x240 net/socket.c:2130 __do_sys_setsockopt net/socket.c:2146 [inline] __se_sys_setsockopt net/socket.c:2143 [inline] __x64_sys_setsockopt+0xba/0x150 net/socket.c:2143 do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe-> #0 (rtnl_mutex){+.+.}:
check_prev_add kernel/locking/lockdep.c:2475 [inline] check_prevs_add kernel/locking/lockdep.c:2580 [inline] validate_chain kernel/locking/lockdep.c:2970 [inline] __lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954 lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484 __mutex_lock_common kernel/locking/mutex.c:956 [inline] __mutex_lock+0x158/0x1340 kernel/locking/mutex.c:1103 do_ip_setsockopt.isra.0+0x277/0x3820 net/ipv4/ip_sockglue.c:644 ip_setsockopt+0x44/0xf0 net/ipv4/ip_sockglue.c:1248 tcp_setsockopt net/ipv4/tcp.c:3159 [inline] tcp_setsockopt+0x8c/0xd0 net/ipv4/tcp.c:3153 kernel_setsockopt+0x121/0x1f0 net/socket.c:3767 mptcp_setsockopt+0x69/0x90 net/mptcp/protocol.c:1288 __sys_setsockopt+0x152/0x240 net/socket.c:2130 __do_sys_setsockopt net/socket.c:2146 [inline] __se_sys_setsockopt net/socket.c:2143 [inline] __x64_sys_setsockopt+0xba/0x150 net/socket.c:2143 do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbeother info that might help us debug this:
Possible unsafe locking scenario:CPU0 CPU1 ---- ---- lock(sk_lock-AF_INET); lock(rtnl_mutex); lock(sk_lock-AF_INET);
lock(rtnl_mutex);
Quoted 8 lines
Quoted 3 lines
Fixes 717e79c867ca5 ("mptcp: Add setsockopt()/getsockopt() socket operations")Reported-by Christoph Paasch <cpaasch(a)apple.com>Signed-off-by Florian Westphal <fw(a)strlen.de>I kicked off syzkaller on top of net-next + this patch here.
I'm still getting some circular lockdep-warnings in the setsockopt codepath (no reproducer yet):
Two C-reproducers for some of the setsockopt lockdep issues:
// autogenerated by syzkaller (https://github.com/google/syzkaller)
#define _GNU_SOURCE
#include <endian.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/syscall.h>
#include <sys/types.h>
#include <unistd.h>
uint64_t r[2] = { 0xffffffffffffffff, 0xffffffffffffffff };
int main(void)
{
syscall(__NR_mmap, 0x20000000ul, 0x1000000ul, 3ul, 0x32ul, -1, 0); intptr_t res = 0;
res = syscall(__NR_socket, 2ul, 1ul, 0ul);
if (res != -1)
r[0] = res;
syscall(__NR_setsockopt, r[0], 0ul, 0x30ul, 0ul, 0ul);
res = syscall(__NR_socket, 2ul, 1ul, 0x106ul);
if (res != -1)
r[1] = res; *(uint32_t *)0x20002c40 = 7;
*(uint16_t *)0x20002c48 = 2;
*(uint16_t *)0x20002c4a = htobe16(0x4e23);
*(uint32_t *)0x20002c4c = htobe32(0xe0000002); syscall(__NR_setsockopt, r[1], 0ul, 0x2aul, 0x20002c40ul, 0x88ul); return 0;
}
======
// autogenerated by syzkaller (https://github.com/google/syzkaller)
#define _GNU_SOURCE
#include <endian.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/syscall.h>
#include <sys/types.h>
#include <unistd.h>
uint64_t r[2] = { 0xffffffffffffffff, 0xffffffffffffffff };
int main(void)
{
syscall(__NR_mmap, 0x20000000ul, 0x1000000ul, 3ul, 0x32ul, -1, 0); intptr_t res = 0;
res = syscall(__NR_socket, 0xaul, 2ul, 0ul);
if (res != -1)
r[0] = res;
syscall(__NR_setsockopt, r[0], 0x29ul, 0x2aul, 0ul, 0ul);
res = syscall(__NR_socket, 0xaul, 1ul, 0x106ul);
if (res != -1)
r[1] = res; *(uint8_t *)0x20000080 = 0xfe;
*(uint8_t *)0x20000081 = 0x80;
*(uint8_t *)0x20000082 = 0;
*(uint8_t *)0x20000083 = 0;
*(uint8_t *)0x20000084 = 0;
*(uint8_t *)0x20000085 = 0;
*(uint8_t *)0x20000086 = 0;
*(uint8_t *)0x20000087 = 0;
*(uint8_t *)0x20000088 = 0;
*(uint8_t *)0x20000089 = 0;
*(uint8_t *)0x2000008a = 0;
*(uint8_t *)0x2000008b = 0;
*(uint8_t *)0x2000008c = 0;
*(uint8_t *)0x2000008d = 0;
*(uint8_t *)0x2000008e = 0;
*(uint8_t *)0x2000008f = 0x21;
*(uint32_t *)0x20000090 = 0;
syscall(__NR_setsockopt, r[1], 0x29ul, 0x1bul, 0x20000080ul, 0x14ul); return 0;
}
Christoph
Quoted 238 lines
==============
======================================================
WARNING: possible circular locking dependency detected
5.5.0-rc7 #1 Not tainted
------------------------------------------------------
syz-executor.3/22312 is trying to acquire lock:ffffffff84f7aac0(rtnl_mutex){+.+.}, at:ipv6_sock_mc_close+0xc1/0xf0net/ipv6/mcast.c:323but task is already holding lock:
ffff888111f74010(sk_lock-AF_INET6){+.+.}, at:lock_sockinclude/net/sock.h:1516[inline]ffff888111f74010(sk_lock-AF_INET6){+.+.}, at:mptcp_close+0x18/0x30net/mptcp/protocol.c:665which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (sk_lock-AF_INET6){+.+.}:
lock_sock_nested+0xca/0x120 net/core/sock.c:2944 lock_sock include/net/sock.h:1516 [inline] do_ipv6_setsockopt.isra.0+0x362/0x4360 net/ipv6/ipv6_sockglue.c:165 ipv6_setsockopt+0x101/0x180 net/ipv6/ipv6_sockglue.c:944 udpv6_setsockopt+0x5d/0xa0 net/ipv6/udp.c:1564 __sys_setsockopt+0x152/0x240 net/socket.c:2130 __do_sys_setsockopt net/socket.c:2146 [inline] __se_sys_setsockopt net/socket.c:2143 [inline] __x64_sys_setsockopt+0xba/0x150 net/socket.c:2143 do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe-> #0 (rtnl_mutex){+.+.}:
check_prev_add kernel/locking/lockdep.c:2475 [inline] check_prevs_add kernel/locking/lockdep.c:2580 [inline] validate_chain kernel/locking/lockdep.c:2970 [inline] __lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954 lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484 __mutex_lock_common kernel/locking/mutex.c:956 [inline] __mutex_lock+0x158/0x1340 kernel/locking/mutex.c:1103 ipv6_sock_mc_close+0xc1/0xf0 net/ipv6/mcast.c:323 inet6_release+0x3c/0x70 net/ipv6/af_inet6.c:465 __sock_release+0x1dd/0x290 net/socket.c:605 __mptcp_close_ssk net/mptcp/protocol.c:592 [inline] __mptcp_close+0xec/0x360 net/mptcp/protocol.c:654 inet_release+0xe9/0x1f0 net/ipv4/af_inet.c:427 inet6_release+0x4c/0x70 net/ipv6/af_inet6.c:470 __sock_release+0xd2/0x290 net/socket.c:605 sock_close+0x18/0x20 net/socket.c:1283 __fput+0x2da/0x850 fs/file_table.c:280 task_work_run+0x144/0x1c0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_usermode_loop+0x1d2/0x200 arch/x86/entry/common.c:164 prepare_exit_to_usermode arch/x86/entry/common.c:195 [inline] syscall_return_slowpath arch/x86/entry/common.c:278 [inline] do_syscall_64+0x4d7/0x5b0 arch/x86/entry/common.c:304 entry_SYSCALL_64_after_hwframe+0x49/0xbeother info that might help us debug this:
Possible unsafe locking scenario:CPU0 CPU1 ---- ---- lock(sk_lock-AF_INET6); lock(rtnl_mutex); lock(sk_lock-AF_INET6);
lock(rtnl_mutex);*** DEADLOCK ***
2 locks held by syz-executor.3/22312:
#0:ffff888109b4a500(&sb->s_type->i_mutex_key#10){+.+.}, at:inode_lockinclude/linux/fs.h:791[inline] #0:ffff888109b4a500(&sb->s_type->i_mutex_key#10){+.+.}, at:__sock_release+0x86/0x290net/socket.c:604#1:ffff888111f74010(sk_lock-AF_INET6){+.+.}, at:lock_sockinclude/net/sock.h:1516[inline] #1:ffff888111f74010(sk_lock-AF_INET6){+.+.}, at:mptcp_close+0x18/0x30net/mptcp/protocol.c:665stack backtrace: CPU: 0 PID: 22312 Comm: syz-executor.3 Not tainted 5.5.0-rc7 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xef/0x16e lib/dump_stack.c:118 check_noncircular+0x337/0x3f0 kernel/locking/lockdep.c:1808 check_prev_add kernel/locking/lockdep.c:2475 [inline] check_prevs_add kernel/locking/lockdep.c:2580 [inline] validate_chain kernel/locking/lockdep.c:2970 [inline] __lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954 lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484 __mutex_lock_common kernel/locking/mutex.c:956 [inline] __mutex_lock+0x158/0x1340 kernel/locking/mutex.c:1103 ipv6_sock_mc_close+0xc1/0xf0 net/ipv6/mcast.c:323 inet6_release+0x3c/0x70 net/ipv6/af_inet6.c:465 __sock_release+0x1dd/0x290 net/socket.c:605 __mptcp_close_ssk net/mptcp/protocol.c:592 [inline] __mptcp_close+0xec/0x360 net/mptcp/protocol.c:654 inet_release+0xe9/0x1f0 net/ipv4/af_inet.c:427 inet6_release+0x4c/0x70 net/ipv6/af_inet6.c:470 __sock_release+0xd2/0x290 net/socket.c:605 sock_close+0x18/0x20 net/socket.c:1283 __fput+0x2da/0x850 fs/file_table.c:280 task_work_run+0x144/0x1c0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_usermode_loop+0x1d2/0x200 arch/x86/entry/common.c:164 prepare_exit_to_usermode arch/x86/entry/common.c:195 [inline] syscall_return_slowpath arch/x86/entry/common.c:278 [inline] do_syscall_64+0x4d7/0x5b0 arch/x86/entry/common.c:304 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f691394128d Code: c1 20 00 00 75 10 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8 ee fb ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 37 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01 RSP: 002b:00007ffec314aaf0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 0000000000000001 RCX: 00007f691394128d RDX: 0000001b30220000 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 0000000000000004 R08: 00000000006704a8 R09: 000000008fa73b09 R10: 000000008fa73b0d R11: 0000000000000293 R12: 0000000000000001 R13: 000000000002076c R14: 00000000006704a8 R15: 00000000000007d0syz-executor.2 (2179) used greatest stack depth: 24704 bytes left syz-executor.1 (2127) used greatest stack depth: 24384 bytes left
===============================================================================
WARNING: possible circular locking dependency detected
5.5.0-rc7 #1 Not tainted
------------------------------------------------------
syz-executor.5/16250 is trying to acquire lock:ffff88811348e690(sk_lock-AF_INET6){+.+.}, at:lock_sockinclude/net/sock.h:1516[inline]ffff88811348e690(sk_lock-AF_INET6){+.+.}, at: do_ipv6_setsockopt.isra.0+0x362/0x4360net/ipv6/ipv6_sockglue.c:165but task is already holding lock:
ffffffff84f7aac0(rtnl_mutex){+.+.}, at: do_ipv6_setsockopt.isra.0+0x358/0x4360net/ipv6/ipv6_sockglue.c:164which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (rtnl_mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:956 [inline] __mutex_lock+0x158/0x1340 kernel/locking/mutex.c:1103 ipv6_sock_mc_close+0xc1/0xf0 net/ipv6/mcast.c:323 inet6_release+0x3c/0x70 net/ipv6/af_inet6.c:465 __sock_release+0x1dd/0x290 net/socket.c:605 __mptcp_close_ssk net/mptcp/protocol.c:592 [inline] __mptcp_close+0xec/0x360 net/mptcp/protocol.c:654 inet_release+0xe9/0x1f0 net/ipv4/af_inet.c:427 inet6_release+0x4c/0x70 net/ipv6/af_inet6.c:470 __sock_release+0xd2/0x290 net/socket.c:605 sock_close+0x18/0x20 net/socket.c:1283 __fput+0x2da/0x850 fs/file_table.c:280 task_work_run+0x144/0x1c0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_usermode_loop+0x1d2/0x200 arch/x86/entry/common.c:164 prepare_exit_to_usermode arch/x86/entry/common.c:195 [inline] syscall_return_slowpath arch/x86/entry/common.c:278 [inline] do_syscall_64+0x4d7/0x5b0 arch/x86/entry/common.c:304 entry_SYSCALL_64_after_hwframe+0x49/0xbe-> #0 (sk_lock-AF_INET6){+.+.}:
check_prev_add kernel/locking/lockdep.c:2475 [inline] check_prevs_add kernel/locking/lockdep.c:2580 [inline] validate_chain kernel/locking/lockdep.c:2970 [inline] __lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954 lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484 lock_sock_nested+0xca/0x120 net/core/sock.c:2944 lock_sock include/net/sock.h:1516 [inline] do_ipv6_setsockopt.isra.0+0x362/0x4360 net/ipv6/ipv6_sockglue.c:165 ipv6_setsockopt+0x101/0x180 net/ipv6/ipv6_sockglue.c:944 udpv6_setsockopt+0x5d/0xa0 net/ipv6/udp.c:1564 __sys_setsockopt+0x152/0x240 net/socket.c:2130 __do_sys_setsockopt net/socket.c:2146 [inline] __se_sys_setsockopt net/socket.c:2143 [inline] __x64_sys_setsockopt+0xba/0x150 net/socket.c:2143 do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbeother info that might help us debug this:
Possible unsafe locking scenario:CPU0 CPU1 ---- ---- lock(rtnl_mutex); lock(sk_lock-AF_INET6); lock(rtnl_mutex);
lock(sk_lock-AF_INET6);*** DEADLOCK ***
1 lock held by syz-executor.5/16250:
#0:ffffffff84f7aac0(rtnl_mutex){+.+.}, at: do_ipv6_setsockopt.isra.0+0x358/0x4360net/ipv6/ipv6_sockglue.c:164stack backtrace: CPU: 1 PID: 16250 Comm: syz-executor.5 Not tainted 5.5.0-rc7 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xef/0x16e lib/dump_stack.c:118 check_noncircular+0x337/0x3f0 kernel/locking/lockdep.c:1808 check_prev_add kernel/locking/lockdep.c:2475 [inline] check_prevs_add kernel/locking/lockdep.c:2580 [inline] validate_chain kernel/locking/lockdep.c:2970 [inline] __lock_acquire+0x1fb2/0x4680 kernel/locking/lockdep.c:3954 lock_acquire+0x127/0x330 kernel/locking/lockdep.c:4484 lock_sock_nested+0xca/0x120 net/core/sock.c:2944 lock_sock include/net/sock.h:1516 [inline] do_ipv6_setsockopt.isra.0+0x362/0x4360 net/ipv6/ipv6_sockglue.c:165 ipv6_setsockopt+0x101/0x180 net/ipv6/ipv6_sockglue.c:944 udpv6_setsockopt+0x5d/0xa0 net/ipv6/udp.c:1564 __sys_setsockopt+0x152/0x240 net/socket.c:2130 __do_sys_setsockopt net/socket.c:2146 [inline] __se_sys_setsockopt net/socket.c:2143 [inline] __x64_sys_setsockopt+0xba/0x150 net/socket.c:2143 do_syscall_64+0xbd/0x5b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f35bd9ad469 Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d ff 49 2b 00 f7 d8 64 89 01 48 RSP: 002b:00007f35be09ddd8 EFLAGS: 00000246 ORIG_RAX: 0000000000000036 RAX: ffffffffffffffda RBX: 000000000066bf00 RCX: 00007f35bd9ad469 RDX: 000000000000002c RSI: 0000000000000029 RDI: 0000000000000015 RBP: 00000000ffffffff R08: 0000000000000108 R09: 0000000000000000 R10: 0000000020000540 R11: 0000000000000246 R12: 0000000000000a50 R13: 0000000000439e70 R14: 00007f35be09e5c0 R15: 0000000000000003syz-executor.7 (2193) used greatest stack depth: 24704 bytes left syz-executor.1 (2164) used greatest stack depth: 24568 bytes left syz-executor.6 (2142) used greatest stack depth: 24448 bytes left syz-executor.3 (2140) used greatest stack depth: 24336 bytes left
Cheers,
Christoph