Skip to contentSkip to conversation

app/testpmd: use correct RFC addresses for tx-only

PATCH Applied Stephen Hemminger 2 participants 2 messages Jan 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 app/testpmd: use correct RFC addresses for tx-only

The previous patch to change default IP addresses for tx only mode got the wrong values (typo).

Fixes bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")
---
 app/test-pmd/txonly.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
app/test-pmd/txonly.c +2 -2
index 871cf6c1547f..4b5bec443b44 100644
@@ -45,8 +45,8 @@ uint16_t tx_udp_src_port = 9;
 uint16_t tx_udp_dst_port = 9;
 
 /* use RFC5735 / RFC2544 reserved network test addresses */
-uint32_t tx_ip_src_addr = (192U << 24) | (18 << 16) | (0 << 8) | 1;
-uint32_t tx_ip_dst_addr = (192U << 24) | (18 << 16) | (0 << 8) | 2;
+uint32_t tx_ip_src_addr = (198U << 24) | (18 << 16) | (0 << 8) | 1;
+uint32_t tx_ip_dst_addr = (198U << 24) | (18 << 16) | (0 << 8) | 2;
 
 #define IP_DEFTTL  64   /* from RFC 1340. */
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1 Applied
#1 lore raw
Quoted 15 lines · Stephen Hemminger

The previous patch to change default IP addresses for tx only mode got the wrong values (typo).

Fixes bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")
---
 app/test-pmd/txonly.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
app/test-pmd/txonly.c +0 -0
index 871cf6c1547f..4b5bec443b44 100644

app/test-pmd/txonly.c uint16_t tx_udp_src_port = 9; · line 52

Quoted 10 lines
app/test-pmd/txonly.c +2 -2
@@ -45,8 +45,8 @@ uint16_t tx_udp_src_port = 9;
 uint16_t tx_udp_dst_port = 9;
 
 /* use RFC5735 / RFC2544 reserved network test addresses */
-uint32_t tx_ip_src_addr = (192U << 24) | (18 << 16) | (0 << 8) | 1;
-uint32_t tx_ip_dst_addr = (192U << 24) | (18 << 16) | (0 << 8) | 2;
+uint32_t tx_ip_src_addr = (198U << 24) | (18 << 16) | (0 << 8) | 1;
+uint32_t tx_ip_dst_addr = (198U << 24) | (18 << 16) | (0 << 8) | 2;
 
 #define IP_DEFTTL  64   /* from RFC 1340. */
 

I confirm from rfc5735:

198.18.0.0/15 - This block has been allocated for use in benchmark
tests of network interconnect devices. [RFC2544] explains that this range was assigned to minimize the chance of conflict in case a testing device were to be accidentally connected to part of the Internet. Packets with source addresses from this range are not meant to be forwarded across the Internet.

Applied to dpdk-next-net/master, thanks.