staging: rtl8723bs: core: fix condition with no effect
PATCH 1/1 staging: rtl8723bs: core: fix condition with no effect
fix warning reorted by coccicheck
WARNING: possible condition with no effect (if == else)
Signed-off-by Saurav Girepunje <[email protected]>
--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme.c +2 -12
@@ -2771,18 +2771,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len, u8 channeDBG_871X ("+rtw_update_ht_cap()\n" );/* maybe needs check if ap supports rx ampdu. */ -if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable ==1 ) { -if (pregistrypriv->wifi_spec ==1 ) { -/* remove this part because testbed AP should disable RX AMPDU */ -/* phtpriv->ampdu_enable = false; */ - phtpriv->ampdu_enable = true; - }else { - phtpriv->ampdu_enable = true; - } - }else if (pregistrypriv->ampdu_enable ==2 ) { -/* remove this part because testbed AP should disable RX AMPDU */ -/* phtpriv->ampdu_enable = true; */ - } +if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable ==1 ) + phtpriv->ampdu_enable = true;/* check Max Rx A-MPDU Size */ len =0 ;
Signature · 1 line
1.9.1
Quoted 4 lines · Saurav Girepunje
fix warning reorted by coccicheck
WARNING: possible condition with no effect (if == else)Signed-off-by Saurav Girepunje <[email protected]>
This one looks good.
The difference between this one and the last one, is that this stuff looks like documentation but it's just a lot of garbage dead code so it's good to delete it.
But unfortunately, these patches don't apply. Please read Documentation/process/email-clients.rst
regards,
dan carpenter