tests/dumb_buffer: Remove page nonaligned buffer tests
PATCH 1/1 tests/dumb_buffer: Remove page nonaligned buffer tests
Considering that kernel returns the real memory size(page aligned) allocated, nonaligned buffer tests are not valid anymore. Hence removing them.
--- tests/dumb_buffer.c | 52 --------------------------------------------- 1 file changed, 52 deletions(-)
tests/dumb_buffer.c +0 -52
@@ -200,52 +200,6 @@ static void invalid_size_map(int fd)dumb_destroy (fd, create.handle); } -/* -* Creating an dumb buffer with non-aligned size and trying to access it with an -* offset, which is greater than the requested size but smaller than the -* object's last page boundary. pwrite here must be successful. -*/ -static void valid_nonaligned_size (int fd) -{ -struct drm_mode_create_dumb create = { - .width =24 , - .height =24 , - .bpp =32 , - }; -char buf[PAGE_SIZE ]; - -igt_require (is_i915_device (fd)); - -dumb_create (fd, &create); - -gem_write (fd, create.handle,PAGE_SIZE /2 , buf,PAGE_SIZE /2 ); - -dumb_destroy (fd, create.handle); -} - -/* -* Creating an object with non-aligned size and trying to access it with an -* offset, which is greater than the requested size and larger than the -* object's last page boundary. pwrite here must fail. -*/ -static void invalid_nonaligned_size (int fd) -{ -struct drm_mode_create_dumb create = { - .width =24 , - .height =24 , - .bpp =32 , - }; -char buf[PAGE_SIZE ]; - -igt_require (is_i915_device (fd)); - -dumb_create (fd, &create); -/* This should fail. Hence cannot use gem_write. */ -igt_assert (__gem_write (fd, create.handle, - create.size - (PAGE_SIZE /2 ), buf,PAGE_SIZE )); -dumb_destroy (fd, create.handle); -} - static uint64_t atomic_compare_swap_u64(_Atomic(uint64_t) *ptr,uint64_t oldval,uint64_t newval) {
@@ -362,12 +316,6 @@ igt_main igt_subtest("create-valid-dumb")valid_dumb_creation_test (fd); - igt_subtest("create-valid-nonaligned") -valid_nonaligned_size (fd); - - igt_subtest("create-invalid-nonaligned") -invalid_nonaligned_size (fd); - igt_subtest("map-valid")valid_map (fd);
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Ramalingam C (2020-01-27 08:32:03)
Quoted 6 lines
Considering that kernel returns the real memory size(page aligned) allocated, nonaligned buffer tests are not valid anymore. Hence removing them.
Signed-off-by Ramalingam C <[email protected]>cc Chris Wilson <[email protected]>
Just because they work is not necessary a good reason to scrap them :) But since these are most definitely based on i915 assumptions,
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for tests/dumb_buffer: Remove page nonaligned buffer tests
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: tests/dumb_buffer: Remove page nonaligned buffer tests
URL : https://patchwork.freedesktop.org/series/72602/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7814 -> IGTPW_3997
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3997 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_3997, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3997:
### IGT changes ###
#### Possible regressions ####
* igt@gem_close_race@basic-threads:
- fi-hsw-peppy: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7814/fi-hsw-peppy/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/fi-hsw-peppy/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_3997 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@fds:
- fi-byt-n2820: [PASS][3] -> [TIMEOUT][4] ([fdo#112271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7814/fi-byt-n2820/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/fi-byt-n2820/igt@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-6700k2: [PASS][5] -> [INCOMPLETE][6] ([i915#671])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7814/fi-skl-6700k2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/fi-skl-6700k2/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-skl-6600u: [PASS][7] -> [DMESG-WARN][8] ([i915#889]) +23 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7814/fi-skl-6600u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/fi-skl-6600u/igt@[email protected]
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [PASS][9] -> [DMESG-FAIL][10] ([i915#553] / [i915#725])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7814/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/fi-hsw-4770r/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gt_lrc:
- fi-skl-6600u: [PASS][11] -> [DMESG-FAIL][12] ([i915#889]) +7 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7814/fi-skl-6600u/igt@i915_selftest@live_gt_lrc.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/fi-skl-6600u/igt@i915_selftest@live_gt_lrc.html
#### Possible fixes ####
* igt@gem_exec_parallel@contexts:
- fi-byt-n2820: [TIMEOUT][13] ([fdo#112271]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7814/fi-byt-n2820/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/fi-byt-n2820/igt@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-x1275: [INCOMPLETE][15] ([i915#879]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7814/fi-kbl-x1275/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/fi-kbl-x1275/igt@[email protected]
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#879]: https://gitlab.freedesktop.org/drm/intel/issues/879
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
Participating hosts (44 -> 42)
------------------------------
Additional (5): fi-bdw-gvtdvm fi-kbl-7500u fi-blb-e6850 fi-snb-2600 fi-kbl-r
Missing (7): fi-cml-u2 fi-tgl-u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5384 -> IGTPW_3997
CI-20190529: 20190529
CI_DRM_7814: bc626bbb5b6efa3fb6a90407e85a04ae64461db6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3997: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/index.html
IGT_5384: fd6896567f7d612c76207970376d4f1e634ded55 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
-igt@dumb_buffer@create-invalid-nonaligned
-igt@dumb_buffer@create-valid-nonaligned
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3997/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev