Skip to contentSkip to conversation

screenshot: Remove this screenshot tool in favor of fbgrab

PATCH In review Andrew F. Davis 3 participants 5 messages Jan 27, 2020 – Feb 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 screenshot: Remove this screenshot tool in favor of fbgrab

This takes a screenshot of the current framebuffer only. There are tools for taking screenshots of the current window system which is usually what a user wants. If the user really wants the conent of the framebuffer then they can use fbgrab which is already in meta-oe.

---
 .../packagegroup-arago-tisdk-amsdk.bb         |  5 ----
 .../screenshot/screenshot_1.0.bb              | 27 -------------------
 2 files changed, 32 deletions(-)
 delete mode 100644 meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk.bb +0 -5
index 42c6aefa..c9a17c5e 100644
@@ -17,11 +17,6 @@ OOBE_ti43x += "\
     parse-ip \
 "
 
-EXTRA_APPLICATIONS = "\
-    screenshot \
-"
-
 RDEPENDS_${PN} = "\
     ${OOBE} \
-    ${EXTRA_APPLICATIONS} \
 "
meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb deleted +0 -27
deleted file mode 100644
index 08a3040b..00000000
@@ -1,27 +0,0 @@
-SUMMARY = "Screenshot"
-HOMEPAGE = "https://gitorious.org/screenshot"
-LICENSE = "BSD"
-LIC_FILES_CHKSUM = "file://COPYING;md5=5cad16cc3f514a15adb1d710b82d5fc4"
-SECTION = "graphics"
-
-PR = "r2"
-
-BRANCH ?= "master"
-SRCREV = "169242aa7a265d5c94755d74601ad4a3f1828c96"
-
-SRC_URI = "git://git.ti.com/apps/screenshot.git;protocol=git;branch=${BRANCH}"
-
-S = "${WORKDIR}/git"
-
-do_compile() {
-    export CROSS_COMPILE=${TARGET_PREFIX}
-    export CFLAGS='${TARGET_CC_ARCH}'
-    # build the release version
-    make release CC="${CC}"
-}
-
-do_install() {
-    make DESTDIR=${D} install
-}
-
-INSANE_SKIP_${PN} = "ldflags"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Andrew F. Davis

This takes a screenshot of the current framebuffer only. There are tools for taking screenshots of the current window system which is usually what a user wants. If the user really wants the conent of the framebuffer then they can use fbgrab which is already in meta-oe.

I'm not 100% sure, but I believe there's some use of screeshot tool in Matrix demos. I guess we would need to update that too for this change.

Jake, any comments from OOBE perspective?

Denys

Quoted 59 lines
---
 .../packagegroup-arago-tisdk-amsdk.bb         |  5 ----
 .../screenshot/screenshot_1.0.bb              | 27 -------------------
 2 files changed, 32 deletions(-)
 delete mode 100644 meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk.bb +0 -5
index 42c6aefa..c9a17c5e 100644
@@ -17,11 +17,6 @@ OOBE_ti43x += "\
     parse-ip \
 "
 
-EXTRA_APPLICATIONS = "\
-    screenshot \
-"
-
 RDEPENDS_${PN} = "\
     ${OOBE} \
-    ${EXTRA_APPLICATIONS} \
 "
meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb deleted +0 -27
deleted file mode 100644
index 08a3040b..00000000
@@ -1,27 +0,0 @@
-SUMMARY = "Screenshot"
-HOMEPAGE = "https://gitorious.org/screenshot"
-LICENSE = "BSD"
-LIC_FILES_CHKSUM = "file://COPYING;md5=5cad16cc3f514a15adb1d710b82d5fc4"
-SECTION = "graphics"
-
-PR = "r2"
-
-BRANCH ?= "master"
-SRCREV = "169242aa7a265d5c94755d74601ad4a3f1828c96"
-
-SRC_URI = "git://git.ti.com/apps/screenshot.git;protocol=git;branch=${BRANCH}"
-
-S = "${WORKDIR}/git"
-
-do_compile() {
-    export CROSS_COMPILE=${TARGET_PREFIX}
-    export CFLAGS='${TARGET_CC_ARCH}'
-    # build the release version
-    make release CC="${CC}"
-}
-
-do_install() {
-    make DESTDIR=${D} install
-}
-
-INSANE_SKIP_${PN} = "ldflags"
Signature · 1 line
2.17.1
#2 lore raw
Quoted 10 lines · Denys Dmytriyenko
Quoted 4 lines · Andrew F. Davis

This takes a screenshot of the current framebuffer only. There are tools for taking screenshots of the current window system which is usually what a user wants. If the user really wants the conent of the framebuffer then they can use fbgrab which is already in meta-oe.

I'm not 100% sure, but I believe there's some use of screeshot tool in Matrix demos. I guess we would need to update that too for this change.

Jake, any comments from OOBE perspective?

Ping

Quoted 66 lines

Denys

Quoted 59 lines
---
 .../packagegroup-arago-tisdk-amsdk.bb         |  5 ----
 .../screenshot/screenshot_1.0.bb              | 27 -------------------
 2 files changed, 32 deletions(-)
 delete mode 100644 meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk.bb +0 -5
index 42c6aefa..c9a17c5e 100644
@@ -17,11 +17,6 @@ OOBE_ti43x += "\
     parse-ip \
 "
 
-EXTRA_APPLICATIONS = "\
-    screenshot \
-"
-
 RDEPENDS_${PN} = "\
     ${OOBE} \
-    ${EXTRA_APPLICATIONS} \
 "
meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb deleted +0 -27
deleted file mode 100644
index 08a3040b..00000000
@@ -1,27 +0,0 @@
-SUMMARY = "Screenshot"
-HOMEPAGE = "https://gitorious.org/screenshot"
-LICENSE = "BSD"
-LIC_FILES_CHKSUM = "file://COPYING;md5=5cad16cc3f514a15adb1d710b82d5fc4"
-SECTION = "graphics"
-
-PR = "r2"
-
-BRANCH ?= "master"
-SRCREV = "169242aa7a265d5c94755d74601ad4a3f1828c96"
-
-SRC_URI = "git://git.ti.com/apps/screenshot.git;protocol=git;branch=${BRANCH}"
-
-S = "${WORKDIR}/git"
-
-do_compile() {
-    export CROSS_COMPILE=${TARGET_PREFIX}
-    export CFLAGS='${TARGET_CC_ARCH}'
-    # build the release version
-    make release CC="${CC}"
-}
-
-do_install() {
-    make DESTDIR=${D} install
-}
-
-INSANE_SKIP_${PN} = "ldflags"
Signature · 1 line
2.17.1

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

#3 lore raw
Quoted 6 lines · Denys Dmytriyenko
Quoted 5 lines · Denys Dmytriyenko
Quoted 4 lines · Andrew F. Davis

This takes a screenshot of the current framebuffer only. There are tools for taking screenshots of the current window system which is usually what a user wants. If the user really wants the conent of the framebuffer then they can use fbgrab which is already in meta-oe.

Quoted 6 lines
Quoted 4 lines

I'm not 100% sure, but I believe there's some use of screeshot tool in Matrix demos. I guess we would need to update that too for this change.

Jake, any comments from OOBE perspective?

Ping

I am not able to find any reference to this screenshot tool.

- Jake

Quoted 70 lines
Quoted 58 lines

Denys

Quoted 55 lines
---
  .../packagegroup-arago-tisdk-amsdk.bb         |  5 ----
  .../screenshot/screenshot_1.0.bb              | 27 -------------------
  2 files changed, 32 deletions(-)

delete mode 100644 meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk.bb +0 -5
index 42c6aefa..c9a17c5e 100644
@@ -17,11 +17,6 @@ OOBE_ti43x += "\
      parse-ip \
  "
 
-EXTRA_APPLICATIONS = "\
-    screenshot \
-"
-
  RDEPENDS_${PN} = "\
      ${OOBE} \
-    ${EXTRA_APPLICATIONS} \
  "
meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb deleted +0 -26
deleted file mode 100644
index 08a3040b..00000000
@@ -1,27 +0,0 @@
-SUMMARY = "Screenshot"
-HOMEPAGE = "https://gitorious.org/screenshot"
-LICENSE = "BSD"
-LIC_FILES_CHKSUM = "file://COPYING;md5=5cad16cc3f514a15adb1d710b82d5fc4"
-SECTION = "graphics"
-
-PR = "r2"
-
-BRANCH ?= "master"
-SRCREV = "169242aa7a265d5c94755d74601ad4a3f1828c96"
-
-SRC_URI = "git://git.ti.com/apps/screenshot.git;protocol=git;branch=${BRANCH}"
-
-S = "${WORKDIR}/git"
-
-do_compile() {
-    export CROSS_COMPILE=${TARGET_PREFIX}
-    export CFLAGS='${TARGET_CC_ARCH}'
-    # build the release version
-    make release CC="${CC}"
-}
-
-do_install() {
-    make DESTDIR=${D} install
-}
-
Quoted 8 lines
Quoted 4 lines
meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb deleted +0 -1
-INSANE_SKIP_${PN} = "ldflags"
Signature · 1 line
2.17.1

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

#4 lore raw
Quoted 8 lines · Jacob Stiffler
Quoted 6 lines · Denys Dmytriyenko
Quoted 5 lines · Denys Dmytriyenko
Quoted 4 lines · Andrew F. Davis

This takes a screenshot of the current framebuffer only. There are tools for taking screenshots of the current window system which is usually what a user wants. If the user really wants the conent of the framebuffer then they can use fbgrab which is already in meta-oe.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

I'm not 100% sure, but I believe there's some use of screeshot tool in Matrix demos. I guess we would need to update that too for this change.

Jake, any comments from OOBE perspective?

Ping

I am not able to find any reference to this screenshot tool.

Ok, I guess we can just drop it then.

Quoted 72 lines

- Jake

Quoted 69 lines
Quoted 57 lines

Denys

Quoted 54 lines
---
 .../packagegroup-arago-tisdk-amsdk.bb         |  5 ----
 .../screenshot/screenshot_1.0.bb              | 27 -------------------
 2 files changed, 32 deletions(-)
 delete mode 100644 meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk.bb +0 -5
index 42c6aefa..c9a17c5e 100644
@@ -17,11 +17,6 @@ OOBE_ti43x += "\
     parse-ip \
 "
-EXTRA_APPLICATIONS = "\
-    screenshot \
-"
-
 RDEPENDS_${PN} = "\
     ${OOBE} \
-    ${EXTRA_APPLICATIONS} \
 "
meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb deleted +0 -26
deleted file mode 100644
index 08a3040b..00000000
@@ -1,27 +0,0 @@
-SUMMARY = "Screenshot"
-HOMEPAGE = "https://gitorious.org/screenshot"
-LICENSE = "BSD"
-LIC_FILES_CHKSUM = "file://COPYING;md5=5cad16cc3f514a15adb1d710b82d5fc4"
-SECTION = "graphics"
-
-PR = "r2"
-
-BRANCH ?= "master"
-SRCREV = "169242aa7a265d5c94755d74601ad4a3f1828c96"
-
-SRC_URI = "git://git.ti.com/apps/screenshot.git;protocol=git;branch=${BRANCH}"
-
-S = "${WORKDIR}/git"
-
-do_compile() {
-    export CROSS_COMPILE=${TARGET_PREFIX}
-    export CFLAGS='${TARGET_CC_ARCH}'
-    # build the release version
-    make release CC="${CC}"
-}
-
-do_install() {
-    make DESTDIR=${D} install
-}
-
Quoted 8 lines
Quoted 4 lines
meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb deleted +0 -1
-INSANE_SKIP_${PN} = "ldflags"
Signature · 1 line
2.17.1

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago