Kconfig: add btrfs to distro boot
PATCH v4 1/2 Kconfig: add btrfs to distro boot
From: Matthias Brugger <[email protected]>
Some distributions use btrfs as the default file system. Enable btrfs support by default when using distro boot for all architectures but riscv, as it breaks compilation due to size problems.
---
Changes in v4:
- do not build for MIPS either
Changes in v3:
- use imply instead of select
Changes in v2:
- disable default btrfs support riscv
Kconfig | 1 + 1 file changed, 1 insertion(+)
Kconfig +1 -0
@@ -93,6 +93,7 @@ config DISTRO_DEFAULTS select HUSH_PARSER select SUPPORT_RAW_INITRD select SYS_LONGHELP + imply CMD_BTRFS if !RISCV && !MIPS imply CMD_MII if NET imply USB_STORAGE imply USE_BOOTCOMMAND
Signature · 1 line
2.24.0
PATCH v4 2/2 configs: Re-sync with CONFIG_DISTRO_DEFAULTS
From: Matthias Brugger <[email protected]>
CONFIG_DISTRO_DEFAULTS now enables CMD_BTRFS by default, we can delete the config option in the corresponding default configs. Other boards won't build with btrfs enabled so disable the support by default.
---
Changes in v4:
- disable for some boards
Changes in v3: None
Changes in v2: None
configs/am335x_evm_defconfig | 2 ++ configs/sandbox64_defconfig | 1 - configs/sandbox_defconfig | 1 - configs/socfpga_arria10_defconfig | 2 ++ configs/turris_mox_defconfig | 1 - configs/turris_omnia_defconfig | 1 - 6 files changed, 4 insertions(+), 4 deletions(-)
configs/am335x_evm_defconfig +2 -0
@@ -80,3 +80,5 @@ CONFIG_DYNAMIC_CRC_TABLE=y CONFIG_RSA=y CONFIG_LZO=y # CONFIG_OF_LIBFDT_OVERLAY is not set +# CONFIG_CMD_BTRFS is not set +# CONFIG_FS_BTRFS is not set
configs/sandbox64_defconfig +0 -1
@@ -63,7 +63,6 @@ CONFIG_CMD_REGULATOR=y CONFIG_CMD_AES=y CONFIG_CMD_TPM=y CONFIG_CMD_TPM_TEST=y -CONFIG_CMD_BTRFS=y CONFIG_CMD_CBFS=y CONFIG_CMD_CRAMFS=y CONFIG_CMD_EXT4_WRITE=y
configs/sandbox_defconfig +0 -1
@@ -71,7 +71,6 @@ CONFIG_CMD_REGULATOR=y CONFIG_CMD_AES=y CONFIG_CMD_TPM=y CONFIG_CMD_TPM_TEST=y -CONFIG_CMD_BTRFS=y CONFIG_CMD_CBFS=y CONFIG_CMD_CRAMFS=y CONFIG_CMD_EXT4_WRITE=y
configs/socfpga_arria10_defconfig +2 -0
@@ -50,3 +50,5 @@ CONFIG_TIMER=y CONFIG_SPL_TIMER=y CONFIG_DESIGNWARE_APB_TIMER=y # CONFIG_SPL_WDT is not set +# CONFIG_CMD_BTRFS is not set +# CONFIG_FS_BTRFS is not set
configs/turris_mox_defconfig +0 -1
@@ -32,7 +32,6 @@ CONFIG_CMD_TFTPPUT=y CONFIG_CMD_CACHE=y CONFIG_CMD_TIME=y CONFIG_CMD_MVEBU_BUBT=y -CONFIG_CMD_BTRFS=y CONFIG_CMD_EXT4_WRITE=y CONFIG_MAC_PARTITION=y CONFIG_OF_BOARD_FIXUP=y
configs/turris_omnia_defconfig +0 -1
@@ -49,7 +49,6 @@ CONFIG_CMD_CACHE=y CONFIG_CMD_TIME=y CONFIG_CMD_AES=y CONFIG_CMD_HASH=y -CONFIG_CMD_BTRFS=y # CONFIG_SPL_PARTITION_UUIDS is not set CONFIG_DEFAULT_DEVICE_TREE="armada-385-turris-omnia" CONFIG_ENV_IS_IN_SPI_FLASH=y
Signature · 1 line
2.24.0
PATCH v4 1/2 Kconfig: add btrfs to distro boot
In reply to matthias.bgg at kernel.orgQuoted 8 lines · matthias.bgg at kernel.org
From: Matthias Brugger <[email protected]>
Some distributions use btrfs as the default file system. Enable btrfs support by default when using distro boot for all architectures but riscv, as it breaks compilation due to size problems.
Signed-off-by Matthias Brugger <[email protected]>
Any comments on this?
FYI the Travis CI outcome can be seen here:
https://travis-ci.org/mbgg/u-boot/builds/638599305
Regards,
Matthias
Quoted 27 lines
---
Changes in v4:
- do not build for MIPS eitherChanges in v3:
- use imply instead of selectChanges in v2:
- disable default btrfs support riscvKconfig | 1 + 1 file changed, 1 insertion(+)Kconfig +1
-0@@ -93,6 +93,7 @@ config DISTRO_DEFAULTS select HUSH_PARSER select SUPPORT_RAW_INITRD select SYS_LONGHELP + imply CMD_BTRFS if !RISCV && !MIPS imply CMD_MII if NET imply USB_STORAGE imply USE_BOOTCOMMAND
PATCH v4 1/2 Kconfig: add btrfs to distro boot
In reply to matthias.bgg at kernel.orgQuoted 7 lines · matthias.bgg at kernel.org
From: Matthias Brugger <[email protected]>
Some distributions use btrfs as the default file system. Enable btrfs support by default when using distro boot for all architectures but riscv, as it breaks compilation due to size problems.
Signed-off-by Matthias Brugger <[email protected]>
This adds around 60kb to many platforms, so I'm not going to take this right now. But I'm not rejecting it outright. My question however is, I was under the impression that the direction distributions were taking was that bootefi would be used to start GRUB2 and that (and its filesystem modules) would be responsible for doing the next steps. So we wouldn't need btrfs support here for example as everything would be
picked out of the system partition, which is FAT32. Am I mistaken
about the flow here? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200127/dd151e33/attachment.sig>
PATCH v4 1/2 Kconfig: add btrfs to distro boot
Quoted 2 lines · On Mon, 27 Jan 2020 16:58:06 -0500 Tom Rini <[email protected]> wrote:
This adds around 60kb to many platforms, so I'm not going to take this right now.
Off topic: I was wondering how much space could be saved if it were possible to use -Os with LTO in U-Boot.
PATCH v4 1/2 Kconfig: add btrfs to distro boot
Quoted 8 lines · Marek Behun
Quoted 2 lines · On Mon, 27 Jan 2020 16:58:06 -0500 Tom Rini <[email protected]> wrote:
This adds around 60kb to many platforms, so I'm not going to take this right now.
Off topic: I was wondering how much space could be saved if it were possible to use -Os with LTO in U-Boot.
It's a good question. Step one is to switch to using gcc to link directly.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200127/db15e73c/attachment.sig>
PATCH v4 1/2 Kconfig: add btrfs to distro boot
Quoted 5 lines · On Mon, 27 Jan 2020 18:28:25 -0500 Tom Rini <[email protected]> wrote:
Quoted 3 lines · Marek Behun
On Mon, 27 Jan 2020 16:58:06 -0500
Tom Rini <[email protected]> wrote:
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
This adds around 60kb to many platforms, so I'm not going to take this right now.
Off topic: I was wondering how much space could be saved if it were possible to use -Os with LTO in U-Boot.
It's a good question. Step one is to switch to using gcc to link directly.
Tom, another option would be to try to amalge btrfs sources into one file and try to compile it with -Os, I am curious about what would happen. Maybe I'll try sometime this week.
PATCH v4 1/2 Kconfig: add btrfs to distro boot
Quoted 14 lines · Marek Behun
Quoted 11 lines · On Mon, 27 Jan 2020 18:28:25 -0500 Tom Rini <[email protected]> wrote:
Quoted 8 lines · Marek Behun
Quoted 2 lines · On Mon, 27 Jan 2020 16:58:06 -0500 Tom Rini <[email protected]> wrote:
This adds around 60kb to many platforms, so I'm not going to take this right now.
Off topic: I was wondering how much space could be saved if it were possible to use -Os with LTO in U-Boot.
Quoted 6 lines
Quoted 2 lines
It's a good question. Step one is to switch to using gcc to link directly.
Tom, another option would be to try to amalge btrfs sources into one file and try to compile it with -Os, I am curious about what would happen. Maybe I'll try sometime this week.
Sure, but per the other email I just sent out, just like how I'm not happy about adding a few hundred bytes to hundreds of boards for QSPI support, I'm not happy to see this be the default for a few hundred boards and we need something more fine-grained.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200128/49e70564/attachment.sig>
PATCH v4 1/2 Kconfig: add btrfs to distro boot
In reply to Tom RiniQuoted 10 lines · Tom Rini
Quoted 7 lines · matthias.bgg at kernel.org
From: Matthias Brugger <[email protected]>
Some distributions use btrfs as the default file system. Enable btrfs support by default when using distro boot for all architectures but riscv, as it breaks compilation due to size problems.
Signed-off-by Matthias Brugger <[email protected]>
Quoted 9 lines
This adds around 60kb to many platforms, so I'm not going to take this right now. But I'm not rejecting it outright. My question however is, I was under the impression that the direction distributions were taking was that bootefi would be used to start GRUB2 and that (and its filesystem modules) would be responsible for doing the next steps. So we wouldn't need btrfs support here for example as everything would be
picked out of the system partition, which is FAT32. Am I mistaken
about the flow here? Thanks!
I think the assumption is correct for most of the distributions (if not all). However in distro boot we support e.g. extlinux/sysboot which not necessarily boots a EFI binary. Apart from that, think about a broken system partition. In that case if your distribution has the kernel on a btrfs partition, you would not be able to boot this kernel.
That's the reason why we enable ext2 and ext4 support in distro boot.
Regarding the size, I'm aware of the problem, that's why it is set as imply in Kconfig so that individual boards can turn it off. We might think about chaning ext2 and ext4 from select to imply as well as we are at the limit on some platforms.
Regards,
Matthias
Regards,
Matthias
PATCH v4 1/2 Kconfig: add btrfs to distro boot
Quoted 30 lines · Matthias Brugger
Quoted 10 lines · Tom Rini
Quoted 7 lines · matthias.bgg at kernel.org
From: Matthias Brugger <[email protected]>
Some distributions use btrfs as the default file system. Enable btrfs support by default when using distro boot for all architectures but riscv, as it breaks compilation due to size problems.
Signed-off-by Matthias Brugger <[email protected]>Quoted 9 lines
This adds around 60kb to many platforms, so I'm not going to take this right now. But I'm not rejecting it outright. My question however is, I was under the impression that the direction distributions were taking was that bootefi would be used to start GRUB2 and that (and its filesystem modules) would be responsible for doing the next steps. So we wouldn't need btrfs support here for example as everything would be
picked out of the system partition, which is FAT32. Am I mistaken
about the flow here? Thanks!I think the assumption is correct for most of the distributions (if not all). However in distro boot we support e.g. extlinux/sysboot which not necessarily boots a EFI binary. Apart from that, think about a broken system partition. In that case if your distribution has the kernel on a btrfs partition, you would not be able to boot this kernel.
That's the reason why we enable ext2 and ext4 support in distro boot.
Quoted 3 lines
Regarding the size, I'm aware of the problem, that's why it is set as imply in
Kconfigso that individual boards can turn it off. We might think about chaning ext2 and ext4 from select to imply as well as we are at the limit on some platforms.
The extN support portion I thought predates bootefi+GRUB being viable/common and is for when /boot was/is formatted as such.
My concern here (similar to my concern about distro boot + SPI) is that we encourage the default for all boards to be "use distro boot, it makes life easy on users". Both big name distributions support it as well as embedded oriented distributions. Non-Linux supports it. So growth here is very important to consider.
Perhaps what we can talk about, for v2020.07, is a new not-default sub-option of DISTRO_DEFAULTS to make it more robust, as in your use-case and select more filesystems. And move EXT2/EXT4 to that, but also make all existing users keep it enabled (which is a little tricky, but doable of a migration) and add BTRFS. We can even see if it makes sense to add ZFS there too for the BSD folks.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200128/11c748fc/attachment.sig>
PATCH v4 1/2 Kconfig: add btrfs to distro boot
In reply to matthias.bgg at kernel.orgHi,
Quoted 1 line
Signed-off-by Matthias Brugger <[email protected]>
Kind regards,
Petr