Skip to contentSkip to conversation

MAINTAINERS: Sort entries in database for VSPRINTF

PATCH In review Andy Shevchenko 2 participants 5 messages Jan 28, 2020 – Feb 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Sort entries in database for VSPRINTF

Run parse-maintainers.pl and choose VSPRINTF record. Fix it accordingly.

---
 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
MAINTAINERS +3 -3
index 211043d91cd0..4791757ba1ef 100644
@@ -17932,11 +17932,11 @@ M:	Steven Rostedt <[email protected]>
 M:	Sergey Senozhatsky <[email protected]>
 R:	Andy Shevchenko <[email protected]>
 R:	Rasmus Villemoes <[email protected]>
-T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git
 S:	Maintained
-F:	lib/vsprintf.c
-F:	lib/test_printf.c
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git
 F:	Documentation/core-api/printk-formats.rst
+F:	lib/test_printf.c
+F:	lib/vsprintf.c
 
 VT1211 HARDWARE MONITOR DRIVER
 M:	Juerg Haefliger <[email protected]>
Signature · 1 line
2.24.1
#1 lore raw

Hi Andy,

Quoted 1 line · Andy Shevchenko

Run parse-maintainers.pl and choose VSPRINTF record. Fix it accordingly.

Does this produce any visible error or warning anywhere, please?

checkpatch.pl does not warn about it.

Also the order does not look defined in the file. When I run parse-maintainers.pl on the entire MAINTAINERS file:

 MAINTAINERS | 5584 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------
 1 file changed, 2787 insertions(+), 2797 deletions(-)

The file has 18545 lines. It means that huge amount of entries do not follow the order.

Best Regards,
Petr

Quoted 26 lines
---
 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
MAINTAINERS +3 -3
index 211043d91cd0..4791757ba1ef 100644
@@ -17932,11 +17932,11 @@ M:	Steven Rostedt <[email protected]>
 M:	Sergey Senozhatsky <[email protected]>
 R:	Andy Shevchenko <[email protected]>
 R:	Rasmus Villemoes <[email protected]>
-T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git
 S:	Maintained
-F:	lib/vsprintf.c
-F:	lib/test_printf.c
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git
 F:	Documentation/core-api/printk-formats.rst
+F:	lib/test_printf.c
+F:	lib/vsprintf.c
 
 VT1211 HARDWARE MONITOR DRIVER
 M:	Juerg Haefliger <[email protected]>
Signature · 1 line
2.24.1
#2 lore raw
Quoted 6 lines · Petr Mladek

Hi Andy,

Quoted 1 line · Andy Shevchenko

Run parse-maintainers.pl and choose VSPRINTF record. Fix it accordingly.

Does this produce any visible error or warning anywhere, please?

Not for the moment.
Nevertheless, there is an initial motivation behind this [1,2].

Quoted 4 lines

checkpatch.pl does not warn about it.

Also the order does not look defined in the file. When I run parse-maintainers.pl on the entire MAINTAINERS file:

See [2] for the details.

Quoted 5 lines
 MAINTAINERS | 5584 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------
 1 file changed, 2787 insertions(+), 2797 deletions(-)

The file has 18545 lines. It means that huge amount of entries do not follow the order.

Yes, but it's getting better.

[1]: 7683e9e52925 ("Properly alphabetize MAINTAINERS file")
[2]: https://lore.kernel.org/lkml/CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@mail.gmail.com/

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Petr Mladek

Also the order does not look defined in the file. When I run parse-maintainers.pl on the entire MAINTAINERS file:

See [2] for the details.

"... But in the meantime, at least that MAINTAINERS file should _really_ be alpha-sorted now."

Quoted 1 line

[2]: https://lore.kernel.org/lkml/CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@mail.gmail.com/

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
In reply to Andy Shevchenko
Quoted 14 lines · Andy Shevchenko
Quoted 7 lines · Petr Mladek

Hi Andy,

Quoted 1 line · Andy Shevchenko

Run parse-maintainers.pl and choose VSPRINTF record. Fix it accordingly.

Also the order does not look defined in the file. When I run parse-maintainers.pl on the entire MAINTAINERS file:

See [2] for the details.

Quoted 3 lines
 MAINTAINERS | 5584 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------
 1 file changed, 2787 insertions(+), 2797 deletions(-)
Quoted 7 lines
Quoted 2 lines

The file has 18545 lines. It means that huge amount of entries do not follow the order.

Yes, but it's getting better.

[1]: 7683e9e52925 ("Properly alphabetize MAINTAINERS file")
[2]: https://lore.kernel.org/lkml/CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@mail.gmail.com/

Ok, the message [2] is Linus' reaction on a similar patch. He complained that

(a) the ordering wasn't complete
(b) this wasn't scripted.

In fact, parse-maintainers.pl was created to automatize such clean ups and allow to fix all entries at once.

Fixing only VSPRITF record is a tiny-piece-by-piece approach. It is an approach that will create a lot of work for many people.

If you want to do a clean up then please ask Linus to do it by the script.

Also please add a check into checkpatch.pl to reduce regressions.

Best Regards,
Petr