Skip to contentSkip to conversation

net/bnx2x: fix to set stripped flag for VLAN packet

PATCH Applied Rasesh Mody 2 participants 2 messages Jan 29, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/bnx2x: fix to set stripped flag for VLAN packet

For VLAN packet the tci is saved in rx_mb->vlan_tci, however the STRIPPED offload flag is not set along with PKT_RX_VLAN flag. Set the PKT_RX_VLAN_STRIPPED flag as well.

Fixes 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
Fixes b37b528d957c ("mbuf: add new Rx flags for stripped VLAN")
---
 drivers/net/bnx2x/bnx2x_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnx2x/bnx2x_rxtx.c +1 -1
index ae97dfee36..ea2b53dff8 100644
@@ -414,7 +414,7 @@ bnx2x_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 		 */
 		if (cqe_fp->pars_flags.flags & PARSING_FLAGS_VLAN) {
 			rx_mb->vlan_tci = cqe_fp->vlan_tag;
-			rx_mb->ol_flags |= PKT_RX_VLAN;
+			rx_mb->ol_flags |= PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
 		}
 
 		rx_pkts[nb_rx] = rx_mb;
Signature · 1 line
2.18.0
Applied
#1 lore raw
Quoted 9 lines · Rasesh Mody

For VLAN packet the tci is saved in rx_mb->vlan_tci, however the STRIPPED offload flag is not set along with PKT_RX_VLAN flag. Set the PKT_RX_VLAN_STRIPPED flag as well.

Fixes 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
Fixes b37b528d957c ("mbuf: add new Rx flags for stripped VLAN")

Applied to dpdk-next-net-mrvl/master. Thanks

Quoted 20 lines
---
 drivers/net/bnx2x/bnx2x_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnx2x/bnx2x_rxtx.c +1 -2
index ae97dfee36..ea2b53dff8 100644
@@ -414,7 +414,7 @@ bnx2x_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                 */
                if (cqe_fp->pars_flags.flags & PARSING_FLAGS_VLAN) {
                        rx_mb->vlan_tci = cqe_fp->vlan_tag;
-                       rx_mb->ol_flags |= PKT_RX_VLAN;
+                       rx_mb->ol_flags |= PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
                }
 
                rx_pkts[nb_rx] = rx_mb;
--

2.18.0