Skip to contentSkip to conversation

tests/i915/gem_ctx_persistence: Set context with supported engines

PATCH In review Bommu Krishnaiah 4 participants 12 messages Jan 29, 2020 – Feb 1, 2020

lore
Share & tools
lore
#0 lore raw

v6 cover tests/i915/gem_ctx_persistence: Set context with supported engines

Update the context with supported engines on the platform with set_property I915_CONTEXT_PARAM_ENGINES to make sure the work load is submitted to the available engines only.

v2: addressed the review comments.
v3: addressed v2 review comments.
V4: Re-introduced the gem_context_set_all_engines() API,test_process_mixed() test creating new forked process, to set engine map to new forked process I added gem_context_set_all_engines() API.
v5: addressed v4 review comments.
v6: addressed chris comments.

Bommu Krishnaiah (1):
tests/i915/gem_ctx_persistence: Set context with supported engines

 tests/i915/gem_ctx_persistence.c | 59 +++++++++++++++++++++++++-------
 1 file changed, 46 insertions(+), 13 deletions(-)
Signature · 6 lines
2.24.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH v6 1/1 tests/i915/gem_ctx_persistence: Set context with supported engines

Update the context with supported engines on the platform with set_property I915_CONTEXT_PARAM_ENGINES to make sure the work load is submitted to the available engines only.

v2: addressed the review comments.
v3: addressed v2 review comments.
V4: Re-introduced the gem_context_set_all_engines() API,test_process_mixed() test creating new forked process, to set engine map to new forked process I added gem_context_set_all_engines() API.
v5: addressed v4 review comments.
v6: addressed chris comments.

---
 tests/i915/gem_ctx_persistence.c | 59 +++++++++++++++++++++++++-------
 1 file changed, 46 insertions(+), 13 deletions(-)
tests/i915/gem_ctx_persistence.c +46 -13
index 43333aaf..de6f5925 100644
@@ -156,7 +156,7 @@ static void test_persistence(int i915, unsigned int engine)
 	 * request is retired -- no early termination.
 	 */
 
-	ctx = gem_context_create(i915);
+	ctx = gem_context_clone_with_engines(i915, 0);
 	gem_context_set_persistence(i915, ctx, true);
 
 	spin = igt_spin_new(i915, ctx,
@@ -188,7 +188,7 @@ static void test_nonpersistent_cleanup(int i915, unsigned int engine)
 	 * any inflight request is cancelled.
 	 */
 
-	ctx = gem_context_create(i915);
+	ctx = gem_context_clone_with_engines(i915, 0);
 	gem_context_set_persistence(i915, ctx, false);
 
 	spin = igt_spin_new(i915, ctx,
@@ -217,7 +217,7 @@ static void test_nonpersistent_mixed(int i915, unsigned int engine)
 		igt_spin_t *spin;
 		uint32_t ctx;
 
-		ctx = gem_context_create(i915);
+		ctx = gem_context_clone_with_engines(i915, 0);
 		gem_context_set_persistence(i915, ctx, i & 1);
 
 		spin = igt_spin_new(i915, ctx,
@@ -253,7 +253,7 @@ static void test_nonpersistent_hostile(int i915, unsigned int engine)
 	 * the requests and cleanup the context.
 	 */
 
-	ctx = gem_context_create(i915);
+	ctx = gem_context_clone_with_engines(i915, 0);
 	gem_context_set_persistence(i915, ctx, false);
 
 	spin = igt_spin_new(i915, ctx,
@@ -284,7 +284,7 @@ static void test_nonpersistent_hostile_preempt(int i915, unsigned int engine)
 
 	igt_require(gem_scheduler_has_preemption(i915));
 
-	ctx = gem_context_create(i915);
+	ctx = gem_context_clone_with_engines(i915, 0);
 	gem_context_set_persistence(i915, ctx, true);
 	gem_context_set_priority(i915, ctx, 0);
 	spin[0] = igt_spin_new(i915, ctx,
@@ -295,7 +295,7 @@ static void test_nonpersistent_hostile_preempt(int i915, unsigned int engine)
 
 	igt_spin_busywait_until_started(spin[0]);
 
-	ctx = gem_context_create(i915);
+	ctx = gem_context_clone_with_engines(i915, 0);
 	gem_context_set_persistence(i915, ctx, false);
 	gem_context_set_priority(i915, ctx, 1); /* higher priority than 0 */
 	spin[1] = igt_spin_new(i915, ctx,
@@ -445,7 +445,7 @@ static void test_nonpersistent_queued(int i915, unsigned int engine)
 
 	gem_quiescent_gpu(i915);
 
-	ctx = gem_context_create(i915);
+	ctx = gem_context_clone_with_engines(i915, 0);
 	gem_context_set_persistence(i915, ctx, false);
 	spin = igt_spin_new(i915, ctx,
 			    .engine = engine,
@@ -552,7 +552,7 @@ static void test_process(int i915)
 	gem_quiescent_gpu(i915);
 }
 
-static void test_process_mixed(int i915, unsigned int engine)
+static void test_process_mixed(int pfd, unsigned int engine)
 {
 	int fence[2], sv[2];
 
@@ -565,7 +565,8 @@ static void test_process_mixed(int i915, unsigned int engine)
 	igt_require(socketpair(AF_UNIX, SOCK_DGRAM, 0, sv) == 0);
 
 	igt_fork(child, 1) {
-		i915 = gem_reopen_driver(i915);
+		int i915;
+		i915 = gem_reopen_driver(pfd);
 		gem_quiescent_gpu(i915);
 
 		for (int persists = 0; persists <= 1; persists++) {
@@ -573,6 +574,7 @@ static void test_process_mixed(int i915, unsigned int engine)
 			uint32_t ctx;
 
 			ctx = gem_context_create(i915);
+			gem_context_copy_engines(pfd, 0, i915, ctx);
 			gem_context_set_persistence(i915, ctx, persists);
 
 			spin = igt_spin_new(i915, ctx,
@@ -586,7 +588,7 @@ static void test_process_mixed(int i915, unsigned int engine)
 	}
 	close(sv[0]);
 	igt_waitchildren();
-	flush_delayed_fput(i915);
+	flush_delayed_fput(pfd);
 
 	fence[0] = recvfd(sv[1]);
 	fence[1] = recvfd(sv[1]);
@@ -602,9 +604,9 @@ static void test_process_mixed(int i915, unsigned int engine)
 	close(fence[1]);
 
 	/* We have to manually clean up the orphaned spinner */
-	igt_drop_caches_set(i915, DROP_RESET_ACTIVE);
+	igt_drop_caches_set(pfd, DROP_RESET_ACTIVE);
 
-	gem_quiescent_gpu(i915);
+	gem_quiescent_gpu(pfd);
 }
 
 static void test_processes(int i915)
@@ -789,13 +791,44 @@ igt_main
 	igt_subtest("hang")
 		test_nohangcheck_hang(i915);
 
-	__for_each_static_engine(e) {
+	for_each_engine(e, i915) {
 		igt_subtest_group {
 			igt_fixture {
 				gem_require_ring(i915, e->flags);
 				gem_require_contexts(i915);
 			}
 
+			igt_subtest_f("legacy-%s-persistence", e->name)
+				test_persistence(i915, e->flags);
+
+			igt_subtest_f("legacy-%s-cleanup", e->name)
+				test_nonpersistent_cleanup(i915, e->flags);
+
+			igt_subtest_f("legacy-%s-queued", e->name)
+				test_nonpersistent_queued(i915, e->flags);
+
+			igt_subtest_f("legacy-%s-mixed", e->name)
+				test_nonpersistent_mixed(i915, e->flags);
+
+			igt_subtest_f("legacy-%s-mixed-process", e->name)
+				test_process_mixed(i915, e->flags);
+
+			igt_subtest_f("legacy-%s-hostile", e->name)
+				test_nonpersistent_hostile(i915, e->flags);
+
+			igt_subtest_f("legacy-%s-hostile-preempt", e->name)
+				test_nonpersistent_hostile_preempt(i915,
+								   e->flags);
+		}
+	}
+
+        __for_each_physical_engine(i915, e) {
+                igt_subtest_group {
+                        igt_fixture {
+                                gem_require_ring(i915, e->flags);
+                                gem_require_contexts(i915);
+                        }
+
 			igt_subtest_f("%s-persistence", e->name)
 				test_persistence(i915, e->flags);
 
Signature · 6 lines
2.24.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#2 lore raw

Quoting Bommu Krishnaiah (2020-01-29 18:10:02)

Quoted 11 lines

Update the context with supported engines on the platform with set_property I915_CONTEXT_PARAM_ENGINES to make sure the work load is submitted to the available engines only.

v2: addressed the review comments.
v3: addressed v2 review comments.
V4: Re-introduced the gem_context_set_all_engines() API,test_process_mixed() test creating new forked process, to set engine map to new forked process I added gem_context_set_all_engines() API.
v5: addressed v4 review comments.
v6: addressed chris comments.

This is totally useless as a recording of the history. Explain why you had to make the changes, for posterity.

tests/i915/gem_ctx_persistence.c igt_main · line 794

Quoted 2 lines
tests/i915/gem_ctx_persistence.c +1 -1
-       __for_each_static_engine(e) {
+       for_each_engine(e, i915) {

Incorrect change that leads to compiler warnings and prevents the legacy tests being listed by CI.

I've given up and fixed it.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw
Quoted 16 lines · Chris Wilson

Quoting Bommu Krishnaiah (2020-01-29 18:10:02)

Quoted 11 lines

Update the context with supported engines on the platform with set_property I915_CONTEXT_PARAM_ENGINES to make sure the work load is submitted to the available engines only.

v2: addressed the review comments.
v3: addressed v2 review comments.
V4: Re-introduced the gem_context_set_all_engines() API,test_process_mixed() test creating new forked process, to set engine map to new forked process I added gem_context_set_all_engines() API.
v5: addressed v4 review comments.
v6: addressed chris comments.

This is totally useless as a recording of the history. Explain why you had to make the changes, for posterity.

Quoted 7 lines

Review

Quoted 2 lines
(quoted diff) +1 -1
-       __for_each_static_engine(e) {
+       for_each_engine(e, i915) {

Incorrect change that leads to compiler warnings and prevents the legacy tests being listed by CI.

I've given up and fixed it.

Partially my bad, I suggested to use for_each_engine while forgetting subtest enumeration needs to be static and for_each_engine has an runtime element. :(

This diff on top fixes it:

tests/i915/gem_ctx_persistence.c +22 -21
index de6f59251200..c56189c57cdd 100644
@@ -758,7 +758,8 @@ static void smoketest(int i915)
 
 igt_main
 {
-       const struct intel_execution_engine2 *e;
+       const struct intel_execution_engine *e;
+       const struct intel_execution_engine2 *e2;
        int i915;
 
        igt_fixture {
@@ -791,10 +792,10 @@ igt_main
        igt_subtest("hang")
                test_nohangcheck_hang(i915);
 
-       for_each_engine(e, i915) {
+       for (e = intel_execution_engines; e->name; e++) {
                igt_subtest_group {
                        igt_fixture {
-                               gem_require_ring(i915, e->flags);
+                               gem_require_ring(i915, eb_ring(e));
                                gem_require_contexts(i915);
                        }
 
@@ -822,37 +823,37 @@ igt_main
                }
        }
 
-        __for_each_physical_engine(i915, e) {
+        __for_each_physical_engine(i915, e2) {
                 igt_subtest_group {
                         igt_fixture {
-                                gem_require_ring(i915, e->flags);
+                                gem_require_ring(i915, e2->flags);
                                 gem_require_contexts(i915);
                         }
 
-                       igt_subtest_f("%s-persistence", e->name)
-                               test_persistence(i915, e->flags);
+                       igt_subtest_f("%s-persistence", e2->name)
+                               test_persistence(i915, e2->flags);
 
-                       igt_subtest_f("%s-cleanup", e->name)
-                               test_nonpersistent_cleanup(i915, e->flags);
+                       igt_subtest_f("%s-cleanup", e2->name)
+                               test_nonpersistent_cleanup(i915, e2->flags);
 
-                       igt_subtest_f("%s-queued", e->name)
-                               test_nonpersistent_queued(i915, e->flags);
+                       igt_subtest_f("%s-queued", e2->name)
+                               test_nonpersistent_queued(i915, e2->flags);
 
-                       igt_subtest_f("%s-mixed", e->name)
-                               test_nonpersistent_mixed(i915, e->flags);
+                       igt_subtest_f("%s-mixed", e2->name)
+                               test_nonpersistent_mixed(i915, e2->flags);
 
-                       igt_subtest_f("%s-mixed-process", e->name)
-                               test_process_mixed(i915, e->flags);
+                       igt_subtest_f("%s-mixed-process", e2->name)
+                               test_process_mixed(i915, e2->flags);
 
-                       igt_subtest_f("%s-hostile", e->name)
-                               test_nonpersistent_hostile(i915, e->flags);
+                       igt_subtest_f("%s-hostile", e2->name)
+                               test_nonpersistent_hostile(i915, e2->flags);
 
-                       igt_subtest_f("%s-hostile-preempt", e->name)
+                       igt_subtest_f("%s-hostile-preempt", e2->name)
                                test_nonpersistent_hostile_preempt(i915,
-                                                                  e->flags);
+                                                                  e2->flags);
 
-                       igt_subtest_f("%s-hang", e->name)
-                               test_nonpersistent_hang(i915, e->flags);
+                       igt_subtest_f("%s-hang", e2->name)
+                               test_nonpersistent_hang(i915, e2->flags);
                }
        }
 

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw
Quoted 18 lines · Tvrtko Ursulin
Quoted 16 lines · Chris Wilson

Quoting Bommu Krishnaiah (2020-01-29 18:10:02)

Quoted 11 lines

Update the context with supported engines on the platform with set_property I915_CONTEXT_PARAM_ENGINES to make sure the work load is submitted to the available engines only.

v2: addressed the review comments.
v3: addressed v2 review comments.
V4: Re-introduced the gem_context_set_all_engines() API,test_process_mixed() test creating new forked process, to set engine map to new forked process I added gem_context_set_all_engines() API.
v5: addressed v4 review comments.
v6: addressed chris comments.

This is totally useless as a recording of the history. Explain why you had to make the changes, for posterity.

Quoted 7 lines
Quoted 7 lines

Review

Quoted 2 lines
(quoted diff) +1 -1
-       __for_each_static_engine(e) {
+       for_each_engine(e, i915) {

Incorrect change that leads to compiler warnings and prevents the legacy tests being listed by CI.

I've given up and fixed it.

Where's your version Chris?

Krish please try the below. Hang subtest fails for me and destroys most of the following subtests but I am not sure what kernel I have deployed where I tested it.

tests/i915/gem_ctx_persistence.c +31 -28
index de6f59251200..2e3f8509a3d7 100644
@@ -758,7 +758,8 @@ static void smoketest(int i915)
 
 igt_main
 {
-       const struct intel_execution_engine2 *e;
+       const struct intel_execution_engine *e;
+       const struct intel_execution_engine2 *e2;
        int i915;
 
        igt_fixture {
@@ -791,68 +792,70 @@ igt_main
        igt_subtest("hang")
                test_nohangcheck_hang(i915);
 
-       for_each_engine(e, i915) {
+       for (e = intel_execution_engines; e->name; e++) {
+               unsigned int flags = eb_ring(e);
+
                igt_subtest_group {
                        igt_fixture {
-                               gem_require_ring(i915, e->flags);
+                               gem_require_ring(i915, flags);
                                gem_require_contexts(i915);
                        }
 
                        igt_subtest_f("legacy-%s-persistence", e->name)
-                               test_persistence(i915, e->flags);
+                               test_persistence(i915, flags);
 
                        igt_subtest_f("legacy-%s-cleanup", e->name)
-                               test_nonpersistent_cleanup(i915, e->flags);
+                               test_nonpersistent_cleanup(i915, flags);
 
                        igt_subtest_f("legacy-%s-queued", e->name)
-                               test_nonpersistent_queued(i915, e->flags);
+                               test_nonpersistent_queued(i915, flags);
 
                        igt_subtest_f("legacy-%s-mixed", e->name)
-                               test_nonpersistent_mixed(i915, e->flags);
+                               test_nonpersistent_mixed(i915, flags);
 
                        igt_subtest_f("legacy-%s-mixed-process", e->name)
-                               test_process_mixed(i915, e->flags);
+                               test_process_mixed(i915, flags);
 
                        igt_subtest_f("legacy-%s-hostile", e->name)
-                               test_nonpersistent_hostile(i915, e->flags);
+                               test_nonpersistent_hostile(i915, flags);
 
                        igt_subtest_f("legacy-%s-hostile-preempt", e->name)
                                test_nonpersistent_hostile_preempt(i915,
-                                                                  e->flags);
+                                                                  flags);
                }
        }
 
-        __for_each_physical_engine(i915, e) {
+        __for_each_physical_engine(i915, e2) {
                 igt_subtest_group {
                         igt_fixture {
-                                gem_require_ring(i915, e->flags);
+                                gem_require_ring(i915, e2->flags);
                                 gem_require_contexts(i915);
                         }
 
-                       igt_subtest_f("%s-persistence", e->name)
-                               test_persistence(i915, e->flags);
+                       igt_subtest_f("%s-persistence", e2->name)
+                               test_persistence(i915, e2->flags);
 
-                       igt_subtest_f("%s-cleanup", e->name)
-                               test_nonpersistent_cleanup(i915, e->flags);
+                       igt_subtest_f("%s-cleanup", e2->name)
+                               test_nonpersistent_cleanup(i915, e2->flags);
 
-                       igt_subtest_f("%s-queued", e->name)
-                               test_nonpersistent_queued(i915, e->flags);
+                       igt_subtest_f("%s-queued", e2->name)
+                               test_nonpersistent_queued(i915, e2->flags);
 
-                       igt_subtest_f("%s-mixed", e->name)
-                               test_nonpersistent_mixed(i915, e->flags);
+                       igt_subtest_f("%s-mixed", e2->name)
+                               test_nonpersistent_mixed(i915, e2->flags);
 
-                       igt_subtest_f("%s-mixed-process", e->name)
-                               test_process_mixed(i915, e->flags);
+                       igt_subtest_f("%s-mixed-process", e2->name)
+                               test_process_mixed(i915, e2->flags);
 
-                       igt_subtest_f("%s-hostile", e->name)
-                               test_nonpersistent_hostile(i915, e->flags);
+                       igt_subtest_f("%s-hostile", e2->name)
+                               test_nonpersistent_hostile(i915, e2->flags);
 
-                       igt_subtest_f("%s-hostile-preempt", e->name)
+                       igt_subtest_f("%s-hostile-preempt", e2->name)
                                test_nonpersistent_hostile_preempt(i915,
-                                                                  e->flags);
+                                                                  e2->flags);
 
-                       igt_subtest_f("%s-hang", e->name)
-                               test_nonpersistent_hang(i915, e->flags);
+                       igt_subtest_f("%s-hang", e2->name)
+                               test_nonpersistent_hang(i915, e2->flags);
                }
        }
 

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

Quoting Tvrtko Ursulin (2020-01-30 10:52:26)

Quoted 23 lines · Tvrtko Ursulin
Quoted 21 lines · Chris Wilson
Quoted 19 lines

Quoting Bommu Krishnaiah (2020-01-29 18:10:02)

Quoted 11 lines

Update the context with supported engines on the platform with set_property I915_CONTEXT_PARAM_ENGINES to make sure the work load is submitted to the available engines only.

v2: addressed the review comments.
v3: addressed v2 review comments.
V4: Re-introduced the gem_context_set_all_engines() API,test_process_mixed() test creating new forked process, to set engine map to new forked process I added gem_context_set_all_engines() API.
v5: addressed v4 review comments.
v6: addressed chris comments.

This is totally useless as a recording of the history. Explain why you had to make the changes, for posterity.

Quoted 2 lines
(quoted diff) +1 -1
-       __for_each_static_engine(e) {
+       for_each_engine(e, i915) {
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

Incorrect change that leads to compiler warnings and prevents the legacy tests being listed by CI.

I've given up and fixed it.

Where's your version Chris?

21f4d0f72c0a3519270712565b2fe688157fc18b
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#6 lore raw
Quoted 22 lines · Chris Wilson

Quoting Tvrtko Ursulin (2020-01-30 10:52:26)

Quoted 21 lines · Tvrtko Ursulin
Quoted 20 lines · Chris Wilson
Quoted 19 lines

Quoting Bommu Krishnaiah (2020-01-29 18:10:02)

Quoted 11 lines

Update the context with supported engines on the platform with set_property I915_CONTEXT_PARAM_ENGINES to make sure the work load is submitted to the available engines only.

v2: addressed the review comments.
v3: addressed v2 review comments.
V4: Re-introduced the gem_context_set_all_engines() API,test_process_mixed() test creating new forked process, to set engine map to new forked process I added gem_context_set_all_engines() API.
v5: addressed v4 review comments.
v6: addressed chris comments.

This is totally useless as a recording of the history. Explain why you had to make the changes, for posterity.

Quoted 2 lines
(quoted diff) +1 -1
-       __for_each_static_engine(e) {
+       for_each_engine(e, i915) {
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

Incorrect change that leads to compiler warnings and prevents the legacy tests being listed by CI.

I've given up and fixed it.

Where's your version Chris?

21f4d0f72c0a3519270712565b2fe688157fc18b

I suggest the below delta to a) not add more dependencies on the static e2 list and b) also cover I915_EXEC_BSD. I'll send a patch if you agree.

tests/i915/gem_ctx_persistence.c +30 -27
index 8b9633b214ff..4d4b735d4936 100644
@@ -759,7 +759,8 @@ static void smoketest(int i915)
 
 igt_main
 {
-       const struct intel_execution_engine2 *e;
+       const struct intel_execution_engine *e;
+       const struct intel_execution_engine2 *e2;
        int i915;
 
        igt_fixture {
@@ -792,66 +793,68 @@ igt_main
        igt_subtest("hang")
                test_nohangcheck_hang(i915);
 
-       __for_each_static_engine(e) {
+       for (e = intel_execution_engines; e->name; e++) {
+               unsigned int flags = eb_ring(e);
+
                igt_subtest_group {
                        igt_fixture {
-                               gem_require_ring(i915, e->flags);
+                               gem_require_ring(i915, flags);
                                gem_require_contexts(i915);
                        }
 
                        igt_subtest_f("legacy-%s-persistence", e->name)
-                               test_persistence(i915, e->flags);
+                               test_persistence(i915, flags);
 
                        igt_subtest_f("legacy-%s-cleanup", e->name)
-                               test_nonpersistent_cleanup(i915, e->flags);
+                               test_nonpersistent_cleanup(i915, flags);
 
                        igt_subtest_f("legacy-%s-queued", e->name)
-                               test_nonpersistent_queued(i915, e->flags);
+                               test_nonpersistent_queued(i915, flags);
 
                        igt_subtest_f("legacy-%s-mixed", e->name)
-                               test_nonpersistent_mixed(i915, e->flags);
+                               test_nonpersistent_mixed(i915, flags);
 
                        igt_subtest_f("legacy-%s-mixed-process", e->name)
-                               test_process_mixed(i915, e->flags);
+                               test_process_mixed(i915, flags);
 
                        igt_subtest_f("legacy-%s-hostile", e->name)
-                               test_nonpersistent_hostile(i915, e->flags);
+                               test_nonpersistent_hostile(i915, flags);
 
                        igt_subtest_f("legacy-%s-hostile-preempt", e->name)
                                test_nonpersistent_hostile_preempt(i915,
-                                                                  e->flags);
+                                                                  flags);
                }
        }
 
-        __for_each_physical_engine(i915, e) {
+        __for_each_physical_engine(i915, e2) {
                 igt_subtest_group {
                         igt_fixture
                                 gem_require_contexts(i915);
 
-                       igt_subtest_f("%s-persistence", e->name)
-                               test_persistence(i915, e->flags);
+                       igt_subtest_f("%s-persistence", e2->name)
+                               test_persistence(i915, e2->flags);
 
-                       igt_subtest_f("%s-cleanup", e->name)
-                               test_nonpersistent_cleanup(i915, e->flags);
+                       igt_subtest_f("%s-cleanup", e2->name)
+                               test_nonpersistent_cleanup(i915, e2->flags);
 
-                       igt_subtest_f("%s-queued", e->name)
-                               test_nonpersistent_queued(i915, e->flags);
+                       igt_subtest_f("%s-queued", e2->name)
+                               test_nonpersistent_queued(i915, e2->flags);
 
-                       igt_subtest_f("%s-mixed", e->name)
-                               test_nonpersistent_mixed(i915, e->flags);
+                       igt_subtest_f("%s-mixed", e2->name)
+                               test_nonpersistent_mixed(i915, e2->flags);
 
-                       igt_subtest_f("%s-mixed-process", e->name)
-                               test_process_mixed(i915, e->flags);
+                       igt_subtest_f("%s-mixed-process", e2->name)
+                               test_process_mixed(i915, e2->flags);
 
-                       igt_subtest_f("%s-hostile", e->name)
-                               test_nonpersistent_hostile(i915, e->flags);
+                       igt_subtest_f("%s-hostile", e2->name)
+                               test_nonpersistent_hostile(i915, e2->flags);
 
-                       igt_subtest_f("%s-hostile-preempt", e->name)
+                       igt_subtest_f("%s-hostile-preempt", e2->name)
                                test_nonpersistent_hostile_preempt(i915,
-                                                                  e->flags);
+                                                                  e2->flags);
 
-                       igt_subtest_f("%s-hang", e->name)
-                               test_nonpersistent_hang(i915, e->flags);
+                       igt_subtest_f("%s-hang", e2->name)
+                               test_nonpersistent_hang(i915, e2->flags);
                }
        }
 

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#7 lore raw

Quoting Tvrtko Ursulin (2020-01-30 11:08:47)

Quoted 50 lines · Chris Wilson
Quoted 22 lines

Quoting Tvrtko Ursulin (2020-01-30 10:52:26)

Quoted 21 lines · Tvrtko Ursulin
Quoted 20 lines · Chris Wilson
Quoted 19 lines

Quoting Bommu Krishnaiah (2020-01-29 18:10:02)

Quoted 11 lines

Update the context with supported engines on the platform with set_property I915_CONTEXT_PARAM_ENGINES to make sure the work load is submitted to the available engines only.

v2: addressed the review comments.
v3: addressed v2 review comments.
V4: Re-introduced the gem_context_set_all_engines() API,test_process_mixed() test creating new forked process, to set engine map to new forked process I added gem_context_set_all_engines() API.
v5: addressed v4 review comments.
v6: addressed chris comments.

This is totally useless as a recording of the history. Explain why you had to make the changes, for posterity.

Quoted 2 lines
(quoted diff) +1 -1
-       __for_each_static_engine(e) {
+       for_each_engine(e, i915) {
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

Incorrect change that leads to compiler warnings and prevents the legacy tests being listed by CI.

I've given up and fixed it.

Where's your version Chris?

21f4d0f72c0a3519270712565b2fe688157fc18b

I suggest the below delta to a) not add more dependencies on the static e2 list and b) also cover I915_EXEC_BSD. I'll send a patch if you agree.

tests/i915/gem_ctx_persistence.c +2 -1
index 8b9633b214ff..4d4b735d4936 100644
@@ -759,7 +759,8 @@ static void smoketest(int i915)
 
 igt_main
 {
-       const struct intel_execution_engine2 *e;
+       const struct intel_execution_engine *e;
+       const struct intel_execution_engine2 *e2;
        int i915;
 
        igt_fixture {

tests/i915/gem_ctx_persistence.c igt_main · line 796

Quoted 5 lines
tests/i915/gem_ctx_persistence.c +1 -1
@@ -792,66 +793,68 @@ igt_main
        igt_subtest("hang")
                test_nohangcheck_hang(i915);
 
-       __for_each_static_engine(e) {
+       for (e = intel_execution_engines; e->name; e++) {

I don't mind too much, I just expected the __for_each_static_engine() to save on typing. But yeah, eb_ring().

But much yuck on e and e2. Can we move them to separate functions to hide the eyesore?
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#8 lore raw
Quoted 54 lines · Chris Wilson

Quoting Tvrtko Ursulin (2020-01-30 11:08:47)

Quoted 53 lines · Chris Wilson
Quoted 22 lines

Quoting Tvrtko Ursulin (2020-01-30 10:52:26)

Quoted 21 lines · Tvrtko Ursulin
Quoted 20 lines · Chris Wilson
Quoted 19 lines

Quoting Bommu Krishnaiah (2020-01-29 18:10:02)

Quoted 11 lines

Update the context with supported engines on the platform with set_property I915_CONTEXT_PARAM_ENGINES to make sure the work load is submitted to the available engines only.

v2: addressed the review comments.
v3: addressed v2 review comments.
V4: Re-introduced the gem_context_set_all_engines() API,test_process_mixed() test creating new forked process, to set engine map to new forked process I added gem_context_set_all_engines() API.
v5: addressed v4 review comments.
v6: addressed chris comments.

This is totally useless as a recording of the history. Explain why you had to make the changes, for posterity.

Quoted 2 lines
(quoted diff) +1 -1
-       __for_each_static_engine(e) {
+       for_each_engine(e, i915) {
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

Incorrect change that leads to compiler warnings and prevents the legacy tests being listed by CI.

I've given up and fixed it.

Where's your version Chris?

21f4d0f72c0a3519270712565b2fe688157fc18b

I suggest the below delta to a) not add more dependencies on the static e2 list and b) also cover I915_EXEC_BSD. I'll send a patch if you agree.

tests/i915/gem_ctx_persistence.c +2 -1
index 8b9633b214ff..4d4b735d4936 100644
@@ -759,7 +759,8 @@ static void smoketest(int i915)
 
  igt_main
  {
-       const struct intel_execution_engine2 *e;
+       const struct intel_execution_engine *e;
+       const struct intel_execution_engine2 *e2;
         int i915;
 
         igt_fixture {
@@ -792,66 +793,68 @@ igt_main
         igt_subtest("hang")
                 test_nohangcheck_hang(i915);
 
Quoted 5 lines

tests/i915/gem_ctx_persistence.c igt_main · line 796

Quoted 2 lines
tests/i915/gem_ctx_persistence.c +1 -1
-       __for_each_static_engine(e) {
+       for (e = intel_execution_engines; e->name; e++) {

I don't mind too much, I just expected the __for_each_static_engine() to save on typing. But yeah, eb_ring().

__for_each_static_engine is the one which we are >.< this close eliminating after dynamic subtests and "i915/gem_engine_topology: Generate engine names based on class" but more importantly my vision of splitting legacy eb.flags and physical engine testing was that they are completely separate.

Sequence of steps along the lines of:

delete __for_each_static_engine

for_each_physical_engine -> __for_each_physical_engine and required test adaptations

delete for_each_physical_engine

rename __for_each_pyhsical_engine into for_each_physical_engine

(optional) rename for_each_engine into for_each_engine_flag (give or take)

(optional) add convenience macro to iterate legacy eb flags statically (alternative) convert those into dynamic subtests and use for_each_engine_flags

Quoted 2 lines

But much yuck on e and e2. Can we move them to separate functions to hide the eyesore?

Move to functions, how?

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#10 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_ctx_persistence: Set context with supported engines (rev7)

In reply to Bommu Krishnaiah
== Series Details ==

== Series Details ==

Series: tests/i915/gem_ctx_persistence: Set context with supported engines (rev7)
URL : https://patchwork.freedesktop.org/series/71810/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7838 -> IGTPW_4032
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4032:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_module_load@reload-with-fault-injection:
- {fi-ehl-1}: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-ehl-1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-ehl-1/igt@[email protected]

* igt@runner@aborted:
- {fi-ehl-1}: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-ehl-1/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4032 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [PASS][4] -> [FAIL][5] ([CI#94])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-tgl-y/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-tgl-y/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][6] -> [FAIL][7] ([i915#178])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-skl-6770hq/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-skl-6770hq/igt@[email protected]

* igt@i915_selftest@live_execlists:
- fi-icl-u2: [PASS][8] -> [INCOMPLETE][9] ([i915#140])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-icl-u2/igt@i915_selftest@live_execlists.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-icl-u2/igt@i915_selftest@live_execlists.html
- fi-icl-dsi: [PASS][10] -> [INCOMPLETE][11] ([i915#140])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-icl-dsi/igt@i915_selftest@live_execlists.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-icl-dsi/igt@i915_selftest@live_execlists.html

* igt@prime_self_import@basic-llseek-bad:
- fi-tgl-y: [PASS][12] -> [DMESG-WARN][13] ([CI#94] / [i915#402]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-tgl-y/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-tgl-y/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][14] ([i915#553] / [i915#725]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-hsw-4770/igt@i915_selftest@live_blt.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-hsw-4770/igt@i915_selftest@live_blt.html
- fi-hsw-4770r: [DMESG-FAIL][16] ([i915#725]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-hsw-4770r/igt@i915_selftest@live_blt.html

* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8700k: [INCOMPLETE][18] ([i915#424]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html

* igt@i915_selftest@live_gtt:
- fi-bdw-5557u: [TIMEOUT][20] ([fdo#112271]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-bdw-5557u/igt@i915_selftest@live_gtt.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-bdw-5557u/igt@i915_selftest@live_gtt.html

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-icl-dsi: [DMESG-WARN][22] ([i915#109]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-icl-dsi/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-icl-dsi/igt@[email protected]

* igt@prime_self_import@basic-llseek-size:
- fi-tgl-y: [DMESG-WARN][24] ([CI#94] / [i915#402]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-tgl-y/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-tgl-y/igt@[email protected]

#### Warnings ####

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][26] ([fdo#111096] / [i915#323]) -> [FAIL][27] ([fdo#111407])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/fi-kbl-7500u/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/fi-kbl-7500u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#998]: https://gitlab.freedesktop.org/drm/intel/issues/998

Participating hosts (50 -> 48)
------------------------------

Additional (2): fi-byt-n2820 fi-bwr-2160
Missing (4): fi-ilk-m540 fi-byt-clapper fi-bdw-samus fi-hsw-4200u

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5404 -> IGTPW_4032

CI-20190529: 20190529
CI_DRM_7838: d3d96beea538c8de906a1c4d7e6793a47d17a471 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4032: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/index.html
IGT_5404: 4147bab8e3dcaf11bd657b5fb4c109708e94e60c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#11 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/i915/gem_ctx_persistence: Set context with supported engines (rev7)

In reply to Bommu Krishnaiah
== Series Details ==

== Series Details ==

Series: tests/i915/gem_ctx_persistence: Set context with supported engines (rev7)
URL : https://patchwork.freedesktop.org/series/71810/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7838_full -> IGTPW_4032_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4032_full:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@gem_ctx_persistence@vcs2-hang}:
- shard-iclb: [SKIP][1] ([fdo#109276]) -> [SKIP][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb4/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4032_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_balancer@hang:
- shard-tglb: [PASS][3] -> [TIMEOUT][4] ([fdo#112271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-tglb3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-tglb6/igt@[email protected]

* igt@gem_exec_schedule@pi-common-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([i915#677])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb5/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb1/igt@[email protected]

* igt@gem_exec_schedule@pi-shared-iova-bsd2:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +14 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb3/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb5/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb4/igt@[email protected]

* igt@i915_selftest@live_blt:
- shard-hsw: [PASS][11] -> [DMESG-FAIL][12] ([i915#725])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-hsw1/igt@i915_selftest@live_blt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-hsw8/igt@i915_selftest@live_blt.html

* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-hsw: [PASS][13] -> [FAIL][14] ([i915#57])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-hsw6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-hsw8/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [PASS][15] -> [INCOMPLETE][16] ([i915#61])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-hsw2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-hsw8/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-tglb: [PASS][17] -> [SKIP][18] ([i915#668])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-tglb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite.html

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-apl8/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-apl4/igt@[email protected]

* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-kbl: [PASS][21] -> [FAIL][22] ([i915#247])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-kbl1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-kbl1/igt@[email protected]
- shard-apl: [PASS][23] -> [FAIL][24] ([i915#247])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-apl2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-apl1/igt@[email protected]

* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][25] -> [FAIL][26] ([i915#173])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb4/igt@kms_psr@no_drrs.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb1/igt@kms_psr@no_drrs.html

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][29] -> [FAIL][30] ([i915#31])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-apl1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-apl1/igt@[email protected]

* igt@perf_pmu@busy-accuracy-2-vcs1:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#112080]) +11 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb8/igt@[email protected]

* igt@prime_mmap_coherency@ioctl-errors:
- shard-hsw: [PASS][33] -> [FAIL][34] ([i915#831])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-hsw2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-hsw6/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [SKIP][35] ([fdo#109276] / [fdo#112080]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb2/igt@[email protected]

* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][37] ([fdo#110841]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb7/igt@[email protected]

* igt@gem_exec_balancer@hang:
- shard-iclb: [TIMEOUT][39] ([fdo#112271]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb5/igt@[email protected]

* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][41] ([fdo#112146]) -> [PASS][42] +9 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb6/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-hsw: [FAIL][43] ([i915#694]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-hsw5/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-hsw2/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-hsw: [FAIL][45] ([i915#520]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-hsw6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-hsw2/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [FAIL][47] ([i915#644]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-glk4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-glk1/igt@[email protected]
- shard-kbl: [FAIL][49] ([i915#644]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-kbl3/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-kbl7/igt@[email protected]

* igt@gem_tiled_blits@normal:
- shard-hsw: [FAIL][51] ([i915#818]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-hsw5/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-hsw4/igt@[email protected]

* igt@i915_hangman@error-state-capture-vcs1:
- shard-iclb: [SKIP][53] ([fdo#112080]) -> [PASS][54] +8 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb8/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb4/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][55] ([i915#180]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-apl6/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-apl2/igt@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-hsw: [DMESG-WARN][57] ([i915#44]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-hsw5/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-hsw2/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][59] ([i915#180]) -> [PASS][60] +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-kbl7/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-kbl7/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-iclb: [TIMEOUT][61] -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb8/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb7/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][63] ([fdo#109642] / [fdo#111068]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb6/igt@kms_psr2_su@page_flip.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb2/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb5/igt@kms_psr@psr2_primary_blt.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb2/igt@kms_psr@psr2_primary_blt.html

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][67] ([fdo#109276]) -> [PASS][68] +10 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb7/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb1/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [FAIL][69] ([IGT#28]) -> [SKIP][70] ([fdo#112080])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb4/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb7/igt@[email protected]

* igt@gem_ctx_persistence@vcs2-mixed:
- shard-iclb: [SKIP][71] ([fdo#109276] / [fdo#112080]) -> [SKIP][72] ([fdo#112080]) +10 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-iclb7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-iclb4/igt@[email protected]

* igt@gem_eio@in-flight-1us:
- shard-apl: [TIMEOUT][73] ([fdo#112271]) -> [INCOMPLETE][74] ([CI#80] / [fdo#103927])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-apl6/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-apl3/igt@[email protected]

* igt@gem_tiled_blits@interruptible:
- shard-hsw: [FAIL][75] ([i915#694]) -> [FAIL][76] ([i915#818])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7838/shard-hsw1/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/shard-hsw2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#247]: https://gitlab.freedesktop.org/drm/intel/issues/247
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44
[i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
[i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
[i915#831]: https://gitlab.freedesktop.org/drm/intel/issues/831

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5404 -> IGTPW_4032
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_7838: d3d96beea538c8de906a1c4d7e6793a47d17a471 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4032: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/index.html
IGT_5404: 4147bab8e3dcaf11bd657b5fb4c109708e94e60c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4032/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev