ext4: skip concurrent inode updates in lazytime optimization
Subsystems (2)
RFC PATCH 1/1 ext4: skip concurrent inode updates in lazytime optimization
Function ext4_update_other_inodes_time() implements optimization which opportunistically updates times for inodes within same inode table block.
For now concurrent inode lookup by number does not scale well because
inode hash table is protected with single spinlock. It could become very hot at concurrent writes to fast nvme when inode cache has enough inodes.
Probably someday inode hash will become searchable under RCU. (see linked patchset by David Howells)
Let's skip concurrent updates instead of wasting cpu time at spinlock.
--- fs/ext4/inode.c | 7 +++++++ 1 file changed, 7 insertions(+)
fs/ext4/inode.c +7 -0
@@ -4849,11 +4849,16 @@ static int other_inode_match(struct inode * inode, unsigned long ino,static void ext4_update_other_inodes_time (struct super_block *sb,unsigned long orig_ino,char *buf) { +static DEFINE_SPINLOCK (lock);struct other_inode oi;unsigned long ino;int i, inodes_per_block =EXT4_SB (sb)->s_inodes_per_block;int inode_size =EXT4_INODE_SIZE (sb); +/* Don't bother inode_hash_lock with concurrent updates. */ +if (!spin_trylock (&lock)) +return ; + oi.orig_ino = orig_ino;/* * Calculate the first inode in the inode table block. Inode
@@ -4867,6 +4872,8 @@ static void ext4_update_other_inodes_time(struct super_block *sb, oi.raw_inode = (struct ext4_inode *) buf; (void )find_inode_nowait (sb, ino, other_inode_match, &oi); } + +spin_unlock (&lock); }/*
Quoted 4 lines · Konstantin Khlebnikov
Function
ext4_update_other_inodes_time()implements optimization which opportunistically updates times for inodes within same inode table block.
Quoted 8 lines
For now concurrent inode lookup by number does not scale well because
inode hash table is protected with single spinlock. It could become very hot at concurrent writes to fast nvme when inode cache has enough inodes.Probably someday inode hash will become searchable under RCU. (see linked patchset by David Howells)
Let's skip concurrent updates instead of wasting cpu time at spinlock.
Do you have any benchmark numbers to confirm that this is an improvement? The performance results should be included here in the commit message, so that the patch reviewers can make a useful decision about the patch, and in the future if this patch is shown to be a regression for some other workload we can see what workload(s) it originally improved performance on.
Cheers, Andreas
Quoted 30 lines
Signed-off-by Konstantin Khlebnikov <[email protected]>---
fs/ext4/inode.c| 7 +++++++1 file changed, 7 insertions(+)fs/ext4/inode.c +5
-0@@ -4849,11 +4849,16 @@ static int other_inode_match(struct inode * inode, unsigned long ino,static void ext4_update_other_inodes_time (struct super_block *sb,unsigned long orig_ino,char *buf) { +static DEFINE_SPINLOCK (lock);struct other_inode oi;unsigned long ino;int i, inodes_per_block =EXT4_SB (sb)->s_inodes_per_block;int inode_size =EXT4_INODE_SIZE (sb); +/* Don't bother inode_hash_lock with concurrent updates. */ +if (!spin_trylock (&lock)) +return ; + oi.orig_ino = orig_ino;/* * Calculate the first inode in the inode table block. Inode
fs/ext4/inode.c static void ext4_update_other_inodes_time(struct super_block *sb, · line 4879
Quoted 8 lines
fs/ext4/inode.c +2
-0@@ -4867,6 +4872,8 @@ static void ext4_update_other_inodes_time(struct super_block *sb, oi.raw_inode = (struct ext4_inode *) buf; (void )find_inode_nowait (sb, ino, other_inode_match, &oi); } + +spin_unlock (&lock); }/*
Cheers, Andreas
Theodore Y. Ts'o
maintainerQuoted 7 lines · Konstantin Khlebnikov
Function
ext4_update_other_inodes_time()implements optimization which opportunistically updates times for inodes within same inode table block.For now concurrent inode lookup by number does not scale well because
inode hash table is protected with single spinlock. It could become very hot at concurrent writes to fast nvme when inode cache has enough inodes.
Quoted 7 lines
Probably someday inode hash will become searchable under RCU. (see linked patchset by David Howells)
Let's skip concurrent updates instead of wasting cpu time at spinlock.
Hmm.... I wonder what Al thinks of adding a varaint of find_inode_nowait() which uses tries to grab the inode_hash_lock() using a trylock, and returns ERR_PTR(-EAGAIN) if the attempt to grab the lock fails.
This might be better since it will prevent other conflicts between ext4_update_other_inodes_time() and other attempts to lookup inodes which can't be skipped if things are busy.
- Ted