Skip to contentSkip to conversation

-Wfortify-source in kernel/printk/printk.c

DISCUSSION Nathan Chancellor 3 participants 4 messages Jan 30, 2020

lore
Share & tools
lore
#0 lore raw

Hi all,

After commit 6d485ff455e ("Improve static checks for sprintf and __builtin___sprintf_chk") in clang [1], the following warning appears when CONFIG_PRINTK is disabled (e.g. allnoconfig):

../kernel/printk/printk.c:2416:10: warning: 'sprintf' will always overflow; destination buffer has size 0, but format string expands to at least 33 [-Wfortify-source]
len = sprintf(text,
^
1 warning generated.

Specifically referring to
https://elixir.bootlin.com/linux/v5.5/source/kernel/printk/printk.c#L2416.

It isn't wrong, given that when CONFIG_PRINTK is disabled, text's length is 0 (LOG_LINE_MAX and PREFIX_MAX are both zero). How should this warning be dealt this? I am not familiar enough with the printk code to say myself.

[1]: https://github.com/llvm/llvm-project/commit/6d485ff455ea2b37fef9e06e426dae6c1241b231

Cheers,
Nathan

#1 lore raw
Quoted 13 lines · Nathan Chancellor

Hi all,

After commit 6d485ff455e ("Improve static checks for sprintf and __builtin___sprintf_chk") in clang [1], the following warning appears when CONFIG_PRINTK is disabled (e.g. allnoconfig):

../kernel/printk/printk.c:2416:10: warning: 'sprintf' will always overflow; destination buffer has size 0, but format string expands to at least 33 [-Wfortify-source]
len = sprintf(text,
^
1 warning generated.

Quoted 2 lines

Specifically referring to
https://elixir.bootlin.com/linux/v5.5/source/kernel/printk/printk.c#L2416.

Good catch.

Quoted 4 lines

It isn't wrong, given that when CONFIG_PRINTK is disabled, text's length is 0 (LOG_LINE_MAX and PREFIX_MAX are both zero). How should this warning be dealt this? I am not familiar enough with the printk code to say myself.

It's not wrong.

Unless I'm missing something completely obvious: with disabled printk() we don't have any functions that can append messages to the logbuf, hence we can't overflow it. So the error in question should never trigger.

- Normal printk() is void, so kernel cannot append messages;
- dev_printk() is void, so drivers cannot append messages and dicts;
- devkmsg_write() is void, so user space cannot write to logbuf.

So I think we should never trigger that overflow (assuming that I didn't miss something) message.

In any case feel free to submit a patch - switch it to snprintf().

	-ss
#2 lore raw
Quoted 30 lines · Sergey Senozhatsky
Quoted 13 lines · Nathan Chancellor

Hi all,

After commit 6d485ff455e ("Improve static checks for sprintf and __builtin___sprintf_chk") in clang [1], the following warning appears when CONFIG_PRINTK is disabled (e.g. allnoconfig):

../kernel/printk/printk.c:2416:10: warning: 'sprintf' will always overflow; destination buffer has size 0, but format string expands to at least 33 [-Wfortify-source]
len = sprintf(text,
^
1 warning generated.

Quoted 2 lines

Specifically referring to
https://elixir.bootlin.com/linux/v5.5/source/kernel/printk/printk.c#L2416.

Good catch.

Quoted 4 lines

It isn't wrong, given that when CONFIG_PRINTK is disabled, text's length is 0 (LOG_LINE_MAX and PREFIX_MAX are both zero). How should this warning be dealt this? I am not familiar enough with the printk code to say myself.

It's not wrong.

Unless I'm missing something completely obvious: with disabled printk() we don't have any functions that can append messages to the logbuf, hence we can't overflow it. So the error in question should never trigger.

Quoted 8 lines

- Normal printk() is void, so kernel cannot append messages;
- dev_printk() is void, so drivers cannot append messages and dicts;
- devkmsg_write() is void, so user space cannot write to logbuf.

So I think we should never trigger that overflow (assuming that I didn't miss something) message.

In any case feel free to submit a patch - switch it to snprintf().

and/or make the code depend on CONFIG_PRINTK

#3 lore raw
Quoted 15 lines · Joe Perches
Quoted 15 lines
Quoted 4 lines

It isn't wrong, given that when CONFIG_PRINTK is disabled, text's length is 0 (LOG_LINE_MAX and PREFIX_MAX are both zero). How should this warning be dealt this? I am not familiar enough with the printk code to say myself.

It's not wrong.

Unless I'm missing something completely obvious: with disabled printk() we don't have any functions that can append messages to the logbuf, hence we can't overflow it. So the error in question should never trigger.

- Normal printk() is void, so kernel cannot append messages;
- dev_printk() is void, so drivers cannot append messages and dicts;
- devkmsg_write() is void, so user space cannot write to logbuf.

Quoted 6 lines
Quoted 4 lines

So I think we should never trigger that overflow (assuming that I didn't miss something) message.

In any case feel free to submit a patch - switch it to snprintf().

and/or make the code depend on CONFIG_PRINTK

console_unlock() still needs to at least up() the console semaphore. We don't have printk(), but the tty subsystem is still there and serial consoles and definitely still up and running. So... maybe we can have two versions of console_unlock().

	-ss