configs: rpi: Set phy auto negotiation
PATCH 1/1 configs: rpi: Set phy auto negotiation
From: Matthias Brugger <[email protected]>
Lower timeout for PHY auto negotiation as otherwise we have to wait for far too long.
---
include/configs/rpi.h | 8 ++++++++ 1 file changed, 8 insertions(+)
include/configs/rpi.h +8 -0
@@ -74,6 +74,14 @@#define CONFIG_TFTP_TSIZE #endif +/* +* RPi4 genet uses the generic phy support, set the +* timeout for auto-negotiation of the PHY in 50 ms units +*/ +#ifdef PHYLIB +#define PHY_ANEG_TIMEOUT 20 +#endif +/* Console configuration */ #define CONFIG_SYS_CBSIZE 1024
Signature · 1 line
2.24.1
PATCH 1/1 configs: rpi: Set phy auto negotiation
On Thu, 30 Jan 2020 10:15:26 +0100
matthias.bgg at kernel.org wrote:
Hi,
Quoted 4 lines
From: Matthias Brugger <[email protected]>
Lower timeout for PHY auto negotiation as otherwise we have to wait for far too long.
Good observation, but isn't this more properly solved by this?
https://lists.denx.de/pipermail/u-boot/2020-January/395151.html
Joe, can we please merge this ^^^ patch of mine, if there are no objections? Stefan already reviewed it (thanks for that!)
Cheers,
Andre
Quoted 26 lines
Signed-off-by Matthias Brugger <[email protected]>---
include/configs/rpi.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/configs/rpi.h +8
-0@@ -74,6 +74,14 @@#define CONFIG_TFTP_TSIZE #endif +/* +* RPi4 genet uses the generic phy support, set the +* timeout for auto-negotiation of the PHY in 50 ms units +*/ +#ifdef PHYLIB +#define PHY_ANEG_TIMEOUT 20 +#endif +/* Console configuration */ #define CONFIG_SYS_CBSIZE 1024
PATCH 1/1 configs: rpi: Set phy auto negotiation
Quoted 7 lines · Andre Przywara
On Thu, 30 Jan 2020 10:15:26 +0100
matthias.bgg at kernel.org wrote:Hi,
Quoted 2 lines
From: Matthias Brugger <[email protected]>
Quoted 9 lines
Quoted 2 lines
Lower timeout for PHY auto negotiation as otherwise we have to wait for far too long.
Good observation, but isn't this more properly solved by this?
https://lists.denx.de/pipermail/u-boot/2020-January/395151.htmlJoe, can we please merge this ^^^ patch of mine, if there are no objections? Stefan already reviewed it (thanks for that!)
I was looking into that and my mid-term goal was to get PHY_ANEG_TIMEOUT into Kconfig. I stumbled over that yesterday as well, but didn't do the investigation to see if this was broken by some recent commit.
So, yes you are right, that's the correct fix.
Regards,
Matthias
Quoted 30 lines
Cheers,
AndreQuoted 26 lines
Signed-off-by Matthias Brugger <[email protected]>---
include/configs/rpi.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/configs/rpi.h +8
-0@@ -74,6 +74,14 @@#define CONFIG_TFTP_TSIZE #endif +/* +* RPi4 genet uses the generic phy support, set the +* timeout for auto-negotiation of the PHY in 50 ms units +*/ +#ifdef PHYLIB +#define PHY_ANEG_TIMEOUT 20 +#endif +/* Console configuration */ #define CONFIG_SYS_CBSIZE 1024