Skip to contentSkip to conversation

rbd: remove barriers from img_request_layered_{set,clear,test}()

PATCH New Ilya Dryomov 1 participant 1 message Jan 30, 2020

Subsystems (2)
lore
Share & tools
lore

Ilya Dryomov

author maintainer
#0 lore raw

PATCH 1/1 rbd: remove barriers from img_request_layered_{set,clear,test}()

IMG_REQ_LAYERED is set in rbd_img_request_create(), and tested and cleared in rbd_img_request_destroy() when the image request is about to be destroyed. The barriers are unnecessary.

---
 drivers/block/rbd.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/block/rbd.c +0 -3
index f21f9bc8d74a..4e494d5600cc 100644
@@ -1371,18 +1371,15 @@ static void rbd_osd_submit(struct ceph_osd_request *osd_req)
 static void img_request_layered_set(struct rbd_img_request *img_request)
 {
 	set_bit(IMG_REQ_LAYERED, &img_request->flags);
-	smp_mb();
 }
 
 static void img_request_layered_clear(struct rbd_img_request *img_request)
 {
 	clear_bit(IMG_REQ_LAYERED, &img_request->flags);
-	smp_mb();
 }
 
 static bool img_request_layered_test(struct rbd_img_request *img_request)
 {
-	smp_mb();
 	return test_bit(IMG_REQ_LAYERED, &img_request->flags) != 0;
 }
 
Signature · 1 line
2.19.2