Skip to contentSkip to conversation

netfilter: nf_flowtable: fix documentation

PATCH Applied Matteo Croce 3 participants 4 messages Jan 30, 2020 – Jan 31, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfilter: nf_flowtable: fix documentation

In the flowtable documentation there is a missing semicolon, the command as is would give this error:

    nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
                    hook ingress priority 0 devices = { br0, pppoe-data };
                                            ^^^^^^^
    nftables.conf:4:12-13: Error: invalid hook (null)
            flowtable ft {
                      ^^
Fixes 19b351f16fd9 ("netfilter: add flowtable documentation")
---
 Documentation/networking/nf_flowtable.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/networking/nf_flowtable.txt +1 -1
index ca2136c76042..0bf32d1121be 100644
@@ -76,7 +76,7 @@ flowtable and add one rule to your forward chain.
 
         table inet x {
 		flowtable f {
-			hook ingress priority 0 devices = { eth0, eth1 };
+			hook ingress priority 0; devices = { eth0, eth1 };
 		}
                 chain y {
                         type filter hook forward priority 0; policy accept;
Signature · 1 line
2.24.1
maintainer
#1 lore raw
Quoted 10 lines · Matteo Croce

In the flowtable documentation there is a missing semicolon, the command as is would give this error:

    nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
                    hook ingress priority 0 devices = { br0, pppoe-data };
                                            ^^^^^^^
    nftables.conf:4:12-13: Error: invalid hook (null)
            flowtable ft {
                      ^^
Quoted 2 lines
Fixes 19b351f16fd9 ("netfilter: add flowtable documentation")

This is netfilter so even though it's tagged as net, I'm expecting Pablo (or Jon) to take it. Please LMK if I'm wrong.

#2 lore raw
Quoted 12 lines · Jakub Kicinski
Quoted 10 lines · Matteo Croce

In the flowtable documentation there is a missing semicolon, the command as is would give this error:

    nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
                    hook ingress priority 0 devices = { br0, pppoe-data };
                                            ^^^^^^^
    nftables.conf:4:12-13: Error: invalid hook (null)
            flowtable ft {
                      ^^
Quoted 6 lines
Quoted 2 lines
Fixes 19b351f16fd9 ("netfilter: add flowtable documentation")

This is netfilter so even though it's tagged as net, I'm expecting Pablo (or Jon) to take it. Please LMK if I'm wrong.

You're right.
As get_maintainers.pl didn't list [email protected] I missed it.

Signature · 2 lines
Matteo Croce
per aspera ad upstream
maintainer Applied
#3 lore raw
In reply to Matteo Croce
Quoted 9 lines · Matteo Croce

In the flowtable documentation there is a missing semicolon, the command as is would give this error:

    nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
                    hook ingress priority 0 devices = { br0, pppoe-data };
                                            ^^^^^^^
    nftables.conf:4:12-13: Error: invalid hook (null)
            flowtable ft {
                      ^^

Applied, thanks.