Skip to contentSkip to conversation

Handling mmap_gtt

PATCH In review Ramalingam C 5 participants 33 messages Jan 31, 2020 – Feb 9, 2020

lore
Share & tools
lore
#0 lore raw

cover Handling mmap_gtt

When platform doesn't support mappable aperture, we use device coherent mapping instead of mmap_gtt.

And in such scenarios we are skipping the tiling based tests and fence related tests along with GTT mmap specific tests.

Ramalingam C (9):
tests/prime_vgem: Skip fence and gtt specific tests tests/intel_dp_compliance: Skip tests as tiling is not supported tests/prime_mmap_coherency: use device coherent mapping instead of
mmap_gtt
tests/prime_mmap: use device coherent mapping instead of mmap_gtt tests/kms_psr: Skip tests on mmap_gtt, if no mappable aperture tests/kms_available_modes_crc: Skip test if mappable aperture not
supported
tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt tests/i915_suspend: skip fence related tests, if no mmap_gtt tests/gem_tiling_max_stride: Skip if set tiling is not supported

 tests/i915/gem_tiling_max_stride.c |  1 +
 tests/i915/i915_pm_rpm.c           | 24 +++++++++++++++---------
 tests/i915/i915_suspend.c          | 16 ++++++++++++----
 tests/kms_available_modes_crc.c    |  1 +
 tests/kms_psr.c                    |  1 +
 tests/prime_mmap.c                 |  4 ++--
 tests/prime_mmap_coherency.c       |  2 +-
 tests/prime_vgem.c                 | 12 +++++++++---
 tools/intel_dp_compliance.c        |  2 ++
 9 files changed, 44 insertions(+), 19 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH 1/9 tests/prime_vgem: Skip fence and gtt specific tests

In the absence of the mappable aperture, skip GTT and fence specific tests.

v2:
requirement check is moved to subtest start [Zbigniew]

---
 tests/prime_vgem.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
tests/prime_vgem.c +9 -3
index 3bdb23007d56..c483cbe722ea 100644
@@ -846,14 +846,18 @@ igt_main
 	igt_subtest("basic-write")
 		test_write(vgem, i915);
 
-	igt_subtest("basic-gtt")
+	igt_subtest("basic-gtt") {
+		gem_require_mappable_ggtt(i915);
 		test_gtt(vgem, i915);
+	}
 
 	igt_subtest("shrink")
 		test_shrink(vgem, i915);
 
-	igt_subtest("coherency-gtt")
+	igt_subtest("coherency-gtt") {
+		gem_require_mappable_ggtt(i915);
 		test_gtt_interleaved(vgem, i915);
+	}
 
 	for (e = intel_execution_engines; e->name; e++) {
 		igt_subtest_f("%ssync-%s",
@@ -902,8 +906,10 @@ igt_main
 
 		igt_subtest("basic-fence-read")
 			test_fence_read(i915, vgem);
-		igt_subtest("basic-fence-mmap")
+		igt_subtest("basic-fence-mmap") {
+			gem_require_mappable_ggtt(i915);
 			test_fence_mmap(i915, vgem);
+		}
 
 		for (e = intel_execution_engines; e->name; e++) {
 			igt_subtest_f("%sfence-wait-%s",
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#2 lore raw

Re: [igt-dev] [PATCH i-g-t 1/9] tests/prime_vgem: Skip fence and gtt specific tests

Quoted 17 lines · Ramalingam C

In the absence of the mappable aperture, skip GTT and fence specific tests.

v2:
requirement check is moved to subtest start [Zbigniew]

---
 tests/prime_vgem.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
tests/prime_vgem.c +0 -0
index 3bdb23007d56..c483cbe722ea 100644

tests/prime_vgem.c igt_main · line 852

Quoted 8 lines
tests/prime_vgem.c +3 -1
@@ -846,14 +846,18 @@ igt_main
 	igt_subtest("basic-write")
 		test_write(vgem, i915);
 
-	igt_subtest("basic-gtt")
+	igt_subtest("basic-gtt") {
+		gem_require_mappable_ggtt(i915);
 		test_gtt(vgem, i915);
+	}

To me seems no reason to skip this. We could either unconditionally use device_coherent() or use mmap_gtt() if gtt is available else device_coherent()? Though probably the test would need to be renamed as test_device_coherent()?

tests/prime_vgem.c igt_main · line 860

Quoted 9 lines
tests/prime_vgem.c +3 -1
 	igt_subtest("shrink")
 		test_shrink(vgem, i915);
 
-	igt_subtest("coherency-gtt")
+	igt_subtest("coherency-gtt") {
+		gem_require_mappable_ggtt(i915);
 		test_gtt_interleaved(vgem, i915);
+	}

Probably similar situation here, though with WC instead of GTT the test should always pass?

tests/prime_vgem.c igt_main · line 912

Quoted 12 lines
tests/prime_vgem.c +3 -1
 	for (e = intel_execution_engines; e->name; e++) {
 		igt_subtest_f("%ssync-%s",
@@ -902,8 +906,10 @@ igt_main
 
 		igt_subtest("basic-fence-read")
 			test_fence_read(i915, vgem);
-		igt_subtest("basic-fence-mmap")
+		igt_subtest("basic-fence-mmap") {
+			gem_require_mappable_ggtt(i915);
 			test_fence_mmap(i915, vgem);
+		}

Once again, just use device_coherent()?
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

Re: [igt-dev] [PATCH i-g-t 1/9] tests/prime_vgem: Skip fence and gtt specific tests

Quoted 21 lines · Ashutosh
Quoted 20 lines · Ramalingam C

In the absence of the mappable aperture, skip GTT and fence specific tests.

v2:
requirement check is moved to subtest start [Zbigniew]

---
 tests/prime_vgem.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
tests/prime_vgem.c +0 -0
index 3bdb23007d56..c483cbe722ea 100644
@@ -846,14 +846,18 @@ igt_main
 	igt_subtest("basic-write")
 		test_write(vgem, i915);
 
Quoted 7 lines

tests/prime_vgem.c igt_main · line 852

Quoted 5 lines
tests/prime_vgem.c +3 -1
-	igt_subtest("basic-gtt")
+	igt_subtest("basic-gtt") {
+		gem_require_mappable_ggtt(i915);
 		test_gtt(vgem, i915);
+	}

To me seems no reason to skip this.

Only I915_MMAP_OFFSET_GTT type of mmap-offset to a PRIME imported dma-buf backed object is supported, other types are not, then the test can only succeed if mappable aperture is available, otherwise it should be skipped. This applies to all 3 subtests.

Thanks,
Janusz

Quoted 23 lines

We could either unconditionally use
device_coherent() or use mmap_gtt() if gtt is available else device_coherent()? Though probably the test would need to be renamed as test_device_coherent()?

tests/prime_vgem.c igt_main · line 860

Quoted 9 lines
tests/prime_vgem.c +3 -1
 	igt_subtest("shrink")
 		test_shrink(vgem, i915);
 
-	igt_subtest("coherency-gtt")
+	igt_subtest("coherency-gtt") {
+		gem_require_mappable_ggtt(i915);
 		test_gtt_interleaved(vgem, i915);
+	}

Probably similar situation here, though with WC instead of GTT the test should always pass?

Quoted 5 lines
tests/prime_vgem.c +0 -0
 	for (e = intel_execution_engines; e->name; e++) {
 		igt_subtest_f("%ssync-%s",
@@ -902,8 +906,10 @@ igt_main
 
Quoted 10 lines

tests/prime_vgem.c igt_main · line 912

Quoted 7 lines
tests/prime_vgem.c +3 -1
 		igt_subtest("basic-fence-read")
 			test_fence_read(i915, vgem);
-		igt_subtest("basic-fence-mmap")
+		igt_subtest("basic-fence-mmap") {
+			gem_require_mappable_ggtt(i915);
 			test_fence_mmap(i915, vgem);
+		}

Once again, just use device_coherent()?

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/9
#4 lore raw

Re: [igt-dev] [PATCH i-g-t 1/9] tests/prime_vgem: Skip fence and gtt specific tests

In reply to Ramalingam C
Quoted 39 lines · CET Ramalingam C

In the absence of the mappable aperture, skip GTT and fence specific tests.

v2:
requirement check is moved to subtest start [Zbigniew]

---
 tests/prime_vgem.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
tests/prime_vgem.c +6 -2
index 3bdb23007d56..c483cbe722ea 100644
@@ -846,14 +846,18 @@ igt_main
 	igt_subtest("basic-write")
 		test_write(vgem, i915);
 
-	igt_subtest("basic-gtt")
+	igt_subtest("basic-gtt") {
+		gem_require_mappable_ggtt(i915);
 		test_gtt(vgem, i915);
+	}
 
 	igt_subtest("shrink")
 		test_shrink(vgem, i915);
 
-	igt_subtest("coherency-gtt")
+	igt_subtest("coherency-gtt") {
+		gem_require_mappable_ggtt(i915);
 		test_gtt_interleaved(vgem, i915);
+	}
 
 	for (e = intel_execution_engines; e->name; e++) {
 		igt_subtest_f("%ssync-%s",
@@ -902,8 +906,10 @@ igt_main
 

tests/prime_vgem.c igt_main · line 915

Quoted 10 lines
tests/prime_vgem.c +3 -1
 		igt_subtest("basic-fence-read")
 			test_fence_read(i915, vgem);
-		igt_subtest("basic-fence-mmap")
+		igt_subtest("basic-fence-mmap") {
+			gem_require_mappable_ggtt(i915);
 			test_fence_mmap(i915, vgem);
+		}
 
 		for (e = intel_execution_engines; e->name; e++) {
 			igt_subtest_f("%sfence-wait-%s",

As discussed before, we need blitter based replacements for completeness, but those skips are needed anyway, better than failures we currently get, as long as we decided to not provide support for non-GTT mapping of dma-buf objects.

Thanks,
Janusz

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

PATCH 2/9 tests/intel_dp_compliance: Skip tests as tiling is not supported

In reply to Ramalingam C

Skip the test if the tiling is not supported on the platforms.

---
 tools/intel_dp_compliance.c | 2 ++
 1 file changed, 2 insertions(+)
tools/intel_dp_compliance.c +2 -0
index 5cc3d37a71d6..8f4ea3f3d328 100644
@@ -1043,6 +1043,8 @@ int main(int argc, char **argv)
 	drm_fd = drm_open_driver(DRIVER_ANY);
 	gen = intel_gen(intel_get_drm_devid(drm_fd));
 
+	/* Set tiling is not supported on newer platforms */
+	gem_require_mappable_ggtt(drm_fd);
 	kmstest_set_vt_graphics_mode();
 	setup_debugfs_files();
 	cleanup_test();
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#6 lore raw

Re: [igt-dev] [PATCH i-g-t 2/9] tests/intel_dp_compliance: Skip tests as tiling is not supported

Quoted 13 lines · Ramalingam C

Skip the test if the tiling is not supported on the platforms.

---
 tools/intel_dp_compliance.c | 2 ++
 1 file changed, 2 insertions(+)
tools/intel_dp_compliance.c +0 -0
index 5cc3d37a71d6..8f4ea3f3d328 100644

tools/intel_dp_compliance.c int main(int argc, char **argv) · line 1047

Quoted 5 lines
tools/intel_dp_compliance.c +2 -0
@@ -1043,6 +1043,8 @@ int main(int argc, char **argv)
 	drm_fd = drm_open_driver(DRIVER_ANY);
 	gen = intel_gen(intel_get_drm_devid(drm_fd));
 
+	/* Set tiling is not supported on newer platforms */
+	gem_require_mappable_ggtt(drm_fd);

But the test exclusively uses LOCAL_DRM_FORMAT_MOD_NONE? We should see if it can use device_coherent() or see if we can drop this from this series for now and revisit later with the other display tests?
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#7 lore raw

Re: [igt-dev] [PATCH i-g-t 2/9] tests/intel_dp_compliance: Skip tests as tiling is not supported

Quoted 18 lines · Ashutosh
Quoted 16 lines · Ramalingam C

Skip the test if the tiling is not supported on the platforms.

---
 tools/intel_dp_compliance.c | 2 ++
 1 file changed, 2 insertions(+)
tools/intel_dp_compliance.c +0 -0
index 5cc3d37a71d6..8f4ea3f3d328 100644
@@ -1043,6 +1043,8 @@ int main(int argc, char **argv)
 	drm_fd = drm_open_driver(DRIVER_ANY);
 	gen = intel_gen(intel_get_drm_devid(drm_fd));
 
Quoted 6 lines

tools/intel_dp_compliance.c int main(int argc, char **argv) · line 1047

Quoted 2 lines
tools/intel_dp_compliance.c +2 -0
+	/* Set tiling is not supported on newer platforms */
+	gem_require_mappable_ggtt(drm_fd);

But the test exclusively uses LOCAL_DRM_FORMAT_MOD_NONE? We should see if it can use device_coherent() or see if we can drop this from this series for now and revisit later with the other display tests?

I think this can just use device_coherent().
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#8 lore raw

Re: [igt-dev] [PATCH i-g-t 2/9] tests/intel_dp_compliance: Skip tests as tiling is not supported

Quoted 19 lines · Ashutosh
Quoted 18 lines · Ashutosh
Quoted 16 lines · Ramalingam C

Skip the test if the tiling is not supported on the platforms.

---
 tools/intel_dp_compliance.c | 2 ++
 1 file changed, 2 insertions(+)
tools/intel_dp_compliance.c +0 -0
index 5cc3d37a71d6..8f4ea3f3d328 100644
@@ -1043,6 +1043,8 @@ int main(int argc, char **argv)
 	drm_fd = drm_open_driver(DRIVER_ANY);
 	gen = intel_gen(intel_get_drm_devid(drm_fd));
 
Quoted 8 lines
Quoted 6 lines

tools/intel_dp_compliance.c int main(int argc, char **argv) · line 1047

Quoted 2 lines
tools/intel_dp_compliance.c +2 -0
+	/* Set tiling is not supported on newer platforms */
+	gem_require_mappable_ggtt(drm_fd);

But the test exclusively uses LOCAL_DRM_FORMAT_MOD_NONE? We should see if it can use device_coherent() or see if we can drop this from this series for now and revisit later with the other display tests?

I think this can just use device_coherent().

Ashutosh,

Still we have the set_tiling used in this flow. As per our discussion we should skip when we try to do legacy tiling. Am I missing something here?

-Ram
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#9 lore raw

Re: [igt-dev] [PATCH i-g-t 2/9] tests/intel_dp_compliance: Skip tests as tiling is not supported

Quoted 28 lines · Ramalingam C
Quoted 26 lines · Ashutosh
Quoted 24 lines · Ashutosh
Quoted 13 lines · Ramalingam C

Skip the test if the tiling is not supported on the platforms.

---
 tools/intel_dp_compliance.c | 2 ++
 1 file changed, 2 insertions(+)
tools/intel_dp_compliance.c +0 -0
index 5cc3d37a71d6..8f4ea3f3d328 100644

tools/intel_dp_compliance.c int main(int argc, char **argv) · line 1047

Quoted 5 lines
tools/intel_dp_compliance.c +2 -0
@@ -1043,6 +1043,8 @@ int main(int argc, char **argv)
 	drm_fd = drm_open_driver(DRIVER_ANY);
 	gen = intel_gen(intel_get_drm_devid(drm_fd));
 
+	/* Set tiling is not supported on newer platforms */
+	gem_require_mappable_ggtt(drm_fd);

But the test exclusively uses LOCAL_DRM_FORMAT_MOD_NONE? We should see if it can use device_coherent() or see if we can drop this from this series for now and revisit later with the other display tests?

Quoted 6 lines
Quoted 1 line

I think this can just use device_coherent().

Ashutosh,

Still we have the set_tiling used in this flow. As per our discussion we should skip when we try to do legacy tiling. Am I missing something here?

Afais set_tiling is not used, only LOCAL_DRM_FORMAT_MOD_NONE is used.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#10 lore raw

PATCH 3/9 tests/prime_mmap_coherency: use device coherent mapping instead of mmap_gtt

In reply to Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

---
 tests/prime_mmap_coherency.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/prime_mmap_coherency.c +1 -1
index 39538767c68f..32d78ee1a771 100644
@@ -69,7 +69,7 @@ static int test_read_flush(void)
 
 	/* STEP #3: write 0x11 into BO 1. */
 	bo_2 = drm_intel_bo_alloc(bufmgr, "BO 2", width * height * 4, 4096);
-	ptr_gtt = gem_mmap__gtt(fd, bo_2->handle, width * height, PROT_READ | PROT_WRITE);
+	ptr_gtt = gem_mmap__device_coherent(fd, bo_2->handle, 0, width * height, PROT_READ | PROT_WRITE);
 	gem_set_domain(fd, bo_2->handle,
 		       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
 	memset(ptr_gtt, 0xc5, width * height);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#11 lore raw

Re: [igt-dev] [PATCH i-g-t 3/9] tests/prime_mmap_coherency: use device coherent mapping instead of mmap_gtt

Quoted 16 lines · Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

---
 tests/prime_mmap_coherency.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/prime_mmap_coherency.c +0 -0
index 39538767c68f..32d78ee1a771 100644

tests/prime_mmap_coherency.c static int test_read_flush(void) · line 75

Quoted 8 lines
tests/prime_mmap_coherency.c +1 -1
@@ -69,7 +69,7 @@ static int test_read_flush(void)
 
 	/* STEP #3: write 0x11 into BO 1. */
 	bo_2 = drm_intel_bo_alloc(bufmgr, "BO 2", width * height * 4, 4096);
-	ptr_gtt = gem_mmap__gtt(fd, bo_2->handle, width * height, PROT_READ | PROT_WRITE);
+	ptr_gtt = gem_mmap__device_coherent(fd, bo_2->handle, 0, width * height, PROT_READ | PROT_WRITE);
 	gem_set_domain(fd, bo_2->handle,
 		       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
 	memset(ptr_gtt, 0xc5, width * height);

I think the patch is ok but did you check if the test passes/fails on devices with/without a mappable aperture? I sort of expect it to always fail, at least with WC, but not sure if it ever passes with the GTT mapping (since we haven't done a clflush).
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#12 lore raw

Re: [igt-dev] [PATCH i-g-t 3/9] tests/prime_mmap_coherency: use device coherent mapping instead of mmap_gtt

Quoted 18 lines · Ashutosh
Quoted 17 lines · Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

---
 tests/prime_mmap_coherency.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/prime_mmap_coherency.c +0 -0
index 39538767c68f..32d78ee1a771 100644
@@ -69,7 +69,7 @@ static int test_read_flush(void)
 
Quoted 12 lines

tests/prime_mmap_coherency.c static int test_read_flush(void) · line 75

Quoted 7 lines
tests/prime_mmap_coherency.c +1 -1
 	/* STEP #3: write 0x11 into BO 1. */
 	bo_2 = drm_intel_bo_alloc(bufmgr, "BO 2", width * height * 4, 4096);
-	ptr_gtt = gem_mmap__gtt(fd, bo_2->handle, width * height, PROT_READ | PROT_WRITE);
+	ptr_gtt = gem_mmap__device_coherent(fd, bo_2->handle, 0, width * height, PROT_READ | PROT_WRITE);
 	gem_set_domain(fd, bo_2->handle,
 		       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
 	memset(ptr_gtt, 0xc5, width * height);

I think the patch is ok but did you check if the test passes/fails on devices with/without a mappable aperture? I sort of expect it to always fail, at least with WC, but not sure if it ever passes with the GTT mapping (since we haven't done a clflush).

Subtest read fails at gem_mmap__gtt but with device_coherent mapping the test is passing.

-Ram
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by
#13 lore raw

Re: [igt-dev] [PATCH i-g-t 3/9] tests/prime_mmap_coherency: use device coherent mapping instead of mmap_gtt

In reply to Dixit, Ashutosh
Quoted 18 lines · Ashutosh
Quoted 17 lines · Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

---
 tests/prime_mmap_coherency.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/prime_mmap_coherency.c +0 -0
index 39538767c68f..32d78ee1a771 100644
@@ -69,7 +69,7 @@ static int test_read_flush(void)
 
Quoted 12 lines

tests/prime_mmap_coherency.c static int test_read_flush(void) · line 75

Quoted 7 lines
tests/prime_mmap_coherency.c +1 -1
 	/* STEP #3: write 0x11 into BO 1. */
 	bo_2 = drm_intel_bo_alloc(bufmgr, "BO 2", width * height * 4, 4096);
-	ptr_gtt = gem_mmap__gtt(fd, bo_2->handle, width * height, PROT_READ | PROT_WRITE);
+	ptr_gtt = gem_mmap__device_coherent(fd, bo_2->handle, 0, width * height, PROT_READ | PROT_WRITE);
 	gem_set_domain(fd, bo_2->handle,
 		       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
 	memset(ptr_gtt, 0xc5, width * height);

I think the patch is ok but did you check if the test passes/fails on devices with/without a mappable aperture? I sort of expect it to always fail, at least with WC, but not sure if it ever passes with the GTT mapping (since we haven't done a clflush).

According to Chris "the gtt mapping uses WC" so cache effects for both WC and GTT mappings should be equivalent. Therefore:

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#14 lore raw

PATCH 4/9 tests/prime_mmap: use device coherent mapping instead of mmap_gtt

In reply to Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

---
 tests/prime_mmap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/prime_mmap.c +2 -2
index fc985784407b..1433424109c8 100644
@@ -85,8 +85,8 @@ test_correct(void)
 	dma_buf_fd = prime_handle_to_fd(fd, handle);
 	igt_assert(errno == 0);
 
-	/* Check correctness vs GEM_MMAP_GTT */
-	ptr1 = gem_mmap__gtt(fd, handle, BO_SIZE, PROT_READ);
+	/* Check correctness vs GEM_MMAP */
+	ptr1 = gem_mmap__device_coherent(fd, handle, 0, BO_SIZE, PROT_READ);
 	ptr2 = mmap(NULL, BO_SIZE, PROT_READ, MAP_SHARED, dma_buf_fd, 0);
 	igt_assert(ptr1 != MAP_FAILED);
 	igt_assert(ptr2 != MAP_FAILED);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#15 lore raw

Re: [igt-dev] [PATCH i-g-t 4/9] tests/prime_mmap: use device coherent mapping instead of mmap_gtt

Quoted 16 lines · Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

---
 tests/prime_mmap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/prime_mmap.c +0 -0
index fc985784407b..1433424109c8 100644

tests/prime_mmap.c test_correct(void) · line 89

Quoted 7 lines
tests/prime_mmap.c +2 -2
@@ -85,8 +85,8 @@ test_correct(void)
 	dma_buf_fd = prime_handle_to_fd(fd, handle);
 	igt_assert(errno == 0);
 
-	/* Check correctness vs GEM_MMAP_GTT */
-	ptr1 = gem_mmap__gtt(fd, handle, BO_SIZE, PROT_READ);
+	/* Check correctness vs GEM_MMAP */
+	ptr1 = gem_mmap__device_coherent(fd, handle, 0, BO_SIZE, PROT_READ);

Once again, does this test pass with gtt mapping but fail with wc mapping? I thought gtt mapping also bypasses the cache like wc? What about prime mmap's? Can someone please confirm? Otherwise I will try to look.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#16 lore raw

Re: [igt-dev] [PATCH i-g-t 4/9] tests/prime_mmap: use device coherent mapping instead of mmap_gtt

Quoted 20 lines · Ashutosh
Quoted 19 lines · Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

---
 tests/prime_mmap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/prime_mmap.c +0 -0
index fc985784407b..1433424109c8 100644
@@ -85,8 +85,8 @@ test_correct(void)
 	dma_buf_fd = prime_handle_to_fd(fd, handle);
 	igt_assert(errno == 0);
 
Quoted 8 lines

tests/prime_mmap.c test_correct(void) · line 89

Quoted 4 lines
tests/prime_mmap.c +2 -2
-	/* Check correctness vs GEM_MMAP_GTT */
-	ptr1 = gem_mmap__gtt(fd, handle, BO_SIZE, PROT_READ);
+	/* Check correctness vs GEM_MMAP */
+	ptr1 = gem_mmap__device_coherent(fd, handle, 0, BO_SIZE, PROT_READ);

Once again, does this test pass with gtt mapping but fail with wc mapping? I thought gtt mapping also bypasses the cache like wc? What about prime mmap's? Can someone please confirm? Otherwise I will try to look.

Ashutosh,

At this test subtest test-correct is failing at gem_mmap__gtt, but passes when we use device coherent mapping.

-Ram
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by
#17 lore raw

Re: [igt-dev] [PATCH i-g-t 4/9] tests/prime_mmap: use device coherent mapping instead of mmap_gtt

In reply to Dixit, Ashutosh
Quoted 21 lines · Ashutosh
Quoted 19 lines · Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

---
 tests/prime_mmap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/prime_mmap.c +0 -0
index fc985784407b..1433424109c8 100644
@@ -85,8 +85,8 @@ test_correct(void)
 	dma_buf_fd = prime_handle_to_fd(fd, handle);
 	igt_assert(errno == 0);
 
Quoted 8 lines

tests/prime_mmap.c test_correct(void) · line 89

Quoted 4 lines
tests/prime_mmap.c +2 -2
-	/* Check correctness vs GEM_MMAP_GTT */
-	ptr1 = gem_mmap__gtt(fd, handle, BO_SIZE, PROT_READ);
+	/* Check correctness vs GEM_MMAP */
+	ptr1 = gem_mmap__device_coherent(fd, handle, 0, BO_SIZE, PROT_READ);

Once again, does this test pass with gtt mapping but fail with wc mapping? I thought gtt mapping also bypasses the cache like wc? What about prime mmap's? Can someone please confirm? Otherwise I will try to look.

Similar to prime_mmap_coherency: according to Chris "the gtt mapping uses WC" so cache effects for both WC and GTT mappings should be equivalent. Also it is the regular handle not the prime handle which is being mmap'd using gem_mmap__device_coherent(). Therefore:

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#18 lore raw

PATCH 5/9 tests/kms_psr: Skip tests on mmap_gtt, if no mappable aperture

In reply to Ramalingam C

Due to non availability of the mappable aperture on discrete GPUs, skip the tests specific to mmap_gtt

---
 tests/kms_psr.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_psr.c +1 -0
index d9be87d927b2..13ed02f46ac4 100644
@@ -270,6 +270,7 @@ static void run_test(data_t *data)
 		expected = "GREEN";
 		break;
 	case MMAP_GTT:
+		gem_require_mappable_ggtt(data->drm_fd);
 		ptr = gem_mmap__gtt(data->drm_fd, handle, data->mod_size,
 				    PROT_WRITE);
 		gem_set_domain(data->drm_fd, handle,
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#19 lore raw

Re: [igt-dev] [PATCH i-g-t 5/9] tests/kms_psr: Skip tests on mmap_gtt, if no mappable aperture

Quoted 14 lines · Ramalingam C

Due to non availability of the mappable aperture on discrete GPUs, skip the tests specific to mmap_gtt

---
 tests/kms_psr.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_psr.c +0 -0
index d9be87d927b2..13ed02f46ac4 100644

tests/kms_psr.c static void run_test(data_t *data) · line 276

Quoted 7 lines
tests/kms_psr.c +1 -0
@@ -270,6 +270,7 @@ static void run_test(data_t *data)
 		expected = "GREEN";
 		break;
 	case MMAP_GTT:
+		gem_require_mappable_ggtt(data->drm_fd);
 		ptr = gem_mmap__gtt(data->drm_fd, handle, data->mod_size,
 				    PROT_WRITE);
 		gem_set_domain(data->drm_fd, handle,

This test is actually using tiling (using LOCAL_I915_FORMAT_MOD_X_TILED) so probably more than this needs to be skipped?
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by
#20 lore raw

Re: [igt-dev] [PATCH i-g-t 5/9] tests/kms_psr: Skip tests on mmap_gtt, if no mappable aperture

Quoted 11 lines · Ashutosh
Quoted 9 lines · Ramalingam C

Due to non availability of the mappable aperture on discrete GPUs, skip the tests specific to mmap_gtt

---
 tests/kms_psr.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines

tests/kms_psr.c static void run_test(data_t *data) · line 276

Quoted 12 lines
tests/kms_psr.c +1 -0
index d9be87d927b2..13ed02f46ac4 100644
@@ -270,6 +270,7 @@ static void run_test(data_t *data)
 		expected = "GREEN";
 		break;
 	case MMAP_GTT:
+		gem_require_mappable_ggtt(data->drm_fd);
 		ptr = gem_mmap__gtt(data->drm_fd, handle, data->mod_size,
 				    PROT_WRITE);
 		gem_set_domain(data->drm_fd, handle,

This test is actually using tiling (using LOCAL_I915_FORMAT_MOD_X_TILED) so probably more than this needs to be skipped?

Sorry, my earlier assessment was incorrect:

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#21 lore raw

PATCH 6/9 tests/kms_available_modes_crc: Skip test if mappable aperture not supported

In reply to Ramalingam C

If the mappable aperture is not supported, skip the test.

---
 tests/kms_available_modes_crc.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_available_modes_crc.c +1 -0
index d1b7b51708b0..12761343459a 100644
@@ -448,6 +448,7 @@ igt_main
 	data.commit = data.display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY;
 
 	igt_subtest("available_mode_test_crc") {
+		gem_require_mappable_ggtt(data.gfx_fd);
 		test_available_modes(&data);
 	}
 
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v1 6/9
#22 lore raw

Re: [igt-dev] [PATCH i-g-t 6/9] tests/kms_available_modes_crc: Skip test if mappable aperture not supported

Quoted 13 lines · Ramalingam C

If the mappable aperture is not supported, skip the test.

---
 tests/kms_available_modes_crc.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_available_modes_crc.c +0 -0
index d1b7b51708b0..12761343459a 100644

tests/kms_available_modes_crc.c igt_main · line 452

Quoted 5 lines
tests/kms_available_modes_crc.c +1 -0
@@ -448,6 +448,7 @@ igt_main
 	data.commit = data.display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY;
 
 	igt_subtest("available_mode_test_crc") {
+		gem_require_mappable_ggtt(data.gfx_fd);
 		test_available_modes(&data);

The test uses tiling, mmap_gtt. So for now from what I can see it's ok to skip till a different way if any is devised to fix these display tests:

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#23 lore raw

PATCH 7/9 tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt

In reply to Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

Incase of fencing/gtt related tests, we mandate the existance of the mmap_gtt.

---
 tests/i915/i915_pm_rpm.c | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)
tests/i915/i915_pm_rpm.c +15 -9
index f5f813c3d952..9524d7d3a4dd 100644
@@ -1392,8 +1392,8 @@ static void gem_evict_pwrite_subtest(void)
 
 	for (n = 0; n < num_trash_bos; n++) {
 		trash_bos[n].handle = gem_create(drm_fd, 1024*1024);
-		trash_bos[n].ptr = gem_mmap__gtt(drm_fd, trash_bos[n].handle,
-						 1024*1024, PROT_WRITE);
+		trash_bos[n].ptr = gem_mmap__device_coherent(drm_fd, trash_bos[n].handle,
+							     0, 1024*1024, PROT_WRITE);
 		*trash_bos[n].ptr = 0;
 	}
 
@@ -1535,7 +1535,7 @@ static void fill_igt_fb(struct igt_fb *fb, uint32_t color)
 	int i;
 	uint32_t *ptr;
 
-	ptr = gem_mmap__gtt(drm_fd, fb->gem_handle, fb->size, PROT_WRITE);
+	ptr = gem_mmap__device_coherent(drm_fd, fb->gem_handle, 0, fb->size, PROT_WRITE);
 	for (i = 0; i < fb->size/sizeof(uint32_t); i++)
 		ptr[i] = color;
 	igt_assert(munmap(ptr, fb->size) == 0);
@@ -1827,8 +1827,8 @@ static void pm_test_tiling(void)
 		for (j = 0, k = 1 << off_bit;
 		     k <= gtt_obj_max_size; k <<= 1, j++) {
 			handles[j] = gem_create(drm_fd, k);
-			gem_bufs[j] = gem_mmap__gtt(drm_fd, handles[j],
-						    k, PROT_WRITE);
+			gem_bufs[j] = gem_mmap__device_coherent(drm_fd, handles[j],
+								0, k, PROT_WRITE);
 			memset(gem_bufs[j], 0x0, k);
 		}
 
@@ -1872,7 +1872,7 @@ static void pm_test_caching(void)
 
 	handle = gem_create(drm_fd, gtt_obj_max_size);
 	default_cache_level = gem_get_caching(drm_fd, handle);
-	gem_buf = gem_mmap__gtt(drm_fd, handle, gtt_obj_max_size, PROT_WRITE);
+	gem_buf = gem_mmap__device_coherent(drm_fd, handle, 0, gtt_obj_max_size, PROT_WRITE);
 
 	for (i = 0; i < ARRAY_SIZE(cache_levels); i++) {
 		igt_assert(wait_for_suspended());
@@ -2016,8 +2016,10 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 	/* GEM */
 	igt_subtest("gem-mmap-cpu")
 		gem_mmap_subtest(false);
-	igt_subtest("gem-mmap-gtt")
+	igt_subtest("gem-mmap-gtt") {
+		gem_require_mappable_ggtt(drm_fd);
 		gem_mmap_subtest(true);
+	}
 	igt_subtest("gem-pread")
 		gem_pread_subtest();
 	igt_subtest("gem-execbuf")
@@ -2058,10 +2060,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 		dpms_mode_unset_subtest(SCREEN_TYPE_LPSP);
 	igt_subtest("dpms-mode-unset-non-lpsp")
 		dpms_mode_unset_subtest(SCREEN_TYPE_NON_LPSP);
-	igt_subtest("fences")
+	igt_subtest("fences") {
+		gem_require_mappable_ggtt(drm_fd);
 		fences_subtest(false);
-	igt_subtest("fences-dpms")
+	}
+	igt_subtest("fences-dpms") {
+		gem_require_mappable_ggtt(drm_fd);
 		fences_subtest(true);
+	}
 
 	/* Modeset stress */
 	igt_subtest("modeset-lpsp-stress")
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#24 lore raw

Re: [igt-dev] [PATCH i-g-t 7/9] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt

Quoted 19 lines · Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

Incase of fencing/gtt related tests, we mandate the existance of the mmap_gtt.

---
 tests/i915/i915_pm_rpm.c | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)
tests/i915/i915_pm_rpm.c +0 -0
index f5f813c3d952..9524d7d3a4dd 100644

tests/i915/i915_pm_rpm.c static void gem_evict_pwrite_subtest(void) · line 1398

Quoted 9 lines
tests/i915/i915_pm_rpm.c +2 -2
@@ -1392,8 +1392,8 @@ static void gem_evict_pwrite_subtest(void)
 
 	for (n = 0; n < num_trash_bos; n++) {
 		trash_bos[n].handle = gem_create(drm_fd, 1024*1024);
-		trash_bos[n].ptr = gem_mmap__gtt(drm_fd, trash_bos[n].handle,
-						 1024*1024, PROT_WRITE);
+		trash_bos[n].ptr = gem_mmap__device_coherent(drm_fd, trash_bos[n].handle,
+							     0, 1024*1024, PROT_WRITE);
 		*trash_bos[n].ptr = 0;
 	}

What does gem_mappable_aperture_size() just above return when we don't have a mappable aperture? Maybe this also needs to be skipped instead?

tests/i915/i915_pm_rpm.c static void fill_igt_fb(struct igt_fb *fb, uint32_t color) · line 1541

Quoted 9 lines
tests/i915/i915_pm_rpm.c +1 -1
@@ -1535,7 +1535,7 @@ static void fill_igt_fb(struct igt_fb *fb, uint32_t color)
 	int i;
 	uint32_t *ptr;
 
-	ptr = gem_mmap__gtt(drm_fd, fb->gem_handle, fb->size, PROT_WRITE);
+	ptr = gem_mmap__device_coherent(drm_fd, fb->gem_handle, 0, fb->size, PROT_WRITE);
 	for (i = 0; i < fb->size/sizeof(uint32_t); i++)
 		ptr[i] = color;
 	igt_assert(munmap(ptr, fb->size) == 0);

Even though fill_igt_fb() is called with tiling set, I think it is still ok to do this since all we are doing is filling a solid color for which tiling is immaterial.

tests/i915/i915_pm_rpm.c static void pm_test_tiling(void) · line 1833

Quoted 10 lines
tests/i915/i915_pm_rpm.c +2 -2
@@ -1827,8 +1827,8 @@ static void pm_test_tiling(void)
 		for (j = 0, k = 1 << off_bit;
 		     k <= gtt_obj_max_size; k <<= 1, j++) {
 			handles[j] = gem_create(drm_fd, k);
-			gem_bufs[j] = gem_mmap__gtt(drm_fd, handles[j],
-						    k, PROT_WRITE);
+			gem_bufs[j] = gem_mmap__device_coherent(drm_fd, handles[j],
+								0, k, PROT_WRITE);
 			memset(gem_bufs[j], 0x0, k);
 		}

Maybe we should skip this instead because set/get tiling calls below will fail/assert?

tests/i915/i915_pm_rpm.c static void pm_test_caching(void) · line 1878

Quoted 9 lines
tests/i915/i915_pm_rpm.c +1 -1
@@ -1872,7 +1872,7 @@ static void pm_test_caching(void)
 
 	handle = gem_create(drm_fd, gtt_obj_max_size);
 	default_cache_level = gem_get_caching(drm_fd, handle);
-	gem_buf = gem_mmap__gtt(drm_fd, handle, gtt_obj_max_size, PROT_WRITE);
+	gem_buf = gem_mmap__device_coherent(drm_fd, handle, 0, gtt_obj_max_size, PROT_WRITE);
 
 	for (i = 0; i < ARRAY_SIZE(cache_levels); i++) {
 		igt_assert(wait_for_suspended());

Does the test work ok or assert with this change? Also I am not sure but from the comments it seems the purpose of the test is to really do with GGTT so it should be skipped when we don't have aperture?

Quoted 16 lines
tests/i915/i915_pm_rpm.c +3 -1
@@ -2016,8 +2016,10 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 	/* GEM */
 	igt_subtest("gem-mmap-cpu")
 		gem_mmap_subtest(false);
-	igt_subtest("gem-mmap-gtt")
+	igt_subtest("gem-mmap-gtt") {
+		gem_require_mappable_ggtt(drm_fd);
 		gem_mmap_subtest(true);
+	}
 	igt_subtest("gem-pread")
 		gem_pread_subtest();
 	igt_subtest("gem-execbuf")
@@ -2058,10 +2060,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 		dpms_mode_unset_subtest(SCREEN_TYPE_LPSP);
 	igt_subtest("dpms-mode-unset-non-lpsp")
 		dpms_mode_unset_subtest(SCREEN_TYPE_NON_LPSP);

tests/i915/i915_pm_rpm.c igt_main_args("", long_options, help_str, opt_handler, NULL) · line 2070

Quoted 10 lines
tests/i915/i915_pm_rpm.c +6 -2
-	igt_subtest("fences")
+	igt_subtest("fences") {
+		gem_require_mappable_ggtt(drm_fd);
 		fences_subtest(false);
-	igt_subtest("fences-dpms")
+	}
+	igt_subtest("fences-dpms") {
+		gem_require_mappable_ggtt(drm_fd);
 		fences_subtest(true);
+	}

These skips look ok to me.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#25 lore raw

Re: [igt-dev] [PATCH i-g-t 7/9] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt

Quoted 21 lines · Ashutosh
Quoted 20 lines · Ramalingam C

Since on new discrete GPUs we dont have the mappable aperture, if that is acceptable for the test purpose, we should use GEM_MMAP_OFFSET. Hence using gem_mmap_device_coherent() which wraps the mmap options in the order of gem_mmap_offset / gem_mmap / mmap_gtt

Incase of fencing/gtt related tests, we mandate the existance of the mmap_gtt.

---
 tests/i915/i915_pm_rpm.c | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)
tests/i915/i915_pm_rpm.c +0 -0
index f5f813c3d952..9524d7d3a4dd 100644
@@ -1392,8 +1392,8 @@ static void gem_evict_pwrite_subtest(void)
 
Quoted 11 lines

tests/i915/i915_pm_rpm.c static void gem_evict_pwrite_subtest(void) · line 1398

Quoted 8 lines
tests/i915/i915_pm_rpm.c +2 -2
 	for (n = 0; n < num_trash_bos; n++) {
 		trash_bos[n].handle = gem_create(drm_fd, 1024*1024);
-		trash_bos[n].ptr = gem_mmap__gtt(drm_fd, trash_bos[n].handle,
-						 1024*1024, PROT_WRITE);
+		trash_bos[n].ptr = gem_mmap__device_coherent(drm_fd, trash_bos[n].handle,
+							     0, 1024*1024, PROT_WRITE);
 		*trash_bos[n].ptr = 0;
 	}

What does gem_mappable_aperture_size() just above return when we don't have a mappable aperture? Maybe this also needs to be skipped instead?

Actually the tests are skipped because igt_pm_dmc_loaded(debugfs) is failing at setup_environment. So all gtt related cases are hidden. But yes this has to be skipped as aperture size is used or rewritten for display. For now I am choosing the skipping path.

Quoted 15 lines

tests/i915/i915_pm_rpm.c static void fill_igt_fb(struct igt_fb *fb, uint32_t color) · line 1541

Quoted 10 lines
tests/i915/i915_pm_rpm.c +1 -1
@@ -1535,7 +1535,7 @@ static void fill_igt_fb(struct igt_fb *fb, uint32_t color)
 	int i;
 	uint32_t *ptr;
 
-	ptr = gem_mmap__gtt(drm_fd, fb->gem_handle, fb->size, PROT_WRITE);
+	ptr = gem_mmap__device_coherent(drm_fd, fb->gem_handle, 0, fb->size, PROT_WRITE);
 	for (i = 0; i < fb->size/sizeof(uint32_t); i++)
 		ptr[i] = color;
 	igt_assert(munmap(ptr, fb->size) == 0);

Even though fill_igt_fb() is called with tiling set, I think it is still ok to do this since all we are doing is filling a solid color for which tiling is immaterial.

Quoted 13 lines

tests/i915/i915_pm_rpm.c static void pm_test_tiling(void) · line 1833

Quoted 10 lines
tests/i915/i915_pm_rpm.c +2 -2
@@ -1827,8 +1827,8 @@ static void pm_test_tiling(void)
 		for (j = 0, k = 1 << off_bit;
 		     k <= gtt_obj_max_size; k <<= 1, j++) {
 			handles[j] = gem_create(drm_fd, k);
-			gem_bufs[j] = gem_mmap__gtt(drm_fd, handles[j],
-						    k, PROT_WRITE);
+			gem_bufs[j] = gem_mmap__device_coherent(drm_fd, handles[j],
+								0, k, PROT_WRITE);
 			memset(gem_bufs[j], 0x0, k);
 		}

Maybe we should skip this instead because set/get tiling calls below will fail/assert?

Yes I will skip.

Quoted 8 lines
Quoted 8 lines
tests/i915/i915_pm_rpm.c +1 -1
@@ -1872,7 +1872,7 @@ static void pm_test_caching(void)
 
 	handle = gem_create(drm_fd, gtt_obj_max_size);
 	default_cache_level = gem_get_caching(drm_fd, handle);
-	gem_buf = gem_mmap__gtt(drm_fd, handle, gtt_obj_max_size, PROT_WRITE);
+	gem_buf = gem_mmap__device_coherent(drm_fd, handle, 0, gtt_obj_max_size, PROT_WRITE);
 
Quoted 6 lines

tests/i915/i915_pm_rpm.c static void pm_test_caching(void) · line 1878

Quoted 2 lines
tests/i915/i915_pm_rpm.c +0 -0
 	for (i = 0; i < ARRAY_SIZE(cache_levels); i++) {
 		igt_assert(wait_for_suspended());

Does the test work ok or assert with this change? Also I am not sure but from the comments it seems the purpose of the test is to really do with GGTT so it should be skipped when we don't have aperture?

since all tests are skipping, I am not sure about the functional impact. True comments talk about GGTT mapping. Better skip as of now. I will do the changes

Ram

Quoted 21 lines
Quoted 21 lines
tests/i915/i915_pm_rpm.c +5 -2
@@ -2016,8 +2016,10 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 	/* GEM */
 	igt_subtest("gem-mmap-cpu")
 		gem_mmap_subtest(false);
-	igt_subtest("gem-mmap-gtt")
+	igt_subtest("gem-mmap-gtt") {
+		gem_require_mappable_ggtt(drm_fd);
 		gem_mmap_subtest(true);
+	}
 	igt_subtest("gem-pread")
 		gem_pread_subtest();
 	igt_subtest("gem-execbuf")
@@ -2058,10 +2060,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 		dpms_mode_unset_subtest(SCREEN_TYPE_LPSP);
 	igt_subtest("dpms-mode-unset-non-lpsp")
 		dpms_mode_unset_subtest(SCREEN_TYPE_NON_LPSP);
-	igt_subtest("fences")
+	igt_subtest("fences") {
+		gem_require_mappable_ggtt(drm_fd);
 		fences_subtest(false);
Quoted 8 lines

tests/i915/i915_pm_rpm.c igt_main_args("", long_options, help_str, opt_handler, NULL) · line 2070

Quoted 6 lines
tests/i915/i915_pm_rpm.c +4 -1
-	igt_subtest("fences-dpms")
+	}
+	igt_subtest("fences-dpms") {
+		gem_require_mappable_ggtt(drm_fd);
 		fences_subtest(true);
+	}

These skips look ok to me.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#26 lore raw

PATCH 8/9 tests/i915_suspend: skip fence related tests, if no mmap_gtt

In reply to Ramalingam C

When mappable aperture is not available, skip the fencing related tests.

---
 tests/i915/i915_suspend.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)
tests/i915/i915_suspend.c +12 -4
index 5a2ec76699d6..47e134b12086 100644
@@ -208,11 +208,15 @@ igt_main
 	igt_fixture
 		fd = drm_open_driver(DRIVER_INTEL);
 
-	igt_subtest("fence-restore-tiled2untiled")
+	igt_subtest("fence-restore-tiled2untiled") {
+		gem_require_mappable_ggtt(fd);
 		test_fence_restore(fd, true, false);
+	}
 
-	igt_subtest("fence-restore-untiled")
+	igt_subtest("fence-restore-untiled") {
+		gem_require_mappable_ggtt(fd);
 		test_fence_restore(fd, false, false);
+	}
 
 	igt_subtest("debugfs-reader")
 		test_debugfs_reader(fd, false);
@@ -226,11 +230,15 @@ igt_main
 	igt_subtest("forcewake")
 		test_forcewake(fd, false);
 
-	igt_subtest("fence-restore-tiled2untiled-hibernate")
+	igt_subtest("fence-restore-tiled2untiled-hibernate") {
+		gem_require_mappable_ggtt(fd);
 		test_fence_restore(fd, true, true);
+	}
 
-	igt_subtest("fence-restore-untiled-hibernate")
+	igt_subtest("fence-restore-untiled-hibernate") {
+		gem_require_mappable_ggtt(fd);
 		test_fence_restore(fd, false, true);
+	}
 
 	igt_subtest("debugfs-reader-hibernate")
 		test_debugfs_reader(fd, true);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v1 8/9
#27 lore raw

Re: [igt-dev] [PATCH i-g-t 8/9] tests/i915_suspend: skip fence related tests, if no mmap_gtt

Quoted 35 lines · Ramalingam C

When mappable aperture is not available, skip the fencing related tests.

---
 tests/i915/i915_suspend.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)
tests/i915/i915_suspend.c +6 -3
index 5a2ec76699d6..47e134b12086 100644
@@ -208,11 +208,15 @@ igt_main
 	igt_fixture
 		fd = drm_open_driver(DRIVER_INTEL);
 
-	igt_subtest("fence-restore-tiled2untiled")
+	igt_subtest("fence-restore-tiled2untiled") {
+		gem_require_mappable_ggtt(fd);
 		test_fence_restore(fd, true, false);
+	}
 
-	igt_subtest("fence-restore-untiled")
+	igt_subtest("fence-restore-untiled") {
+		gem_require_mappable_ggtt(fd);
 		test_fence_restore(fd, false, false);
+	}
 
 	igt_subtest("debugfs-reader")
 		test_debugfs_reader(fd, false);
@@ -226,11 +230,15 @@ igt_main
 	igt_subtest("forcewake")
 		test_forcewake(fd, false);
 
-	igt_subtest("fence-restore-tiled2untiled-hibernate")

tests/i915/i915_suspend.c igt_main · line 241

Quoted 10 lines
tests/i915/i915_suspend.c +6 -1
+	igt_subtest("fence-restore-tiled2untiled-hibernate") {
+		gem_require_mappable_ggtt(fd);
 		test_fence_restore(fd, true, true);
+	}
 
-	igt_subtest("fence-restore-untiled-hibernate")
+	igt_subtest("fence-restore-untiled-hibernate") {
+		gem_require_mappable_ggtt(fd);
 		test_fence_restore(fd, false, true);
+	}

Afaict test_fence_restore() is intimately related with gtt and tiling. So skipping makes sense:

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#28 lore raw

PATCH 9/9 tests/gem_tiling_max_stride: Skip if set tiling is not supported

In reply to Ramalingam C

When mmapable aperture is not supported set tiling also not supported. Hence skip the test.

---
 tests/i915/gem_tiling_max_stride.c | 1 +
 1 file changed, 1 insertion(+)
tests/i915/gem_tiling_max_stride.c +1 -0
index 0e99d979f0ca..77f7223ba19b 100644
@@ -71,6 +71,7 @@ igt_simple_main
 	fd = drm_open_driver(DRIVER_INTEL);
 
 	devid = intel_get_drm_devid(fd);
+	gem_require_mappable_ggtt(fd);
 
 	if (intel_gen(devid) >= 7) {
 		stride = 256 * 1024;
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Acked-by on v1 9/9
#29 lore raw

Re: [igt-dev] [PATCH i-g-t 9/9] tests/gem_tiling_max_stride: Skip if set tiling is not supported

Quoted 13 lines · Ramalingam C

When mmapable aperture is not supported set tiling also not supported. Hence skip the test.

---
  tests/i915/gem_tiling_max_stride.c | 1 +
  1 file changed, 1 insertion(+)
tests/i915/gem_tiling_max_stride.c +0 -0
index 0e99d979f0ca..77f7223ba19b 100644

tests/i915/gem_tiling_max_stride.c igt_simple_main · line 74

Quoted 4 lines
tests/i915/gem_tiling_max_stride.c +1 -0
@@ -71,6 +71,7 @@ igt_simple_main
  	fd = drm_open_driver(DRIVER_INTEL);
 
  	devid = intel_get_drm_devid(fd);
+	gem_require_mappable_ggtt(fd);

AFAICT it would not work without tiled access.

tests/i915/gem_tiling_max_stride.c igt_simple_main

Quoted 4 lines
tests/i915/gem_tiling_max_stride.c +0 -0
  	if (intel_gen(devid) >= 7) {
  		stride = 256 * 1024;
 

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by
#30 lore raw

Re: [igt-dev] [PATCH i-g-t 9/9] tests/gem_tiling_max_stride: Skip if set tiling is not supported

Quoted 20 lines · Antonio Argenziano
Quoted 13 lines · Ramalingam C

When mmapable aperture is not supported set tiling also not supported. Hence skip the test.

---
  tests/i915/gem_tiling_max_stride.c | 1 +
  1 file changed, 1 insertion(+)
tests/i915/gem_tiling_max_stride.c +0 -0
index 0e99d979f0ca..77f7223ba19b 100644

tests/i915/gem_tiling_max_stride.c igt_simple_main · line 73

Quoted 3 lines
tests/i915/gem_tiling_max_stride.c +1 -0
@@ -71,6 +71,7 @@ igt_simple_main
 	fd = drm_open_driver(DRIVER_INTEL);
 		devid = intel_get_drm_devid(fd);
+	gem_require_mappable_ggtt(fd);

AFAICT it would not work without tiled access.

Quoted 1 line

Agreed:

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#31 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Handling mmap_gtt

In reply to Ramalingam C
== Series Details ==

== Series Details ==

Series: Handling mmap_gtt
URL : https://patchwork.freedesktop.org/series/72837/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7853 -> IGTPW_4065
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/index.html

Known issues
------------

Here are the changes found in IGTPW_4065 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][1] -> [FAIL][2] ([i915#178])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-skl-6770hq/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/fi-skl-6770hq/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [PASS][3] -> [DMESG-FAIL][4] ([i915#563])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-ivb-3770: [PASS][5] -> [DMESG-FAIL][6] ([i915#770])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-ivb-3770/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/fi-ivb-3770/igt@i915_selftest@live_blt.html

* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8700k: [PASS][7] -> [INCOMPLETE][8] ([i915#424])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html

#### Possible fixes ####

* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [TIMEOUT][9] ([fdo#112271] / [i915#1084] / [i915#816]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-byt-j1900/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/fi-byt-j1900/igt@[email protected]
- fi-byt-n2820: [TIMEOUT][11] ([fdo#112271] / [i915#1084] / [i915#816]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-byt-n2820/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/fi-byt-n2820/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][13] ([i915#563]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-hsw-4770/igt@i915_selftest@live_blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/fi-hsw-4770/igt@i915_selftest@live_blt.html

* igt@i915_selftest@live_execlists:
- fi-icl-y: [DMESG-FAIL][15] ([fdo#108569]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-icl-y/igt@i915_selftest@live_execlists.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/fi-icl-y/igt@i915_selftest@live_execlists.html

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][17] ([fdo#111096] / [i915#323]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-kbl-7500u/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/fi-kbl-7500u/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [FAIL][19] ([i915#579]) -> [SKIP][20] ([fdo#109271])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-kbl-guc/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/fi-kbl-guc/igt@[email protected]

[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816

Participating hosts (47 -> 46)
------------------------------

Additional (5): fi-gdg-551 fi-cfl-8109u fi-skl-6600u fi-skl-6700k2 fi-snb-2600
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5409 -> IGTPW_4065

CI-20190529: 20190529
CI_DRM_7853: 1df04205c16923e525efe9c26d6e98612d38c9b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4065: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/index.html
IGT_5409: 93aefe6baa3fabf8c0cabe83e185f7b8f8d8753d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#32 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for Handling mmap_gtt

In reply to Ramalingam C
== Series Details ==

== Series Details ==

Series: Handling mmap_gtt
URL : https://patchwork.freedesktop.org/series/72837/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7853_full -> IGTPW_4065_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4065_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4065_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4065_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-iclb: [PASS][1] -> [SKIP][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb7/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4065_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@idempotent:
- shard-tglb: [PASS][3] -> [SKIP][4] ([fdo#112179] / [i915#1099])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-tglb3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-tglb7/igt@[email protected]
- shard-apl: [PASS][5] -> [SKIP][6] ([fdo#109271] / [i915#1099])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-apl1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-apl3/igt@[email protected]
- shard-glk: [PASS][7] -> [SKIP][8] ([fdo#109271] / [i915#1099])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-glk9/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-glk7/igt@[email protected]
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112179] / [i915#1099])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb5/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb1/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-chain-bsd2:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb8/igt@[email protected]

* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#112146]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb2/igt@[email protected]

* igt@gem_partial_pwrite_pread@reads-snoop:
- shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#110789] / [i915#478])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-snb5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-snb5/igt@[email protected]

* igt@i915_pm_rps@reset:
- shard-iclb: [PASS][17] -> [FAIL][18] ([i915#413]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [PASS][19] -> [INCOMPLETE][20] ([i915#61]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-hsw7/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-hsw5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-apl8/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-apl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-slowdraw:
- shard-tglb: [PASS][23] -> [SKIP][24] ([i915#668]) +5 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-tglb8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-tglb2/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_gtt.html

* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#112080]) +10 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb7/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [DMESG-WARN][29] ([i915#180]) -> [PASS][30] +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-apl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-apl8/igt@[email protected]

* {igt@gem_ctx_persistence@hang}:
- shard-tglb: [SKIP][31] ([i915#1099]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-tglb3/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-tglb6/igt@[email protected]
- shard-iclb: [SKIP][33] ([i915#1099]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb7/igt@[email protected]

* igt@gem_ctx_persistence@processes:
- shard-apl: [SKIP][35] ([fdo#109271] / [i915#1099]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-apl7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-apl2/igt@[email protected]
- shard-iclb: [SKIP][37] ([fdo#112179] / [i915#1099]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb3/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb5/igt@[email protected]
- shard-glk: [SKIP][39] ([fdo#109271] / [i915#1099]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-glk1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-glk4/igt@[email protected]
- shard-tglb: [SKIP][41] ([fdo#112179] / [i915#1099]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-tglb3/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-tglb5/igt@[email protected]

* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][43] ([fdo#112080]) -> [PASS][44] +12 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [SKIP][45] ([fdo#109276]) -> [PASS][46] +23 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [SKIP][47] ([i915#677]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb3/igt@[email protected]

* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][49] ([fdo#112146]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb3/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][51] ([i915#454]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb7/igt@[email protected]

* igt@kms_busy@basic-flip-pipe-a:
- shard-tglb: [DMESG-WARN][53] ([i915#402]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-tglb3/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-tglb7/igt@[email protected]

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-pipe-b:
- shard-glk: [INCOMPLETE][55] ([CI#80] / [i915#58] / [k.org#198133]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-glk5/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-glk3/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled:
- shard-glk: [FAIL][57] ([i915#52] / [i915#54]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-glk4/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-glk5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-gtt:
- shard-snb: [DMESG-WARN][59] ([i915#478]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-snb6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-snb4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-kbl4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-kbl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-tglb: [SKIP][63] ([i915#668]) -> [PASS][64] +14 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-tglb3/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-tglb2/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb1/igt@kms_psr@psr2_sprite_plane_onoff.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html

#### Warnings ####

* igt@runner@aborted:
- shard-snb: ([FAIL][67], [FAIL][68], [FAIL][69], [FAIL][70], [FAIL][71], [FAIL][72], [FAIL][73], [FAIL][74]) ([fdo#111870] / [i915#1077] / [i915#698]) -> ([FAIL][75], [FAIL][76], [FAIL][77], [FAIL][78], [FAIL][79], [FAIL][80], [FAIL][81], [FAIL][82]) ([fdo#111870] / [i915#1077])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-snb5/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-snb4/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-snb6/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-snb2/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-snb5/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-snb6/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-snb2/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-snb2/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-snb6/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-snb5/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-snb1/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-snb6/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-snb5/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-snb1/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-snb5/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/shard-snb2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112179]: https://bugs.freedesktop.org/show_bug.cgi?id=112179
[i915#1077]: https://gitlab.freedesktop.org/drm/intel/issues/1077
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#698]: https://gitlab.freedesktop.org/drm/intel/issues/698
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5409 -> IGTPW_4065
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_7853: 1df04205c16923e525efe9c26d6e98612d38c9b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4065: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/index.html
IGT_5409: 93aefe6baa3fabf8c0cabe83e185f7b8f8d8753d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4065/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev