Skip to contentSkip to conversation

fstests: btrfs/153: Remove it from auto group

PATCH In review Qu Wenruo 3 participants 5 messages Jan 14, 2020 – Feb 1, 2020 Btrfs file system

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/1 fstests: btrfs/153: Remove it from auto group

This test case always fail after commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to").
As btrfs no longer checks nodatacow at buffered write time.

That commits brings in a big performance enhancement, as that check is not cheap, but breaks qgroup, as write into preallocated space now needs extra space.

There isn't yet a good solution (reverting that patch is not possible, and only check nodatacow for quota enabled case is very bug prune due to quite a lot code change).

We may solve it using the new ticketed space reservation facility, but that won't come into fruit anytime soon.

So let's just remove that test case from 'auto' group, but still keep the test case to inform we still have a lot of work to do.

---
 tests/btrfs/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/btrfs/group +1 -1
index 697b6a38ea00..3c554a194742 100644
@@ -155,7 +155,7 @@
 150 auto quick dangerous
 151 auto quick volume
 152 auto quick metadata qgroup send
-153 auto quick qgroup limit
+153 quick qgroup limit
 154 auto quick volume
 155 auto quick send
 156 auto quick trim
Signature · 1 line
2.24.1
#1 lore raw
Quoted 12 lines · Qu Wenruo

This test case always fail after commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to").
As btrfs no longer checks nodatacow at buffered write time.

That commits brings in a big performance enhancement, as that check is not cheap, but breaks qgroup, as write into preallocated space now needs extra space.

There isn't yet a good solution (reverting that patch is not possible, and only check nodatacow for quota enabled case is very bug prune due to quite a lot code change).

Quoted 7 lines

We may solve it using the new ticketed space reservation facility, but that won't come into fruit anytime soon.

So let's just remove that test case from 'auto' group, but still keep the test case to inform we still have a lot of work to do.

I'd like to see an ACK from btrfs folks. Thanks!

Eryu

Quoted 20 lines
---
 tests/btrfs/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/btrfs/group +1 -1
index 697b6a38ea00..3c554a194742 100644
@@ -155,7 +155,7 @@
 150 auto quick dangerous
 151 auto quick volume
 152 auto quick metadata qgroup send
-153 auto quick qgroup limit
+153 quick qgroup limit
 154 auto quick volume
 155 auto quick send
 156 auto quick trim
Signature · 1 line
2.24.1
#2 lore raw
Quoted 30 lines · Eryu Guan
Quoted 12 lines · Qu Wenruo

This test case always fail after commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to").
As btrfs no longer checks nodatacow at buffered write time.

That commits brings in a big performance enhancement, as that check is not cheap, but breaks qgroup, as write into preallocated space now needs extra space.

There isn't yet a good solution (reverting that patch is not possible, and only check nodatacow for quota enabled case is very bug prune due to quite a lot code change).

Quoted 7 lines

We may solve it using the new ticketed space reservation facility, but that won't come into fruit anytime soon.

So let's just remove that test case from 'auto' group, but still keep the test case to inform we still have a lot of work to do.

I'd like to see an ACK from btrfs folks. Thanks!

Eryu

Quoted 4 lines
---
 tests/btrfs/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

tests/btrfs/group line 158

Quoted 10 lines
tests/btrfs/group +1 -1
index 697b6a38ea00..3c554a194742 100644
@@ -155,7 +155,7 @@
 150 auto quick dangerous
 151 auto quick volume
 152 auto quick metadata qgroup send
-153 auto quick qgroup limit
+153 quick qgroup limit

Hmm, if removing from auto it might make sense to also remove it from quick, because people often use quick as a sanity regression group.

The issue at hand is a recurring pattern.
It is also been discussed recently about generic/484:
https://lore.kernel.org/fstests/[email protected]/

I also handled something like this with:
fdb69864 overlay/061: remove from auto and quick groups

I suggest adding a group 'broken' to mark known/wontfix issues then a default regression test could run -g auto -x broken or -g quick -x broken for a quick regression sanity.

Thoughts?

Amir.

author
#3 lore raw
Quoted 31 lines · Amir Goldstein
Quoted 30 lines · Eryu Guan
Quoted 12 lines · Qu Wenruo

This test case always fail after commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to").
As btrfs no longer checks nodatacow at buffered write time.

That commits brings in a big performance enhancement, as that check is not cheap, but breaks qgroup, as write into preallocated space now needs extra space.

There isn't yet a good solution (reverting that patch is not possible, and only check nodatacow for quota enabled case is very bug prune due to quite a lot code change).

Quoted 7 lines

We may solve it using the new ticketed space reservation facility, but that won't come into fruit anytime soon.

So let's just remove that test case from 'auto' group, but still keep the test case to inform we still have a lot of work to do.

I'd like to see an ACK from btrfs folks. Thanks!

Eryu

Quoted 4 lines
---
 tests/btrfs/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines
Quoted 10 lines

tests/btrfs/group line 158

Quoted 10 lines
tests/btrfs/group +1 -1
index 697b6a38ea00..3c554a194742 100644
@@ -155,7 +155,7 @@
 150 auto quick dangerous
 151 auto quick volume
 152 auto quick metadata qgroup send
-153 auto quick qgroup limit
+153 quick qgroup limit

Hmm, if removing from auto it might make sense to also remove it from quick, because people often use quick as a sanity regression group.

That's also one of my concern.

However recently I tend to run more same VMs on different ranges of fstests to speed up the testing progress other than using 'quick' group.

Anyway this depends on the end users (QA and developers).

Quoted 11 lines

The issue at hand is a recurring pattern.
It is also been discussed recently about generic/484:
https://lore.kernel.org/fstests/[email protected]/

I also handled something like this with:
fdb69864 overlay/061: remove from auto and quick groups

I suggest adding a group 'broken' to mark known/wontfix issues then a default regression test could run -g auto -x broken or -g quick -x broken for a quick regression sanity.

That's much better.

Just one question, if a test is in both quick and broken group, will -g quick -x broken still exclude it?

Thanks,
Qu

Quoted 5 lines

Thoughts?

Amir.

#4 lore raw
Quoted 64 lines · Qu Wenruo
Quoted 31 lines · Amir Goldstein
Quoted 30 lines · Eryu Guan
Quoted 12 lines · Qu Wenruo

This test case always fail after commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to").
As btrfs no longer checks nodatacow at buffered write time.

That commits brings in a big performance enhancement, as that check is not cheap, but breaks qgroup, as write into preallocated space now needs extra space.

There isn't yet a good solution (reverting that patch is not possible, and only check nodatacow for quota enabled case is very bug prune due to quite a lot code change).

Quoted 7 lines

We may solve it using the new ticketed space reservation facility, but that won't come into fruit anytime soon.

So let's just remove that test case from 'auto' group, but still keep the test case to inform we still have a lot of work to do.

I'd like to see an ACK from btrfs folks. Thanks!

Eryu

Quoted 4 lines
---
 tests/btrfs/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines
Quoted 10 lines

tests/btrfs/group line 158

Quoted 10 lines
tests/btrfs/group +1 -1
index 697b6a38ea00..3c554a194742 100644
@@ -155,7 +155,7 @@
 150 auto quick dangerous
 151 auto quick volume
 152 auto quick metadata qgroup send
-153 auto quick qgroup limit
+153 quick qgroup limit

Hmm, if removing from auto it might make sense to also remove it from quick, because people often use quick as a sanity regression group.

That's also one of my concern.

However recently I tend to run more same VMs on different ranges of fstests to speed up the testing progress other than using 'quick' group.

Anyway this depends on the end users (QA and developers).

Quoted 8 lines

The issue at hand is a recurring pattern.
It is also been discussed recently about generic/484:
https://lore.kernel.org/fstests/[email protected]/

I also handled something like this with:
fdb69864 overlay/061: remove from auto and quick groups

Quoted 9 lines
Quoted 3 lines

I suggest adding a group 'broken' to mark known/wontfix issues then a default regression test could run -g auto -x broken or -g quick -x broken for a quick regression sanity.

That's much better.

Just one question, if a test is in both quick and broken group, will -g quick -x broken still exclude it?

Yes.
That is the main use case for -x. Often used with -x dangerous.

What we don't have, AFAIK, is the ability to request 'auto && quick'.

Thanks,
Amir.