Skip to contentSkip to conversation

MAINTAINERS: add TRACE EVENT LIBRARY section

RFC PATCH In review Lukas Bulwahn 5 participants 8 messages Feb 1, 2020 – Jul 1, 2020

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 MAINTAINERS: add TRACE EVENT LIBRARY section

The git history shows that the files under ./tools/lib/traceevent/ are being developed and maintained by Tzetomir Stoyanov and Steven Rostedt and are discussed on the linux-trace-devel list.

Add a suitable section in MAINTAINERS for patches to reach them.

This was identified with a small script that finds all files only belonging to "THE REST" according to the current MAINTAINERS file, and I acted upon its output.

---
Ceco, Steven, I added the information based on what I could see from an outsider view. Please change and more files to the entry if needed.

applies cleanly on current master and next-20200131

Ceco, congrats becoming a kernel maintainer :)

 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)
MAINTAINERS +7 -0
index 1f77fb8cdde3..17eb358c3fda 100644
@@ -16903,6 +16903,13 @@ T:	git git://git.infradead.org/users/jjs/linux-tpmdd.git
 S:	Maintained
 F:	drivers/char/tpm/
 
+TRACE EVENT LIBRARY
+M:	Tzvetomir Stoyanov <[email protected]>
+M:	Steven Rostedt <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	tools/lib/traceevent/
+
 TRACING
 M:	Steven Rostedt <[email protected]>
 M:	Ingo Molnar <[email protected]>
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Sat, 1 Feb 2020 17:19:31 +0100 Lukas Bulwahn <[email protected]>…

The git history shows that the files under ./tools/lib/traceevent/ are being developed and maintained by Tzetomir Stoyanov and Steven Rostedt and are discussed on the linux-trace-devel list.

Add a suitable section in MAINTAINERS for patches to reach them.

This was identified with a small script that finds all files only belonging to "THE REST" according to the current MAINTAINERS file, and I acted upon its output.

Thanks Lukas!

Arnaldo, would you like to take this?

-- Steve

Quoted 31 lines

---
Ceco, Steven, I added the information based on what I could see from an outsider view. Please change and more files to the entry if needed.

applies cleanly on current master and next-20200131

Ceco, congrats becoming a kernel maintainer :)

 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)
MAINTAINERS +7 -0
index 1f77fb8cdde3..17eb358c3fda 100644
@@ -16903,6 +16903,13 @@ T:	git git://git.infradead.org/users/jjs/linux-tpmdd.git
 S:	Maintained
 F:	drivers/char/tpm/
 
+TRACE EVENT LIBRARY
+M:	Tzvetomir Stoyanov <[email protected]>
+M:	Steven Rostedt <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	tools/lib/traceevent/
+
 TRACING
 M:	Steven Rostedt <[email protected]>
 M:	Ingo Molnar <[email protected]>
#2 lore raw

Em Sat, Feb 01, 2020 at 01:14:53PM -0500, Steven Rostedt escreveu:

Quoted 13 lines
Quoted 9 lines · On Sat, 1 Feb 2020 17:19:31 +0100 Lukas Bulwahn <[email protected]>…

The git history shows that the files under ./tools/lib/traceevent/ are being developed and maintained by Tzetomir Stoyanov and Steven Rostedt and are discussed on the linux-trace-devel list.

Add a suitable section in MAINTAINERS for patches to reach them.

This was identified with a small script that finds all files only belonging to "THE REST" according to the current MAINTAINERS file, and I acted upon its output.

Quoted 5 lines

Thanks Lukas!

Arnaldo, would you like to take this?

Sure

Quoted 34 lines

-- Steve

Quoted 31 lines

---
Ceco, Steven, I added the information based on what I could see from an outsider view. Please change and more files to the entry if needed.

applies cleanly on current master and next-20200131

Ceco, congrats becoming a kernel maintainer :)

 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)
MAINTAINERS +7 -0
index 1f77fb8cdde3..17eb358c3fda 100644
@@ -16903,6 +16903,13 @@ T:	git git://git.infradead.org/users/jjs/linux-tpmdd.git
 S:	Maintained
 F:	drivers/char/tpm/
 
+TRACE EVENT LIBRARY
+M:	Tzvetomir Stoyanov <[email protected]>
+M:	Steven Rostedt <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	tools/lib/traceevent/
+
 TRACING
 M:	Steven Rostedt <[email protected]>
 M:	Ingo Molnar <[email protected]>
Signature · 1 line
- Arnaldo
#3 lore raw
Quoted 15 lines · Arnaldo Carvalho de Melo

Em Sat, Feb 01, 2020 at 01:14:53PM -0500, Steven Rostedt escreveu:

Quoted 13 lines
Quoted 9 lines · On Sat, 1 Feb 2020 17:19:31 +0100 Lukas Bulwahn <[email protected]>…

The git history shows that the files under ./tools/lib/traceevent/ are being developed and maintained by Tzetomir Stoyanov and Steven Rostedt and are discussed on the linux-trace-devel list.

Add a suitable section in MAINTAINERS for patches to reach them.

This was identified with a small script that finds all files only belonging to "THE REST" according to the current MAINTAINERS file, and I acted upon its output.

Quoted 8 lines
Quoted 5 lines

Thanks Lukas!

Arnaldo, would you like to take this?

Sure

Arnaldo, I think you never picked this patch and it did not make it into mainline. I checked that the patch still applies to the current master, so maybe you can pick it now. It is a minor non-urgent patch and cannot break any builds :)

Thanks,

Lukas

#4 lore raw
In reply to Lukas Bulwahn
Quoted 11 lines · Lukas Bulwahn

The git history shows that the files under ./tools/lib/traceevent/ are being developed and maintained by Tzetomir Stoyanov and Steven Rostedt and are discussed on the linux-trace-devel list.

Add a suitable section in MAINTAINERS for patches to reach them.

This was identified with a small script that finds all files only belonging to "THE REST" according to the current MAINTAINERS file, and I acted upon its output.

Quoted 9 lines

---
Ceco, Steven, I added the information based on what I could see from an outsider view. Please change and more files to the entry if needed.

applies cleanly on current master and next-20200131

Ceco, congrats becoming a kernel maintainer :)

Thanks, Lukas!

Quoted 24 lines
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)
MAINTAINERS +7 -1
index 1f77fb8cdde3..17eb358c3fda 100644
@@ -16903,6 +16903,13 @@ T:     git git://git.infradead.org/users/jjs/linux-tpmdd.git
 S:     Maintained
 F:     drivers/char/tpm/
 
+TRACE EVENT LIBRARY
+M:     Tzvetomir Stoyanov <[email protected]>
+M:     Steven Rostedt <[email protected]>
+L:     [email protected]
+S:     Maintained
+F:     tools/lib/traceevent/
+
 TRACING
 M:     Steven Rostedt <[email protected]>
 M:     Ingo Molnar <[email protected]>
--

2.17.1

Signature · 2 lines
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center
#5 lore raw
In reply to Lukas Bulwahn
Quoted 11 lines · Lukas Bulwahn

The git history shows that the files under ./tools/lib/traceevent/ are being developed and maintained by Tzetomir Stoyanov and Steven Rostedt and are discussed on the linux-trace-devel list.

Add a suitable section in MAINTAINERS for patches to reach them.

This was identified with a small script that finds all files only belonging to "THE REST" according to the current MAINTAINERS file, and I acted upon its output.

MAINTAINERS T: git git://git.infradead.org/users/jjs/linux-tpmdd.git · line 16911

Quoted 6 lines
MAINTAINERS +6 -0
+TRACE EVENT LIBRARY
+M:     Tzvetomir Stoyanov <[email protected]>
+M:     Steven Rostedt <[email protected]>
+L:     [email protected]
+S:     Maintained
+F:     tools/lib/traceevent/

Don't forget to run early mentioned scripts (in some other threads).

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw
Quoted 12 lines · Andy Shevchenko
Quoted 10 lines · Lukas Bulwahn

The git history shows that the files under ./tools/lib/traceevent/ are being developed and maintained by Tzetomir Stoyanov and Steven Rostedt and are discussed on the linux-trace-devel list.

Add a suitable section in MAINTAINERS for patches to reach them.

This was identified with a small script that finds all files only belonging to "THE REST" according to the current MAINTAINERS file, and I acted upon its output.

Quoted 9 lines

MAINTAINERS T: git git://git.infradead.org/users/jjs/linux-tpmdd.git · line 16911

Quoted 6 lines
MAINTAINERS +6 -0
+TRACE EVENT LIBRARY
+M:     Tzvetomir Stoyanov <[email protected]>
+M:     Steven Rostedt <[email protected]>
+L:     [email protected]
+S:     Maintained
+F:     tools/lib/traceevent/

Don't forget to run early mentioned scripts (in some other threads).

Andy, I did run on next-20200203:

$ ./scripts/checkpatch.pl -f MAINTAINERS

WARNING: MAINTAINERS entries use one tab after TYPE:
#14607: FILE: MAINTAINERS:14607:
+M: Micah Morton <[email protected]>

WARNING: MAINTAINERS entries use one tab after TYPE:
#14608: FILE: MAINTAINERS:14608:
+S: Supported

WARNING: MAINTAINERS entries use one tab after TYPE:
#14609: FILE: MAINTAINERS:14609:
+F: security/safesetid/

WARNING: MAINTAINERS entries use one tab after TYPE:
#14610: FILE: MAINTAINERS:14610:
+F: Documentation/admin-guide/LSM/SafeSetID.rst

total: 0 errors, 4 warnings, 18577 lines checked

That issue in MAINTAINERS has a pending patch since 2019-12-07, with three attempts of asking to be picked up by now:

- https://lore.kernel.org/lkml/[email protected]/
- https://lore.kernel.org/lkml/[email protected]/
- https://lore.kernel.org/lkml/[email protected]/

It is not related to this patch in MAINTAINERS here.

I also ran $ perl ./scripts/parse-maintainers.pl and checked the generated diff for this entry, but there was no reordering required; a one-element list of F: entries is difficult to get unsorted ;)

I am not adding any mess (ordering issues) to MAINTAINERS with this patch, other than what is already there, but cleaning that up is completely other story.

Lukas

#7 lore raw
Quoted 27 lines · Lukas Bulwahn
Quoted 12 lines · Andy Shevchenko
Quoted 10 lines · Lukas Bulwahn

The git history shows that the files under ./tools/lib/traceevent/ are being developed and maintained by Tzetomir Stoyanov and Steven Rostedt and are discussed on the linux-trace-devel list.

Add a suitable section in MAINTAINERS for patches to reach them.

This was identified with a small script that finds all files only belonging to "THE REST" according to the current MAINTAINERS file, and I acted upon its output.

Quoted 9 lines

MAINTAINERS T: git git://git.infradead.org/users/jjs/linux-tpmdd.git · line 16911

Quoted 6 lines
MAINTAINERS +6 -0
+TRACE EVENT LIBRARY
+M:     Tzvetomir Stoyanov <[email protected]>
+M:     Steven Rostedt <[email protected]>
+L:     [email protected]
+S:     Maintained
+F:     tools/lib/traceevent/

Don't forget to run early mentioned scripts (in some other threads).

Quoted 1 line

Andy, I did run on next-20200203:

Awesome, thanks!

Quoted 38 lines
$ ./scripts/checkpatch.pl -f MAINTAINERS

WARNING: MAINTAINERS entries use one tab after TYPE:
#14607: FILE: MAINTAINERS:14607:
+M: Micah Morton <[email protected]>

WARNING: MAINTAINERS entries use one tab after TYPE:
#14608: FILE: MAINTAINERS:14608:
+S: Supported

WARNING: MAINTAINERS entries use one tab after TYPE:
#14609: FILE: MAINTAINERS:14609:
+F: security/safesetid/

WARNING: MAINTAINERS entries use one tab after TYPE:
#14610: FILE: MAINTAINERS:14610:
+F: Documentation/admin-guide/LSM/SafeSetID.rst

total: 0 errors, 4 warnings, 18577 lines checked

That issue in MAINTAINERS has a pending patch since 2019-12-07, with three attempts of asking to be picked up by now:

- https://lore.kernel.org/lkml/[email protected]/
- https://lore.kernel.org/lkml/[email protected]/
- https://lore.kernel.org/lkml/[email protected]/

It is not related to this patch in MAINTAINERS here.

I also ran $ perl ./scripts/parse-maintainers.pl and checked the generated diff for this entry, but there was no reordering required; a one-element list of F: entries is difficult to get unsorted ;)

I am not adding any mess (ordering issues) to MAINTAINERS with this patch, other than what is already there, but cleaning that up is completely other story.

Signature · 2 lines
With Best Regards,
Andy Shevchenko