RISC-V: unbreak built-in dtb
PATCH 1/1 RISC-V: unbreak built-in dtb
The commit c5d38e92010174 ("lds: Add and use RO_DATA_SECTION macro") consolidates all RO sections link script declaration in the single RO_DATA_SECTION macro. So all all individual RO section declarations have to be removed from per-arch linker scripts.
Alas the BAREBOX_CLK_TABLE and the BAREBOX_DTB link script sections were not removed from RISC-V linker script making these sections declared twice. As a result incorrect __clk_of_table_start and __dtb_start addresses are passed to the barebox code therefore the RISC-V barebox is completely unusable.
--- arch/riscv/lib/barebox.lds.S | 4 ---- 1 file changed, 4 deletions(-)
arch/riscv/lib/barebox.lds.S +0 -4
@@ -48,10 +48,6 @@ SECTIONS .rela.dyn : { *(.rela*) } - .oftables : { BAREBOX_CLK_TABLE } - - .dtb : { BAREBOX_DTB } - _edata = .; . = ALIGN(8); __bss_start = .;
Signature · 7 lines
2.25.0 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Sascha Hauer
AppliedQuoted 11 lines · Antony Pavlov
The commit
c5d38e92010174("lds: Add and useRO_DATA_SECTIONmacro") consolidates all RO sections link script declaration in the singleRO_DATA_SECTIONmacro. So all all individual RO section declarations have to be removed from per-arch linker scripts.Alas the
BAREBOX_CLK_TABLEand theBAREBOX_DTBlink script sections were not removed from RISC-V linker script making these sections declared twice. As a result incorrect__clk_of_table_startand__dtb_startaddresses are passed to the barebox code therefore the RISC-V barebox is completely unusable.
Quoted 4 lines
Signed-off-by Antony Pavlov <[email protected]>--- arch/riscv/lib/barebox.lds.S | 4 ---- 1 file changed, 4 deletions(-)
Applied, thanks
Sascha
Signature · 9 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox