Skip to contentSkip to conversation

RDMA/vmw_pvrdma: Disable PCI device on error

PATCH Adit Ranadive 2 participants 2 messages Feb 3, 2020 1 message not in the archive InfiniBand

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Adit Ranadive

author Acked-by
#1 lore raw
Quoted 16 lines · On 2/3/20 10:37 AM, "Yuval Shaia yuval.shaia.ml"@gmail.com wrote:

From: Yuval Shaia <[email protected]>

We need to disable the PCI device on any error happen after we enable the device.

---
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c +0 -0
index e580ae9cc55a..780fd2dfc07e 100644

drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c static int pvrdma_pci_probe(struct pci_dev *pdev, · line 835

Quoted 8 lines
drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c +1 -1
@@ -829,7 +829,7 @@ static int pvrdma_pci_probe(struct pci_dev *pdev,
 	    !(pci_resource_flags(pdev, 1) & IORESOURCE_MEM)) {
 		dev_err(&pdev->dev, "PCI BAR region not MMIO\n");
 		ret = -ENOMEM;
-		goto err_free_device;
+		goto err_disable_pdev;
 	}
 
 	ret = pci_request_regions(pdev, DRV_NAME);

Looks fine to me. Please add a Fixes tag and cc stable.

#2 lore raw
In reply to a message not in the archive
Quoted 8 lines · On Mon, Feb 03, 2020 at 08:37:36PM +0200, [email protected]…

From: Yuval Shaia <[email protected]>

We need to disable the PCI device on any error happen after we enable the device.

 drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Lets have fixes lines for this and the other patch please

Jason