Skip to contentSkip to conversation

staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621

PATCH In review Chuanhong Guo 3 participants 6 messages Feb 4, 2020 – Feb 9, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621

There are 3 uarts on mt7621. This patch adds device tree node for 2nd and 2rd ones.

---
 drivers/staging/mt7621-dts/mt7621.dtsi | 38 ++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
drivers/staging/mt7621-dts/mt7621.dtsi +38 -0
index d89d68ffa7bc..cee23710d03b 100644
@@ -166,6 +166,44 @@ uartlite: uartlite@c00 {
 			no-loopback-test;
 		};
 
+		uartlite2: uartlite@d00 {
+			compatible = "ns16550a";
+			reg = <0xd00 0x100>;
+
+			clock-frequency = <50000000>;
+
+			interrupt-parent = <&gic>;
+			interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>;
+
+			reg-shift = <2>;
+			reg-io-width = <4>;
+			no-loopback-test;
+
+			status = "disabled";
+
+			pinctrl-names = "default";
+			pinctrl-0 = <&uart2_pins>;
+		};
+
+		uartlite3: uartlite@e00 {
+			compatible = "ns16550a";
+			reg = <0xe00 0x100>;
+
+			clock-frequency = <50000000>;
+
+			interrupt-parent = <&gic>;
+			interrupts = <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>;
+
+			reg-shift = <2>;
+			reg-io-width = <4>;
+			no-loopback-test;
+
+			status = "disabled";
+
+			pinctrl-names = "default";
+			pinctrl-0 = <&uart3_pins>;
+		};
+
 		spi0: spi@b00 {
 			status = "disabled";
 
Signature · 1 line
2.24.1
#1 lore raw

Please use ./scripts/get_maintainer.pl to pick the CC list and resend.

The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and a couple other email lists.

regards,
dan carpenter

#2 lore raw

Hi!

Quoted 5 lines · Dan Carpenter

Please use ./scripts/get_maintainer.pl to pick the CC list and resend.

The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and a couple other email lists.

According to get_maintainer.pl, Matthias Brugger is the maintainer of Mediatek ARM SoC:

Matthias Brugger <[email protected]> (maintainer:ARM/Mediatek SoC support) [email protected] (moderated list:ARM/Mediatek SoC support) [email protected] (moderated list:ARM/Mediatek SoC support)

I specifically removed the above 3 addresses because they are all for Mediatek ARM chips
while mt7621 is a mips chip and belongs to ralink target under /arch/mips/mach-ralink.
Code contribution for mt7621 goes through linux-mips instead of linux-arm or linux-mediatek,

I thinks this is an incorrect setup of get_maintainer.pl and should be corrected.

Regards,
Chuanhong Guo

#3 lore raw
Quoted 16 lines · Chuanhong Guo

Hi!

Quoted 5 lines · Dan Carpenter

Please use ./scripts/get_maintainer.pl to pick the CC list and resend.

The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and a couple other email lists.

According to get_maintainer.pl, Matthias Brugger is the maintainer of Mediatek ARM SoC:

Matthias Brugger <[email protected]> (maintainer:ARM/Mediatek SoC support) [email protected] (moderated list:ARM/Mediatek SoC support) [email protected] (moderated list:ARM/Mediatek SoC support)

Quoted 6 lines

I specifically removed the above 3 addresses because they are all for Mediatek ARM chips
while mt7621 is a mips chip and belongs to ralink target under /arch/mips/mach-ralink.
Code contribution for mt7621 goes through linux-mips instead of linux-arm or linux-mediatek,

I would have thought that we would still CC linux-mediatek?

Quoted 3 lines

I thinks this is an incorrect setup of get_maintainer.pl and should be corrected.

We could ask him...

It's always easiest to fix MAINTAINERS instead of remembering all the exceptions and rules.

regards,
dan carpenter

#4 lore raw

Are people from linux-mediatek also interested in Mediatek MIPS SoCs? [Was: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621]

Quoted 28 lines · Dan Carpenter
Quoted 16 lines · Chuanhong Guo

Hi!

Quoted 5 lines · Dan Carpenter

Please use ./scripts/get_maintainer.pl to pick the CC list and resend.

The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and a couple other email lists.

According to get_maintainer.pl, Matthias Brugger is the maintainer of Mediatek ARM SoC:

Matthias Brugger <[email protected]> (maintainer:ARM/Mediatek SoC support) [email protected] (moderated list:ARM/Mediatek SoC support) [email protected] (moderated list:ARM/Mediatek SoC support)

Quoted 6 lines

I specifically removed the above 3 addresses because they are all for Mediatek ARM chips
while mt7621 is a mips chip and belongs to ralink target under /arch/mips/mach-ralink.
Code contribution for mt7621 goes through linux-mips instead of linux-arm or linux-mediatek,

I would have thought that we would still CC linux-mediatek?

Quoted 1 line
Quoted 7 lines
Quoted 2 lines

I thinks this is an incorrect setup of get_maintainer.pl and should be corrected.

We could ask him...

It's always easiest to fix MAINTAINERS instead of remembering all the exceptions and rules.

Hi Matthias and other folks on linux-mediatek:

I noticed that get_maintainers.pl reports "ARM/Mediatek SoC support" e-mail addreses for MTK MIPS SoCs (mt7620/mt7621/mt76x8) because of "mt[678]" name match in MAINTAINERS file.
This is confusing because these MIPS SoCs clearly don't fall into "ARM" category. Is this an incorrect match or is it intentional? If it's intentional I think we should remove the confusing ARM prefix, and if it's incorrect we may need to figure out how to exclude mt7620/mt7621/mt76x8 from "ARM/Mediatek SoC support".

Regards,
Chuanhong Guo

maintainer
#5 lore raw

Re: Are people from linux-mediatek also interested in Mediatek MIPS SoCs? [Was: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621]

Quoted 39 lines · Chuanhong Guo
Quoted 28 lines · Dan Carpenter
Quoted 16 lines · Chuanhong Guo

Hi!

Quoted 5 lines · Dan Carpenter

Please use ./scripts/get_maintainer.pl to pick the CC list and resend.

The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and a couple other email lists.

According to get_maintainer.pl, Matthias Brugger is the maintainer of Mediatek ARM SoC:

Matthias Brugger <[email protected]> (maintainer:ARM/Mediatek SoC support) [email protected] (moderated list:ARM/Mediatek SoC support) [email protected] (moderated list:ARM/Mediatek SoC support)

Quoted 6 lines

I specifically removed the above 3 addresses because they are all for Mediatek ARM chips
while mt7621 is a mips chip and belongs to ralink target under /arch/mips/mach-ralink.
Code contribution for mt7621 goes through linux-mips instead of linux-arm or linux-mediatek,

I would have thought that we would still CC linux-mediatek?

Quoted 1 line
Quoted 7 lines
Quoted 2 lines

I thinks this is an incorrect setup of get_maintainer.pl and should be corrected.

We could ask him...

It's always easiest to fix MAINTAINERS instead of remembering all the exceptions and rules.

Hi Matthias and other folks on linux-mediatek:

Quoted 9 lines

I noticed that get_maintainers.pl reports "ARM/Mediatek SoC support" e-mail addreses for MTK MIPS SoCs (mt7620/mt7621/mt76x8) because of "mt[678]" name match in MAINTAINERS file.
This is confusing because these MIPS SoCs clearly don't fall into "ARM" category. Is this an incorrect match or is it intentional? If it's intentional I think we should remove the confusing ARM prefix, and if it's incorrect we may need to figure out how to exclude mt7620/mt7621/mt76x8 from "ARM/Mediatek SoC support".

That's a good question. I think it's an accident as I don't have good knowledge of the MIPS architecture. Also I try to track the upstream support for MIPS as well:
https://mtk.bcnfs.org/doku.php?id=linux_mainline_effort

Regards,
Matthias