Skip to contentSkip to conversation

package/python-imutils: new package

PATCH Superseded Aalx 3 participants 5 messages Aug 2, 2019 – Sep 23, 2020 1 message not in the archive

lore
Share & tools
lore

Aalx

author
#0 lore raw

PATCH v3 1/1 package/python-imutils: new package

From: Alexandre PAYEN <[email protected]>

python-imutils is a series of convenience functions to make basic image processing functions. It wrap openCV functions into easiers one. So it depends on opencv and more precisly on opencv ImgCodec

No license file can be found in the downloaded tarball but the license is MIT[1].

[1]: https://github.com/jrosebr1/imutils/blob/master/LICENSE.txt

---
v2 : Set MIT license in python-imutils.mk.
No file can be found but, int imutils repository on github, there is this a LICENSE.txt file which describe a MIT license.

v3 : Resolve a recursive dependency with opencv3.
From now, imutils depends on opencv3.

---
 package/Config.in                          |  1 +
 package/python-imutils/Config.in           | 33 ++++++++++++++++++++++
 package/python-imutils/python-imutils.hash |  3 ++
 package/python-imutils/python-imutils.mk   | 13 +++++++++
 4 files changed, 50 insertions(+)
 create mode 100644 package/python-imutils/Config.in
 create mode 100644 package/python-imutils/python-imutils.hash
 create mode 100644 package/python-imutils/python-imutils.mk
package/Config.in +1 -0
index 68905849dc..12eadbd483 100644
@@ -909,6 +909,7 @@ menu "External python modules"
 	source "package/python-ibmiotf/Config.in"
 	source "package/python-id3/Config.in"
 	source "package/python-idna/Config.in"
+	source "package/python-imutils/Config.in"
 	source "package/python-incremental/Config.in"
 	source "package/python-inflection/Config.in"
 	source "package/python-influxdb/Config.in"
package/python-imutils/Config.in new file +36 -0
new file mode 100644
index 0000000000..0c8ffbda56
@@ -0,0 +1,36 @@
+config BR2_PACKAGE_PYTHON_IMUTILS
+	bool "python-imutils"
+	depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS # python-scipy
+	depends on BR2_PACKAGE_PYTHON3 # python-scipy
+	depends on BR2_TOOLCHAIN_HAS_FORTRAN # python-scipy
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC # opencv3
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # opencv3
+	depends on BR2_INSTALL_LIBSTDCPP # opencv3
+	depends on BR2_USE_WCHAR # opencv3
+	depends on !BR2_STATIC_LIBS  # opencv3
+	depends on !BR2_PACKAGE_OPENCV # opencv3
+	depends on BR2_PACKAGE_OPENCV3
+	select BR2_PACKAGE_PYTHON_SCIPY
+	select BR2_PACKAGE_OPENCV3_LIB_PYTHON
+	select BR2_PACKAGE_OPENCV3_LIB_IMGCODECS
+	help
+	  A series of convenience functions to make basic image
+	  processing functions such as translation, rotation,
+	  resizing, skeletonization, displaying Matplotlib images,
+	  sorting contours, detecting edges, and much more easier
+	  with OpenCV and both Python 2.7 and Python 3.
+
+	  https://github.com/jrosebr1/imutils
+
+comment "python-imutils needs a toolchain w/ C++, NPTL, wchar, dynamic library, gFortran"
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
+	depends on !BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS
+	depends on !BR2_PACKAGE_PYTHON3
+	depends on !BR2_PACKAGE_OPENCV
+	depends on !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
+		BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_FORTRAN
+
+comment "python-imutils needs Opencv3"
+	depends on !BR2_PACKAGE_OPENCV3
package/python-imutils/python-imutils.hash new file +3 -0
new file mode 100644
index 0000000000..f8326de660
@@ -0,0 +1,3 @@
+# md5, sha256 from https://pypi.org/pypi/imutils/json
+md5	bfb5a2cd095cebd3e4a27e8653d1322c  imutils-0.5.2.tar.gz
+sha256	1d2bdf373e3e6cfbdc113d4e91547d3add3774d8722c8d4f225fa39586fb8076  imutils-0.5.2.tar.gz
package/python-imutils/python-imutils.mk new file +13 -0
new file mode 100644
index 0000000000..c5168e2be0
@@ -0,1 +1,13 @@
+################################################################################
+#
+# python-imutils
+#
+################################################################################
+
+PYTHON_IMUTILS_VERSION = 0.5.2
+PYTHON_IMUTILS_SOURCE = imutils-$(PYTHON_IMUTILS_VERSION).tar.gz
+PYTHON_IMUTILS_SITE = https://files.pythonhosted.org/packages/5e/0c/659c2bdae8e8ca5ef810b9da02db28feaa29ea448ff36b65a1664ff28142
+PYTHON_IMUTILS_SETUP_TYPE = distutils
+PYTHON_IMUTILS_LICENSE = MIT
+
+$(eval $(python-package))
Signature · 1 line
2.21.0
#1 lore raw

PATCH v3 1/1 package/python-imutils: new package

Hello Alexandre,

Quoted 8 lines · On Fri, 2 Aug 2019 16:45:03 +0200 Aalx <[email protected]> wrote:
package/python-imutils/Config.in new file +2 -0
new file mode 100644
index 0000000000..0c8ffbda56
@@ -0,0 +1,36 @@
+config BR2_PACKAGE_PYTHON_IMUTILS
+	bool "python-imutils"

package/python-imutils/Config.in line 12

Quoted 10 lines
package/python-imutils/Config.in new file +10 -0
+	depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS # python-scipy
+	depends on BR2_PACKAGE_PYTHON3 # python-scipy
+	depends on BR2_TOOLCHAIN_HAS_FORTRAN # python-scipy
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC # opencv3
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # opencv3
+	depends on BR2_INSTALL_LIBSTDCPP # opencv3
+	depends on BR2_USE_WCHAR # opencv3
+	depends on !BR2_STATIC_LIBS  # opencv3
+	depends on !BR2_PACKAGE_OPENCV # opencv3
+	depends on BR2_PACKAGE_OPENCV3

If you "depends on BR2_PACKAGE_OPENCV3", there is no need to replicate all the dependencies of opencv3 inside this package.

package/python-imutils/Config.in line 13

Quoted 1 line
package/python-imutils/Config.in new file +1 -0
+	select BR2_PACKAGE_PYTHON_SCIPY

We don't have this package in Buildroot, this needs to be added before we can merge python-imutils.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v3 1/1 package/python-imutils: new package

Hi Thomas,

thanks for the review.
This patch was part of my work with lapack/clapack if I remember.

I will soon take some time to provide a new version of this patch.

Regards,
Alexandre

Le mer. 5 f?vr. 2020 ? 16:20, Thomas Petazzoni <[email protected]> a ?crit :

Quoted 33 lines

Hello Alexandre,

Review

Quoted 1 line · On Fri, 2 Aug 2019 16:45:03 +0200 Aalx <[email protected]> wrote:
(quoted diff) +0 -0

b/package/python-imutils/Config.in

Quoted 7 lines

new file mode 100644
index 0000000000..0c8ffbda56

package/python-imutils/Config.in new file +2 -0
@@ -0,0 +1,36 @@
+config BR2_PACKAGE_PYTHON_IMUTILS
+     bool "python-imutils"

package/python-imutils/Config.in line 12

Quoted 10 lines
package/python-imutils/Config.in new file +10 -0
+     depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS # python-scipy
+     depends on BR2_PACKAGE_PYTHON3 # python-scipy
+     depends on BR2_TOOLCHAIN_HAS_FORTRAN # python-scipy
+     depends on BR2_TOOLCHAIN_HAS_ATOMIC # opencv3
+     depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # opencv3
+     depends on BR2_INSTALL_LIBSTDCPP # opencv3
+     depends on BR2_USE_WCHAR # opencv3
+     depends on !BR2_STATIC_LIBS  # opencv3
+     depends on !BR2_PACKAGE_OPENCV # opencv3
+     depends on BR2_PACKAGE_OPENCV3

If you "depends on BR2_PACKAGE_OPENCV3", there is no need to replicate all the dependencies of opencv3 inside this package.

package/python-imutils/Config.in line 13

Quoted 1 line
package/python-imutils/Config.in new file +1 -0
+     select BR2_PACKAGE_PYTHON_SCIPY

We don't have this package in Buildroot, this needs to be added before we can merge python-imutils.

Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200205/5d65ff15/attachment.html>

#3 lore raw

PATCH v3 1/1 package/python-imutils: new package

In reply to Thomas Petazzoni

Am Wed, 05 Feb 2020 16:20:13 +0100 schrieb Thomas Petazzoni:

Quoted 7 lines

If you "depends on BR2_PACKAGE_OPENCV3", there is no need to replicate all the dependencies of opencv3 inside this package.

package/python-imutils/Config.in line 13

Quoted 1 line
package/python-imutils/Config.in new file +1 -0
+	select BR2_PACKAGE_PYTHON_SCIPY

We don't have this package in Buildroot, this needs to be added before we can merge python-imutils.

Hi Thomas,

please change the patch state of http://patchwork.ozlabs.org/project/
buildroot/patch/20190802144503.23601-1-alexandre.payen at smile.fr/ to "Changes Requested".

Regards, Bernd

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

PATCH v3 1/1 package/python-imutils: new package

Quoted 5 lines · On Wed, 23 Sep 2020 07:04:07 +0200 Bernd Kuhls <[email protected]> wrote:

Hi Thomas,

please change the patch state of http://patchwork.ozlabs.org/project/
buildroot/patch/20190802144503.23601-1-alexandre.payen at smile.fr/ to "Changes Requested".

Done. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com