Skip to contentSkip to conversation

test/i915/gem_pipe_control_store_loop: Removal of test

PATCH In review ranjeet kumar 3 participants 8 messages Feb 6, 2020 – Feb 21, 2020 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test/i915/gem_pipe_control_store_loop: Removal of test

This test doesnt have any dependecy with other tests, hence is called out as redundant. This test has already been covered by gem_sync, hence it is being removed. gem_pipe_control_store_loop is not covered by gen2/gen3.

Cc Argenziano Antonio <[email protected]>
Cc Tahvanainen Jari <[email protected]>
---
 tests/Makefile.sources                   |   3 -
 tests/i915/gem_pipe_control_store_loop.c | 196 -----------------------
 tests/meson.build                        |   1 -
 3 files changed, 200 deletions(-)
 delete mode 100644 tests/i915/gem_pipe_control_store_loop.c
tests/Makefile.sources +0 -3
index 9d86f853..99b1281c 100644
@@ -318,9 +318,6 @@ gem_mmap_wc_SOURCES = i915/gem_mmap_wc.c
 TESTS_progs += gem_partial_pwrite_pread
 gem_partial_pwrite_pread_SOURCES = i915/gem_partial_pwrite_pread.c
 
-TESTS_progs += gem_pipe_control_store_loop
-gem_pipe_control_store_loop_SOURCES = i915/gem_pipe_control_store_loop.c
-
 TESTS_progs += gem_ppgtt
 gem_ppgtt_SOURCES = i915/gem_ppgtt.c
 
tests/i915/gem_pipe_control_store_loop.c deleted +0 -196

196 lines not on this page · raw message

tests/meson.build +0 -1
index dc16665b..1102d0a3 100644
@@ -171,7 +171,6 @@ i915_progs = [
 	'gem_mmap_gtt',
 	'gem_mmap_wc',
 	'gem_partial_pwrite_pread',
-	'gem_pipe_control_store_loop',
 	'gem_ppgtt',
 	'gem_pread',
 	'gem_pread_after_blit',
Signature · 6 lines
2.25.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

Quoting ranjeet kumar (2020-02-06 11:01:10)

Quoted 3 lines

This test doesnt have any dependecy with other tests, hence is called out as redundant. This test has already been covered by gem_sync, hence it is being removed. gem_pipe_control_store_loop is not covered by gen2/gen3.

Except it does do something rather special, since on gen6 this instruction was broken and we needed a bit of extra uAPI to cater for it... It's the magical reloc=(INSTRUCTION, INSTRUCTION). -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

Thanks Chris for the review,

Can we go ahead and remove this test ? or am I missing something?

Thanks,
Ranjeet

-----Original Message-----
From: Chris Wilson <[email protected]>
Sent: Monday, February 10, 2020 5:00 PM
To: [email protected]; Kumar, Ranjeet1 <[email protected]>
Subject: Re: [igt-dev] [PATCH] [PATCH i-g-t]test/i915/gem_pipe_control_store_loop: Removal of test

Quoting ranjeet kumar (2020-02-06 11:01:10)

Quoted 3 lines

This test doesnt have any dependecy with other tests, hence is called out as redundant. This test has already been covered by gem_sync, hence it is being removed. gem_pipe_control_store_loop is not covered by gen2/gen3.

Except it does do something rather special, since on gen6 this instruction was broken and we needed a bit of extra uAPI to cater for it... It's the magical reloc=(INSTRUCTION, INSTRUCTION). -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw

Hi Chris ,

This OUT_RELLOC instruction are covered in gem_exec_bad_domains, gem_write_read_ring_switch test too.
I tried replacing OUT_RELLOC with OUT_RELLOC_FENCED and successfully tests got passed.

Thanks,
Ranjeet

We can enhance this test case by adding

-----Original Message-----
From: Chris Wilson <[email protected]>
Sent: Thursday, February 13, 2020 1:33 PM
To: Kumar, Ranjeet1 <[email protected]>; [email protected]
Subject: RE: [igt-dev] [PATCH] [PATCH i-g-t]test/i915/gem_pipe_control_store_loop: Removal of test

Quoting Kumar, Ranjeet1 (2020-02-13 04:09:37)

Quoted 3 lines

Thanks Chris for the review,

Can we go ahead and remove this test ? or am I missing something?

The test is capturing a vital bit of uAPI. How are you planning to enhance the test?

No, you may not remove it.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

Quoting Kumar, Ranjeet1 (2020-02-20 08:50:42)

Quoted 4 lines

Hi Chris ,

This OUT_RELLOC instruction are covered in gem_exec_bad_domains, gem_write_read_ring_switch test too.
I tried replacing OUT_RELLOC with OUT_RELLOC_FENCED and successfully tests got passed.

The test is a regression test developed because we found a bug in the kernel that was not being exercised (a race condition during retire). We need to be certain that we retain such coverage. E.g. if we were to reintroduce such a bug, would CI pick it up? [Always a useful exercise to determine the efficacy of CI.]
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#6 lore raw

Hi Chris,

For the coverage purpose we are enhancing "gem_exec_bad_domains" to exercise this race condition i.e. OUT_RELLOC. I will be sending enhanced "gem_exec_bad_domains" program by Monday.

Thanks,
Ranjeet

-----Original Message-----
From: Chris Wilson <[email protected]>
Sent: Thursday, February 20, 2020 2:34 PM
To: Kumar, Ranjeet1 <[email protected]>; [email protected]
Subject: RE: [igt-dev] [PATCH] [PATCH i-g-t]test/i915/gem_pipe_control_store_loop: Removal of test

Quoting Kumar, Ranjeet1 (2020-02-20 08:50:42)

Quoted 4 lines

Hi Chris ,

This OUT_RELLOC instruction are covered in gem_exec_bad_domains, gem_write_read_ring_switch test too.
I tried replacing OUT_RELLOC with OUT_RELLOC_FENCED and successfully tests got passed.

The test is a regression test developed because we found a bug in the kernel that was not being exercised (a race condition during retire). We need to be certain that we retain such coverage. E.g. if we were to reintroduce such a bug, would CI pick it up? [Always a useful exercise to determine the efficacy of CI.] -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#7 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for test/i915/gem_pipe_control_store_loop: Removal of test

In reply to ranjeet kumar
== Series Details ==

== Series Details ==

Series: test/i915/gem_pipe_control_store_loop: Removal of test
URL : https://patchwork.freedesktop.org/series/73236/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7900 -> IGTPW_4120
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4120 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4120, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4120/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4120:

### IGT changes ###

#### Possible regressions ####

* igt@prime_busy@basic-wait-after-default:
- fi-skl-6770hq: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7900/fi-skl-6770hq/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4120/fi-skl-6770hq/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4120 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_blt:
- fi-ivb-3770: [PASS][3] -> [DMESG-FAIL][4] ([i915#725])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7900/fi-ivb-3770/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4120/fi-ivb-3770/igt@i915_selftest@live_blt.html

* igt@i915_selftest@live_gtt:
- fi-kbl-7500u: [PASS][5] -> [TIMEOUT][6] ([fdo#112271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7900/fi-kbl-7500u/igt@i915_selftest@live_gtt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4120/fi-kbl-7500u/igt@i915_selftest@live_gtt.html

#### Possible fixes ####

* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][7] ([i915#553] / [i915#725]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7900/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4120/fi-hsw-4770r/igt@i915_selftest@live_blt.html

* igt@i915_selftest@live_gtt:
- fi-skl-6600u: [TIMEOUT][9] ([fdo#111732] / [fdo#112271]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7900/fi-skl-6600u/igt@i915_selftest@live_gtt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4120/fi-skl-6600u/igt@i915_selftest@live_gtt.html

* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#109635] / [i915#217]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7900/fi-kbl-7500u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4120/fi-kbl-7500u/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][13] ([fdo#111407]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7900/fi-kbl-7500u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4120/fi-kbl-7500u/igt@[email protected]

[fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111732]: https://bugs.freedesktop.org/show_bug.cgi?id=111732
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725

Participating hosts (51 -> 47)
------------------------------

Additional (2): fi-byt-n2820 fi-bwr-2160
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5432 -> IGTPW_4120

CI-20190529: 20190529
CI_DRM_7900: f4ab479a4e3c9e0bc9120f6618b9876bfdece9cc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4120: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4120/index.html
IGT_5432: 6677811be6e9be9000b3217e8862353b3945a4f3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Testlist changes ==

-igt@gem_pipe_control_store_loop@fresh-buffer
-igt@gem_pipe_control_store_loop@reused-buffer

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4120/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev