nvme/pci: Add sleep quirk for Samsung and Toshiba drives
PATCH v2 1/1 nvme/pci: Add sleep quirk for Samsung and Toshiba drives
From: Shyjumon N <[email protected]>
The Samsung SSD SM981/PM981 and Toshiba SSD KBG40ZNT256G on the Lenovo C640 platform experience runtime resume issues when the SSDs are kept in sleep/suspend mode for long time.
This patch applies the 'Simple Suspend' quirk to these configurations. With this patch, the issue had not been observed in a 1+ day test.
---
V2: Rebased
Added my reviewed-by
drivers/nvme/host/pci.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/nvme/host/pci.c +12 -0
@@ -2726,6 +2726,18 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev) (dmi_match(DMI_BOARD_NAME, "PRIME B350M-A") || dmi_match(DMI_BOARD_NAME, "PRIME Z370-A")))return NVME_QUIRK_NO_APST ; + }else if ((pdev->vendor ==0x144d && (pdev->device ==0xa801 || + pdev->device ==0xa808 || pdev->device ==0xa809 )) || + (pdev->vendor ==0x1e0f && pdev->device ==0x0001 )) { +/* +* Forcing to use host managed nvme power settings for +* lowest idle power with quick resume latency on +* Samsung and Toshiba SSDs based on suspend behavior +* on Coffee Lake board for LENOVO C640 +*/ +if ((dmi_match (DMI_BOARD_VENDOR ,"LENOVO" )) && +dmi_match (DMI_BOARD_NAME ,"LNVNB161216" )) +return NVME_QUIRK_SIMPLE_SUSPEND ; }return 0 ;
Signature · 7 lines
2.24.1 _______________________________________________ linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Keith Busch
maintainerQuoted 11 lines · Jon Derrick
From: Shyjumon N <[email protected]>
The Samsung SSD SM981/PM981 and Toshiba SSD KBG40ZNT256G on the Lenovo C640 platform experience runtime resume issues when the SSDs are kept in sleep/suspend mode for long time.
This patch applies the 'Simple Suspend' quirk to these configurations. With this patch, the issue had not been observed in a 1+ day test.
Reviewed-by Jon Derrick <[email protected]>Signed-off-by Shyjumon N <[email protected]>
I'm not seeing a better option, but I'll just wait another day before applying.
_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Looks good,
_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keith Busch
maintainerPatch applied, started a new nvme-5.6-rc3 branch.
_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme