Skip to contentSkip to conversation

oeqa: Touch cpio configure script before building

PATCH In review Khem Raj 3 participants 4 messages Feb 7, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH v2 1/1 oeqa: Touch cpio configure script before building

since the versions of autotools might differ, and difference in timestamps for configure and system can result in reconfigure lets avoid that by touching the configure script to match system time

Avoids
error: newly created file is older than distributed files!

[YOCTO #13779]

---
v2: Touch configure to match timestamps with system
Move the touch cmd to configure step itself

 meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
 meta/lib/oeqa/sdk/cases/buildcpio.py     | 2 +-
 meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
meta/lib/oeqa/runtime/cases/buildcpio.py +1 -1
index 4bd72dd37e..a2cc8148db 100644
@@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
     @OEHasPackage(['autoconf'])
     def test_cpio(self):
         self.project.download_archive()
-        self.project.run_configure()
+        self.project.run_configure('','touch ./configure;')
         self.project.run_make()
         self.project.run_install()
meta/lib/oeqa/sdk/cases/buildcpio.py +1 -1
index b0beafb38f..e412ee189f 100644
@@ -28,7 +28,7 @@ class BuildCpioTest(OESDKTestCase):
             self.assertTrue(os.path.isdir(dirs["source"]))
             os.makedirs(dirs["build"])
 
-            self._run("cd {build} && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
+            self._run("cd {build} && touch {source}/configure && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
             self._run("cd {build} && make -j".format(**dirs))
             self._run("cd {build} && make install DESTDIR={install}".format(**dirs))
 
meta/lib/oeqa/selftest/cases/meta_ide.py +1 -1
index 809142559a..16acd1154d 100644
@@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
                         "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
                         self.tmpdir_metaideQA, self.td['DATETIME'], dl_dir=dl_dir)
         self.project.download_archive()
-        self.assertEqual(self.project.run_configure(), 0,
+        self.assertEqual(self.project.run_configure('','touch configure;'), 0,
                         msg="Running configure failed")
         self.assertEqual(self.project.run_make(), 0,
                         msg="Running make failed")
Signature · 1 line
2.25.0
#1 lore raw

✗ patchtest: failure for oeqa: Touch cpio configure script before building

== Series Details ==

Series: oeqa: Touch cpio configure script before building
Revision: 1
URL : https://patchwork.openembedded.org/series/22476/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 6f6a6bbac6)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#2 lore raw
In reply to Khem Raj
Quoted 4 lines · Khem Raj

since the versions of autotools might differ, and difference in timestamps for configure and system can result in reconfigure lets avoid that by touching the configure script to match system time

This is probably only a partial fix. If you look at the various dependencies in Makefile.in, ensuring that configure is newer than $(am__configure_deps) is only one case that needs to be handled. You also need to ensure that e.g. Makefile.in is newer than $(srcdir)/Makefile.am $(srcdir)/Make.rules $(am__configure_deps), that aclocal.m4 is newer than $(am__aclocal_m4_deps), etc.

Touching various files in the right order can be made to work, but there's more to it than just touching configure. Configuring with --disable-maintainer-mode and therefore disabling all these autotools rules is probably a more robust solution.

Quoted 61 lines

Avoids
error: newly created file is older than distributed files!

[YOCTO #13779]

---
v2: Touch configure to match timestamps with system
Move the touch cmd to configure step itself

 meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
 meta/lib/oeqa/sdk/cases/buildcpio.py     | 2 +-
 meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
meta/lib/oeqa/runtime/cases/buildcpio.py +1 -1
index 4bd72dd37e..a2cc8148db 100644
@@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
     @OEHasPackage(['autoconf'])
     def test_cpio(self):
         self.project.download_archive()
-        self.project.run_configure()
+        self.project.run_configure('','touch ./configure;')
         self.project.run_make()
         self.project.run_install()
meta/lib/oeqa/sdk/cases/buildcpio.py +1 -1
index b0beafb38f..e412ee189f 100644
@@ -28,7 +28,7 @@ class BuildCpioTest(OESDKTestCase):
             self.assertTrue(os.path.isdir(dirs["source"]))
             os.makedirs(dirs["build"])
 
-            self._run("cd {build} && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
+            self._run("cd {build} && touch {source}/configure && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
             self._run("cd {build} && make -j".format(**dirs))
             self._run("cd {build} && make install DESTDIR={install}".format(**dirs))
 
meta/lib/oeqa/selftest/cases/meta_ide.py +1 -2
index 809142559a..16acd1154d 100644
@@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
                         "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
                         self.tmpdir_metaideQA, self.td['DATETIME'], dl_dir=dl_dir)
         self.project.download_archive()
-        self.assertEqual(self.project.run_configure(), 0,
+        self.assertEqual(self.project.run_configure('','touch configure;'), 0,
                         msg="Running configure failed")
         self.assertEqual(self.project.run_make(), 0,
                         msg="Running make failed")
--

2.25.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#3 lore raw
Quoted 14 lines · Andre McCurdy
Quoted 4 lines · Khem Raj

since the versions of autotools might differ, and difference in timestamps for configure and system can result in reconfigure lets avoid that by touching the configure script to match system time

This is probably only a partial fix. If you look at the various dependencies in Makefile.in, ensuring that configure is newer than $(am__configure_deps) is only one case that needs to be handled. You also need to ensure that e.g. Makefile.in is newer than $(srcdir)/Makefile.am $(srcdir)/Make.rules $(am__configure_deps), that aclocal.m4 is newer than $(am__aclocal_m4_deps), etc.

Quoted 4 lines

Touching various files in the right order can be made to work, but there's more to it than just touching configure. Configuring with --disable-maintainer-mode and therefore disabling all these autotools rules is probably a more robust solution.

right. Lets see if we run into that as well, I would send a v3 if this is effective then we know we are on right path.

Quoted 62 lines
Quoted 62 lines

Avoids
error: newly created file is older than distributed files!

[YOCTO #13779]

---
v2: Touch configure to match timestamps with system
Move the touch cmd to configure step itself

 meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
 meta/lib/oeqa/sdk/cases/buildcpio.py     | 2 +-
 meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
meta/lib/oeqa/runtime/cases/buildcpio.py +1 -1
index 4bd72dd37e..a2cc8148db 100644
@@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
     @OEHasPackage(['autoconf'])
     def test_cpio(self):
         self.project.download_archive()
-        self.project.run_configure()
+        self.project.run_configure('','touch ./configure;')
         self.project.run_make()
         self.project.run_install()
meta/lib/oeqa/sdk/cases/buildcpio.py +1 -1
index b0beafb38f..e412ee189f 100644
@@ -28,7 +28,7 @@ class BuildCpioTest(OESDKTestCase):
             self.assertTrue(os.path.isdir(dirs["source"]))
             os.makedirs(dirs["build"])
 
-            self._run("cd {build} && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
+            self._run("cd {build} && touch {source}/configure && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
             self._run("cd {build} && make -j".format(**dirs))
             self._run("cd {build} && make install DESTDIR={install}".format(**dirs))
 
meta/lib/oeqa/selftest/cases/meta_ide.py +1 -2
index 809142559a..16acd1154d 100644
@@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
                         "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
                         self.tmpdir_metaideQA, self.td['DATETIME'], dl_dir=dl_dir)
         self.project.download_archive()
-        self.assertEqual(self.project.run_configure(), 0,
+        self.assertEqual(self.project.run_configure('','touch configure;'), 0,
                         msg="Running configure failed")
         self.assertEqual(self.project.run_make(), 0,
                         msg="Running make failed")
--

2.25.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core