Skip to contentSkip to conversation

dt-bindings: iio: adc: max1363 etc i2c ADC binding conversion

PATCH In review [email protected] 2 participants 3 messages Feb 8, 2020 – Feb 21, 2020

Subsystems (2)
Device tree bindings IIO
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: iio: adc: max1363 etc i2c ADC binding conversion

From: Jonathan Cameron <[email protected]>

Split the binding in two to reflect the threshold monitor capabilities and hence interrupts vs the more straight forward parts that don't have this facility.

Signed-off-by Jonathan Cameron <[email protected]>
---
 .../devicetree/bindings/iio/adc/max1363.txt   | 63 ---------------
 .../bindings/iio/adc/maxim,max1238.yaml       | 76 +++++++++++++++++++
 .../bindings/iio/adc/maxim,max1363.yaml       | 50 ++++++++++++
 3 files changed, 126 insertions(+), 63 deletions(-)
Documentation/devicetree/bindings/iio/adc/max1363.txt deleted +0 -63
deleted file mode 100644
index 94a9011dd860..000000000000
@@ -1,63 +0,0 @@
-* Maxim 1x3x/136x/116xx Analog to Digital Converter (ADC)
-
-The node for this driver must be a child node of a I2C controller, hence
-all mandatory properties for your controller must be specified. See directory:
-
-        Documentation/devicetree/bindings/i2c
-
-for more details.
-
-Required properties:
-  - compatible: Should be one of
-		"maxim,max1361"
-		"maxim,max1362"
-		"maxim,max1363"
-		"maxim,max1364"
-		"maxim,max1036"
-		"maxim,max1037"
-		"maxim,max1038"
-		"maxim,max1039"
-		"maxim,max1136"
-		"maxim,max1137"
-		"maxim,max1138"
-		"maxim,max1139"
-		"maxim,max1236"
-		"maxim,max1237"
-		"maxim,max1238"
-		"maxim,max1239"
-		"maxim,max11600"
-		"maxim,max11601"
-		"maxim,max11602"
-		"maxim,max11603"
-		"maxim,max11604"
-		"maxim,max11605"
-		"maxim,max11606"
-		"maxim,max11607"
-		"maxim,max11608"
-		"maxim,max11609"
-		"maxim,max11610"
-		"maxim,max11611"
-		"maxim,max11612"
-		"maxim,max11613"
-		"maxim,max11614"
-		"maxim,max11615"
-		"maxim,max11616"
-		"maxim,max11617"
-		"maxim,max11644"
-		"maxim,max11645"
-		"maxim,max11646"
-		"maxim,max11647"
-  - reg: Should contain the ADC I2C address
-
-Optional properties:
-  - vcc-supply: phandle to the regulator that provides power to the ADC.
-  - vref-supply: phandle to the regulator for ADC reference voltage.
-  - interrupts: IRQ line for the ADC. If not used the driver will use
-    polling.
-
-Example:
-adc: max11644@36 {
-	compatible = "maxim,max11644";
-	reg = <0x36>;
-	vref-supply = <&adc_vref>;
-};
Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml new file +76 -0

76 lines not on this page · raw message

Documentation/devicetree/bindings/iio/adc/maxim,max1363.yaml new file +50 -0

50 lines not on this page · raw message

Signature · 1 line
2.25.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · On Sat, Feb 08, 2020 at 05:23:12PM +0000, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Split the binding in two to reflect the threshold monitor capabilities and hence interrupts vs the more straight forward parts that don't have this facility.

Signed-off-by Jonathan Cameron <[email protected]>
---
 .../devicetree/bindings/iio/adc/max1363.txt   | 63 ---------------
 .../bindings/iio/adc/maxim,max1238.yaml       | 76 +++++++++++++++++++
 .../bindings/iio/adc/maxim,max1363.yaml       | 50 ++++++++++++
 3 files changed, 126 insertions(+), 63 deletions(-)

Documentation/devicetree/bindings/iio/adc/maxim,max1363.yaml line 19

Quoted 4 lines
Documentation/devicetree/bindings/iio/adc/maxim,max1363.yaml new file +4 -0
+properties:
+  compatible:
+    enum:
+      - maxim,max1361,

Dangling comma.

Otherwise,

Reviewed-by Rob Herring <[email protected]>
Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/maxim,max1363.yaml new file +3 -0
+      - maxim,max1362
+      - maxim,max1363
+      - maxim,max1364
author maintainer
#2 lore raw
Quoted 19 lines · On Wed, 19 Feb 2020 16:10:05 -0600 Rob Herring <[email protected]> wrote:
Quoted 13 lines · On Sat, Feb 08, 2020 at 05:23:12PM +0000, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Split the binding in two to reflect the threshold monitor capabilities and hence interrupts vs the more straight forward parts that don't have this facility.

Signed-off-by Jonathan Cameron <[email protected]>
---
 .../devicetree/bindings/iio/adc/max1363.txt   | 63 ---------------
 .../bindings/iio/adc/maxim,max1238.yaml       | 76 +++++++++++++++++++
 .../bindings/iio/adc/maxim,max1363.yaml       | 50 ++++++++++++
 3 files changed, 126 insertions(+), 63 deletions(-)

Documentation/devicetree/bindings/iio/adc/maxim,max1363.yaml line 19

Quoted 4 lines
Documentation/devicetree/bindings/iio/adc/maxim,max1363.yaml new file +4 -0
+properties:
+  compatible:
+    enum:
+      - maxim,max1361,
Quoted 5 lines

Dangling comma.

Otherwise,

Reviewed-by Rob Herring <[email protected]>

Fixed up and applied. Thanks Rob

Jonathan

Quoted 5 lines
Quoted 4 lines
Documentation/devicetree/bindings/iio/adc/maxim,max1363.yaml new file +3 -0
+      - maxim,max1362
+      - maxim,max1363
+      - maxim,max1364