gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO
PATCH v2 1/2 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO
Since commit bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL") CONFIG_DM_74X164 is no longer built for mx7dsabresd_defconfig, as this target does not use CONFIG_SPL_GPIO.
Remove such dependency and let the the 74X164 GPIO driver be built again.
This restores Ethernet functionality on the imx7-sdb board as the Ethernet reset PHY comes from a GPIO driven by a 74LV595PW I/O expander.
---
Changes since v1:
- Move to the 'ifndef CONFIG_SPL_BUILD' block so that it does not cause issues on SPL targets, such as mx6ul_14x14_defconfig
drivers/gpio/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpio/Makefile +1 -3
@@ -6,13 +6,11 @@ ifndef CONFIG_SPL_BUILD obj-$(CONFIG_DWAPB_GPIO) += dwapb_gpio.o obj-$(CONFIG_AXP_GPIO) += axp_gpio.o +obj-$(CONFIG_DM_74X164) += 74x164_gpio.o endif obj-$(CONFIG_$(SPL_TPL_)DM_GPIO) += gpio-uclass.o obj-$(CONFIG_$(SPL_)DM_PCA953X) += pca953x_gpio.o -ifdef CONFIG_$(SPL_TPL_)GPIO -obj-$(CONFIG_DM_74X164) += 74x164_gpio.o -endif obj-$(CONFIG_AT91_GPIO) += at91_gpio.o obj-$(CONFIG_ATMEL_PIO4) += atmel_pio4.o
Signature · 1 line
2.17.1
PATCH v2 2/2 mx6ul_14x14_evk: Move CONFIG_DM_74X164 to defconfig
The CONFIG_DM_74X164 symbols should be moved to the defconfig file, as indicated in the comments.
--- configs/mx6ul_14x14_evk_defconfig | 1 + include/configs/mx6ul_14x14_evk.h | 5 ----- 2 files changed, 1 insertion(+), 5 deletions(-)
configs/mx6ul_14x14_evk_defconfig +1 -0
@@ -44,6 +44,7 @@ CONFIG_DEFAULT_DEVICE_TREE="imx6ul-14x14-evk" CONFIG_ENV_IS_IN_MMC=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y +CONFIG_DM_74X164=y CONFIG_DM_I2C=y CONFIG_DM_MMC=y CONFIG_FSL_USDHC=y
include/configs/mx6ul_14x14_evk.h +0 -5
@@ -44,11 +44,6 @@#define CONFIG_SYS_I2C_SPEED 100000#endif -/* Note: This is incorrect and should move to Kconfig / defconfig */ -#ifdef CONFIG_DM_GPIO -#define CONFIG_DM_74X164 -#endif -#define CONFIG_SYS_MMC_IMG_LOAD_PART 1#define CONFIG_EXTRA_ENV_SETTINGS \
Signature · 1 line
2.17.1
PATCH v2 2/2 mx6ul_14x14_evk: Move CONFIG_DM_74X164 to defconfig
Quoted 4 lines · Fabio Estevam
The
CONFIG_DM_74X164symbols should be moved to the defconfig file, as indicated in the comments.Signed-off-by Fabio Estevam <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200129/7d1aa8ac/attachment.sig>
PATCH v2 2/2 mx6ul_14x14_evk: Move CONFIG_DM_74X164 to defconfig
In reply to Fabio EstevamQuoted 4 lines
The
CONFIG_DM_74X164symbols should be moved to the defconfig file, as indicated in the comments.Signed-off-by Fabio Estevam <[email protected]>Reviewed-by Tom Rini <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v2 1/2 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO
In reply to Fabio EstevamQuoted 7 lines · Fabio Estevam
Since commit
bcee8d6764f9("dm: gpio: Allow control of GPIO uclass in SPL")CONFIG_DM_74X164is no longer built formx7dsabresd_defconfig, as this target does not useCONFIG_SPL_GPIO.Remove such dependency and let the the 74X164 GPIO driver be built again.
Quoted 6 lines
This restores Ethernet functionality on the imx7-sdb board as the Ethernet reset PHY comes from a GPIO driven by a 74LV595PW I/O expander.
Fixes bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL")Signed-off-by Fabio Estevam <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200129/aa7e76f1/attachment.sig>
PATCH v2 1/2 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO
In reply to Fabio EstevamTested on mx7dsabresd board:
U-Boot 2020.04-rc1-00035-gb6e6e4f9d9 (Jan 30 2020 - 10:03:12 -0300)
CPU: Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz) CPU: Commercial temperature grade (0C to 95C) at 39C Reset cause: POR Model: Freescale i.MX7 SabreSD Board Board: i.MX7D SABRESD in secure mode DRAM: 1 GiB PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11 MMC: FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... OK Video: 480x272x24 In: serial Out: serial Err: serial Net: eth0: ethernet at 30be0000 Hit any key to stop autoboot: 0
=> dhcp Image
BOOTP broadcast 1
DHCP client bound to address 10.29.244.24 (327 ms)
Using ethernet at 30be0000 device
TFTP from server 10.29.240.177; our IP address is 10.29.244.24; sending through gateway 10.29.244.254
Filename 'Image'.
Load address: 0x80800000
Loading: #################################################################
#################################################################
#################################################################
...
#################################################################
#################################################################
###########################################
2.9 MiB/sdone
Bytes transferred = 27509248 (1a3c200 hex)
=>
Em qua., 29 de jan. de 2020 Ã s 13:58, Fabio Estevam <[email protected]> escreveu:
Quoted 44 lines
Since commit
bcee8d6764f9("dm: gpio: Allow control of GPIO uclass in SPL")CONFIG_DM_74X164is no longer built formx7dsabresd_defconfig, as this target does not useCONFIG_SPL_GPIO.Remove such dependency and let the the 74X164 GPIO driver be built again.
This restores Ethernet functionality on the imx7-sdb board as the Ethernet reset PHY comes from a GPIO driven by a 74LV595PW I/O expander.
Fixes bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL")Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Move to the 'ifndefCONFIG_SPL_BUILD' block so that it does not cause issues on SPL targets, such asmx6ul_14x14_defconfigdrivers/gpio/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpio/Makefile +1
-4@@ -6,13 +6,11 @@ ifndef CONFIG_SPL_BUILD obj-$(CONFIG_DWAPB_GPIO) += dwapb_gpio.o obj-$(CONFIG_AXP_GPIO) += axp_gpio.o +obj-$(CONFIG_DM_74X164) += 74x164_gpio.o endif obj-$(CONFIG_$(SPL_TPL_)DM_GPIO) += gpio-uclass.o obj-$(CONFIG_$(SPL_)DM_PCA953X) += pca953x_gpio.o -ifdef CONFIG_$(SPL_TPL_)GPIO -obj-$(CONFIG_DM_74X164) += 74x164_gpio.o -endif obj-$(CONFIG_AT91_GPIO) += at91_gpio.o obj-$(CONFIG_ATMEL_PIO4) += atmel_pio4.o --2.17.1
PATCH v2 1/2 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO
In reply to Fabio EstevamQuoted 8 lines
Since commit
bcee8d6764f9("dm: gpio: Allow control of GPIO uclass in SPL")CONFIG_DM_74X164is no longer built formx7dsabresd_defconfig, as this target does not useCONFIG_SPL_GPIO.
Remove such dependency and let the the 74X164 GPIO driver be built again.
This restores Ethernet functionality on the imx7-sdb board as the Ethernet reset PHY comes from a GPIO driven by a 74LV595PW I/O expander.
Quoted 4 lines
Fixes bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL")Signed-off-by Fabio Estevam <[email protected]>Reviewed-by Tom Rini <[email protected]>Tested-by Alifer Moraes <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================