Skip to contentSkip to conversation

lib/igt_draw: Refactor get_tiling calls

PATCH In review Imre Deak 4 participants 36 messages Feb 11, 2020 – Feb 15, 2020 Library code

lore
Share & tools
lore

Imre Deak

author
#0 lore raw

PATCH v2 1/8 lib/igt_draw: Refactor get_tiling calls

From: Vanshidhar Konda <[email protected]>

Simplify the number of places from which gem_get_tiling method is called and call it only if the device has support in hardware for tiling.

For consistency also fix up the gem_mmap__cpu() prot argument in draw_rect_mmap_cpu(). Atm, gem_mmap__cpu() ignores this, however the implementation of it may change, so make sure we pass the correct protection flags.

v2:
- Use gem_available_fences() to check for HW detiling.
v3: (Matt)
- Fix docbook for draw_rect_render()
- Remove unused swizzle params from the blt/render draw funcs.
- Describe the gem_mmap__cpu() prot argument fix in the commit log.

---
 lib/igt_draw.c                   | 57 ++++++++++++++++----------------
 lib/igt_draw.h                   |  5 +--
 tests/kms_frontbuffer_tracking.c |  8 +++--
 3 files changed, 36 insertions(+), 34 deletions(-)
lib/igt_draw.c +28 -29
index 6950bc49..fa8ab562 100644
@@ -333,20 +333,19 @@ static void draw_rect_ptr_tiled(void *ptr, uint32_t stride, uint32_t tiling,
 }
 
 static void draw_rect_mmap_cpu(int fd, struct buf_data *buf, struct rect *rect,
-			       uint32_t color)
+			       uint32_t tiling, uint32_t swizzle, uint32_t color)
 {
 	uint32_t *ptr;
-	uint32_t tiling, swizzle;
 
 	gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_CPU,
 		       I915_GEM_DOMAIN_CPU);
-	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
 
 	/* We didn't implement suport for the older tiling methods yet. */
 	if (tiling != I915_TILING_NONE)
 		igt_require(intel_gen(intel_get_drm_devid(fd)) >= 5);
 
-	ptr = gem_mmap__cpu(fd, buf->handle, 0, PAGE_ALIGN(buf->size), 0);
+	ptr = gem_mmap__cpu(fd, buf->handle, 0, PAGE_ALIGN(buf->size),
+			    PROT_READ | PROT_WRITE);
 
 	switch (tiling) {
 	case I915_TILING_NONE:
@@ -384,14 +383,12 @@ static void draw_rect_mmap_gtt(int fd, struct buf_data *buf, struct rect *rect,
 }
 
 static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
-			      uint32_t color)
+			      uint32_t tiling, uint32_t swizzle, uint32_t color)
 {
 	uint32_t *ptr;
-	uint32_t tiling, swizzle;
 
 	gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
 		       I915_GEM_DOMAIN_GTT);
-	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
 
 	/* We didn't implement suport for the older tiling methods yet. */
 	if (tiling != I915_TILING_NONE)
@@ -495,12 +492,9 @@ static void draw_rect_pwrite_tiled(int fd, struct buf_data *buf,
 }
 
 static void draw_rect_pwrite(int fd, struct buf_data *buf,
-			     struct rect *rect, uint32_t color)
+			     struct rect *rect, uint32_t tiling,
+			     uint32_t swizzle, uint32_t color)
 {
-	uint32_t tiling, swizzle;
-
-	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
-
 	switch (tiling) {
 	case I915_TILING_NONE:
 		draw_rect_pwrite_untiled(fd, buf, rect, color);
@@ -517,18 +511,15 @@ static void draw_rect_pwrite(int fd, struct buf_data *buf,
 
 static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
 			  struct buf_data *buf, struct rect *rect,
-			  uint32_t color)
+			  uint32_t tiling, uint32_t color)
 {
 	drm_intel_bo *dst;
 	struct intel_batchbuffer *batch;
 	int blt_cmd_len, blt_cmd_tiling, blt_cmd_depth;
 	uint32_t devid = intel_get_drm_devid(fd);
 	int gen = intel_gen(devid);
-	uint32_t tiling, swizzle;
 	int pitch;
 
-	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
-
 	dst = gem_handle_to_libdrm_bo(cmd_data->bufmgr, fd, "", buf->handle);
 	igt_assert(dst);
 
@@ -574,28 +565,25 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
 
 static void draw_rect_render(int fd, struct cmd_data *cmd_data,
 			     struct buf_data *buf, struct rect *rect,
-			     uint32_t color)
+			     uint32_t tiling, uint32_t color)
 {
 	drm_intel_bo *src, *dst;
 	uint32_t devid = intel_get_drm_devid(fd);
 	igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid);
 	struct igt_buf src_buf = {}, dst_buf = {};
 	struct intel_batchbuffer *batch;
-	uint32_t tiling, swizzle;
 	struct buf_data tmp;
 	int pixel_size = buf->bpp / 8;
 
 	igt_skip_on(!rendercopy);
 
-	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
-
 	/* We create a temporary buffer and copy from it using rendercopy. */
 	tmp.size = rect->w * rect->h * pixel_size;
 	tmp.handle = gem_create(fd, tmp.size);
 	tmp.stride = rect->w * pixel_size;
 	tmp.bpp = buf->bpp;
 	draw_rect_mmap_cpu(fd, &tmp, &(struct rect){0, 0, rect->w, rect->h},
-			   color);
+			   I915_TILING_NONE, I915_BIT_6_SWIZZLE_NONE, color);
 
 	src = gem_handle_to_libdrm_bo(cmd_data->bufmgr, fd, "", tmp.handle);
 	igt_assert(src);
@@ -634,6 +622,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
  * @buf_handle: the handle of the buffer where you're going to draw to
  * @buf_size: the size of the buffer
  * @buf_stride: the stride of the buffer
+ * @tiling: the tiling of the buffer
  * @method: method you're going to use to write to the buffer
  * @rect_x: horizontal position on the buffer where your rectangle starts
  * @rect_y: vertical position on the buffer where your rectangle starts
@@ -647,9 +636,12 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
  */
 void igt_draw_rect(int fd, drm_intel_bufmgr *bufmgr, drm_intel_context *context,
 		   uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
-		   enum igt_draw_method method, int rect_x, int rect_y,
-		   int rect_w, int rect_h, uint32_t color, int bpp)
+		   uint32_t tiling, enum igt_draw_method method,
+		   int rect_x, int rect_y, int rect_w, int rect_h,
+		   uint32_t color, int bpp)
 {
+	uint32_t buf_tiling, swizzle;
+
 	struct cmd_data cmd_data = {
 		.bufmgr = bufmgr,
 		.context = context,
@@ -667,24 +659,30 @@ void igt_draw_rect(int fd, drm_intel_bufmgr *bufmgr, drm_intel_context *context,
 		.h = rect_h,
 	};
 
+	swizzle = I915_BIT_6_SWIZZLE_NONE;
+	if (tiling != I915_TILING_NONE && gem_available_fences(fd)) {
+		gem_get_tiling(fd, buf_handle, &buf_tiling, &swizzle);
+		igt_assert(tiling == buf_tiling);
+	}
+
 	switch (method) {
 	case IGT_DRAW_MMAP_CPU:
-		draw_rect_mmap_cpu(fd, &buf, &rect, color);
+		draw_rect_mmap_cpu(fd, &buf, &rect, tiling, swizzle, color);
 		break;
 	case IGT_DRAW_MMAP_GTT:
 		draw_rect_mmap_gtt(fd, &buf, &rect, color);
 		break;
 	case IGT_DRAW_MMAP_WC:
-		draw_rect_mmap_wc(fd, &buf, &rect, color);
+		draw_rect_mmap_wc(fd, &buf, &rect, tiling, swizzle, color);
 		break;
 	case IGT_DRAW_PWRITE:
-		draw_rect_pwrite(fd, &buf, &rect, color);
+		draw_rect_pwrite(fd, &buf, &rect, tiling, swizzle, color);
 		break;
 	case IGT_DRAW_BLT:
-		draw_rect_blt(fd, &cmd_data, &buf, &rect, color);
+		draw_rect_blt(fd, &cmd_data, &buf, &rect, tiling, color);
 		break;
 	case IGT_DRAW_RENDER:
-		draw_rect_render(fd, &cmd_data, &buf, &rect, color);
+		draw_rect_render(fd, &cmd_data, &buf, &rect, tiling, color);
 		break;
 	default:
 		igt_assert(false);
@@ -715,7 +713,8 @@ void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr,
 		      int rect_w, int rect_h, uint32_t color)
 {
 	igt_draw_rect(fd, bufmgr, context, fb->gem_handle, fb->size, fb->strides[0],
-		      method, rect_x, rect_y, rect_w, rect_h, color,
+		      igt_fb_mod_to_tiling(fb->modifier), method,
+		      rect_x, rect_y, rect_w, rect_h, color,
 		      igt_drm_format_to_bpp(fb->drm_format));
 }
 
lib/igt_draw.h +3 -2
index b030131e..ec146754 100644
@@ -52,8 +52,9 @@ const char *igt_draw_get_method_name(enum igt_draw_method method);
 
 void igt_draw_rect(int fd, drm_intel_bufmgr *bufmgr, drm_intel_context *context,
 		   uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
-		   enum igt_draw_method method, int rect_x, int rect_y,
-		   int rect_w, int rect_h, uint32_t color, int bpp);
+		   uint32_t tiling, enum igt_draw_method method,
+		   int rect_x, int rect_y, int rect_w, int rect_h,
+		   uint32_t color, int bpp);
 
 void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr,
 		      drm_intel_context *context, struct igt_fb *fb,
tests/kms_frontbuffer_tracking.c +5 -3
index 2c765c34..9c2c3a5d 100644
@@ -291,6 +291,7 @@ struct {
 	int height;
 	uint32_t color;
 	int bpp;
+	uint32_t tiling;
 } busy_thread = {
 	.stop = true,
 };
@@ -1126,9 +1127,9 @@ static void *busy_thread_func(void *data)
 	while (!busy_thread.stop)
 		igt_draw_rect(drm.fd, drm.bufmgr, NULL, busy_thread.handle,
 			      busy_thread.size, busy_thread.stride,
-			      IGT_DRAW_BLT, 0, 0, busy_thread.width,
-			      busy_thread.height, busy_thread.color,
-			      busy_thread.bpp);
+			      busy_thread.tiling, IGT_DRAW_BLT, 0, 0,
+			      busy_thread.width, busy_thread.height,
+			      busy_thread.color, busy_thread.bpp);
 
 	pthread_exit(0);
 }
@@ -1146,6 +1147,7 @@ static void start_busy_thread(struct igt_fb *fb)
 	busy_thread.height = fb->height;
 	busy_thread.color = pick_color(fb, COLOR_PRIM_BG);
 	busy_thread.bpp = igt_drm_format_to_bpp(fb->drm_format);
+	busy_thread.tiling = igt_fb_mod_to_tiling(fb->modifier);
 
 	rc = pthread_create(&busy_thread.thread, NULL, busy_thread_func, NULL);
 	igt_assert_eq(rc, 0);
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#1 lore raw

PATCH v2 2/8 tests/kms_frontbuffer_tracking: Skip set tiling calls if not supported

From: Vanshidhar Konda <[email protected]>

Skip the method that is setting tiling with invalid strides if the hardware does not support HW for tiling/de-tiling.

v2:
- Use gem_available_fences() to check for HW detiling.

---
 tests/kms_frontbuffer_tracking.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tests/kms_frontbuffer_tracking.c +2 -1
index 9c2c3a5d..724f5d16 100644
@@ -2833,7 +2833,8 @@ static void badstride_subtest(const struct test_mode *t)
 	struct modeset_params *params = pick_params(t);
 	int rc;
 
-	try_invalid_strides();
+	if (gem_available_fences(drm.fd))
+		try_invalid_strides();
 
 	prepare_subtest(t, NULL);
 
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#2 lore raw

PATCH v2 3/8 tests/kms_available_modes_crc: Don't set tiling for framebuffer

In reply to Imre Deak

From: Vanshidhar Konda <[email protected]>

The GEM object used for the framebuffer does not need tiling to be set on it as the entire framebuffer is being filled with the same value - tiling will not impact the end value of the buffer.

---
 tests/kms_available_modes_crc.c | 6 ------
 1 file changed, 6 deletions(-)
tests/kms_available_modes_crc.c +0 -6
index 12761343..ed43d1fb 100644
@@ -211,17 +211,11 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
 	data->buf = (unsigned char *)calloc(data->size*2, 1);
 
 	data->gem_handle = gem_create(data->gfx_fd, gemsize);
-	ret = __gem_set_tiling(data->gfx_fd, data->gem_handle,
-			       igt_fb_mod_to_tiling(tiling),
-			       data->fb.strides[0]);
-
 	data->fb.gem_handle = data->gem_handle;
 	data->fb.width = w;
 	data->fb.height = h;
 	fill_in_fb(data, output, plane, format);
 
-	igt_assert_eq(ret, 0);
-
 	ret = __kms_addfb(data->gfx_fd, data->gem_handle, w, h,
 			  format, tiling, data->fb.strides, data->fb.offsets,
 			  num_planes, LOCAL_DRM_MODE_FB_MODIFIERS,
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#3 lore raw

Re: [igt-dev] [PATCH v2 3/8] tests/kms_available_modes_crc: Don't set tiling for framebuffer

Quoted 27 lines · Imre Deak

From: Vanshidhar Konda <[email protected]>

The GEM object used for the framebuffer does not need tiling to be set on it as the entire framebuffer is being filled with the same value - tiling will not impact the end value of the buffer.

---
 tests/kms_available_modes_crc.c | 6 ------
 1 file changed, 6 deletions(-)
tests/kms_available_modes_crc.c +0 -4
index 12761343..ed43d1fb 100644
@@ -211,17 +211,11 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
 	data->buf = (unsigned char *)calloc(data->size*2, 1);
 
 	data->gem_handle = gem_create(data->gfx_fd, gemsize);
-	ret = __gem_set_tiling(data->gfx_fd, data->gem_handle,
-			       igt_fb_mod_to_tiling(tiling),
-			       data->fb.strides[0]);
-

tests/kms_available_modes_crc.c static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane, · line 221

Quoted 10 lines
tests/kms_available_modes_crc.c +0 -2
 	data->fb.gem_handle = data->gem_handle;
 	data->fb.width = w;
 	data->fb.height = h;
 	fill_in_fb(data, output, plane, format);
 
-	igt_assert_eq(ret, 0);
-
 	ret = __kms_addfb(data->gfx_fd, data->gem_handle, w, h,
 			  format, tiling, data->fb.strides, data->fb.offsets,
 			  num_planes, LOCAL_DRM_MODE_FB_MODIFIERS,

I think there are still the following remaining issues with this patch:

1. 33cc93c8 has introduced a gem_require_mappable_ggtt() skipping the entire test. That should probably be removed as part of this patch?

2. do_write() has a gem_mmap__gtt() which should be converted to device_coherent()?

3. This is sort of optional but in my view there is an inconsistency here which should be addressed:

The original test was actually using a tiled object and using the tiling available in the aperture/gtt to write to the object. Through this patch we have essentially removed the tiling on the object. However, we are continuing to use LOCAL_I915_FORMAT_MOD_X_TILED in setup_fb(). It just happens that because we are filling in a single value the modifier is immaterial.

Shouldn't this be made consistent? Either

(a) we should change the modifier to LOCAL_DRM_FORMAT_MOD_NONE, or

(b) if we are going to use the tiled modifer we should assume the object is really tiled and use the blitter or rendercopy to write to the object.

I guess (a) is simpler to do.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#4 lore raw

Re: [igt-dev] [PATCH v2 3/8] tests/kms_available_modes_crc: Don't set tiling for framebuffer

Quoted 41 lines · Ashutosh
Quoted 27 lines · Imre Deak

From: Vanshidhar Konda <[email protected]>

The GEM object used for the framebuffer does not need tiling to be set on it as the entire framebuffer is being filled with the same value - tiling will not impact the end value of the buffer.

---
 tests/kms_available_modes_crc.c | 6 ------
 1 file changed, 6 deletions(-)
tests/kms_available_modes_crc.c +0 -4
index 12761343..ed43d1fb 100644
@@ -211,17 +211,11 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
 	data->buf = (unsigned char *)calloc(data->size*2, 1);
 
 	data->gem_handle = gem_create(data->gfx_fd, gemsize);
-	ret = __gem_set_tiling(data->gfx_fd, data->gem_handle,
-			       igt_fb_mod_to_tiling(tiling),
-			       data->fb.strides[0]);
-

tests/kms_available_modes_crc.c static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane, · line 221

Quoted 10 lines
tests/kms_available_modes_crc.c +0 -2
 	data->fb.gem_handle = data->gem_handle;
 	data->fb.width = w;
 	data->fb.height = h;
 	fill_in_fb(data, output, plane, format);
 
-	igt_assert_eq(ret, 0);
-
 	ret = __kms_addfb(data->gfx_fd, data->gem_handle, w, h,
 			  format, tiling, data->fb.strides, data->fb.offsets,
 			  num_planes, LOCAL_DRM_MODE_FB_MODIFIERS,

I think there are still the following remaining issues with this patch:

Quoted 5 lines

1. 33cc93c8 has introduced a gem_require_mappable_ggtt() skipping the entire test. That should probably be removed as part of this patch?

2. do_write() has a gem_mmap__gtt() which should be converted to device_coherent()?

That's a good point, we'll need to use another way to write the test image to the FB and stop skipping the test. However I think this patch is still valid on its own, and the above things can be done as a follow-up.

Quoted 9 lines

3. This is sort of optional but in my view there is an inconsistency here which should be addressed:

The original test was actually using a tiled object and using the tiling available in the aperture/gtt to write to the object. Through this patch we have essentially removed the tiling on the object. However, we are continuing to use LOCAL_I915_FORMAT_MOD_X_TILED in setup_fb(). It just happens that because we are filling in a single value the modifier is immaterial.

It's not immaterial, the display will scan out an X tiled FB.

Quoted 8 lines

Shouldn't this be made consistent? Either

(a) we should change the modifier to LOCAL_DRM_FORMAT_MOD_NONE, or

(b) if we are going to use the tiled modifer we should assume the object is really tiled and use the blitter or rendercopy to write to the object.

The test just solid fills the FB and we don't need to do that in a pixel line-by-line order.

Quoted 1 line

I guess (a) is simpler to do.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

Re: [igt-dev] [PATCH v2 3/8] tests/kms_available_modes_crc: Don't set tiling for framebuffer

Quoted 7 lines · Imre Deak
Quoted 6 lines · Ashutosh

On Mon, 10 Feb 2020 18:31:03 -0800, Imre Deak wrote:
I think there are still the following remaining issues with this patch:

1. 33cc93c8 has introduced a gem_require_mappable_ggtt() skipping the entire test. That should probably be removed as part of this patch?

Quoted 7 lines
Quoted 2 lines

2. do_write() has a gem_mmap__gtt() which should be converted to device_coherent()?

That's a good point, we'll need to use another way to write the test image to the FB and stop skipping the test. However I think this patch is still valid on its own, and the above things can be done as a follow-up.

OK, you have a R-b on the patch anyway.

Quoted 11 lines
Quoted 9 lines

3. This is sort of optional but in my view there is an inconsistency here which should be addressed:

The original test was actually using a tiled object and using the tiling available in the aperture/gtt to write to the object. Through this patch we have essentially removed the tiling on the object. However, we are continuing to use LOCAL_I915_FORMAT_MOD_X_TILED in setup_fb(). It just happens that because we are filling in a single value the modifier is immaterial.

It's not immaterial, the display will scan out an X tiled FB.

I am aware of it, what I meant was only because it is a solid color, if we write assuming it is untiled whereas the scan out will assume tiled, the output on the display will still look right.

Quoted 12 lines
Quoted 7 lines

Shouldn't this be made consistent? Either

(a) we should change the modifier to LOCAL_DRM_FORMAT_MOD_NONE, or

(b) if we are going to use the tiled modifer we should assume the object is really tiled and use the blitter or rendercopy to write to the object.

The test just solid fills the FB and we don't need to do that in a pixel line-by-line order.

Quoted 1 line

I guess (a) is simpler to do.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#6 lore raw

PATCH v2 4/8 tests/kms_draw_crc: Skip GTT subtests on platforms w/o aperture

In reply to Imre Deak

Subtests drawing through a GTT mapping are not relevant on platforms w/o a GTT aperture, so skip them.

---
 tests/kms_draw_crc.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_draw_crc.c +2 -0
index ea14db9a..6de9feae 100644
@@ -178,6 +178,8 @@ static void draw_method_subtest(enum igt_draw_method method,
 	igt_crc_t crc;
 
 	igt_skip_on(method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd));
+	igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm_fd));
 
 	igt_require(format_is_supported(formats[format_index], tiling));
 
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#7 lore raw

Re: [igt-dev] [PATCH v2 4/8] tests/kms_draw_crc: Skip GTT subtests on platforms w/o aperture

Quoted 16 lines · Imre Deak

Subtests drawing through a GTT mapping are not relevant on platforms w/o a GTT aperture, so skip them.

---
 tests/kms_draw_crc.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_draw_crc.c +0 -0
index ea14db9a..6de9feae 100644

tests/kms_draw_crc.c static void draw_method_subtest(enum igt_draw_method method, · line 182

Quoted 5 lines
tests/kms_draw_crc.c +2 -0
@@ -178,6 +178,8 @@ static void draw_method_subtest(enum igt_draw_method method,
 	igt_crc_t crc;
 
 	igt_skip_on(method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd));
+	igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm_fd));

Can't we add the skip directly in draw_rect_mmap_gtt() so we don't have to go skip in each individual test which ends up calling draw_rect_mmap_gtt()?
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#8 lore raw

Re: [igt-dev] [PATCH v2 4/8] tests/kms_draw_crc: Skip GTT subtests on platforms w/o aperture

Quoted 20 lines · Ashutosh
Quoted 18 lines · Imre Deak

Subtests drawing through a GTT mapping are not relevant on platforms w/o a GTT aperture, so skip them.

---
 tests/kms_draw_crc.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_draw_crc.c +0 -0
index ea14db9a..6de9feae 100644
@@ -178,6 +178,8 @@ static void draw_method_subtest(enum igt_draw_method method,
 	igt_crc_t crc;
 
Quoted 6 lines

tests/kms_draw_crc.c static void draw_method_subtest(enum igt_draw_method method, · line 182

Quoted 3 lines
tests/kms_draw_crc.c +2 -0
 	igt_skip_on(method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd));
+	igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm_fd));

Can't we add the skip directly in draw_rect_mmap_gtt() so we don't have to go skip in each individual test which ends up calling draw_rect_mmap_gtt()?

Sorry, so yes we cannot put a igt_skip() in draw_rect_mmap_gtt() in case say we are looping over all the methods in a subtest and igt_skip() will end up skipping the entire subtest, i.e. all the other methods too. At most we can return without doing anything from draw_rect_mmap_gtt() but we can't igt_skip().

I am assuming that the tests are passing in spite of not being able to set the tiling in igt_create_fb()?
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by
#9 lore raw

Re: [igt-dev] [PATCH v2 4/8] tests/kms_draw_crc: Skip GTT subtests on platforms w/o aperture

Quoted 29 lines · Ashutosh
Quoted 20 lines · Ashutosh
Quoted 18 lines · Imre Deak

Subtests drawing through a GTT mapping are not relevant on platforms w/o a GTT aperture, so skip them.

---
 tests/kms_draw_crc.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_draw_crc.c +0 -0
index ea14db9a..6de9feae 100644
@@ -178,6 +178,8 @@ static void draw_method_subtest(enum igt_draw_method method,
 	igt_crc_t crc;
 
Quoted 6 lines

tests/kms_draw_crc.c static void draw_method_subtest(enum igt_draw_method method, · line 182

Quoted 3 lines
tests/kms_draw_crc.c +2 -0
 	igt_skip_on(method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd));
+	igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm_fd));

Can't we add the skip directly in draw_rect_mmap_gtt() so we don't have to go skip in each individual test which ends up calling draw_rect_mmap_gtt()?

Quoted 8 lines

Sorry, so yes we cannot put a igt_skip() in draw_rect_mmap_gtt() in case say we are looping over all the methods in a subtest and igt_skip() will end up skipping the entire subtest, i.e. all the other methods too. At most we can return without doing anything from draw_rect_mmap_gtt() but we can't igt_skip().

I am assuming that the tests are passing in spite of not being able to set the tiling in igt_create_fb()?

Of course they will pass since the reference/base crc has no tiling.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#10 lore raw

PATCH v2 5/8 tests/kms_draw_crc: Fix generating reference CRCs on platforms w/o aperture

In reply to Imre Deak

Generate reference CRCs by drawing through a CPU mapping, which is also available on platforms w/o a GTT aperture.

v2:
- Fix code comment in draw_method_subtest(). (Matt)

---
 tests/kms_draw_crc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/kms_draw_crc.c +3 -3
index 6de9feae..0e762ad1 100644
@@ -183,11 +183,11 @@ static void draw_method_subtest(enum igt_draw_method method,
 
 	igt_require(format_is_supported(formats[format_index], tiling));
 
-	/* Use IGT_DRAW_MMAP_GTT on an untiled buffer as the parameter for
+	/* Use IGT_DRAW_MMAP_CPU on an untiled buffer as the parameter for
 	 * comparison. Cache the value so we don't recompute it for every single
 	 * subtest. */
 	if (!base_crcs[format_index].set) {
-		get_method_crc(IGT_DRAW_MMAP_GTT, formats[format_index],
+		get_method_crc(IGT_DRAW_MMAP_CPU, formats[format_index],
 			       LOCAL_DRM_FORMAT_MOD_NONE,
 			       &base_crcs[format_index].crc);
 		base_crcs[format_index].set = true;
@@ -225,7 +225,7 @@ static void fill_fb_subtest(void)
 	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
 		      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
 
-	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_CPU,
 			 0, 0, fb.width, fb.height, 0xFF);
 
 	rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0,
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v2 5/8
#11 lore raw

Re: [igt-dev] [PATCH v2 5/8] tests/kms_draw_crc: Fix generating reference CRCs on platforms w/o aperture

Quoted 8 lines · Imre Deak

Generate reference CRCs by drawing through a CPU mapping, which is also available on platforms w/o a GTT aperture.

v2:
- Fix code comment in draw_method_subtest(). (Matt)

Quoted 34 lines
---
 tests/kms_draw_crc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/kms_draw_crc.c +3 -3
index 6de9feae..0e762ad1 100644
@@ -183,11 +183,11 @@ static void draw_method_subtest(enum igt_draw_method method,
 
 	igt_require(format_is_supported(formats[format_index], tiling));
 
-	/* Use IGT_DRAW_MMAP_GTT on an untiled buffer as the parameter for
+	/* Use IGT_DRAW_MMAP_CPU on an untiled buffer as the parameter for
 	 * comparison. Cache the value so we don't recompute it for every single
 	 * subtest. */
 	if (!base_crcs[format_index].set) {
-		get_method_crc(IGT_DRAW_MMAP_GTT, formats[format_index],
+		get_method_crc(IGT_DRAW_MMAP_CPU, formats[format_index],
 			       LOCAL_DRM_FORMAT_MOD_NONE,
 			       &base_crcs[format_index].crc);
 		base_crcs[format_index].set = true;
@@ -225,7 +225,7 @@ static void fill_fb_subtest(void)
 	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
 		      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
 
-	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_CPU,
 			 0, 0, fb.width, fb.height, 0xFF);
 
 	rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0,
Signature · 1 line
2.23.1
Signature · 9 lines
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#12 lore raw

Re: [igt-dev] [PATCH v2 5/8] tests/kms_draw_crc: Fix generating reference CRCs on platforms w/o aperture

In reply to Imre Deak
Quoted 32 lines · Imre Deak

Generate reference CRCs by drawing through a CPU mapping, which is also available on platforms w/o a GTT aperture.

v2:
- Fix code comment in draw_method_subtest(). (Matt)

---
 tests/kms_draw_crc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/kms_draw_crc.c +2 -2
index 6de9feae..0e762ad1 100644
@@ -183,11 +183,11 @@ static void draw_method_subtest(enum igt_draw_method method,
 
 	igt_require(format_is_supported(formats[format_index], tiling));
 
-	/* Use IGT_DRAW_MMAP_GTT on an untiled buffer as the parameter for
+	/* Use IGT_DRAW_MMAP_CPU on an untiled buffer as the parameter for
 	 * comparison. Cache the value so we don't recompute it for every single
 	 * subtest. */
 	if (!base_crcs[format_index].set) {
-		get_method_crc(IGT_DRAW_MMAP_GTT, formats[format_index],
+		get_method_crc(IGT_DRAW_MMAP_CPU, formats[format_index],
 			       LOCAL_DRM_FORMAT_MOD_NONE,
 			       &base_crcs[format_index].crc);
 		base_crcs[format_index].set = true;

tests/kms_draw_crc.c static void fill_fb_subtest(void) · line 229

Quoted 6 lines
tests/kms_draw_crc.c +1 -1
@@ -225,7 +225,7 @@ static void fill_fb_subtest(void)
 	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
 		      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
 
-	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_CPU,
 			 0, 0, fb.width, fb.height, 0xFF);

Should be WC. CPU mapping will not work in all cases.
_______________________________________________
igt-dev mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#13 lore raw

Re: [igt-dev] [PATCH v2 5/8] tests/kms_draw_crc: Fix generating reference CRCs on platforms w/o aperture

Quoted 36 lines · Ashutosh
Quoted 35 lines · Imre Deak

Generate reference CRCs by drawing through a CPU mapping, which is also available on platforms w/o a GTT aperture.

v2:
- Fix code comment in draw_method_subtest(). (Matt)

---
 tests/kms_draw_crc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/kms_draw_crc.c +2 -2
index 6de9feae..0e762ad1 100644
@@ -183,11 +183,11 @@ static void draw_method_subtest(enum igt_draw_method method,
 
 	igt_require(format_is_supported(formats[format_index], tiling));
 
-	/* Use IGT_DRAW_MMAP_GTT on an untiled buffer as the parameter for
+	/* Use IGT_DRAW_MMAP_CPU on an untiled buffer as the parameter for
 	 * comparison. Cache the value so we don't recompute it for every single
 	 * subtest. */
 	if (!base_crcs[format_index].set) {
-		get_method_crc(IGT_DRAW_MMAP_GTT, formats[format_index],
+		get_method_crc(IGT_DRAW_MMAP_CPU, formats[format_index],
 			       LOCAL_DRM_FORMAT_MOD_NONE,
 			       &base_crcs[format_index].crc);
 		base_crcs[format_index].set = true;
@@ -225,7 +225,7 @@ static void fill_fb_subtest(void)
 	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
 		      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
 
Quoted 5 lines

tests/kms_draw_crc.c static void fill_fb_subtest(void) · line 229

Quoted 3 lines
tests/kms_draw_crc.c +1 -1
-	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_CPU,
 			 0, 0, fb.width, fb.height, 0xFF);

Should be WC. CPU mapping will not work in all cases.

I can't see why. This will result in a frontbuffer drawing that calls DRM_IOCTL_I915_GEM_SW_FINISH, which should flush CPU caches if needed.

--Imre
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#14 lore raw

Re: [igt-dev] [PATCH v2 5/8] tests/kms_draw_crc: Fix generating reference CRCs on platforms w/o aperture

Quoted 37 lines · Imre Deak
Quoted 36 lines · Ashutosh
Quoted 35 lines · Imre Deak

Generate reference CRCs by drawing through a CPU mapping, which is also available on platforms w/o a GTT aperture.

v2:
- Fix code comment in draw_method_subtest(). (Matt)

---
 tests/kms_draw_crc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/kms_draw_crc.c +2 -2
index 6de9feae..0e762ad1 100644
@@ -183,11 +183,11 @@ static void draw_method_subtest(enum igt_draw_method method,
 
 	igt_require(format_is_supported(formats[format_index], tiling));
 
-	/* Use IGT_DRAW_MMAP_GTT on an untiled buffer as the parameter for
+	/* Use IGT_DRAW_MMAP_CPU on an untiled buffer as the parameter for
 	 * comparison. Cache the value so we don't recompute it for every single
 	 * subtest. */
 	if (!base_crcs[format_index].set) {
-		get_method_crc(IGT_DRAW_MMAP_GTT, formats[format_index],
+		get_method_crc(IGT_DRAW_MMAP_CPU, formats[format_index],
 			       LOCAL_DRM_FORMAT_MOD_NONE,
 			       &base_crcs[format_index].crc);
 		base_crcs[format_index].set = true;
@@ -225,7 +225,7 @@ static void fill_fb_subtest(void)
 	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
 		      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
 
Quoted 8 lines
Quoted 5 lines

tests/kms_draw_crc.c static void fill_fb_subtest(void) · line 229

Quoted 3 lines
tests/kms_draw_crc.c +1 -1
-	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_CPU,
 			 0, 0, fb.width, fb.height, 0xFF);

Should be WC. CPU mapping will not work in all cases.

I can't see why. This will result in a frontbuffer drawing that calls DRM_IOCTL_I915_GEM_SW_FINISH, which should flush CPU caches if needed.

Ok, so it's not only about cache-flushing but WB mapping not working on local memory in general.

That also means we have to disable subtests that draw to the FB through a CPU mapping, but I'll leave that for a follow-up (as we're missing the required queries for that).

Quoted 6 lines

--Imre
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#15 lore raw

PATCH v3 5/8 tests/kms_draw_crc: Fix generating reference CRCs on platforms w/o aperture

In reply to Imre Deak

Generate reference CRCs by drawing through a WC mapping on platforms w/o a GTT aperture.

v2:
- Fix code comment in draw_method_subtest(). (Matt) v3:
- Use WC instead of CPU mapping. (Ashutosh)

---
 tests/kms_draw_crc.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
tests/kms_draw_crc.c +7 -3
index 6de9feaeb..fa7433ab2 100644
@@ -183,11 +183,13 @@ static void draw_method_subtest(enum igt_draw_method method,
 
 	igt_require(format_is_supported(formats[format_index], tiling));
 
-	/* Use IGT_DRAW_MMAP_GTT on an untiled buffer as the parameter for
+	/* Use IGT_DRAW_MMAP_GTT/WC on an untiled buffer as the parameter for
 	 * comparison. Cache the value so we don't recompute it for every single
 	 * subtest. */
 	if (!base_crcs[format_index].set) {
-		get_method_crc(IGT_DRAW_MMAP_GTT, formats[format_index],
+		get_method_crc(gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT :
+							       IGT_DRAW_MMAP_WC,
+			       formats[format_index],
 			       LOCAL_DRM_FORMAT_MOD_NONE,
 			       &base_crcs[format_index].crc);
 		base_crcs[format_index].set = true;
@@ -225,7 +227,9 @@ static void fill_fb_subtest(void)
 	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
 		      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
 
-	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb,
+			 gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT :
+							 IGT_DRAW_MMAP_WC,
 			 0, 0, fb.width, fb.height, 0xFF);
 
 	rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0,
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v3 5/8
#16 lore raw

Re: [igt-dev] [PATCH v3 5/8] tests/kms_draw_crc: Fix generating reference CRCs on platforms w/o aperture

Quoted 38 lines · Imre Deak

Generate reference CRCs by drawing through a WC mapping on platforms w/o a GTT aperture.

v2:
- Fix code comment in draw_method_subtest(). (Matt) v3:
- Use WC instead of CPU mapping. (Ashutosh)

---
 tests/kms_draw_crc.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
tests/kms_draw_crc.c +4 -2
index 6de9feaeb..fa7433ab2 100644
@@ -183,11 +183,13 @@ static void draw_method_subtest(enum igt_draw_method method,
 
 	igt_require(format_is_supported(formats[format_index], tiling));
 
-	/* Use IGT_DRAW_MMAP_GTT on an untiled buffer as the parameter for
+	/* Use IGT_DRAW_MMAP_GTT/WC on an untiled buffer as the parameter for
 	 * comparison. Cache the value so we don't recompute it for every single
 	 * subtest. */
 	if (!base_crcs[format_index].set) {
-		get_method_crc(IGT_DRAW_MMAP_GTT, formats[format_index],
+		get_method_crc(gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT :
+							       IGT_DRAW_MMAP_WC,
+			       formats[format_index],
 			       LOCAL_DRM_FORMAT_MOD_NONE,
 			       &base_crcs[format_index].crc);
 		base_crcs[format_index].set = true;

tests/kms_draw_crc.c static void fill_fb_subtest(void) · line 232

Quoted 7 lines
tests/kms_draw_crc.c +3 -1
@@ -225,7 +227,9 @@ static void fill_fb_subtest(void)
 	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
 		      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
 
-	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb,
+			 gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT :
+							 IGT_DRAW_MMAP_WC,

Not sure if the conditional switch between GTT and WC is really needed. For example, __gem_mmap__device_coherent() unconditionally prefers WC over GTT. In any case:

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#17 lore raw

Re: [igt-dev] [PATCH v3 5/8] tests/kms_draw_crc: Fix generating reference CRCs on platforms w/o aperture

Quoted 42 lines · Ashutosh
Quoted 41 lines · Imre Deak

Generate reference CRCs by drawing through a WC mapping on platforms w/o a GTT aperture.

v2:
- Fix code comment in draw_method_subtest(). (Matt) v3:
- Use WC instead of CPU mapping. (Ashutosh)

---
 tests/kms_draw_crc.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
tests/kms_draw_crc.c +4 -2
index 6de9feaeb..fa7433ab2 100644
@@ -183,11 +183,13 @@ static void draw_method_subtest(enum igt_draw_method method,
 
 	igt_require(format_is_supported(formats[format_index], tiling));
 
-	/* Use IGT_DRAW_MMAP_GTT on an untiled buffer as the parameter for
+	/* Use IGT_DRAW_MMAP_GTT/WC on an untiled buffer as the parameter for
 	 * comparison. Cache the value so we don't recompute it for every single
 	 * subtest. */
 	if (!base_crcs[format_index].set) {
-		get_method_crc(IGT_DRAW_MMAP_GTT, formats[format_index],
+		get_method_crc(gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT :
+							       IGT_DRAW_MMAP_WC,
+			       formats[format_index],
 			       LOCAL_DRM_FORMAT_MOD_NONE,
 			       &base_crcs[format_index].crc);
 		base_crcs[format_index].set = true;
@@ -225,7 +227,9 @@ static void fill_fb_subtest(void)
 	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
 		      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
 
Quoted 6 lines

tests/kms_draw_crc.c static void fill_fb_subtest(void) · line 232

Quoted 4 lines
tests/kms_draw_crc.c +3 -1
-	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb,
+			 gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT :
+							 IGT_DRAW_MMAP_WC,

Not sure if the conditional switch between GTT and WC is really needed.

We can't use either one unconditionally since neither is available on all platforms. So using GTT if available as before and if not WC.

Quoted 4 lines

For example, __gem_mmap__device_coherent() unconditionally prefers WC over GTT. In any case:

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#18 lore raw

PATCH v2 6/8 tests/kms_frontbuffer_tracking: Skip GTT subtests on platforms w/o aperture

In reply to Imre Deak

Subtests that draw through a GTT mapping are not relevent on a platform w/o GTT aperture, so skip them.

v2:
- Remove the check for aperture where it's not relevant, or where it would skip the test incorrectly (badformat_subtest()).

---
 tests/kms_frontbuffer_tracking.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
tests/kms_frontbuffer_tracking.c +20 -0
index 724f5d16..881cb9ff 100644
@@ -1934,6 +1934,9 @@ static void draw_subtest(const struct test_mode *t)
 	struct modeset_params *params = pick_params(t);
 	struct fb_region *target;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (t->screen) {
 	case SCREEN_PRIM:
 		if (t->method != IGT_DRAW_MMAP_GTT && t->plane == PLANE_PRI)
@@ -2032,6 +2035,11 @@ static void multidraw_subtest(const struct test_mode *t)
 			igt_debug("Methods %s and %s\n",
 				  igt_draw_get_method_name(m1),
 				  igt_draw_get_method_name(m2));
+
+			igt_skip_on((m1 == IGT_DRAW_MMAP_GTT ||
+				     m2 == IGT_DRAW_MMAP_GTT) &&
+				    !gem_has_mappable_ggtt(drm.fd));
+
 			for (r = 0; r < pattern->n_rects; r++) {
 				used_method = (r % 2 == 0) ? m1 : m2;
 
@@ -2276,6 +2284,9 @@ static void flip_subtest(const struct test_mode *t)
 	struct draw_pattern_info *pattern = &pattern1;
 	enum color bg_color;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (t->screen) {
 	case SCREEN_PRIM:
 		assertions |= ASSERT_LAST_ACTION_CHANGED;
@@ -2335,6 +2346,9 @@ static void fliptrack_subtest(const struct test_mode *t, enum flip_type type)
 	struct modeset_params *params = pick_params(t);
 	struct draw_pattern_info *pattern = &pattern1;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	prepare_subtest(t, pattern);
 
 	create_fb(t->format, params->primary.fb->width, params->primary.fb->height,
@@ -2744,6 +2758,9 @@ static void farfromfence_subtest(const struct test_mode *t)
 	int max_height, assertions = 0;
 	int gen = intel_gen(intel_get_drm_devid(drm.fd));
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (gen) {
 	case 2:
 		max_height = 2048;
@@ -3025,6 +3042,9 @@ static void basic_subtest(const struct test_mode *t)
 	fb1 = params->primary.fb;
 
 	for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++, r++) {
+		igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
+			    !gem_has_mappable_ggtt(drm.fd));
+
 		if (r == pattern->n_rects) {
 			params->primary.fb = (params->primary.fb == fb1) ? &fb2 : fb1;
 
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v2 6/8
#19 lore raw

Re: [igt-dev] [PATCH v2 6/8] tests/kms_frontbuffer_tracking: Skip GTT subtests on platforms w/o aperture

Quoted 2 lines · Imre Deak

Subtests that draw through a GTT mapping are not relevent on a platform w/o GTT aperture, so skip them.

Do slow_draw_subtest and scaledprimary_subtest need to skip if t->method is GTT?

Aside from that,

Quoted 80 lines

v2:
- Remove the check for aperture where it's not relevant, or where it would skip the test incorrectly (badformat_subtest()).

---
 tests/kms_frontbuffer_tracking.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
tests/kms_frontbuffer_tracking.c +20 -0
index 724f5d16..881cb9ff 100644
@@ -1934,6 +1934,9 @@ static void draw_subtest(const struct test_mode *t)
 	struct modeset_params *params = pick_params(t);
 	struct fb_region *target;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (t->screen) {
 	case SCREEN_PRIM:
 		if (t->method != IGT_DRAW_MMAP_GTT && t->plane == PLANE_PRI)
@@ -2032,6 +2035,11 @@ static void multidraw_subtest(const struct test_mode *t)
 			igt_debug("Methods %s and %s\n",
 				  igt_draw_get_method_name(m1),
 				  igt_draw_get_method_name(m2));
+
+			igt_skip_on((m1 == IGT_DRAW_MMAP_GTT ||
+				     m2 == IGT_DRAW_MMAP_GTT) &&
+				    !gem_has_mappable_ggtt(drm.fd));
+
 			for (r = 0; r < pattern->n_rects; r++) {
 				used_method = (r % 2 == 0) ? m1 : m2;
 
@@ -2276,6 +2284,9 @@ static void flip_subtest(const struct test_mode *t)
 	struct draw_pattern_info *pattern = &pattern1;
 	enum color bg_color;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (t->screen) {
 	case SCREEN_PRIM:
 		assertions |= ASSERT_LAST_ACTION_CHANGED;
@@ -2335,6 +2346,9 @@ static void fliptrack_subtest(const struct test_mode *t, enum flip_type type)
 	struct modeset_params *params = pick_params(t);
 	struct draw_pattern_info *pattern = &pattern1;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	prepare_subtest(t, pattern);
 
 	create_fb(t->format, params->primary.fb->width, params->primary.fb->height,
@@ -2744,6 +2758,9 @@ static void farfromfence_subtest(const struct test_mode *t)
 	int max_height, assertions = 0;
 	int gen = intel_gen(intel_get_drm_devid(drm.fd));
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (gen) {
 	case 2:
 		max_height = 2048;
@@ -3025,6 +3042,9 @@ static void basic_subtest(const struct test_mode *t)
 	fb1 = params->primary.fb;
 
 	for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++, r++) {
+		igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
+			    !gem_has_mappable_ggtt(drm.fd));
+
 		if (r == pattern->n_rects) {
 			params->primary.fb = (params->primary.fb == fb1) ? &fb2 : fb1;
 
Signature · 1 line
2.23.1
Signature · 9 lines
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#20 lore raw

Re: [igt-dev] [PATCH v2 6/8] tests/kms_frontbuffer_tracking: Skip GTT subtests on platforms w/o aperture

Quoted 5 lines · Matt Roper
Quoted 2 lines · Imre Deak

Subtests that draw through a GTT mapping are not relevent on a platform w/o GTT aperture, so skip them.

Do slow_draw_subtest and scaledprimary_subtest need to skip if t->method is GTT?

Those are blt only subtests, so we won't skip those due to missing aperture.

Quoted 82 lines

Aside from that,

Quoted 77 lines

v2:
- Remove the check for aperture where it's not relevant, or where it would skip the test incorrectly (badformat_subtest()).

---
 tests/kms_frontbuffer_tracking.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
tests/kms_frontbuffer_tracking.c +20 -0
index 724f5d16..881cb9ff 100644
@@ -1934,6 +1934,9 @@ static void draw_subtest(const struct test_mode *t)
 	struct modeset_params *params = pick_params(t);
 	struct fb_region *target;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (t->screen) {
 	case SCREEN_PRIM:
 		if (t->method != IGT_DRAW_MMAP_GTT && t->plane == PLANE_PRI)
@@ -2032,6 +2035,11 @@ static void multidraw_subtest(const struct test_mode *t)
 			igt_debug("Methods %s and %s\n",
 				  igt_draw_get_method_name(m1),
 				  igt_draw_get_method_name(m2));
+
+			igt_skip_on((m1 == IGT_DRAW_MMAP_GTT ||
+				     m2 == IGT_DRAW_MMAP_GTT) &&
+				    !gem_has_mappable_ggtt(drm.fd));
+
 			for (r = 0; r < pattern->n_rects; r++) {
 				used_method = (r % 2 == 0) ? m1 : m2;
 
@@ -2276,6 +2284,9 @@ static void flip_subtest(const struct test_mode *t)
 	struct draw_pattern_info *pattern = &pattern1;
 	enum color bg_color;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (t->screen) {
 	case SCREEN_PRIM:
 		assertions |= ASSERT_LAST_ACTION_CHANGED;
@@ -2335,6 +2346,9 @@ static void fliptrack_subtest(const struct test_mode *t, enum flip_type type)
 	struct modeset_params *params = pick_params(t);
 	struct draw_pattern_info *pattern = &pattern1;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	prepare_subtest(t, pattern);
 
 	create_fb(t->format, params->primary.fb->width, params->primary.fb->height,
@@ -2744,6 +2758,9 @@ static void farfromfence_subtest(const struct test_mode *t)
 	int max_height, assertions = 0;
 	int gen = intel_gen(intel_get_drm_devid(drm.fd));
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (gen) {
 	case 2:
 		max_height = 2048;
@@ -3025,6 +3042,9 @@ static void basic_subtest(const struct test_mode *t)
 	fb1 = params->primary.fb;
 
 	for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++, r++) {
+		igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
+			    !gem_has_mappable_ggtt(drm.fd));
+
 		if (r == pattern->n_rects) {
 			params->primary.fb = (params->primary.fb == fb1) ? &fb2 : fb1;
 
Quoted 10 lines
Quoted 3 lines
Signature · 1 line
2.23.1
Signature · 5 lines
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#21 lore raw

Re: [igt-dev] [PATCH v2 6/8] tests/kms_frontbuffer_tracking: Skip GTT subtests on platforms w/o aperture

In reply to Imre Deak

tests/kms_frontbuffer_tracking.c static void basic_subtest(const struct test_mode *t) · line 3047

Quoted 7 lines · Imre Deak
tests/kms_frontbuffer_tracking.c +3 -0
@@ -3025,6 +3042,9 @@ static void basic_subtest(const struct test_mode *t)
 	fb1 = params->primary.fb;
 
 	for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++, r++) {
+		igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
+			    !gem_has_mappable_ggtt(drm.fd));
+

I don't think this is incorrect. It will result in the entire subtest being skipped, for all methods, rather than only the GTT method. Need to use 'continue' here.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#22 lore raw

Re: [igt-dev] [PATCH v2 6/8] tests/kms_frontbuffer_tracking: Skip GTT subtests on platforms w/o aperture

Quoted 4 lines · Ashutosh
Quoted 3 lines · Imre Deak
tests/kms_frontbuffer_tracking.c +0 -0
@@ -3025,6 +3042,9 @@ static void basic_subtest(const struct test_mode *t)
 	fb1 = params->primary.fb;
 
Quoted 8 lines

tests/kms_frontbuffer_tracking.c static void basic_subtest(const struct test_mode *t) · line 3047

Quoted 4 lines
tests/kms_frontbuffer_tracking.c +3 -0
 	for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++, r++) {
+		igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
+			    !gem_has_mappable_ggtt(drm.fd));
+

I don't think this is incorrect. It will result in the entire subtest being skipped, for all methods, rather than only the GTT method. Need to use 'continue' here.

Right. The test doesn't expect that we skip any methods, but it looks easy to fix that.

-Imre
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#23 lore raw

PATCH v3 6/8 tests/kms_frontbuffer_tracking: Skip GTT subtests on platforms w/o aperture

In reply to Imre Deak

Subtests that draw through a GTT mapping are not relevent on a platform w/o GTT aperture, so skip them.

basic_subtest() so far expected that each method drew a new rectangle to the FB (see the pattern::frames_stack flag), so fix up things allowing the skip now.

v2:
- Remove the check for aperture where it's not relevant, or where it would skip the test incorrectly (badformat_subtest()).
v3:
- Don't skip the whole subtest where multiple draw methods are used. (Ashutosh).

---
 tests/kms_frontbuffer_tracking.c | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)
tests/kms_frontbuffer_tracking.c +25 -1
index 724f5d16c..c4b4af43a 100644
@@ -1934,6 +1934,9 @@ static void draw_subtest(const struct test_mode *t)
 	struct modeset_params *params = pick_params(t);
 	struct fb_region *target;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (t->screen) {
 	case SCREEN_PRIM:
 		if (t->method != IGT_DRAW_MMAP_GTT && t->plane == PLANE_PRI)
@@ -2032,6 +2035,12 @@ static void multidraw_subtest(const struct test_mode *t)
 			igt_debug("Methods %s and %s\n",
 				  igt_draw_get_method_name(m1),
 				  igt_draw_get_method_name(m2));
+
+			if ((m1 == IGT_DRAW_MMAP_GTT ||
+			     m2 == IGT_DRAW_MMAP_GTT) &&
+			    !gem_has_mappable_ggtt(drm.fd))
+				continue;
+
 			for (r = 0; r < pattern->n_rects; r++) {
 				used_method = (r % 2 == 0) ? m1 : m2;
 
@@ -2276,6 +2285,9 @@ static void flip_subtest(const struct test_mode *t)
 	struct draw_pattern_info *pattern = &pattern1;
 	enum color bg_color;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (t->screen) {
 	case SCREEN_PRIM:
 		assertions |= ASSERT_LAST_ACTION_CHANGED;
@@ -2335,6 +2347,9 @@ static void fliptrack_subtest(const struct test_mode *t, enum flip_type type)
 	struct modeset_params *params = pick_params(t);
 	struct draw_pattern_info *pattern = &pattern1;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	prepare_subtest(t, pattern);
 
 	create_fb(t->format, params->primary.fb->width, params->primary.fb->height,
@@ -2744,6 +2759,9 @@ static void farfromfence_subtest(const struct test_mode *t)
 	int max_height, assertions = 0;
 	int gen = intel_gen(intel_get_drm_devid(drm.fd));
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (gen) {
 	case 2:
 		max_height = 2048;
@@ -3024,7 +3042,11 @@ static void basic_subtest(const struct test_mode *t)
 		  opt.tiling, t->plane, &fb2);
 	fb1 = params->primary.fb;
 
-	for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++, r++) {
+	for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++) {
+		if (method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd))
+			continue;
+
 		if (r == pattern->n_rects) {
 			params->primary.fb = (params->primary.fb == fb1) ? &fb2 : fb1;
 
@@ -3040,6 +3062,8 @@ static void basic_subtest(const struct test_mode *t)
 		draw_rect(pattern, &params->primary, method, r);
 		update_wanted_crc(t, &pattern->crcs[t->format][r]);
 		do_assertions(assertions);
+
+		r++;
 	}
 
 	igt_remove_fb(drm.fd, &fb2);
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Acked-by on v3 6/8
#24 lore raw

Re: [igt-dev] [PATCH v3 6/8] tests/kms_frontbuffer_tracking: Skip GTT subtests on platforms w/o aperture

Quoted 15 lines · Imre Deak

Subtests that draw through a GTT mapping are not relevent on a platform w/o GTT aperture, so skip them.

basic_subtest() so far expected that each method drew a new rectangle to the FB (see the pattern::frames_stack flag), so fix up things allowing the skip now.

v2:
- Remove the check for aperture where it's not relevant, or where it would skip the test incorrectly (badformat_subtest()).
v3:
- Don't skip the whole subtest where multiple draw methods are used. (Ashutosh).

Quoted 4 lines
Quoted 84 lines
---
 tests/kms_frontbuffer_tracking.c | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)
tests/kms_frontbuffer_tracking.c +25 -2
index 724f5d16c..c4b4af43a 100644
@@ -1934,6 +1934,9 @@ static void draw_subtest(const struct test_mode *t)
 	struct modeset_params *params = pick_params(t);
 	struct fb_region *target;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (t->screen) {
 	case SCREEN_PRIM:
 		if (t->method != IGT_DRAW_MMAP_GTT && t->plane == PLANE_PRI)
@@ -2032,6 +2035,12 @@ static void multidraw_subtest(const struct test_mode *t)
 			igt_debug("Methods %s and %s\n",
 				  igt_draw_get_method_name(m1),
 				  igt_draw_get_method_name(m2));
+
+			if ((m1 == IGT_DRAW_MMAP_GTT ||
+			     m2 == IGT_DRAW_MMAP_GTT) &&
+			    !gem_has_mappable_ggtt(drm.fd))
+				continue;
+
 			for (r = 0; r < pattern->n_rects; r++) {
 				used_method = (r % 2 == 0) ? m1 : m2;
 
@@ -2276,6 +2285,9 @@ static void flip_subtest(const struct test_mode *t)
 	struct draw_pattern_info *pattern = &pattern1;
 	enum color bg_color;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (t->screen) {
 	case SCREEN_PRIM:
 		assertions |= ASSERT_LAST_ACTION_CHANGED;
@@ -2335,6 +2347,9 @@ static void fliptrack_subtest(const struct test_mode *t, enum flip_type type)
 	struct modeset_params *params = pick_params(t);
 	struct draw_pattern_info *pattern = &pattern1;
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	prepare_subtest(t, pattern);
 
 	create_fb(t->format, params->primary.fb->width, params->primary.fb->height,
@@ -2744,6 +2759,9 @@ static void farfromfence_subtest(const struct test_mode *t)
 	int max_height, assertions = 0;
 	int gen = intel_gen(intel_get_drm_devid(drm.fd));
 
+	igt_skip_on(t->method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd));
+
 	switch (gen) {
 	case 2:
 		max_height = 2048;
@@ -3024,7 +3042,11 @@ static void basic_subtest(const struct test_mode *t)
 		  opt.tiling, t->plane, &fb2);
 	fb1 = params->primary.fb;
 
-	for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++, r++) {
+	for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++) {
+		if (method == IGT_DRAW_MMAP_GTT &&
+		    !gem_has_mappable_ggtt(drm.fd))
+			continue;
+
 		if (r == pattern->n_rects) {
 			params->primary.fb = (params->primary.fb == fb1) ? &fb2 : fb1;
 
@@ -3040,6 +3062,8 @@ static void basic_subtest(const struct test_mode *t)
 		draw_rect(pattern, &params->primary, method, r);
 		update_wanted_crc(t, &pattern->crcs[t->format][r]);
 		do_assertions(assertions);
+
+		r++;
 	}
 
 	igt_remove_fb(drm.fd, &fb2);
--
Quoted 2 lines

2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#25 lore raw

PATCH v2 7/8 lib/igt_draw: Fix igt_draw_fill_fb() on platforms w/o aperture

In reply to Imre Deak

Draw through a CPU mapping on platforms w/o a GTT aperture.

---
 lib/igt_draw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt_draw.c +1 -1
index fa8ab562..b9c3ae26 100644
@@ -728,6 +728,6 @@ void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr,
  */
 void igt_draw_fill_fb(int fd, struct igt_fb *fb, uint32_t color)
 {
-	igt_draw_rect_fb(fd, NULL, NULL, fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(fd, NULL, NULL, fb, IGT_DRAW_MMAP_CPU,
 			 0, 0, fb->width, fb->height, color);
 }
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#26 lore raw

Re: [igt-dev] [PATCH v2 7/8] lib/igt_draw: Fix igt_draw_fill_fb() on platforms w/o aperture

Quoted 15 lines · Imre Deak

Draw through a CPU mapping on platforms w/o a GTT aperture.

---
 lib/igt_draw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt_draw.c +0 -0
index fa8ab562..b9c3ae26 100644

lib/igt_draw.c void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr, · line 732

Quoted 6 lines
lib/igt_draw.c +1 -1
@@ -728,6 +728,6 @@ void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr,
  */
 void igt_draw_fill_fb(int fd, struct igt_fb *fb, uint32_t color)
 {
-	igt_draw_rect_fb(fd, NULL, NULL, fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(fd, NULL, NULL, fb, IGT_DRAW_MMAP_CPU,
 			 0, 0, fb->width, fb->height, color);

Should also be WC.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#27 lore raw

PATCH v3 7/8 lib/igt_draw: Fix igt_draw_fill_fb() on platforms w/o aperture

In reply to Imre Deak

Draw through a WC mapping on platforms w/o a GTT aperture.

v2:
- Use WC instead of CPU mapping. (Ashutosh)

---
 lib/igt_draw.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
lib/igt_draw.c +3 -1
index fa8ab5620..f2340127f 100644
@@ -728,6 +728,8 @@ void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr,
  */
 void igt_draw_fill_fb(int fd, struct igt_fb *fb, uint32_t color)
 {
-	igt_draw_rect_fb(fd, NULL, NULL, fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(fd, NULL, NULL, fb,
+			 gem_has_mappable_ggtt(fd) ? IGT_DRAW_MMAP_GTT :
+						     IGT_DRAW_MMAP_WC,
 			 0, 0, fb->width, fb->height, color);
 }
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v3 7/8
#28 lore raw

Re: [igt-dev] [PATCH v3 7/8] lib/igt_draw: Fix igt_draw_fill_fb() on platforms w/o aperture

Quoted 19 lines · Imre Deak

Draw through a WC mapping on platforms w/o a GTT aperture.

v2:
- Use WC instead of CPU mapping. (Ashutosh)

---
 lib/igt_draw.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
lib/igt_draw.c +0 -0
index fa8ab5620..f2340127f 100644

lib/igt_draw.c void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr, · line 734

Quoted 8 lines
lib/igt_draw.c +3 -1
@@ -728,6 +728,8 @@ void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr,
  */
 void igt_draw_fill_fb(int fd, struct igt_fb *fb, uint32_t color)
 {
-	igt_draw_rect_fb(fd, NULL, NULL, fb, IGT_DRAW_MMAP_GTT,
+	igt_draw_rect_fb(fd, NULL, NULL, fb,
+			 gem_has_mappable_ggtt(fd) ? IGT_DRAW_MMAP_GTT :
+						     IGT_DRAW_MMAP_WC,
 			 0, 0, fb->width, fb->height, color);

Not sure if the conditional switch between GTT and WC is really needed. For example, __gem_mmap__device_coherent() unconditionally prefers WC over GTT. In any case:

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#29 lore raw

PATCH v2 8/8 lib/igt_fb: Make sure tiled YUV framebuffers are fully cleared

In reply to Imre Deak

For tiled FBs that are mapped in an other way than a GTT map we need to clear all tile-rows. Clearing only the first stride*height bytes may leave tiles at the end of the FB uncleared.

v2:
- Don't calculate the plane size for unused planes. (Matt)

---
 lib/igt_fb.c | 31 +++++++++++++++++++++----------
 1 file changed, 21 insertions(+), 10 deletions(-)
lib/igt_fb.c +21 -10
index af3291a2..8bdb0a09 100644
@@ -841,10 +841,21 @@ static void memset64(uint64_t *s, uint64_t c, size_t n)
 static void clear_yuv_buffer(struct igt_fb *fb)
 {
 	bool full_range = fb->color_range == IGT_COLOR_YCBCR_FULL_RANGE;
+	size_t plane_size[2];
 	void *ptr;
 
 	igt_assert(igt_format_is_yuv(fb->drm_format));
 
+	for (int i = 0; i < lookup_drm_format(fb->drm_format)->num_planes; i++) {
+		unsigned int tile_width, tile_height;
+
+		igt_assert_lt(i, ARRAY_SIZE(plane_size));
+		igt_get_fb_tile_size(fb->fd, fb->modifier, fb->plane_bpp[i],
+				     &tile_width, &tile_height);
+		plane_size[i] = fb->strides[i] *
+			ALIGN(fb->plane_height[i], tile_height);
+	}
+
 	/* Ensure the framebuffer is preallocated */
 	ptr = igt_fb_map_buffer(fb->fd, fb);
 	igt_assert(*(uint32_t *)ptr == 0);
@@ -853,48 +864,48 @@ static void clear_yuv_buffer(struct igt_fb *fb)
 	case DRM_FORMAT_NV12:
 		memset(ptr + fb->offsets[0],
 		       full_range ? 0x00 : 0x10,
-		       fb->strides[0] * fb->plane_height[0]);
+		       plane_size[0]);
 		memset(ptr + fb->offsets[1],
 		       0x80,
-		       fb->strides[1] * fb->plane_height[1]);
+		       plane_size[1]);
 		break;
 	case DRM_FORMAT_XYUV8888:
 		wmemset(ptr + fb->offsets[0], full_range ? 0x00008080 : 0x00108080,
-			fb->strides[0] * fb->plane_height[0] / sizeof(wchar_t));
+			plane_size[0] / sizeof(wchar_t));
 		break;
 	case DRM_FORMAT_YUYV:
 	case DRM_FORMAT_YVYU:
 		wmemset(ptr + fb->offsets[0],
 			full_range ? 0x80008000 : 0x80108010,
-			fb->strides[0] * fb->plane_height[0] / sizeof(wchar_t));
+			plane_size[0] / sizeof(wchar_t));
 		break;
 	case DRM_FORMAT_UYVY:
 	case DRM_FORMAT_VYUY:
 		wmemset(ptr + fb->offsets[0],
 			full_range ? 0x00800080 : 0x10801080,
-			fb->strides[0] * fb->plane_height[0] / sizeof(wchar_t));
+			plane_size[0] / sizeof(wchar_t));
 		break;
 	case DRM_FORMAT_P010:
 	case DRM_FORMAT_P012:
 	case DRM_FORMAT_P016:
 		wmemset(ptr, full_range ? 0 : 0x10001000,
-			fb->offsets[1] / sizeof(wchar_t));
+			plane_size[0] / sizeof(wchar_t));
 		wmemset(ptr + fb->offsets[1], 0x80008000,
-			fb->strides[1] * fb->plane_height[1] / sizeof(wchar_t));
+			plane_size[1] / sizeof(wchar_t));
 		break;
 	case DRM_FORMAT_Y210:
 	case DRM_FORMAT_Y212:
 	case DRM_FORMAT_Y216:
 		wmemset(ptr + fb->offsets[0],
 			full_range ? 0x80000000 : 0x80001000,
-			fb->strides[0] * fb->plane_height[0] / sizeof(wchar_t));
+			plane_size[0] / sizeof(wchar_t));
 		break;
 
 	case DRM_FORMAT_XVYU2101010:
 	case DRM_FORMAT_Y410:
 		wmemset(ptr + fb->offsets[0],
 			full_range ? 0x20000200 : 0x20010200,
-		fb->strides[0] * fb->plane_height[0] / sizeof(wchar_t));
+			plane_size[0] / sizeof(wchar_t));
 		break;
 
 	case DRM_FORMAT_XVYU12_16161616:
@@ -903,7 +914,7 @@ static void clear_yuv_buffer(struct igt_fb *fb)
 	case DRM_FORMAT_Y416:
 		memset64(ptr + fb->offsets[0],
 			 full_range ? 0x800000008000ULL : 0x800010008000ULL,
-			 fb->strides[0] * fb->plane_height[0] / sizeof(uint64_t));
+			 plane_size[0] / sizeof(uint64_t));
 		break;
 	}
 
Signature · 6 lines
2.23.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#30 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls

In reply to Imre Deak
== Series Details ==

== Series Details ==

Series: series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls
URL : https://patchwork.freedesktop.org/series/73268/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7904 -> IGTPW_4124
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/index.html

Known issues
------------

Here are the changes found in IGTPW_4124 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_close_race@basic-threads:
- fi-byt-n2820: [PASS][1] -> [INCOMPLETE][2] ([i915#45])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/fi-byt-n2820/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/fi-byt-n2820/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8700k: [INCOMPLETE][3] ([i915#424]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html

* igt@i915_selftest@live_gtt:
- fi-skl-6600u: [TIMEOUT][5] ([fdo#111732] / [fdo#112271]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/fi-skl-6600u/igt@i915_selftest@live_gtt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/fi-skl-6600u/igt@i915_selftest@live_gtt.html

[fdo#111732]: https://bugs.freedesktop.org/show_bug.cgi?id=111732
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45

Participating hosts (46 -> 46)
------------------------------

Additional (5): fi-kbl-soraka fi-hsw-peppy fi-kbl-7500u fi-hsw-4770 fi-gdg-551
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5433 -> IGTPW_4124

CI-20190529: 20190529
CI_DRM_7904: 5de757f49fb13a3c0e42626e7c4b47c2d82b14a1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4124: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/index.html
IGT_5433: 6a96c17f3a1b4e1f90b1a0b0ce42a7219875d1a4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v2 1/8
#31 lore raw
In reply to Imre Deak
Quoted 17 lines · Imre Deak

From: Vanshidhar Konda <[email protected]>

Simplify the number of places from which gem_get_tiling method is called and call it only if the device has support in hardware for tiling.

For consistency also fix up the gem_mmap__cpu() prot argument in draw_rect_mmap_cpu(). Atm, gem_mmap__cpu() ignores this, however the implementation of it may change, so make sure we pass the correct protection flags.

v2:
- Use gem_available_fences() to check for HW detiling.
v3: (Matt)
- Fix docbook for draw_rect_render()
- Remove unused swizzle params from the blt/render draw funcs.
- Describe the gem_mmap__cpu() prot argument fix in the commit log.

Quoted 3 lines
Quoted 237 lines
---
 lib/igt_draw.c                   | 57 ++++++++++++++++----------------
 lib/igt_draw.h                   |  5 +--
 tests/kms_frontbuffer_tracking.c |  8 +++--
 3 files changed, 36 insertions(+), 34 deletions(-)
lib/igt_draw.c +28 -29
index 6950bc49..fa8ab562 100644
@@ -333,20 +333,19 @@ static void draw_rect_ptr_tiled(void *ptr, uint32_t stride, uint32_t tiling,
 }
 
 static void draw_rect_mmap_cpu(int fd, struct buf_data *buf, struct rect *rect,
-			       uint32_t color)
+			       uint32_t tiling, uint32_t swizzle, uint32_t color)
 {
 	uint32_t *ptr;
-	uint32_t tiling, swizzle;
 
 	gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_CPU,
 		       I915_GEM_DOMAIN_CPU);
-	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
 
 	/* We didn't implement suport for the older tiling methods yet. */
 	if (tiling != I915_TILING_NONE)
 		igt_require(intel_gen(intel_get_drm_devid(fd)) >= 5);
 
-	ptr = gem_mmap__cpu(fd, buf->handle, 0, PAGE_ALIGN(buf->size), 0);
+	ptr = gem_mmap__cpu(fd, buf->handle, 0, PAGE_ALIGN(buf->size),
+			    PROT_READ | PROT_WRITE);
 
 	switch (tiling) {
 	case I915_TILING_NONE:
@@ -384,14 +383,12 @@ static void draw_rect_mmap_gtt(int fd, struct buf_data *buf, struct rect *rect,
 }
 
 static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
-			      uint32_t color)
+			      uint32_t tiling, uint32_t swizzle, uint32_t color)
 {
 	uint32_t *ptr;
-	uint32_t tiling, swizzle;
 
 	gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
 		       I915_GEM_DOMAIN_GTT);
-	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
 
 	/* We didn't implement suport for the older tiling methods yet. */
 	if (tiling != I915_TILING_NONE)
@@ -495,12 +492,9 @@ static void draw_rect_pwrite_tiled(int fd, struct buf_data *buf,
 }
 
 static void draw_rect_pwrite(int fd, struct buf_data *buf,
-			     struct rect *rect, uint32_t color)
+			     struct rect *rect, uint32_t tiling,
+			     uint32_t swizzle, uint32_t color)
 {
-	uint32_t tiling, swizzle;
-
-	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
-
 	switch (tiling) {
 	case I915_TILING_NONE:
 		draw_rect_pwrite_untiled(fd, buf, rect, color);
@@ -517,18 +511,15 @@ static void draw_rect_pwrite(int fd, struct buf_data *buf,
 
 static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
 			  struct buf_data *buf, struct rect *rect,
-			  uint32_t color)
+			  uint32_t tiling, uint32_t color)
 {
 	drm_intel_bo *dst;
 	struct intel_batchbuffer *batch;
 	int blt_cmd_len, blt_cmd_tiling, blt_cmd_depth;
 	uint32_t devid = intel_get_drm_devid(fd);
 	int gen = intel_gen(devid);
-	uint32_t tiling, swizzle;
 	int pitch;
 
-	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
-
 	dst = gem_handle_to_libdrm_bo(cmd_data->bufmgr, fd, "", buf->handle);
 	igt_assert(dst);
 
@@ -574,28 +565,25 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
 
 static void draw_rect_render(int fd, struct cmd_data *cmd_data,
 			     struct buf_data *buf, struct rect *rect,
-			     uint32_t color)
+			     uint32_t tiling, uint32_t color)
 {
 	drm_intel_bo *src, *dst;
 	uint32_t devid = intel_get_drm_devid(fd);
 	igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid);
 	struct igt_buf src_buf = {}, dst_buf = {};
 	struct intel_batchbuffer *batch;
-	uint32_t tiling, swizzle;
 	struct buf_data tmp;
 	int pixel_size = buf->bpp / 8;
 
 	igt_skip_on(!rendercopy);
 
-	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
-
 	/* We create a temporary buffer and copy from it using rendercopy. */
 	tmp.size = rect->w * rect->h * pixel_size;
 	tmp.handle = gem_create(fd, tmp.size);
 	tmp.stride = rect->w * pixel_size;
 	tmp.bpp = buf->bpp;
 	draw_rect_mmap_cpu(fd, &tmp, &(struct rect){0, 0, rect->w, rect->h},
-			   color);
+			   I915_TILING_NONE, I915_BIT_6_SWIZZLE_NONE, color);
 
 	src = gem_handle_to_libdrm_bo(cmd_data->bufmgr, fd, "", tmp.handle);
 	igt_assert(src);
@@ -634,6 +622,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
  * @buf_handle: the handle of the buffer where you're going to draw to
  * @buf_size: the size of the buffer
  * @buf_stride: the stride of the buffer
+ * @tiling: the tiling of the buffer
  * @method: method you're going to use to write to the buffer
  * @rect_x: horizontal position on the buffer where your rectangle starts
  * @rect_y: vertical position on the buffer where your rectangle starts
@@ -647,9 +636,12 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
  */
 void igt_draw_rect(int fd, drm_intel_bufmgr *bufmgr, drm_intel_context *context,
 		   uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
-		   enum igt_draw_method method, int rect_x, int rect_y,
-		   int rect_w, int rect_h, uint32_t color, int bpp)
+		   uint32_t tiling, enum igt_draw_method method,
+		   int rect_x, int rect_y, int rect_w, int rect_h,
+		   uint32_t color, int bpp)
 {
+	uint32_t buf_tiling, swizzle;
+
 	struct cmd_data cmd_data = {
 		.bufmgr = bufmgr,
 		.context = context,
@@ -667,24 +659,30 @@ void igt_draw_rect(int fd, drm_intel_bufmgr *bufmgr, drm_intel_context *context,
 		.h = rect_h,
 	};
 
+	swizzle = I915_BIT_6_SWIZZLE_NONE;
+	if (tiling != I915_TILING_NONE && gem_available_fences(fd)) {
+		gem_get_tiling(fd, buf_handle, &buf_tiling, &swizzle);
+		igt_assert(tiling == buf_tiling);
+	}
+
 	switch (method) {
 	case IGT_DRAW_MMAP_CPU:
-		draw_rect_mmap_cpu(fd, &buf, &rect, color);
+		draw_rect_mmap_cpu(fd, &buf, &rect, tiling, swizzle, color);
 		break;
 	case IGT_DRAW_MMAP_GTT:
 		draw_rect_mmap_gtt(fd, &buf, &rect, color);
 		break;
 	case IGT_DRAW_MMAP_WC:
-		draw_rect_mmap_wc(fd, &buf, &rect, color);
+		draw_rect_mmap_wc(fd, &buf, &rect, tiling, swizzle, color);
 		break;
 	case IGT_DRAW_PWRITE:
-		draw_rect_pwrite(fd, &buf, &rect, color);
+		draw_rect_pwrite(fd, &buf, &rect, tiling, swizzle, color);
 		break;
 	case IGT_DRAW_BLT:
-		draw_rect_blt(fd, &cmd_data, &buf, &rect, color);
+		draw_rect_blt(fd, &cmd_data, &buf, &rect, tiling, color);
 		break;
 	case IGT_DRAW_RENDER:
-		draw_rect_render(fd, &cmd_data, &buf, &rect, color);
+		draw_rect_render(fd, &cmd_data, &buf, &rect, tiling, color);
 		break;
 	default:
 		igt_assert(false);
@@ -715,7 +713,8 @@ void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr,
 		      int rect_w, int rect_h, uint32_t color)
 {
 	igt_draw_rect(fd, bufmgr, context, fb->gem_handle, fb->size, fb->strides[0],
-		      method, rect_x, rect_y, rect_w, rect_h, color,
+		      igt_fb_mod_to_tiling(fb->modifier), method,
+		      rect_x, rect_y, rect_w, rect_h, color,
 		      igt_drm_format_to_bpp(fb->drm_format));
 }
 
lib/igt_draw.h +3 -2
index b030131e..ec146754 100644
@@ -52,8 +52,9 @@ const char *igt_draw_get_method_name(enum igt_draw_method method);
 
 void igt_draw_rect(int fd, drm_intel_bufmgr *bufmgr, drm_intel_context *context,
 		   uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
-		   enum igt_draw_method method, int rect_x, int rect_y,
-		   int rect_w, int rect_h, uint32_t color, int bpp);
+		   uint32_t tiling, enum igt_draw_method method,
+		   int rect_x, int rect_y, int rect_w, int rect_h,
+		   uint32_t color, int bpp);
 
 void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr,
 		      drm_intel_context *context, struct igt_fb *fb,
tests/kms_frontbuffer_tracking.c +5 -3
index 2c765c34..9c2c3a5d 100644
@@ -291,6 +291,7 @@ struct {
 	int height;
 	uint32_t color;
 	int bpp;
+	uint32_t tiling;
 } busy_thread = {
 	.stop = true,
 };
@@ -1126,9 +1127,9 @@ static void *busy_thread_func(void *data)
 	while (!busy_thread.stop)
 		igt_draw_rect(drm.fd, drm.bufmgr, NULL, busy_thread.handle,
 			      busy_thread.size, busy_thread.stride,
-			      IGT_DRAW_BLT, 0, 0, busy_thread.width,
-			      busy_thread.height, busy_thread.color,
-			      busy_thread.bpp);
+			      busy_thread.tiling, IGT_DRAW_BLT, 0, 0,
+			      busy_thread.width, busy_thread.height,
+			      busy_thread.color, busy_thread.bpp);
 
 	pthread_exit(0);
 }
@@ -1146,6 +1147,7 @@ static void start_busy_thread(struct igt_fb *fb)
 	busy_thread.height = fb->height;
 	busy_thread.color = pick_color(fb, COLOR_PRIM_BG);
 	busy_thread.bpp = igt_drm_format_to_bpp(fb->drm_format);
+	busy_thread.tiling = igt_fb_mod_to_tiling(fb->modifier);
 
 	rc = pthread_create(&busy_thread.thread, NULL, busy_thread_func, NULL);
 	igt_assert_eq(rc, 0);
Signature · 1 line
2.23.1
Signature · 9 lines
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#32 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls

In reply to Imre Deak
== Series Details ==

== Series Details ==

Series: series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls
URL : https://patchwork.freedesktop.org/series/73268/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7904_full -> IGTPW_4124_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/index.html

Known issues
------------

Here are the changes found in IGTPW_4124_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +6 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb6/igt@[email protected]

* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110841])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112146]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb1/igt@[email protected]

* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb1/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][9] -> [DMESG-WARN][10] ([i915#716])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-glk7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-glk4/igt@[email protected]

* igt@i915_selftest@live_gtt:
- shard-kbl: [PASS][11] -> [TIMEOUT][12] ([fdo#112271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-kbl2/igt@i915_selftest@live_gtt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-kbl6/igt@i915_selftest@live_gtt.html

* igt@kms_cursor_crc@pipe-a-cursor-64x64-random:
- shard-tglb: [PASS][13] -> [FAIL][14] ([fdo#111703]) +5 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb6/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled:
- shard-tglb: [PASS][15] -> [DMESG-FAIL][16] ([i915#402]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb2/igt@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][17] -> [SKIP][18] ([i915#433])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb3/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-apl3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-apl4/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-kbl2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid:
- shard-tglb: [PASS][23] -> [FAIL][24] ([i915#1184])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb6/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#899])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-glk8/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-glk9/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb2/igt@kms_psr@psr2_basic.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb3/igt@kms_psr@psr2_basic.html

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-tglb: [PASS][29] -> [SKIP][30] ([i915#668]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb6/igt@kms_psr@psr2_primary_mmap_cpu.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb5/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][31] -> [FAIL][32] ([i915#31])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-apl8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-apl6/igt@[email protected]

* igt@perf_pmu@rc6-runtime-pm-long:
- shard-hsw: [PASS][33] -> [INCOMPLETE][34] ([CI#80] / [i915#61])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-hsw2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-hsw7/igt@[email protected]

* igt@prime_vgem@coherency-gtt:
- shard-snb: [PASS][35] -> [DMESG-WARN][36] ([i915#478])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-snb4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-snb2/igt@[email protected]

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109276]) +20 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb8/igt@[email protected]

#### Possible fixes ####

* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][39] ([fdo#112080]) -> [PASS][40] +14 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb8/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb2/igt@[email protected]

* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][41] ([fdo#110854]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd:
- shard-iclb: [SKIP][43] ([fdo#112146]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb8/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-hsw: [FAIL][45] ([i915#694]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-hsw6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-hsw1/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [FAIL][47] ([i915#644]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-apl6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-apl4/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][49] ([i915#454]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb3/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- shard-iclb: [FAIL][51] ([i915#413]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb8/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-apl1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-apl6/igt@[email protected]

* igt@kms_big_fb@y-tiled-16bpp-rotate-180:
- shard-tglb: [DMESG-FAIL][55] ([i915#402]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb8/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-64x64-onscreen:
- shard-kbl: [FAIL][57] ([i915#54]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-kbl2/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-kbl1/igt@[email protected]
- shard-apl: [FAIL][59] ([i915#54]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-apl7/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-apl2/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge:
- shard-tglb: [FAIL][61] ([i915#70]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb8/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb5/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled:
- shard-tglb: [FAIL][63] ([i915#559]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb6/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][65] ([i915#61]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-hsw4/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-hsw7/igt@[email protected]

* igt@kms_flip_tiling@flip-changes-tiling:
- shard-tglb: [FAIL][67] ([i915#699]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][69] ([i915#180]) -> [PASS][70] +6 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-kbl7/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-kbl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-tglb: [SKIP][71] ([i915#668]) -> [PASS][72] +5 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb8/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb5/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-tglb: [FAIL][73] ([i915#1184]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb6/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-glk: [FAIL][75] ([i915#899]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-glk4/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-glk4/igt@[email protected]

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_rotation_crc@sprite-rotation-270:
- shard-tglb: [FAIL][79] ([i915#65]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb2/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb8/igt@[email protected]

* igt@prime_busy@after-bsd2:
- shard-iclb: [SKIP][81] ([fdo#109276]) -> [PASS][82] +17 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb8/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb1/igt@[email protected]

* igt@prime_mmap_coherency@ioctl-errors:
- shard-hsw: [FAIL][83] ([i915#831]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-hsw4/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-hsw7/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [SKIP][85] ([fdo#112080]) -> [FAIL][86] ([IGT#28])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb5/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb2/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][87] ([i915#454]) -> [SKIP][88] ([i915#668])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb1/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb5/igt@[email protected]

* igt@perf@gen12-mi-rpc:
- shard-tglb: [TIMEOUT][89] ([fdo#112271] / [i915#1085] / [i915#472]) -> [TIMEOUT][90] ([fdo#112271] / [i915#1085])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb7/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb3/igt@[email protected]

[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085
[i915#1184]: https://gitlab.freedesktop.org/drm/intel/issues/1184
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#559]: https://gitlab.freedesktop.org/drm/intel/issues/559
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#65]: https://gitlab.freedesktop.org/drm/intel/issues/65
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
[i915#70]: https://gitlab.freedesktop.org/drm/intel/issues/70
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#831]: https://gitlab.freedesktop.org/drm/intel/issues/831
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5433 -> IGTPW_4124
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_7904: 5de757f49fb13a3c0e42626e7c4b47c2d82b14a1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4124: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/index.html
IGT_5433: 6a96c17f3a1b4e1f90b1a0b0ce42a7219875d1a4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#33 lore raw

Re: [igt-dev] ✓ Fi.CI.IGT: success for series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls

Quoted 5 lines · Patchwork

== Series Details ==

Series: series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls
URL : https://patchwork.freedesktop.org/series/73268/
State : success

Thanks for the review, pushed to igt.

Quoted 308 lines

== Summary ==

CI Bug Log - changes from CI_DRM_7904_full -> IGTPW_4124_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/index.html

Known issues
------------

Here are the changes found in IGTPW_4124_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +6 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb6/igt@[email protected]

* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110841])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112146]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb1/igt@[email protected]

* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb1/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][9] -> [DMESG-WARN][10] ([i915#716])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-glk7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-glk4/igt@[email protected]

* igt@i915_selftest@live_gtt:
- shard-kbl: [PASS][11] -> [TIMEOUT][12] ([fdo#112271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-kbl2/igt@i915_selftest@live_gtt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-kbl6/igt@i915_selftest@live_gtt.html

* igt@kms_cursor_crc@pipe-a-cursor-64x64-random:
- shard-tglb: [PASS][13] -> [FAIL][14] ([fdo#111703]) +5 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb6/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled:
- shard-tglb: [PASS][15] -> [DMESG-FAIL][16] ([i915#402]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb2/igt@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][17] -> [SKIP][18] ([i915#433])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb3/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-apl3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-apl4/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-kbl2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid:
- shard-tglb: [PASS][23] -> [FAIL][24] ([i915#1184])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb6/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#899])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-glk8/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-glk9/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb2/igt@kms_psr@psr2_basic.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb3/igt@kms_psr@psr2_basic.html

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-tglb: [PASS][29] -> [SKIP][30] ([i915#668]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb6/igt@kms_psr@psr2_primary_mmap_cpu.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb5/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][31] -> [FAIL][32] ([i915#31])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-apl8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-apl6/igt@[email protected]

* igt@perf_pmu@rc6-runtime-pm-long:
- shard-hsw: [PASS][33] -> [INCOMPLETE][34] ([CI#80] / [i915#61])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-hsw2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-hsw7/igt@[email protected]

* igt@prime_vgem@coherency-gtt:
- shard-snb: [PASS][35] -> [DMESG-WARN][36] ([i915#478])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-snb4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-snb2/igt@[email protected]

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109276]) +20 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb8/igt@[email protected]

#### Possible fixes ####

* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][39] ([fdo#112080]) -> [PASS][40] +14 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb8/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb2/igt@[email protected]

* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][41] ([fdo#110854]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd:
- shard-iclb: [SKIP][43] ([fdo#112146]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb8/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-hsw: [FAIL][45] ([i915#694]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-hsw6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-hsw1/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [FAIL][47] ([i915#644]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-apl6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-apl4/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][49] ([i915#454]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb3/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- shard-iclb: [FAIL][51] ([i915#413]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb8/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-apl1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-apl6/igt@[email protected]

* igt@kms_big_fb@y-tiled-16bpp-rotate-180:
- shard-tglb: [DMESG-FAIL][55] ([i915#402]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb8/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-64x64-onscreen:
- shard-kbl: [FAIL][57] ([i915#54]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-kbl2/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-kbl1/igt@[email protected]
- shard-apl: [FAIL][59] ([i915#54]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-apl7/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-apl2/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge:
- shard-tglb: [FAIL][61] ([i915#70]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb8/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb5/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled:
- shard-tglb: [FAIL][63] ([i915#559]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb6/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][65] ([i915#61]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-hsw4/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-hsw7/igt@[email protected]

* igt@kms_flip_tiling@flip-changes-tiling:
- shard-tglb: [FAIL][67] ([i915#699]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][69] ([i915#180]) -> [PASS][70] +6 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-kbl7/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-kbl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-tglb: [SKIP][71] ([i915#668]) -> [PASS][72] +5 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb8/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb5/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-tglb: [FAIL][73] ([i915#1184]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb6/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-glk: [FAIL][75] ([i915#899]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-glk4/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-glk4/igt@[email protected]

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_rotation_crc@sprite-rotation-270:
- shard-tglb: [FAIL][79] ([i915#65]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb2/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb8/igt@[email protected]

* igt@prime_busy@after-bsd2:
- shard-iclb: [SKIP][81] ([fdo#109276]) -> [PASS][82] +17 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb8/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb1/igt@[email protected]

* igt@prime_mmap_coherency@ioctl-errors:
- shard-hsw: [FAIL][83] ([i915#831]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-hsw4/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-hsw7/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [SKIP][85] ([fdo#112080]) -> [FAIL][86] ([IGT#28])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-iclb5/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-iclb2/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][87] ([i915#454]) -> [SKIP][88] ([i915#668])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb1/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb5/igt@[email protected]

* igt@perf@gen12-mi-rpc:
- shard-tglb: [TIMEOUT][89] ([fdo#112271] / [i915#1085] / [i915#472]) -> [TIMEOUT][90] ([fdo#112271] / [i915#1085])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7904/shard-tglb7/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/shard-tglb3/igt@[email protected]

[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085
[i915#1184]: https://gitlab.freedesktop.org/drm/intel/issues/1184
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#559]: https://gitlab.freedesktop.org/drm/intel/issues/559
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#65]: https://gitlab.freedesktop.org/drm/intel/issues/65
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
[i915#70]: https://gitlab.freedesktop.org/drm/intel/issues/70
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#831]: https://gitlab.freedesktop.org/drm/intel/issues/831
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5433 -> IGTPW_4124
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_7904: 5de757f49fb13a3c0e42626e7c4b47c2d82b14a1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4124: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/index.html
IGT_5433: 6a96c17f3a1b4e1f90b1a0b0ce42a7219875d1a4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

Quoted 3 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4124/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#34 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls (rev4)

In reply to Imre Deak
== Series Details ==

== Series Details ==

Series: series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls (rev4)
URL : https://patchwork.freedesktop.org/series/73268/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7925 -> IGTPW_4139
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/index.html

Known issues
------------

Here are the changes found in IGTPW_4139 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_close_race@basic-threads:
- fi-hsw-4770r: [PASS][1] -> [TIMEOUT][2] ([fdo#112271] / [i915#1084])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/fi-hsw-4770r/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/fi-hsw-4770r/igt@[email protected]

* igt@i915_selftest@live_gem_contexts:
- fi-cfl-guc: [PASS][3] -> [INCOMPLETE][4] ([CI#80] / [fdo#106070] / [i915#424])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html

* igt@i915_selftest@live_hangcheck:
- fi-icl-dsi: [PASS][5] -> [INCOMPLETE][6] ([fdo#108569])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html

#### Possible fixes ####

* igt@gem_close_race@basic-threads:
- fi-hsw-peppy: [TIMEOUT][7] ([fdo#112271] / [i915#1084]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/fi-hsw-peppy/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/fi-hsw-peppy/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][9] ([i915#178]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/fi-skl-6770hq/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/fi-skl-6770hq/igt@[email protected]

* igt@i915_selftest@live_gtt:
- {fi-tgl-dsi}: [TIMEOUT][11] ([fdo#112126] / [fdo#112271]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/fi-tgl-dsi/igt@i915_selftest@live_gtt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/fi-tgl-dsi/igt@i915_selftest@live_gtt.html

* igt@i915_selftest@live_hangcheck:
- fi-icl-y: [INCOMPLETE][13] ([fdo#108569]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/fi-icl-y/igt@i915_selftest@live_hangcheck.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937

Participating hosts (42 -> 45)
------------------------------

Additional (9): fi-kbl-7560u fi-ivb-3770 fi-cfl-8109u fi-skl-6700k2 fi-skl-lmem fi-blb-e6850 fi-kbl-r fi-skl-6600u fi-snb-2600
Missing (6): fi-kbl-soraka fi-bsw-n3050 fi-byt-squawks fi-ctg-p8600 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5437 -> IGTPW_4139

CI-20190529: 20190529
CI_DRM_7925: b266b79c3de9874e0f991b6a9cc284a424094649 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4139: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/index.html
IGT_5437: ae42fedfd0c536c560e8e17b06d9c7b94a4e8f0c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#35 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls (rev4)

In reply to Imre Deak
== Series Details ==

== Series Details ==

Series: series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls (rev4)
URL : https://patchwork.freedesktop.org/series/73268/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7925_full -> IGTPW_4139_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/index.html

New tests
---------

New tests have been introduced between CI_DRM_7925_full and IGTPW_4139_full:

### New IGT tests (3) ###

* igt@kms_content_protection@atomic-dpms:
- Statuses : 2 fail(s) 5 skip(s)
- Exec time: [0.0, 126.73] s

* igt@kms_psr2_su@frontbuffer:
- Statuses : 2 pass(s) 5 skip(s)
- Exec time: [0.0, 0.48] s

* igt@kms_psr2_su@page_flip:
- Statuses : 1 pass(s) 6 skip(s)
- Exec time: [0.0, 0.29] s

Known issues
------------

Here are the changes found in IGTPW_4139_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +13 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb6/igt@[email protected]

* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112146]) +7 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb4/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-hsw: [PASS][5] -> [FAIL][6] ([i915#694])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-hsw1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-hsw5/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#644])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-apl8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-apl3/igt@[email protected]

* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#447])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb3/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-modeset:
- shard-kbl: [PASS][11] -> [INCOMPLETE][12] ([fdo#103665] / [i915#151])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-kbl4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-kbl2/igt@[email protected]

* igt@i915_pm_rps@reset:
- shard-iclb: [PASS][13] -> [FAIL][14] ([i915#413])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb6/igt@[email protected]

* igt@i915_selftest@live_gtt:
- shard-kbl: [PASS][15] -> [TIMEOUT][16] ([fdo#112271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-kbl7/igt@i915_selftest@live_gtt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-kbl1/igt@i915_selftest@live_gtt.html

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-kbl: [PASS][17] -> [INCOMPLETE][18] ([fdo#103665])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-kbl2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-kbl3/igt@[email protected]

* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#1172])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb8/igt@[email protected]
- shard-iclb: [PASS][21] -> [SKIP][22] ([i915#1140])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb2/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge:
- shard-tglb: [PASS][23] -> [FAIL][24] ([i915#70])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb8/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-blt-ytiled:
- shard-tglb: [PASS][25] -> [DMESG-FAIL][26] ([i915#402])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb6/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-kbl: [PASS][27] -> [FAIL][28] ([i915#79])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-kbl2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-kbl1/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([i915#180]) +5 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-kbl2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-kbl6/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([i915#180]) +4 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-apl2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-apl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-tglb: [PASS][33] -> [FAIL][34] ([i915#1184])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb5/igt@[email protected]

* igt@kms_plane_cursor@pipe-a-viewport-size-256:
- shard-tglb: [PASS][35] -> [FAIL][36] ([i915#1139])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb8/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb1/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb8/igt@kms_psr@psr2_cursor_render.html

* igt@kms_rotation_crc@primary-x-tiled-reflect-x-180:
- shard-tglb: [PASS][39] -> [DMESG-FAIL][40] ([i915#402] / [i915#65])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb8/igt@[email protected]

* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109276]) +14 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb6/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][43] ([fdo#112080]) -> [PASS][44] +6 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb7/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [SKIP][45] ([i915#677]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb8/igt@[email protected]

* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [SKIP][47] ([fdo#109276]) -> [PASS][48] +18 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][49] ([fdo#112146]) -> [PASS][50] +5 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb2/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb3/igt@[email protected]

* igt@gem_partial_pwrite_pread@reads:
- shard-hsw: [FAIL][51] ([i915#694]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-hsw1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-hsw6/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][53] ([fdo#111870] / [i915#478]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-snb2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-snb6/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][55] ([i915#454]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb4/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- shard-iclb: [FAIL][57] ([i915#413]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb8/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb8/igt@[email protected]

* igt@i915_selftest@live_gtt:
- shard-hsw: [TIMEOUT][59] ([fdo#112271]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-hsw5/igt@i915_selftest@live_gtt.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-hsw5/igt@i915_selftest@live_gtt.html

* igt@i915_suspend@debugfs-reader:
- shard-iclb: [INCOMPLETE][61] -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb3/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding:
- shard-tglb: [FAIL][63] ([fdo#111703]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [DMESG-WARN][65] ([i915#180]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-apl4/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-apl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-kbl4/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-kbl4/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-a-128x128-left-edge:
- shard-tglb: [FAIL][69] ([i915#70]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb7/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb2/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled:
- shard-tglb: [DMESG-FAIL][71] ([i915#402]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb5/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb2/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
- shard-tglb: [FAIL][73] ([i915#559]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb8/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb5/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][75] ([i915#79]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-glk1/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-glk1/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][77] ([i915#61]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-hsw2/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-hsw5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-apl: [FAIL][79] ([i915#49]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-apl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
- shard-kbl: [FAIL][81] ([i915#49]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_plane_cursor@pipe-a-overlay-size-256:
- shard-tglb: [FAIL][83] ([i915#1139]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb3/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb6/igt@[email protected]

* igt@kms_psr2_su@frontbuffer (NEW):
- shard-iclb: [SKIP][85] ([fdo#109642] / [fdo#111068]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb6/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb2/igt@[email protected]

* igt@kms_psr@primary_mmap_cpu:
- shard-tglb: [SKIP][87] ([i915#668]) -> [PASS][88] +3 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb3/igt@kms_psr@primary_mmap_cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb2/igt@kms_psr@primary_mmap_cpu.html

* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][89] ([fdo#109441]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_cpu.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html

* igt@kms_setmode@basic:
- shard-apl: [FAIL][91] ([i915#31]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-apl2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-apl7/igt@[email protected]

* igt@perf@gen12-mi-rpc:
- shard-tglb: [TIMEOUT][93] ([fdo#112271] / [i915#1085]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-tglb7/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-tglb8/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][95] ([IGT#28]) -> [SKIP][96] ([fdo#112080])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb2/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb7/igt@[email protected]

* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [SKIP][97] ([fdo#112080]) -> [FAIL][98] ([IGT#28])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-iclb6/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-iclb2/igt@[email protected]

* igt@gem_tiled_blits@interruptible:
- shard-hsw: [FAIL][99] ([i915#694]) -> [FAIL][100] ([i915#818])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-hsw7/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-hsw5/igt@[email protected]

* igt@gem_tiled_blits@normal:
- shard-hsw: [FAIL][101] ([i915#818]) -> [INCOMPLETE][102] ([i915#61])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-hsw7/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-hsw1/igt@[email protected]

* igt@i915_pm_rpm@system-suspend:
- shard-snb: [SKIP][103] ([fdo#109271]) -> [INCOMPLETE][104] ([i915#82])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-snb5/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/shard-snb2/igt@[email protected]

[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085
[i915#1139]: https://gitlab.freedesktop.org/drm/intel/issues/1139
[i915#1140]: https://gitlab.freedesktop.org/drm/intel/issues/1140
[i915#1172]: https://gitlab.freedesktop.org/drm/intel/issues/1172
[i915#1184]: https://gitlab.freedesktop.org/drm/intel/issues/1184
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#447]: https://gitlab.freedesktop.org/drm/intel/issues/447
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#559]: https://gitlab.freedesktop.org/drm/intel/issues/559
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#65]: https://gitlab.freedesktop.org/drm/intel/issues/65
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#70]: https://gitlab.freedesktop.org/drm/intel/issues/70
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5437 -> IGTPW_4139
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_7925: b266b79c3de9874e0f991b6a9cc284a424094649 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4139: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/index.html
IGT_5437: ae42fedfd0c536c560e8e17b06d9c7b94a4e8f0c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4139/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev