Skip to contentSkip to conversation

ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties

PATCH Applied Johan Hovold 3 participants 3 messages Feb 12, 2020 – Feb 17, 2020

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

PATCH 1/1 ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties

The sram-node compatible properties have mistakingly combined the model-specific string with the generic "mtd-ram" string.

Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are not present in any binding.

The physmap driver will however bind to platform devices that specify "mtd-ram".

Fixes fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
Cc Sanchayan Maity <[email protected]>
Cc Marcel Ziswiler <[email protected]>
Cc Shawn Guo <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts +2 -2
index cd075621de52..84fcc203a2e4 100644
@@ -275,7 +275,7 @@ &weim {
 
 	/* SRAM on Colibri nEXT_CS0 */
 	sram@0,0 {
-		compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
+		compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
 		reg = <0 0 0x00010000>;
 		#address-cells = <1>;
 		#size-cells = <1>;

@@ -286,7 +286,7 @@ sram@0,0 {
 
 	/* SRAM on Colibri nEXT_CS1 */
 	sram@1,0 {
-		compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
+		compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
 		reg = <1 0 0x00010000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
Signature · 1 line
2.24.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Johan Hovold

The sram-node compatible properties have mistakingly combined the model-specific string with the generic "mtd-ram" string.

Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are not present in any binding.

Quoted 8 lines

The physmap driver will however bind to platform devices that specify "mtd-ram".

Fixes fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
Cc Sanchayan Maity <[email protected]>
Cc Marcel Ziswiler <[email protected]>
Cc Shawn Guo <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
Reviewed-by Oleksandr Suvorov <[email protected]>
Quoted 27 lines
---
 arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts +2 -3
index cd075621de52..84fcc203a2e4 100644
@@ -275,7 +275,7 @@ &weim {
 
        /* SRAM on Colibri nEXT_CS0 */
        sram@0,0 {
-               compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
+               compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
                reg = <0 0 0x00010000>;
                #address-cells = <1>;
                #size-cells = <1>;

@@ -286,7 +286,7 @@ sram@0,0 {
 
        /* SRAM on Colibri nEXT_CS1 */
        sram@1,0 {
-               compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
+               compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
                reg = <1 0 0x00010000>;
                #address-cells = <1>;
                #size-cells = <1>;
--
Quoted 2 lines

2.24.1

--
Best regards

Oleksandr Suvorov
[email protected]

Applied
#2 lore raw
In reply to Johan Hovold
Quoted 7 lines · Johan Hovold

The sram-node compatible properties have mistakingly combined the model-specific string with the generic "mtd-ram" string.

Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are not present in any binding.

Quoted 8 lines

The physmap driver will however bind to platform devices that specify "mtd-ram".

Fixes fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
Cc Sanchayan Maity <[email protected]>
Cc Marcel Ziswiler <[email protected]>
Cc Shawn Guo <[email protected]>
Signed-off-by Johan Hovold <[email protected]>

Applied, thanks.