mips: cmd: go: Flush cache before jumping to app/image
PATCH 1/1 mips: cmd: go: Flush cache before jumping to app/image
It has been noticed on MT7628/88 platforms, that booting the RAM image does not work reliably. Sometimes it works and sometimes not. Debugging showed that this "might" be a cache related issue as very strange errors occurred (e.g. output corrupted etc).
This patch adds a cache flush for the complete SDRAM area to the go cmd before jumping to the entry point for the MIPS architecture. The complete area is flushed as we don't know at this point, how big the area of the "application" really is.
--- arch/mips/lib/Makefile | 1 + arch/mips/lib/boot.c | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 arch/mips/lib/boot.c
arch/mips/lib/Makefile +1 -0
@@ -11,5 +11,6 @@ obj-y += stack.o obj-y += traps.o obj-$(CONFIG_CMD_BOOTM) += bootm.o +obj-$(CONFIG_CMD_GO) += boot.o lib-$(CONFIG_USE_PRIVATE_LIBGCC) += ashldi3.o ashrdi3.o lshrdi3.o
arch/mips/lib/boot.c new file +23 -0
@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright (C) 2020 Stefan Roese <[email protected]> +*/ + +#include <common.h> +#include <command.h> +#include <cpu_func.h> + +DECLARE_GLOBAL_DATA_PTR ; + +unsigned long do_go_exec (ulong (*entry)(int ,char *const []), +int argc,char *const argv[]) +{ +/* +* Flush cache before jumping to application. Let's flush the +* whole SDRAM area, since we don't know the size of the image +* that was loaded. +*/ +flush_cache (gd->bd->bi_memstart, gd->bd->bi_memsize); + +return entry (argc, argv); +}
Signature · 1 line
2.25.0
PATCH 1/1 mips: cmd: go: Flush cache before jumping to app/image
Tested on VoCore2 board.
RAM loading seems to work flawlessly.
Regards
Mauro
Quoted 60 lines · Stefan Roese
It has been noticed on MT7628/88 platforms, that booting the RAM image does not work reliably. Sometimes it works and sometimes not. Debugging showed that this "might" be a cache related issue as very strange errors occurred (e.g. output corrupted etc).
This patch adds a cache flush for the complete SDRAM area to the go cmd before jumping to the entry point for the MIPS architecture. The complete area is flushed as we don't know at this point, how big the area of the "application" really is.
Signed-off-by Stefan Roese <[email protected]>Cc Daniel Schwierzeck <[email protected]>Cc Mauro Condarelli <[email protected]>Cc Weijie Gao <[email protected]>--- arch/mips/lib/Makefile | 1 + arch/mips/lib/boot.c | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 arch/mips/lib/boot.carch/mips/lib/Makefile +1
-0@@ -11,5 +11,6 @@ obj-y += stack.o obj-y += traps.o obj-$(CONFIG_CMD_BOOTM) += bootm.o +obj-$(CONFIG_CMD_GO) += boot.o lib-$(CONFIG_USE_PRIVATE_LIBGCC) += ashldi3.o ashrdi3.o lshrdi3.oarch/mips/lib/boot.c new file +23
-0@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright (C) 2020 Stefan Roese <[email protected]> +*/ + +#include <common.h> +#include <command.h> +#include <cpu_func.h> + +DECLARE_GLOBAL_DATA_PTR ; + +unsigned long do_go_exec (ulong (*entry)(int ,char *const []), +int argc,char *const argv[]) +{ +/* +* Flush cache before jumping to application. Let's flush the +* whole SDRAM area, since we don't know the size of the image +* that was loaded. +*/ +flush_cache (gd->bd->bi_memstart, gd->bd->bi_memsize); + +return entry (argc, argv); +}
PATCH 1/1 mips: cmd: go: Flush cache before jumping to app/image
In reply to Stefan RoeseQuoted 48 lines · Stefan Roese
It has been noticed on MT7628/88 platforms, that booting the RAM image does not work reliably. Sometimes it works and sometimes not. Debugging showed that this "might" be a cache related issue as very strange errors occurred (e.g. output corrupted etc).
This patch adds a cache flush for the complete SDRAM area to the go cmd before jumping to the entry point for the MIPS architecture. The complete area is flushed as we don't know at this point, how big the area of the "application" really is.
Signed-off-by Stefan Roese <[email protected]>Cc Daniel Schwierzeck <[email protected]>Cc Mauro Condarelli <[email protected]>Cc Weijie Gao <[email protected]>--- arch/mips/lib/Makefile | 1 + arch/mips/lib/boot.c | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 arch/mips/lib/boot.carch/mips/lib/Makefile +1
-0@@ -11,5 +11,6 @@ obj-y += stack.o obj-y += traps.o obj-$(CONFIG_CMD_BOOTM) += bootm.o +obj-$(CONFIG_CMD_GO) += boot.o lib-$(CONFIG_USE_PRIVATE_LIBGCC) += ashldi3.o ashrdi3.o lshrdi3.oarch/mips/lib/boot.c new file +10
-0@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright (C) 2020 Stefan Roese <[email protected]> +*/ + +#include <common.h> +#include <command.h> +#include <cpu_func.h> + +DECLARE_GLOBAL_DATA_PTR ;
arch/mips/lib/boot.c line 20
Quoted 10 lines
arch/mips/lib/boot.c new file +10
-0+ +unsigned long do_go_exec (ulong (*entry)(int ,char *const []), +int argc,char *const argv[]) +{ +/* +* Flush cache before jumping to application. Let's flush the +* whole SDRAM area, since we don't know the size of the image +* that was loaded. +*/ +flush_cache (gd->bd->bi_memstart, gd->bd->bi_memsize);
please replace gd->bd->bi_memsize with gd->ram_top. One reason is described in
https://patchwork.ozlabs.org/patch/677363/
This also covers MIPS platforms with 64 Bit or multiple or non-linear memory mappings. Thanks.
Otherwise:
Quoted 6 lines
arch/mips/lib/boot.c new file +3
-1+ +return entry (argc, argv); +} --2.25.0
Signature · 1 line
- Daniel