ext4: Simplify checking quota limits in ext4_statfs()
Jan Kara
reviewerPATCH 1/1 ext4: Simplify checking quota limits in ext4_statfs()
Coverity reports that conditions checking quota limits in ext4_statfs() contain dead code. Indeed it is right and current conditions can be simplified.
Reported-by Coverity <[email protected]>
Signed-off-by Jan Kara <[email protected]>
--- fs/ext4/super.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
Note, currently this applies to 'dev' branch in ext4.git.
fs/ext4/super.c +2 -8
@@ -5585,10 +5585,7 @@ static int ext4_statfs_project(struct super_block *sb,return PTR_ERR (dquot);spin_lock (&dquot->dq_dqb_lock); - limit =0 ; -if (dquot->dq_dqb.dqb_bsoftlimit && - (!limit || dquot->dq_dqb.dqb_bsoftlimit < limit)) - limit = dquot->dq_dqb.dqb_bsoftlimit; + limit = dquot->dq_dqb.dqb_bsoftlimit;if (dquot->dq_dqb.dqb_bhardlimit && (!limit || dquot->dq_dqb.dqb_bhardlimit < limit)) limit = dquot->dq_dqb.dqb_bhardlimit;
@@ -5603,10 +5600,7 @@ static int ext4_statfs_project(struct super_block *sb, (buf->f_blocks - curblock) : 0; } - limit =0 ; -if (dquot->dq_dqb.dqb_isoftlimit && - (!limit || dquot->dq_dqb.dqb_isoftlimit < limit)) - limit = dquot->dq_dqb.dqb_isoftlimit; + limit = dquot->dq_dqb.dqb_isoftlimit;if (dquot->dq_dqb.dqb_ihardlimit && (!limit || dquot->dq_dqb.dqb_ihardlimit < limit)) limit = dquot->dq_dqb.dqb_ihardlimit;
Signature · 1 line
2.16.4
Re: [PATCH] ext4: simplify checking quota limits in ext4_statfs()
Quoted 6 lines · Jan Kara
Coverity reports that conditions checking quota limits in
ext4_statfs()contain dead code. Indeed it is right and current conditions can be simplified.Reported-by Coverity <[email protected]>Signed-off-by Jan Kara <[email protected]>
Applied, thanks.
- Ted