Skip to contentSkip to conversation

clk: imx: clock driver for imx8qm?

DISCUSSION Oliver Graute 4 participants 7 messages Feb 13, 2020 – Feb 26, 2020 Common clk

lore
Share & tools
lore
#0 lore raw

Hello Favio,
Hello Anson,

is someone working on clock driver for imx8qm? I miss at least a clk-imx8qm.c in the drivers/imx/clk/ directory. I saw that you are working in this area and perhaps you can give me some insights what is needed here.

Best regards,

Oliver

#1 lore raw

Hi Oliver,

Quoted 10 lines

From: Oliver Graute <[email protected]>
Sent: Thursday, February 13, 2020 11:32 PM

Hello Favio,
Hello Anson,

is someone working on clock driver for imx8qm? I miss at least a clk-imx8qm.c in the drivers/imx/clk/ directory. I saw that you are working in this area and perhaps you can give me some insights what is needed here.

MX8QM/QXP are using the same clock driver clk-imx8qxp.c

[PATCH RESEND V5 00/11] clk: imx8: add new clock binding for better pm support
https://www.spinics.net/lists/arm-kernel/msg781687.html
The review of that patch series is pending for a couple of months.

Stephen,
Would you help it?

Regards
Aisheng

Quoted 3 lines

Best regards,

Oliver

#2 lore raw
Quoted 9 lines · Aisheng Dong

Hi Oliver,

Quoted 5 lines

is someone working on clock driver for imx8qm? I miss at least a clk-imx8qm.c in the drivers/imx/clk/ directory. I saw that you are working in this area and perhaps you can give me some insights what is needed here.

MX8QM/QXP are using the same clock driver clk-imx8qxp.c

ok thx, for that clarification.

Quoted 4 lines

[PATCH RESEND V5 00/11] clk: imx8: add new clock binding for better pm support
https://www.spinics.net/lists/arm-kernel/msg781687.html
The review of that patch series is pending for a couple of months.

yes that is what I currently use. So further imx8qm development can happen if this is integrated?

Best regards,

Oliver

#3 lore raw
Quoted 15 lines

From: Oliver Graute <[email protected]>
Sent: Friday, February 14, 2020 1:42 AM

Quoted 6 lines · Aisheng Dong

Hi Oliver,

Quoted 4 lines

is someone working on clock driver for imx8qm? I miss at least a clk-imx8qm.c in the drivers/imx/clk/ directory. I saw that you are working in this area and perhaps you can give me some insights what is

needed here.

Quoted 3 lines
Quoted 1 line

MX8QM/QXP are using the same clock driver clk-imx8qxp.c

Quoted 8 lines

ok thx, for that clarification.

Quoted 3 lines

[PATCH RESEND V5 00/11] clk: imx8: add new clock binding for better pm The review of that patch series is pending for a couple of months.

yes that is what I currently use. So further imx8qm development can happen if this is integrated?

Yes, it blocks the most following MX8QXP/QM work.
Let me loop in Shawn to see if any suggestions.

Shawn,
Any ideas?

Regards
Aisheng

Quoted 4 lines

Best regards,

Oliver

#4 lore raw
Quoted 21 lines · Aisheng Dong
Quoted 21 lines

From: Oliver Graute <[email protected]>
Sent: Friday, February 14, 2020 1:42 AM

Quoted 6 lines · Aisheng Dong

Hi Oliver,

Quoted 4 lines

is someone working on clock driver for imx8qm? I miss at least a clk-imx8qm.c in the drivers/imx/clk/ directory. I saw that you are working in this area and perhaps you can give me some insights what is

needed here.

Quoted 3 lines
Quoted 1 line

MX8QM/QXP are using the same clock driver clk-imx8qxp.c

ok thx, for that clarification.

Quoted 3 lines

[PATCH RESEND V5 00/11] clk: imx8: add new clock binding for better pm The review of that patch series is pending for a couple of months.

Quoted 8 lines
Quoted 2 lines

yes that is what I currently use. So further imx8qm development can happen if this is integrated?

Yes, it blocks the most following MX8QXP/QM work.
Let me loop in Shawn to see if any suggestions.

Shawn,
Any ideas?

I guess there are still something Stephen is unhappy about, as we haven't got a nod from him. Do we really addressed all his comments and concerns already?

Shawn

#5 lore raw
Quoted 30 lines

From: Shawn Guo <[email protected]>
Sent: Monday, February 17, 2020 3:05 PM

Quoted 14 lines · Aisheng Dong
Quoted 14 lines

From: Oliver Graute <[email protected]>
Sent: Friday, February 14, 2020 1:42 AM

Quoted 7 lines · Aisheng Dong

Hi Oliver,

Quoted 5 lines

is someone working on clock driver for imx8qm? I miss at least a clk-imx8qm.c in the drivers/imx/clk/ directory. I saw that you are working in this area and perhaps you can give me some insights what is

needed here.

Quoted 2 lines
Quoted 1 line
Quoted 7 lines
Quoted 7 lines
Quoted 1 line

MX8QM/QXP are using the same clock driver clk-imx8qxp.c

ok thx, for that clarification.

Quoted 3 lines

[PATCH RESEND V5 00/11] clk: imx8: add new clock binding for better pm The review of that patch series is pending for a couple of

months.

Quoted 4 lines
Quoted 3 lines

yes that is what I currently use. So further imx8qm development can happen if this is integrated?

Quoted 9 lines
Quoted 5 lines

Yes, it blocks the most following MX8QXP/QM work.
Let me loop in Shawn to see if any suggestions.

Shawn,
Any ideas?

I guess there are still something Stephen is unhappy about, as we haven't got a nod from him. Do we really addressed all his comments and concerns already?

I remember I addressed all Stephen's comments in the last round of review which is marked in the V5 resend change log.
https://www.spinics.net/lists/arm-kernel/msg769365.html

But I can double check it.
Should I re-send after a checking or wait for Stephen's feedback?

As this does block a lot of following qm/qxp work for a long time, hopefully we can get some feedback/guidance from Stephen.

BTW, this patchset is already used in NXP internal 5.4 release although it's missed 5.4 LTS kernel.

Regards
Aisheng

Quoted 1 line

Shawn

#6 lore raw

Hi Aisheng,

Quoted 6 lines · Aisheng Dong

I remember I addressed all Stephen's comments in the last round of review which is marked in the V5 resend change log.
https://www.spinics.net/lists/arm-kernel/msg769365.html

But I can double check it.
Should I re-send after a checking or wait for Stephen's feedback?

I think it is a good idea to resend the series.

Thanks