Skip to contentSkip to conversation

lib/i915/gem_engine_topology.c - intel_get_current_engine invalid result

PATCH In review Dale B Stimson 4 participants 8 messages Feb 13, 2020 – Feb 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/i915/gem_engine_topology.c - intel_get_current_engine invalid result

Function intel_get_current_engine() should return NULL (instead of engine 0) if there are no engines.

Function intel_init_engine_list() should not store potential engine data in the output structure unless the engine is present.

Function intel_init_engine_list() should arguably not filter the static engine list with gem_has_ring if fd == -1, so that subtests can still be individually invoked to show subtest FAIL instead of test notrun.

Symptom: A device open failure in gem_ctx_isolation resulted in an endless __for_each_physical_engine "per-engine" loop with the purported last potential engine being processed every time.

Diagnosis: device open (or debugfs open) failed, leaving fd == -1. Control skipped the rest of the initial igt_fixture block, after which an attempt was made to iterate through engines using macro __for_each_physical_engine.

Macro __for_each_physical_engine called intel_init_engine_list() to initialize the loop control data. Because fd == -1, intel_init_engine_list() fell back to using __for_each_static_engine(). All of the engines in the static engine list are rejected due to gem_has_ring returning false (because of fd == -1), leaving 0 engines. That resulted in loop control data with engine_data.nengines == 0 and the data for the last engine considered stored at index 0.

Still in macro __for_each_physical_engine, intel_get_current_engine() was called to get the engine to process. It should have returned NULL, but instead returned the engine entry at index 0, which
had received information describing the last potential engine. This happened without end.

---
 lib/i915/gem_engine_topology.c | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)
lib/i915/gem_engine_topology.c +16 -13
index 9daa03df4..b8ed49bc9 100644
@@ -156,10 +156,10 @@ static void query_engine_list(int fd, struct intel_engine_data *ed)
 struct intel_execution_engine2 *
 intel_get_current_engine(struct intel_engine_data *ed)
 {
-	if (!ed->n)
-		ed->current_engine = &ed->engines[0];
-	else if (ed->n >= ed->nengines)
+	if (ed->n >= ed->nengines)
 		ed->current_engine = NULL;
+	else if (!ed->n)
+		ed->current_engine = &ed->engines[0];
 
 	return ed->current_engine;
 }
@@ -222,18 +222,21 @@ struct intel_engine_data intel_init_engine_list(int fd, uint32_t ctx_id)
 		igt_debug("using pre-allocated engine list\n");
 
 		__for_each_static_engine(e2) {
-			struct intel_execution_engine2 *__e2 =
-				&engine_data.engines[engine_data.nengines];
-
-			strcpy(__e2->name, e2->name);
-			__e2->instance   = e2->instance;
-			__e2->class      = e2->class;
-			__e2->flags      = e2->flags;
-			__e2->is_virtual = false;
-
 			if (igt_only_list_subtests() ||
-			    gem_has_ring(fd, e2->flags))
+			    (fd < 0) ||
+			    gem_has_ring(fd, e2->flags)) {
+				struct intel_execution_engine2 *__e2 =
+					&engine_data.engines[
+					engine_data.nengines];
+
+				strcpy(__e2->name, e2->name);
+				__e2->instance   = e2->instance;
+				__e2->class      = e2->class;
+				__e2->flags      = e2->flags;
+				__e2->is_virtual = false;
+
 				engine_data.nengines++;
+                        }
 		}
 		return engine_data;
 	}
Signature · 6 lines
2.25.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/i915/gem_engine_topology.c - intel_get_current_engine invalid result

== Series Details ==

== Series Details ==

Series: lib/i915/gem_engine_topology.c - intel_get_current_engine invalid result
URL : https://patchwork.freedesktop.org/series/73424/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7934 -> IGTPW_4149
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/index.html

Known issues
------------

Here are the changes found in IGTPW_4149 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [PASS][1] -> [INCOMPLETE][2] ([i915#45])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/fi-byt-j1900/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/fi-byt-j1900/igt@[email protected]

* igt@i915_selftest@live_execlists:
- fi-icl-dsi: [PASS][3] -> [DMESG-FAIL][4] ([fdo#108569])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/fi-icl-dsi/igt@i915_selftest@live_execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/fi-icl-dsi/igt@i915_selftest@live_execlists.html

* igt@i915_selftest@live_gem_contexts:
- fi-cml-s: [PASS][5] -> [DMESG-FAIL][6] ([i915#877])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/fi-cml-s/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/fi-cml-s/igt@i915_selftest@live_gem_contexts.html

* igt@i915_selftest@live_gtt:
- fi-bdw-5557u: [PASS][7] -> [TIMEOUT][8] ([fdo#112271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/fi-bdw-5557u/igt@i915_selftest@live_gtt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/fi-bdw-5557u/igt@i915_selftest@live_gtt.html

#### Possible fixes ####

* igt@gem_close_race@basic-threads:
- fi-byt-n2820: [INCOMPLETE][9] ([i915#45]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/fi-byt-n2820/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/fi-byt-n2820/igt@[email protected]

* igt@i915_selftest@live_gtt:
- fi-skl-6600u: [TIMEOUT][11] ([fdo#111732] / [fdo#112271]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/fi-skl-6600u/igt@i915_selftest@live_gtt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/fi-skl-6600u/igt@i915_selftest@live_gtt.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#111732]: https://bugs.freedesktop.org/show_bug.cgi?id=111732
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877
[i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937

Participating hosts (43 -> 40)
------------------------------

Additional (5): fi-bsw-n3050 fi-hsw-peppy fi-skl-6770hq fi-gdg-551 fi-skl-lmem
Missing (8): fi-kbl-soraka fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-ctg-p8600 fi-kbl-x1275 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5440 -> IGTPW_4149

CI-20190529: 20190529
CI_DRM_7934: 16668f8cd3512f56f626acaed0dd9245692ea3dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4149: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/index.html
IGT_5440: 860924b6ccbed75b66ab4b65897bb9abc91763ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw
In reply to Dale B Stimson

Quoting Dale B Stimson (2020-02-13 19:26:06)

Quoted 2 lines

Function intel_get_current_engine() should return NULL (instead of engine 0) if there are no engines.

There should be some igt to put basic use of for_each_engine() though its paces. Nothing fancy, just complete a loop....

Andi, am I imagining this? I swear saw patches from you to do the basics.

Anyway, there should be some, and this is worth adding to them, for_each_context_engine() on an empty engines[] and assert we do not enter the loop.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Acked-by on v1 1/1
#3 lore raw
In reply to Dale B Stimson
Quoted 62 lines · Dale B Stimson

Function intel_get_current_engine() should return NULL (instead of engine 0) if there are no engines.

Function intel_init_engine_list() should not store potential engine data in the output structure unless the engine is present.

Function intel_init_engine_list() should arguably not filter the static engine list with gem_has_ring if fd == -1, so that subtests can still be individually invoked to show subtest FAIL instead of test notrun.

Symptom: A device open failure in gem_ctx_isolation resulted in an endless __for_each_physical_engine "per-engine" loop with the purported last potential engine being processed every time.

Diagnosis: device open (or debugfs open) failed, leaving fd == -1. Control skipped the rest of the initial igt_fixture block, after which an attempt was made to iterate through engines using macro __for_each_physical_engine.

Macro __for_each_physical_engine called intel_init_engine_list() to initialize the loop control data. Because fd == -1, intel_init_engine_list() fell back to using __for_each_static_engine(). All of the engines in the static engine list are rejected due to gem_has_ring returning false (because of fd == -1), leaving 0 engines. That resulted in loop control data with engine_data.nengines == 0 and the data for the last engine considered stored at index 0.

Still in macro __for_each_physical_engine, intel_get_current_engine() was called to get the engine to process. It should have returned NULL, but instead returned the engine entry at index 0, which
had received information describing the last potential engine. This happened without end.

---
  lib/i915/gem_engine_topology.c | 29 ++++++++++++++++-------------
  1 file changed, 16 insertions(+), 13 deletions(-)
lib/i915/gem_engine_topology.c +3 -5
index 9daa03df4..b8ed49bc9 100644
@@ -156,10 +156,10 @@ static void query_engine_list(int fd, struct intel_engine_data *ed)
  struct intel_execution_engine2 *
  intel_get_current_engine(struct intel_engine_data *ed)
  {
-	if (!ed->n)
-		ed->current_engine = &ed->engines[0];
-	else if (ed->n >= ed->nengines)
+	if (ed->n >= ed->nengines)
  		ed->current_engine = NULL;
+	else if (!ed->n)
+		ed->current_engine = &ed->engines[0];
 
  	return ed->current_engine;
  }
@@ -222,18 +222,21 @@ struct intel_engine_data intel_init_engine_list(int fd, uint32_t ctx_id)
  		igt_debug("using pre-allocated engine list\n");
 
  		__for_each_static_engine(e2) {
-			struct intel_execution_engine2 *__e2 =
-				&engine_data.engines[engine_data.nengines];

lib/i915/gem_engine_topology.c struct intel_engine_data intel_init_engine_list(int fd, uint32_t ctx_id) · line 226

Quoted 10 lines
lib/i915/gem_engine_topology.c +1 -8
-
-			strcpy(__e2->name, e2->name);
-			__e2->instance   = e2->instance;
-			__e2->class      = e2->class;
-			__e2->flags      = e2->flags;
-			__e2->is_virtual = false;
-
  			if (igt_only_list_subtests() ||
-			    gem_has_ring(fd, e2->flags))
+			    (fd < 0) ||

Patch LGTM, Chris do you have any issues merging this before someone implements some tests for the infrastructure?

Quoted 7 lines
lib/i915/gem_engine_topology.c +6 -0
+			    gem_has_ring(fd, e2->flags)) {
+				struct intel_execution_engine2 *__e2 =
+					&engine_data.engines[
+					engine_data.nengines];
+
+				strcpy(__e2->name, e2->name);

lib/i915/gem_engine_topology.c struct intel_engine_data intel_init_engine_list(int fd, uint32_t ctx_id) · line 242

Quoted 10 lines
lib/i915/gem_engine_topology.c +6 -0
+				__e2->instance   = e2->instance;
+				__e2->class      = e2->class;
+				__e2->flags      = e2->flags;
+				__e2->is_virtual = false;
+
  				engine_data.nengines++;
+                        }
  		}
  		return engine_data;
  	}

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw

Quoting Antonio Argenziano (2020-02-14 18:43:01)

Quoted 62 lines · Dale B Stimson
Quoted 59 lines

Function intel_get_current_engine() should return NULL (instead of engine 0) if there are no engines.

Function intel_init_engine_list() should not store potential engine data in the output structure unless the engine is present.

Function intel_init_engine_list() should arguably not filter the static engine list with gem_has_ring if fd == -1, so that subtests can still be individually invoked to show subtest FAIL instead of test notrun.

Symptom: A device open failure in gem_ctx_isolation resulted in an endless __for_each_physical_engine "per-engine" loop with the purported last potential engine being processed every time.

Diagnosis: device open (or debugfs open) failed, leaving fd == -1. Control skipped the rest of the initial igt_fixture block, after which an attempt was made to iterate through engines using macro __for_each_physical_engine.

Macro __for_each_physical_engine called intel_init_engine_list() to initialize the loop control data. Because fd == -1, intel_init_engine_list() fell back to using __for_each_static_engine(). All of the engines in the static engine list are rejected due to gem_has_ring returning false (because of fd == -1), leaving 0 engines. That resulted in loop control data with engine_data.nengines == 0 and the data for the last engine considered stored at index 0.

Still in macro __for_each_physical_engine, intel_get_current_engine() was called to get the engine to process. It should have returned NULL, but instead returned the engine entry at index 0, which
had received information describing the last potential engine. This happened without end.

---
  lib/i915/gem_engine_topology.c | 29 ++++++++++++++++-------------
  1 file changed, 16 insertions(+), 13 deletions(-)
lib/i915/gem_engine_topology.c +3 -3
index 9daa03df4..b8ed49bc9 100644
@@ -156,10 +156,10 @@ static void query_engine_list(int fd, struct intel_engine_data *ed)
  struct intel_execution_engine2 *
  intel_get_current_engine(struct intel_engine_data *ed)
  {
-     if (!ed->n)
-             ed->current_engine = &ed->engines[0];
-     else if (ed->n >= ed->nengines)
+     if (ed->n >= ed->nengines)
              ed->current_engine = NULL;
+     else if (!ed->n)
+             ed->current_engine = &ed->engines[0];
 
      return ed->current_engine;
  }
@@ -222,18 +222,21 @@ struct intel_engine_data intel_init_engine_list(int fd, uint32_t ctx_id)
              igt_debug("using pre-allocated engine list\n");
 
Quoted 16 lines

lib/i915/gem_engine_topology.c struct intel_engine_data intel_init_engine_list(int fd, uint32_t ctx_id) · line 226

Quoted 13 lines
lib/i915/gem_engine_topology.c +1 -10
              __for_each_static_engine(e2) {
-                     struct intel_execution_engine2 *__e2 =
-                             &engine_data.engines[engine_data.nengines];
-
-                     strcpy(__e2->name, e2->name);
-                     __e2->instance   = e2->instance;
-                     __e2->class      = e2->class;
-                     __e2->flags      = e2->flags;
-                     __e2->is_virtual = false;
-
                      if (igt_only_list_subtests() ||
-                         gem_has_ring(fd, e2->flags))
+                         (fd < 0) ||

Patch LGTM, Chris do you have any issues merging this before someone implements some tests for the infrastructure?

It seems like a really trivial one to write a test for. 3 minutes tops... Just do it.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

+static void libapi(int i915)
+{
+ I915_DEFINE_CONTEXT_PARAM_ENGINES(engines, 0);
+ struct drm_i915_gem_context_param p = {

+               .ctx_id = gem_context_create(i915),
+               .param = I915_CONTEXT_PARAM_ENGINES,
+               .value = to_user_pointer(&engines),
+               .size = sizeof(engines),
+       };
+       const struct intel_execution_engine2 *e;
+       unsigned int count = 0;

+
+ gem_context_set_param(i915, &p);
+
+ for_each_context_engine(i915, p.ctx_id, e)
+ count++;
+ igt_assert_eq(count, 0);
+
+ ____for_each_physical_engine(i915, p.ctx_id, e)
+ count++;
+ igt_assert_eq(count, 0);
+
+ gem_context_destroy(i915, p.ctx_id);
+}

I leave find a home and correcting the whitespace to the reader. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#6 lore raw

Quoting Chris Wilson (2020-02-14 18:54:43)

Review

Quoted 3 lines
(quoted diff) +3 -0
+static void libapi(int i915)
+{
+       I915_DEFINE_CONTEXT_PARAM_ENGINES(engines, 0);

I915_DEFINE_CONTEXT_PARAM_ENGINES(engines, 0) = {}; or
struct i915_gem_context_param_engines engines = {};

Quoted 4 lines
(quoted diff) +4 -0
+       struct drm_i915_gem_context_param p = {
+               .ctx_id = gem_context_create(i915),
+               .param = I915_CONTEXT_PARAM_ENGINES,
+               .value = to_user_pointer(&engines),

Review

Quoted 10 lines
(quoted diff) +10 -0
+               .size = sizeof(engines),
+       };
+       const struct intel_execution_engine2 *e;
+       unsigned int count = 0;
+
+       gem_context_set_param(i915, &p);
+
+       for_each_context_engine(i915, p.ctx_id, e)
+               count++;
+       igt_assert_eq(count, 0);

Of course this says that this for_each_context_engine() loop doesn't work anyway.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#7 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for lib/i915/gem_engine_topology.c - intel_get_current_engine invalid result

In reply to Dale B Stimson
== Series Details ==

== Series Details ==

Series: lib/i915/gem_engine_topology.c - intel_get_current_engine invalid result
URL : https://patchwork.freedesktop.org/series/73424/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7934_full -> IGTPW_4149_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4149_full:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@gem_ctx_persistence@close-replace-race}:
- shard-tglb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb1/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4149_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +12 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb8/igt@[email protected]

* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +13 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb6/igt@[email protected]

* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb2/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-kbl2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-kbl1/igt@[email protected]

* igt@gem_mmap_gtt@basic-write-gtt:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([i915#478]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-snb2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-snb4/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#644])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-apl8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-apl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding:
- shard-tglb: [PASS][15] -> [FAIL][16] ([fdo#111703])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-apl7/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-apl6/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#1183])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb7/igt@[email protected]

* igt@kms_plane@plane-panning-top-left-pipe-a-planes:
- shard-tglb: [PASS][21] -> [FAIL][22] ([i915#1171]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb3/igt@[email protected]

* igt@kms_plane_cursor@pipe-a-viewport-size-256:
- shard-tglb: [PASS][23] -> [FAIL][24] ([i915#1139])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb5/igt@[email protected]

* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb5/igt@kms_psr@psr2_sprite_render.html

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([i915#56])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-kbl2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-kbl1/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_shared@exec-shared-gtt-default:
- shard-tglb: [FAIL][29] ([i915#616]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb7/igt@[email protected]

* igt@gem_ctx_shared@exec-shared-gtt-render:
- shard-tglb: [FAIL][31] ([i915#607] / [i915#616]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb2/igt@[email protected]

* igt@gem_eio@in-flight-suspend:
- shard-kbl: [DMESG-WARN][33] ([i915#180]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-kbl4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-kbl3/igt@[email protected]

* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [SKIP][35] ([fdo#112146]) -> [PASS][36] +10 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb7/igt@[email protected]

* igt@gem_exec_schedule@pi-userfault-bsd:
- shard-iclb: [SKIP][37] ([i915#677]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb7/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [FAIL][39] ([i915#644]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-glk3/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-glk4/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][41] ([fdo#111870] / [i915#478]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-snb6/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-snb4/igt@[email protected]

* igt@i915_pm_rps@reset:
- shard-iclb: [FAIL][43] ([i915#413]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb7/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb3/igt@[email protected]

* igt@kms_big_fb@y-tiled-16bpp-rotate-270:
- shard-tglb: [FAIL][45] ([i915#1172]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb7/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb5/igt@[email protected]

* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-iclb: [SKIP][47] ([i915#1140]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb8/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding:
- shard-tglb: [FAIL][49] ([fdo#111703]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb5/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-64x64-random:
- shard-apl: [FAIL][51] ([i915#54]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-apl6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-apl6/igt@[email protected]
- shard-kbl: [FAIL][53] ([i915#54]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-kbl7/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-kbl2/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][55] ([i915#72]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-glk6/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-glk3/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled:
- shard-tglb: [FAIL][57] ([i915#559]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb7/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: [FAIL][59] ([i915#49]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
- shard-glk: [FAIL][61] ([i915#49]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-glk1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-glk3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
- shard-apl: [FAIL][63] ([i915#49]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-apl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-tglb: [SKIP][65] ([i915#668]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite.html

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-apl6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-apl7/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][69] ([fdo#109441]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb3/igt@kms_psr@psr2_primary_mmap_gtt.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html

* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-tglb: [FAIL][71] ([i915#65]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb2/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb3/igt@[email protected]

* igt@kms_setmode@basic:
- shard-kbl: [FAIL][73] ([i915#31]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-kbl1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-kbl7/igt@[email protected]

* igt@perf_pmu@busy-check-all-vcs1:
- shard-iclb: [SKIP][75] ([fdo#112080]) -> [PASS][76] +10 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb5/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb4/igt@[email protected]

* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][77] ([fdo#109276]) -> [PASS][78] +8 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-iclb7/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-iclb2/igt@[email protected]

#### Warnings ####

* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [DMESG-WARN][79] ([fdo#110789] / [fdo#111870] / [i915#478]) -> [DMESG-WARN][80] ([fdo#111870] / [i915#478]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-snb2/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-snb6/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [SKIP][81] ([i915#468]) -> [FAIL][82] ([i915#454])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-tglb2/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-tglb5/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-snb: [INCOMPLETE][83] ([i915#82]) -> [SKIP][84] ([fdo#109271])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7934/shard-snb6/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/shard-snb6/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1139]: https://gitlab.freedesktop.org/drm/intel/issues/1139
[i915#1140]: https://gitlab.freedesktop.org/drm/intel/issues/1140
[i915#1171]: https://gitlab.freedesktop.org/drm/intel/issues/1171
[i915#1172]: https://gitlab.freedesktop.org/drm/intel/issues/1172
[i915#1183]: https://gitlab.freedesktop.org/drm/intel/issues/1183
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#559]: https://gitlab.freedesktop.org/drm/intel/issues/559
[i915#56]: https://gitlab.freedesktop.org/drm/intel/issues/56
[i915#607]: https://gitlab.freedesktop.org/drm/intel/issues/607
[i915#616]: https://gitlab.freedesktop.org/drm/intel/issues/616
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#65]: https://gitlab.freedesktop.org/drm/intel/issues/65
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5440 -> IGTPW_4149
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_7934: 16668f8cd3512f56f626acaed0dd9245692ea3dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4149: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/index.html
IGT_5440: 860924b6ccbed75b66ab4b65897bb9abc91763ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4149/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev