Skip to contentSkip to conversation

package/libcoap: add openssl and gnutls optional dependencies

PATCH New Fabrice Fontaine 2 participants 2 messages Feb 13, 2020 – Apr 12, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libcoap: add openssl and gnutls optional dependencies

openssl and gnutls are optional dependencies since version 4.2.0 and
https://github.com/obgm/libcoap/commit/4cef54f15190a42b6d3ad7a17ed71331e50a1bdf

Prefer gnutls over openssl has done by upstream in their configure.ac when the user does not provide any option (which is the case currently)

---
 package/libcoap/libcoap.mk | 8 ++++++++
 1 file changed, 8 insertions(+)
package/libcoap/libcoap.mk +8 -0
index e2fbaa3dfb..02577ecebe 100644
@@ -13,4 +13,12 @@ LIBCOAP_DEPENDENCIES = host-pkgconf
 LIBCOAP_CONF_OPTS = --disable-examples
 LIBCOAP_AUTORECONF = YES
 
+ifeq ($(BR2_PACKAGE_GNUTLS),y)
+LIBCOAP_DEPENDENCIES += gnutls
+LIBCOAP_CONF_OPTS += --with-gnutls
+else ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBCOAP_DEPENDENCIES += openssl
+LIBCOAP_CONF_OPTS += --with-openssl
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/1 package/libcoap: add openssl and gnutls optional dependencies

Quoted 10 lines · On Thu, 13 Feb 2020 23:15:10 +0100 Fabrice Fontaine…

openssl and gnutls are optional dependencies since version 4.2.0 and
https://github.com/obgm/libcoap/commit/4cef54f15190a42b6d3ad7a17ed71331e50a1bdf

Prefer gnutls over openssl has done by upstream in their configure.ac when the user does not provide any option (which is the case currently)

---
 package/libcoap/libcoap.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

Instead of just handling them as optional dependencies, I slightly improved your patch by handling --enable-dtls/--disable-dtls, which is really what gnutls or openssl are used for. See:

https://git.buildroot.org/buildroot/commit/?id=8b14f6b49b962d4d8f7135d85afa15658ea8f94b

So, your patch is basically applied to master, with some changes. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com