Skip to contentSkip to conversation

package/intel-mediasdk: enable compilation with x11 dri3

PATCH New Louis-Paul Cordier 2 participants 2 messages Feb 14, 2020 – Mar 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/intel-mediasdk: enable compilation with x11 dri3

---
 package/intel-mediasdk/Config.in         | 1 +
 package/intel-mediasdk/intel-mediasdk.mk | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
package/intel-mediasdk/Config.in +1 -0
index 05293d7604..0bfaf1272b 100644
@@ -9,6 +9,7 @@ config BR2_PACKAGE_INTEL_MEDIASDK
 	depends on BR2_PACKAGE_XORG7  # intel-mediadriver
 	select BR2_PACKAGE_INTEL_MEDIADRIVER
 	select BR2_PACKAGE_LIBDRM_INTEL
+	select BR2_PACKAGE_XORGPROTO
 	help
 	  Intel(R) Media SDK provides an API to access
 	  hardware-accelerated video decode, encode and filtering on
package/intel-mediasdk/intel-mediasdk.mk +2 -2
index 368e108308..b040729506 100644
@@ -10,8 +10,8 @@ INTEL_MEDIASDK_LICENSE = MIT
 INTEL_MEDIASDK_LICENSE_FILES = LICENSE
 
 INTEL_MEDIASDK_INSTALL_STAGING = YES
-INTEL_MEDIASDK_DEPENDENCIES = intel-mediadriver
+INTEL_MEDIASDK_DEPENDENCIES = intel-mediadriver xorgproto
 
-INTEL_MEDIASDK_CONF_OPTS = -DMFX_INCLUDE="$(@D)/api/include"
+INTEL_MEDIASDK_CONF_OPTS = -DMFX_INCLUDE="$(@D)/api/include" -DENABLE_X11_DRI3=ON
 
 $(eval $(cmake-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/intel-mediasdk: enable compilation with x11 dri3

Hello Louis-Paul,

Quoted 23 lines · On Fri, 14 Feb 2020 16:43:50 +0100 Louis-Paul Cordier <[email protected]> wrote:
---
 package/intel-mediasdk/Config.in         | 1 +
 package/intel-mediasdk/intel-mediasdk.mk | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
package/intel-mediasdk/Config.in +1 -0
index 05293d7604..0bfaf1272b 100644
@@ -9,6 +9,7 @@ config BR2_PACKAGE_INTEL_MEDIASDK
 	depends on BR2_PACKAGE_XORG7  # intel-mediadriver
 	select BR2_PACKAGE_INTEL_MEDIADRIVER
 	select BR2_PACKAGE_LIBDRM_INTEL
+	select BR2_PACKAGE_XORGPROTO
 	help
 	  Intel(R) Media SDK provides an API to access
 	  hardware-accelerated video decode, encode and filtering on
package/intel-mediasdk/intel-mediasdk.mk +0 -0
index 368e108308..b040729506 100644

package/intel-mediasdk/intel-mediasdk.mk INTEL_MEDIASDK_LICENSE = MIT · line 15

Quoted 8 lines
package/intel-mediasdk/intel-mediasdk.mk +2 -2
@@ -10,8 +10,8 @@ INTEL_MEDIASDK_LICENSE = MIT
 INTEL_MEDIASDK_LICENSE_FILES = LICENSE
 
 INTEL_MEDIASDK_INSTALL_STAGING = YES
-INTEL_MEDIASDK_DEPENDENCIES = intel-mediadriver
+INTEL_MEDIASDK_DEPENDENCIES = intel-mediadriver xorgproto
 
-INTEL_MEDIASDK_CONF_OPTS = -DMFX_INCLUDE="$(@D)/api/include"
+INTEL_MEDIASDK_CONF_OPTS = -DMFX_INCLUDE="$(@D)/api/include" -DENABLE_X11_DRI3=ON

Why are you making xorgproto a mandatory dependency ? intel-mediasdk doesn't build without it ? If it does build and work without it, then this is an optional dependency, and should be treated as such.

Could you confirm this ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com