package/wpa_supplicant: disable TEAP for internal TLS implementation
PATCH 1/1 package/wpa_supplicant: disable TEAP for internal TLS implementation
EAP-TEAP support in hostapd/wpa_supplicant fails to build with internal TLS implementation. This patch disables TEAP support in wpa_supplicant when internal TLS implementation is selected. Similar fix for hostapd package has already been merged to Buildroot: see commit 47d14e3b1c20 ("package/hostapd: disable TEAP for internal TLS implementation").
TEAP is still an experimental feature that is not recommmended for production use. Currently it should not be used for anything else than experimentation and interoperability testing. Those who needs experimenting with TEAP are encouraged to enable openssl in their buildroot configuration.
Fixes:
http://autobuild.buildroot.net/results/e83613c06041a60f89da787f4ebf876245713cd2/
--- package/wpa_supplicant/wpa_supplicant.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/wpa_supplicant/wpa_supplicant.mk +1 -1
@@ -112,7 +112,7 @@ WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libopenssl WPA_SUPPLICANT_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs openssl` WPA_SUPPLICANT_CONFIG_EDITS += 's/\#\(CONFIG_TLS=openssl\)/\1/' else -WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_EAP_PWD +WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_EAP_PWD CONFIG_EAP_TEAP WPA_SUPPLICANT_CONFIG_EDITS += 's/\#\(CONFIG_TLS=\).*/\1internal/' endif
Signature · 1 line
2.24.1
PATCH 1/1 package/wpa_supplicant: disable TEAP for internal TLS implementation
Quoted 11 lines · Sergey Matyukevich
EAP-TEAP support in hostapd/wpa_supplicant fails to build with internal TLS implementation. This patch disables TEAP support in
wpa_supplicantwhen internal TLS implementation is selected. Similar fix for hostapd package has already been merged to Buildroot: see commit47d14e3b1c20("package/hostapd: disable TEAP for internal TLS implementation").TEAP is still an experimental feature that is not recommmended for production use. Currently it should not be used for anything else than experimentation and interoperability testing. Those who needs experimenting with TEAP are encouraged to enable openssl in their buildroot configuration.
So then why don't we just unconditionally disable this feature? Preferably with
a comment in the .mk file that it's disabled due to its experimental nature, so that someone who needs it a couple of years down the line can note that it's not longer experimental.
Regards,
Arnout
Quoted 23 lines
Fixes:
http://autobuild.buildroot.net/results/e83613c06041a60f89da787f4ebf876245713cd2/Signed-off-by Sergey Matyukevich <[email protected]>--- package/wpa_supplicant/wpa_supplicant.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/wpa_supplicant/wpa_supplicant.mk +1
-1@@ -112,7 +112,7 @@ WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libopenssl WPA_SUPPLICANT_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs openssl` WPA_SUPPLICANT_CONFIG_EDITS += 's/\#\(CONFIG_TLS=openssl\)/\1/' else -WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_EAP_PWD +WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_EAP_PWD CONFIG_EAP_TEAP WPA_SUPPLICANT_CONFIG_EDITS += 's/\#\(CONFIG_TLS=\).*/\1internal/' endif
PATCH 1/1 package/wpa_supplicant: disable TEAP for internal TLS implementation
Quoted 13 lines · Sergey Matyukevich
Quoted 11 lines
EAP-TEAP support in hostapd/wpa_supplicant fails to build with internal TLS implementation. This patch disables TEAP support in
wpa_supplicantwhen internal TLS implementation is selected. Similar fix for hostapd package has already been merged to Buildroot: see commit47d14e3b1c20("package/hostapd: disable TEAP for internal TLS implementation").TEAP is still an experimental feature that is not recommmended for production use. Currently it should not be used for anything else than experimentation and interoperability testing. Those who needs experimenting with TEAP are encouraged to enable openssl in their buildroot configuration.
Quoted 4 lines
So then why don't we just unconditionally disable this feature? Preferably with
a comment in the .mk file that it's disabled due to its experimental nature, so that someone who needs it a couple of years down the line can note that it's not longer experimental.
Well, this is another possible option. But I don't see why we should disable it completely. TEAP does not build with internal hostapd TLSv1 implementation, which in its turn is also marked as experimental. On the other hand, TEAP successfully builds if OpenSSL is selected as TLS implementation. So why don't we just disable known broken combination, leaving the choice between working combinations to the end user.
Regards,
Sergey
PATCH 1/1 package/wpa_supplicant: disable TEAP for internal TLS implementation
Quoted 17 lines
Quoted 12 lines
Quoted 11 lines
EAP-TEAP support in hostapd/wpa_supplicant fails to build with internal TLS implementation. This patch disables TEAP support in
wpa_supplicantwhen internal TLS implementation is selected. Similar fix for hostapd package has already been merged to Buildroot: see commit47d14e3b1c20("package/hostapd: disable TEAP for internal TLS implementation").TEAP is still an experimental feature that is not recommmended for production use. Currently it should not be used for anything else than experimentation and interoperability testing. Those who needs experimenting with TEAP are encouraged to enable openssl in their buildroot configuration.
Quoted 4 lines
So then why don't we just unconditionally disable this feature? Preferably with
a comment in the .mk file that it's disabled due to its experimental nature, so that someone who needs it a couple of years down the line can note that it's not longer experimental.
Quoted 6 lines
Well, this is another possible option. But I don't see why we should disable it completely. TEAP does not build with internal hostapd TLSv1 implementation, which in its turn is also marked as experimental. On the other hand, TEAP successfully builds if OpenSSL is selected as TLS implementation. So why don't we just disable known broken combination, leaving the choice between working combinations to the end user.
Hi Thomas, Arnout,
It has been a while since my last reply. Do you still have any other concerns regarding suggested approach ?
Let me reiterate the idea. TEAP is a farily new and experimental hostapd feature which does not compile with internal hostapd TLS implementation. On the other hand, it can be successfully built with OpenSSL as TLS provider for hostapd.
So suggested approach explicitly disables broken configuration, but still lets the users to play with it if they need to.
Regards,
Sergey
PATCH 1/1 package/wpa_supplicant: disable TEAP for internal TLS implementation
In reply to Sergey MatyukevichQuoted 6 lines · Sergey Matyukevich
EAP-TEAP support in hostapd/wpa_supplicant fails to build with internal TLS implementation. This patch disables TEAP support in
wpa_supplicantwhen internal TLS implementation is selected. Similar fix for hostapd package has already been merged to Buildroot: see commit47d14e3b1c20("package/hostapd: disable TEAP for internal TLS implementation").
Quoted 8 lines
TEAP is still an experimental feature that is not recommmended for production use. Currently it should not be used for anything else than experimentation and interoperability testing. Those who needs experimenting with TEAP are encouraged to enable openssl in their buildroot configuration.
Fixes:
http://autobuild.buildroot.net/results/e83613c06041a60f89da787f4ebf876245713cd2/
Also fixes similar recent autobuild failure:
http://autobuild.buildroot.net/results/c52dd7fbb74d8f7bdd0149ce0bd90f89caec5776/
Regards,
Sergey
Thomas Petazzoni
AppliedPATCH 1/1 package/wpa_supplicant: disable TEAP for internal TLS implementation
In reply to Sergey MatyukevichQuoted 12 lines · On Wed, 8 Jan 2020 22:04:39 +0300 Sergey Matyukevich <[email protected]>…
EAP-TEAP support in hostapd/wpa_supplicant fails to build with internal TLS implementation. This patch disables TEAP support in
wpa_supplicantwhen internal TLS implementation is selected. Similar fix for hostapd package has already been merged to Buildroot: see commit47d14e3b1c20("package/hostapd: disable TEAP for internal TLS implementation").TEAP is still an experimental feature that is not recommmended for production use. Currently it should not be used for anything else than experimentation and interoperability testing. Those who needs experimenting with TEAP are encouraged to enable openssl in their buildroot configuration.
Quoted 7 lines
Fixes:
http://autobuild.buildroot.net/results/e83613c06041a60f89da787f4ebf876245713cd2/Signed-off-by Sergey Matyukevich <[email protected]>--- package/wpa_supplicant/wpa_supplicant.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/wpa_supplicant: disable TEAP for internal TLS implementation
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Quoted 12 lines · On Wed, 8 Jan 2020 22:04:39 +0300 Sergey Matyukevich <[email protected]>…
EAP-TEAP support in hostapd/wpa_supplicant fails to build with internal TLS implementation. This patch disables TEAP support in
wpa_supplicantwhen internal TLS implementation is selected. Similar fix for hostapd package has already been merged to Buildroot: see commit47d14e3b1c20("package/hostapd: disable TEAP for internal TLS implementation").TEAP is still an experimental feature that is not recommmended for production use. Currently it should not be used for anything else than experimentation and interoperability testing. Those who needs experimenting with TEAP are encouraged to enable openssl in their buildroot configuration.
Quoted 7 lines
Quoted 7 lines
Fixes:
http://autobuild.buildroot.net/results/e83613c06041a60f89da787f4ebf876245713cd2/Signed-off-by Sergey Matyukevich <[email protected]>---
package/wpa_supplicant/wpa_supplicant.mk| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Committed to 2020.02.x and 2020.05.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard